Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Devices to add version preview/2023-06-30-preview #23758

Merged

Conversation

MikalaiSavenka
Copy link
Contributor

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @MikalaiSavenka Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the IoTHub label Apr 27, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 27, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    iothub.json 2023-06-30-preview(97e52df) 2021-07-02(main)
    iothub.json 2023-06-30-preview(97e52df) 2022-11-15-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'cosmosDBSqlCollections' renamed or removed?
    New: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L2949:7
    Old: Microsoft.Devices/preview/2022-11-15-preview/iothub.json#L2949:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'collectionName' renamed or removed?
    New: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L3238:7
    Old: Microsoft.Devices/preview/2022-11-15-preview/iothub.json#L3238:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'containerName' that was not found in the old version.
    New: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L3238:7
    Old: Microsoft.Devices/preview/2022-11-15-preview/iothub.json#L3238:7
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'containerName' that was not found in the old version.
    New: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L3235:5
    Old: Microsoft.Devices/preview/2022-11-15-preview/iothub.json#L3235:5
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-preview-2023-06 package-preview-2023-06(97e52df) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Devices/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L60
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L61
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L64
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}'
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L76
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L76
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L110
    PutResponseSchemaDescription Description of 201 response code of a PUT operation MUST include term 'create'.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L162
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L181
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L184
    PatchResponseCode LRO PATCH must have 200 and 202 return codes.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L190
    PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L221
    PatchSkuProperty The patch operation body parameter schema should contain property 'sku'.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L221
    LroPatch202 The async patch operation should return 202.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L234
    MissingDefaultResponse Operation is missing a default response.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L234
    RequiredDefaultResponse The response is defined but without a default error response implementation.Consider adding it.'
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L234
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L284
    DeleteResponseBodyEmpty The delete response body must be empty.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L297
    MissingXmsErrorResponse Response code 404 is defined without a x-ms-error-response.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L304
    NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L304
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L307
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L310
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L313
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L320
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L348
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs'
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L361
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L392
    PathResourceTypeNameCamelCase Resource type naming must follow camel case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Devices/IotHubs/{resourceName}/IotHubStats'
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L405
    ResourceNameRestriction The resource name parameter 'resourceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L405
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L435
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Devices/preview/2023-06-30-preview/iothub.json#L439
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 27, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/iothub/armiothub - Approved - 1.2.0-beta.2
    +	Field `CollectionName` of struct `RoutingCosmosDBSQLAPIProperties` has been removed
    +	Field `CosmosDBSQLCollections` of struct `RoutingEndpoints` has been removed


    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.IotHub [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-iothub [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-iothub [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/iothub/armiothub [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `CollectionName` of struct `RoutingCosmosDBSQLAPIProperties` has been removed
      info	[Changelog] - Field `CosmosDBSQLCollections` of struct `RoutingEndpoints` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `ContainerName` in struct `RoutingCosmosDBSQLAPIProperties`
      info	[Changelog] - New field `CosmosDBSQLContainers` in struct `RoutingEndpoints`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 2 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-iothub [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface EncryptionPropertiesDescription
      info	[Changelog]   - Added Interface IotHubManualFailoverHeaders
      info	[Changelog]   - Added Interface IotHubPropertiesDeviceStreams
      info	[Changelog]   - Added Interface IotHubResourceCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface IotHubResourceDeleteHeaders
      info	[Changelog]   - Added Interface IotHubResourceUpdateHeaders
      info	[Changelog]   - Added Interface KeyVaultKeyProperties
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsDeleteHeaders
      info	[Changelog]   - Added Interface PrivateEndpointConnectionsUpdateHeaders
      info	[Changelog]   - Added Interface RootCertificateProperties
      info	[Changelog]   - Added Interface RoutingCosmosDBSqlApiProperties
      info	[Changelog]   - Added Type Alias IpVersion
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter deviceStreams
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter encryption
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter ipVersion
      info	[Changelog]   - Interface IotHubProperties has a new optional parameter rootCertificate
      info	[Changelog]   - Interface RoutingEndpoints has a new optional parameter cosmosDBSqlContainers
      info	[Changelog]   - Add parameters of IotHubResourceUpdateHeaders to TypeAlias IotHubResourceUpdateResponse
      info	[Changelog]   - Added Enum KnownIpVersion
      info	[Changelog]   - Enum KnownRoutingSource has a new value DigitalTwinChangeEvents
      info	[Changelog]   - Enum KnownRoutingSource has a new value MqttBrokerMessages
      info	[Changelog]   - Added function getContinuationToken
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d99f18b. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️iothub [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from d99f18b. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ⚠️Az.iothub.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.iothub.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 27, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/iothub/armiothub https://apiview.dev/Assemblies/Review/ff600ebcbd904fa7b79682556f03c779
    .Net Azure.ResourceManager.IotHub https://apiview.dev/Assemblies/Review/6803a44220344c4e8911324226bf4f56
    Java azure-resourcemanager-iothub https://apiview.dev/Assemblies/Review/12069509cdc843238541936793f6f065
    JavaScript @azure/arm-iothub https://apiview.dev/Assemblies/Review/c42528862e67457ca5c08b2c1b2d92b3

    @MikalaiSavenka MikalaiSavenka marked this pull request as ready for review April 27, 2023 22:29
    @MikalaiSavenka MikalaiSavenka requested a review from rkmanda as a code owner April 27, 2023 22:29
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 27, 2023
    @raych1 raych1 requested a review from JackTn April 28, 2023 02:01
    @pilor
    Copy link
    Contributor

    pilor commented Apr 28, 2023

    I don't know if these breaking changes are really necessary but according to the latest policy its allowed to make these changes from preview to preview version so approving.

    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 28, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 28, 2023
    @JackTn
    Copy link
    Member

    JackTn commented Apr 28, 2023

    In my opinion , This pr added new version preview/2023-06-30-preview. These breaking change is not related to this pr. So that approved, @qiaozha can you take a look on this pr. let me know if i'm wrong. I'm approved.

    @microsoft-github-policy-service
    Copy link
    Contributor

    Hi, @MikalaiSavenka. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @microsoft-github-policy-service
    Copy link
    Contributor

    Hi, @MikalaiSavenka. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @qiaozha
    Copy link
    Member

    qiaozha commented Aug 12, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @vighatke
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 2 pipeline(s).

    @qiaozha qiaozha removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 15, 2023
    @qiaozha
    Copy link
    Member

    qiaozha commented Aug 15, 2023

    I will merge it as this PR assigned to me before the ownership change. @rkmanda

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go DoNotMerge <valid label in PR review process> use to hold merge after approval IoTHub new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants