[Synapse Platform Service - Synase Link] add ActionOnExistingTargetTable properties of synapse link #23670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jingzhong-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| linkConnections.json | 2023-04-18-preview(be3647e) | 2022-12-01-preview(main) |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 92 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.1) | new version | base version |
|---|---|---|
| package-artifacts-composite-v7 | package-artifacts-composite-v7(be3647e) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 30 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L6 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L34 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L48 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L50 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L70 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L73 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L96 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L98 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L113 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L116 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L130 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L132 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L147 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L150 |
||
| All success responses except 202 & 204 should define a response body. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L158 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L164 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L166 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L183 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L186 |
||
| All success responses except 202 & 204 should define a response body. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L203 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L206 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L208 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L225 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L228 |
||
| All success responses except 202 & 204 should define a response body. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L236 |
||
| Error response should contain a x-ms-error-code header. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L239 |
||
Error response schema should contain an object property named error.Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L241 |
||
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'LinkConnectionModel'. Consider using the plural form of 'LinkConnection' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L258 |
||
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L261 |
||
| All success responses except 202 & 204 should define a response body. Location: Microsoft.Synapse/preview/2023-04-18-preview/linkConnections.json#L269 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The readme file has more than one default tag. readme: specification/synapse/data-plane/readme.md |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
|
Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
jingzhong-MS
changed the title
ghost
added
the
|
Hi, @jingzhong-MS, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
jingzhong-MS
force-pushed
the
dev/jingzhong/synapselink-dataplane-2023-04-18-preview
branch
from
571304a to
f1e251e
Compare
jingzhong-MS
changed the title
jingzhong-MS
force-pushed
the
dev/jingzhong/synapselink-dataplane-2023-04-18-preview
branch
from
f1e251e to
fec99ae
Compare
* remove dropExistingTargetTableOnStart properties * add actionOnExistingTargetTable properties
jingzhong-MS
force-pushed
the
dev/jingzhong/synapselink-dataplane-2023-04-18-preview
branch
from
fec99ae to
be3647e
Compare
markweitzel
approved these changes
May 18, 2023
mikekistler
added
the
APIStewardshipBoard-SignedOff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links