Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tianxinliu/20230501 #23661

Merged
merged 10 commits into from
May 23, 2023
Merged

Conversation

tianxin-ms
Copy link
Member

@tianxin-ms tianxin-ms commented Apr 20, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @tianxin-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @ghost ghost added the Cognitive Services label Apr 20, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 92 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    cognitiveservices.json 2023-05-01(581b900) 2022-12-01(main)
    cognitiveservices.json 2023-05-01(581b900) 2016-02-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1003 - RequestBodyFormatNoLongerSupported The new version does not support 'text/json' as a request body format.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L12:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L12:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CognitiveServicesAccountCreateParameters' removed or renamed?
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L2108:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L480:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CognitiveServicesAccountUpdateParameters' removed or renamed?
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L2108:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L480:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CognitiveServicesAccountPropertiesCreateParameters' removed or renamed?
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L2108:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L480:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'subscriptionIdParameter' removed or renamed?
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L4103:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L758:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'apiVersionParameter' removed or renamed?
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L4103:3
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L758:3
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_Create' to 'Accounts_Create'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L31:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L22:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_Update' to 'Accounts_Update'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L96:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L83:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_Delete' to 'Accounts_Delete'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L152:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L139:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_GetProperties' to 'Accounts_Get'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L196:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L185:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_ListByResourceGroup' to 'Accounts_ListByResourceGroup'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L330:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L236:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_List' to 'Accounts_List'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L372:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L280:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_ListKeys' to 'Accounts_ListKeys'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L450:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L317:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_RegenerateKey' to 'Accounts_RegenerateKey'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L492:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L371:7
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'CognitiveServicesAccounts_ListSkus' to 'Accounts_ListSkus'. This will impact generated code.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L584:7
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L429:7
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'parameters' was removed in the new version.
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L46:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'body' was removed in the new version.
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L107:11
    ⚠️ 1009 - RemovedRequiredParameter The required parameter 'body' was removed in the new version.
    Old: Microsoft.CognitiveServices/preview/2016-02-01-preview/cognitiveservices.json#L395:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'account' was added in the new version.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L52:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'account' was added in the new version.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L114:11
    ⚠️ 1010 - AddingRequiredParameter The required parameter 'parameters' was added in the new version.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L510:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L81:11
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 4 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-05 package-2023-05(581b900) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L637
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Usages
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L676
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L900
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L3997


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L68
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L81
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L114
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L114
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L114
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L137
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L152
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L181
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L281
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L313
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L612
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1005
    ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1018
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1062
    RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1062
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1099
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1106
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1121
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1153
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1198
    ResourceNameRestriction The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1256
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1362
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1394
    ResourceNameRestriction The resource name parameter 'commitmentPlanName' should be defined with a 'pattern' restriction.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1455
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1557
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1589
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1640
    ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1989
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L1989
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json#L2228
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.CognitiveServices' for api version '2023-05-01'. The supported api-versions are '2016-02-01-preview,
    2017-04-18,
    2021-04-30,
    2021-10-01,
    2022-03-01,
    2022-10-01,
    2022-12-01'."
    ️❌~[Staging] ServiceAPIReadinessTest: 28 Errors, 0 Warnings failed [Detail]

    Tag package-2023-05; Prod region: Not deployed; Canary region: Deployed

    Test run on region: eastus2euap; Operation coverage: total: 44, untested: 0, failed: 28, passed: 16

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: InvalidApiSetId,
    errorMessage: The account type 'Emotion' is either invalid or unavailable in given region.
    Source: runtime
    OperationId: Accounts_Create
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_ListUsages
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_ListSkus
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_ListModels
    CLIENT_ERROR statusCode: 404,
    errorCode: PatchResourceNotFound,
    errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-jhqUnm-23661/providers/Microsoft.CognitiveServices/accounts/accountnrruzxb' was not found when evaluating policies for a PATCH operation.
    Source: runtime
    OperationId: Accounts_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_RegenerateKey
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Accounts_ListKeys
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: CommitmentPlans_List
    CLIENT_ERROR statusCode: 400,
    errorCode: BadRequest,
    errorMessage: Updating Kind is not supported
    Source: runtime
    OperationId: CommitmentPlans_UpdatePlan
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnrruzxb' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnrruzxb' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnrruzxb' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: CommitmentPlans_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: CommitmentPlans_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Deployments_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Deployments_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Deployments_Get
    SERVER_ERROR statusCode: 500,
    errorCode: InternalServerError,
    errorMessage: Encountered internal server error. Please try again.
    Source: runtime
    OperationId: CommitmentPlans_CreateOrUpdateAssociation
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: Specified resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-jhqUnm-23661/providers/Microsoft.CognitiveServices/commitmentPlans/commitme086er5/accountAssociations/commitmeuiiw1m' cannot be found.
    Source: runtime
    OperationId: CommitmentPlans_GetAssociation
    CLIENT_ERROR statusCode: 404,
    errorCode: InvalidResourceType,
    errorMessage: The resource type 'operations' could not be found in the namespace 'Microsoft.CognitiveServices' for api version '2023-05-01'. The supported api-versions are '2016-02-01-preview,2017-04-18,2021-04-30,2021-10-01,2022-03-01,2022-10-01,2022-12-01'.
    Source: runtime
    OperationId: Operations_List
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.CognitiveServices/locations/resourceGroups/deletedAccounts/delete' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/providers/Microsoft.CognitiveServices/locations/eastus2euap/resourceGroups/apiTest-jhqUnm-23661/deletedAccounts/accountnrruzxb' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: DeletedAccounts_Purge
    CLIENT_ERROR statusCode: 404,
    errorCode: NotFound,
    errorMessage: The deleted account '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-jhqUnm-23661/providers/Microsoft.CognitiveServices/accounts/accountnrruzxb' could not be found.
    Source: runtime
    OperationId: DeletedAccounts_Get
    OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: locationInfo
    Source: response
    OperationId: ResourceSkus_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnrruzxb' not found.
    Source: runtime
    OperationId: PrivateLinkResources_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: Deployments_Delete
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.CognitiveServices/accounts/accountnrruzxb' under resource group 'apiTest-jhqUnm-23661' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: CommitmentPlans_Delete
    CLIENT_ERROR statusCode: 404,
    errorCode: ParentResourceNotFound,
    errorMessage: Can not perform requested operation on nested resource. Parent resource 'accountnrruzxb' not found.
    Source: runtime
    OperationId: PrivateEndpointConnections_Delete
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ba18846. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-cognitiveservices [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation group ModelsOperations
      info	[Changelog]   - Added operation group UsagesOperations
      info	[Changelog]   - Model AccountModel has a new parameter is_default_version
      info	[Changelog]   - Model AccountModel has a new parameter skus
      info	[Changelog]   - Model AccountModel has a new parameter source
      info	[Changelog]   - Model AccountProperties has a new parameter abuse_penalty
      info	[Changelog]   - Model CommitmentPlanProperties has a new parameter provisioning_issues
      info	[Changelog]   - Model Deployment has a new parameter sku
      info	[Changelog]   - Model DeploymentModel has a new parameter source
      info	[Changelog]   - Model DeploymentProperties has a new parameter rate_limits
      info	[Changelog]   - Model DeploymentProperties has a new parameter version_upgrade_option
      info	[Changelog]   - Model UsageListResult has a new parameter next_link
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ba18846. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/cognitiveservices/armcognitiveservices [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `DeploymentProvisioningStateCanceled`, `DeploymentProvisioningStateDisabled` added to enum type `DeploymentProvisioningState`
      info	[Changelog] - New value `HostingModelProvisionedWeb` added to enum type `HostingModel`
      info	[Changelog] - New enum type `AbusePenaltyAction` with values `AbusePenaltyActionBlock`, `AbusePenaltyActionThrottle`
      info	[Changelog] - New enum type `DeploymentModelVersionUpgradeOption` with values `DeploymentModelVersionUpgradeOptionNoAutoUpgrade`, `DeploymentModelVersionUpgradeOptionOnceCurrentVersionExpired`, `DeploymentModelVersionUpgradeOptionOnceNewDefaultVersionAvailable`
      info	[Changelog] - New function `*ClientFactory.NewModelsClient() *ModelsClient`
      info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
      info	[Changelog] - New function `NewModelsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ModelsClient, error)`
      info	[Changelog] - New function `*ModelsClient.NewListPager(string, *ModelsClientListOptions) *runtime.Pager[ModelsClientListResponse]`
      info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
      info	[Changelog] - New function `*UsagesClient.NewListPager(string, *UsagesClientListOptions) *runtime.Pager[UsagesClientListResponse]`
      info	[Changelog] - New struct `AbusePenalty`
      info	[Changelog] - New struct `CapacityConfig`
      info	[Changelog] - New struct `Model`
      info	[Changelog] - New struct `ModelListResult`
      info	[Changelog] - New struct `ModelSKU`
      info	[Changelog] - New field `IsDefaultVersion`, `SKUs`, `Source` in struct `AccountModel`
      info	[Changelog] - New field `AbusePenalty` in struct `AccountProperties`
      info	[Changelog] - New field `ProvisioningIssues` in struct `CommitmentPlanProperties`
      info	[Changelog] - New field `SKU` in struct `Deployment`
      info	[Changelog] - New field `Source` in struct `DeploymentModel`
      info	[Changelog] - New field `RateLimits`, `VersionUpgradeOption` in struct `DeploymentProperties`
      info	[Changelog] - New field `NextLink` in struct `UsageListResult`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 33 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ba18846. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cognitiveservices [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group Models
      info	[Changelog]   - Added operation group Usages
      info	[Changelog]   - Added Interface AbusePenalty
      info	[Changelog]   - Added Interface CapacityConfig
      info	[Changelog]   - Added Interface Model
      info	[Changelog]   - Added Interface ModelListResult
      info	[Changelog]   - Added Interface ModelSku
      info	[Changelog]   - Added Interface ModelsListNextOptionalParams
      info	[Changelog]   - Added Interface ModelsListOptionalParams
      info	[Changelog]   - Added Interface UsagesListNextOptionalParams
      info	[Changelog]   - Added Interface UsagesListOptionalParams
      info	[Changelog]   - Added Type Alias AbusePenaltyAction
      info	[Changelog]   - Added Type Alias DeploymentModelVersionUpgradeOption
      info	[Changelog]   - Added Type Alias ModelsListNextResponse
      info	[Changelog]   - Added Type Alias ModelsListResponse
      info	[Changelog]   - Added Type Alias UsagesListNextResponse
      info	[Changelog]   - Added Type Alias UsagesListResponse
      info	[Changelog]   - Interface AccountModel has a new optional parameter isDefaultVersion
      info	[Changelog]   - Interface AccountModel has a new optional parameter skus
      info	[Changelog]   - Interface AccountProperties has a new optional parameter abusePenalty
      info	[Changelog]   - Interface CommitmentPlanProperties has a new optional parameter provisioningIssues
      info	[Changelog]   - Interface Deployment has a new optional parameter sku
      info	[Changelog]   - Interface DeploymentModel has a new optional parameter source
      info	[Changelog]   - Interface DeploymentProperties has a new optional parameter rateLimits
      info	[Changelog]   - Interface DeploymentProperties has a new optional parameter versionUpgradeOption
      info	[Changelog]   - Interface UsageListResult has a new optional parameter nextLink
      info	[Changelog]   - Added Enum KnownAbusePenaltyAction
      info	[Changelog]   - Added Enum KnownDeploymentModelVersionUpgradeOption
      info	[Changelog]   - Enum KnownDeploymentProvisioningState has a new value Canceled
      info	[Changelog]   - Enum KnownDeploymentProvisioningState has a new value Disabled
      info	[Changelog]   - Enum KnownHostingModel has a new value ProvisionedWeb
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ba18846. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️cognitiveservices [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from ba18846. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • ️✔️Az.cognitiveservices.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.cognitiveservices.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 20, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/cognitiveservices/armcognitiveservices https://apiview.dev/Assemblies/Review/358f2aae5c614a9a9758126de29eab0d
    Java azure-resourcemanager-cognitiveservices https://apiview.dev/Assemblies/Review/8fec1e48a82e46859d79642adc8e2354
    .Net Azure.ResourceManager.CognitiveServices There is no API change compared with the previous version
    JavaScript @azure/arm-cognitiveservices https://apiview.dev/Assemblies/Review/c164a61e90c4467e9242a13c005a0c7c

    @openapi-workflow-bot
    Copy link

    Hi, @tianxin-ms, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @openapi-workflow-bot
    Copy link

    Hi @tianxin-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 3, 2023
    @tianxin-ms tianxin-ms marked this pull request as ready for review May 4, 2023 14:15
    @tianxin-ms tianxin-ms requested a review from yangyuan as a code owner May 4, 2023 14:15
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 5, 2023
    @tianxin-ms tianxin-ms force-pushed the tianxinliu/20230501 branch from f1c3d86 to 2370359 Compare May 5, 2023 21:05
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2023
    @tianxin-ms
    Copy link
    Member Author

    "/subscriptions/{subscriptionId}/providers/Microsoft.CognitiveServices/locations/{location}/models": {
    

    Looks like you have not modelled this as standard ARM resource .

    Is this a standard contract that you are implementing like usages ? Can you please share any documentation on this ?

    Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json:888 in e5fccc9. [](commit_id = e5fccc9, deletion_comment = False)

    @raosuhas , "models" here means AI models, not an ARM resource. This API means to get the list of AI models.

    @xiaomin-ms
    Copy link

    "/subscriptions/{subscriptionId}/providers/Microsoft.CognitiveServices/locations/{location}/models": {
    

    Looks like you have not modelled this as standard ARM resource .

    Is this a standard contract that you are implementing like usages ? Can you please share any documentation on this ?

    Refers to: specification/cognitiveservices/resource-manager/Microsoft.CognitiveServices/stable/2023-05-01/cognitiveservices.json:888 in e5fccc9. [](commit_id = e5fccc9, deletion_comment = False)

    The models is read-only metadata for OpenAI models, it's very similar to "skus" API, so we don't include the "id", "type" as a regular ARM resource.

    @AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label May 16, 2023
    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 17, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 17, 2023
    @v-jiaodi
    Copy link
    Member

    @tianxin-ms Please fix API Readiness Check error.

    @v-jiaodi
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @v-jiaodi
    Copy link
    Member

    @msyyc @raych1 @qiaozha Could you help to take a look at the SDK Breaking Change error in this PR? Thanks

    @qiaozha
    Copy link
    Member

    qiaozha commented May 23, 2023

    removed the JS breaking change label as there are no breaking changes.

    @v-jiaodi v-jiaodi added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 23, 2023
    @weidongxu-microsoft
    Copy link
    Member

    If you request SDK, comment in request when you think rollout be complete (so that user won't get SDK that not works).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-MissingBaseCommit Cognitive Services new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.