[Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-05-01-privatepreview #23601

noneumar · 2023-04-18T12:50:56Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…/2021-08-08 to version 2023-05-01-privatepreview

openapi-workflow-bot · 2023-04-18T12:51:00Z

Hi, @noneumar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-18T12:51:03Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 7 Errors, 19 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
AlertProcessingRules.json	2023-05-01-preview(0d37c81)	2021-08-08(main)
AlertProcessingRules.json	2023-05-01-preview(0d37c81)	2021-08-08-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed? New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L362:3 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L359:3
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L34:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L76:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L121:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L168:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L251:9
`❌` 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L304:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L34:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L34:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L76:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L76:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L121:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L121:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L168:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L168:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L254:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L251:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L307:9 Old: Microsoft.AlertsManagement/stable/2021-08-08/AlertProcessingRules.json#L304:9

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1007 - RemovedClientParameter	The new version is missing a client parameter that was found in the old version. Was 'api-version' removed or renamed? New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L362:3 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L359:3
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L34:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L34:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L76:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L76:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L121:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L121:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L168:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L168:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L254:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L251:9
⚠️ 1016 - ConstantStatusHasChanged	The 'constant' status changed from the old version to the new. New: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L307:9 Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L304:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L34:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L76:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L121:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L168:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L251:9
⚠️ 1049 - RemovedXmsEnum	The new version is missing a 'x-ms-enum' found in the old version. Old: Microsoft.AlertsManagement/preview/2021-08-08-preview/AlertProcessingRules.json#L304:9

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.2)	new version	base version
package-2023-03	package-2023-03(0d37c81)	package-2023-03(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'alertProcessingRuleName' should be defined with a 'pattern' restriction. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L117
`❌` XmsParameterLocation	The parameter 'subscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L363
`❌` MissingTypeObject	The schema 'errorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L381
`❌` MissingTypeObject	The schema 'errorResponseBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L389
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L404
`❌` MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L413
`❌` MissingTypeObject	The schema 'ManagedResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L434
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L517
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L542
`❌` XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L697
`❌` MissingTypeObject	The schema 'PatchProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L844
`❌` MissingTypeObject	The schema 'PatchObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L853
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L34
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L34
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L76
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L76
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L121
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L121
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L168
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L168
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L254
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L254
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L307
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L307
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L708
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AlertsManagement/preview/2023-05-01-preview/AlertProcessingRules.json#L847

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/alertsmanagement/resource-manager/readme.md tag: specification/alertsmanagement/resource-manager/readme.md#tag-package-2023-03

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌~[Staging] ServiceAPIReadinessTest: 0 Errors, 0 Warnings failed [Detail]

Tag package-2023-03; Prod region: Not deployed; Canary region: Not deployed

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T12:51:03Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/alertsmanagement/armalertsmanagement - Approved - 0.9.0

+	Function `NewClientFactory` parameter(s) have been changed from `(string, azcore.TokenCredential, *arm.ClientOptions)` to `(string, string, azcore.TokenCredential, *arm.ClientOptions)`

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from fba7ffa. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.AlertsManagement [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from fba7ffa. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-alertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group AlertRuleRecommendationsOperations
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ResourceAutoGenerated no longer has parameter system_data

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from fba7ffa. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/alertsmanagement/armalertsmanagement [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `AlertsClientChangeStateOptions.Comment` has been changed from `*string` to `*Comments`
info	[Changelog] - Type of `ErrorResponse.Error` has been changed from `*ErrorResponseBody` to `*ErrorDetail`
info	[Changelog] - Type of `ErrorResponseAutoGenerated.Error` has been changed from `*ErrorResponseBodyAutoGenerated` to `*ErrorResponseBody`
info	[Changelog] - Type of `ErrorResponseAutoGenerated2.Error` has been changed from `*ErrorResponseBodyAutoGenerated2` to `*ErrorResponseBodyAutoGenerated`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ActionTypeCorrelateAlerts` added to enum type `ActionType`
info	[Changelog] - New enum type `MetricAlertsDisplayUnit` with values `MetricAlertsDisplayUnitBillion`, `MetricAlertsDisplayUnitBillionPerSecond`, `MetricAlertsDisplayUnitBytes`, `MetricAlertsDisplayUnitBytesPerDay`, `MetricAlertsDisplayUnitBytesPerHour`, `MetricAlertsDisplayUnitBytesPerMinute`, `MetricAlertsDisplayUnitBytesPerSecond`, `MetricAlertsDisplayUnitCount`, `MetricAlertsDisplayUnitCountPerDay`, `MetricAlertsDisplayUnitCountPerHour`, `MetricAlertsDisplayUnitCountPerMinute`, `MetricAlertsDisplayUnitCountPerSecond`, `MetricAlertsDisplayUnitDays`, `MetricAlertsDisplayUnitGigabytes`, `MetricAlertsDisplayUnitGigabytesPerSecond`, `MetricAlertsDisplayUnitHours`, `MetricAlertsDisplayUnitKilobytes`, `MetricAlertsDisplayUnitKilobytesPerSecond`, `MetricAlertsDisplayUnitMegabytes`, `MetricAlertsDisplayUnitMegabytesPerSecond`, `MetricAlertsDisplayUnitMicroSeconds`, `MetricAlertsDisplayUnitMilliSeconds`, `MetricAlertsDisplayUnitMillion`, `MetricAlertsDisplayUnitMillionPerSecond`, `MetricAlertsDisplayUnitMinutes`, `MetricAlertsDisplayUnitNone`, `MetricAlertsDisplayUnitPercentage`, `MetricAlertsDisplayUnitPetabytes`, `MetricAlertsDisplayUnitPetabytesPerSecond`, `MetricAlertsDisplayUnitSeconds`, `MetricAlertsDisplayUnitTerabytes`, `MetricAlertsDisplayUnitTerabytesPerSecond`, `MetricAlertsDisplayUnitThousand`, `MetricAlertsDisplayUnitThousandPerSecond`, `MetricAlertsDisplayUnitTrillion`, `MetricAlertsDisplayUnitTrillionPerSecond`
info	[Changelog] - New enum type `NotificationsForCorrelatedAlerts` with values `NotificationsForCorrelatedAlertsNotifyAlways`, `NotificationsForCorrelatedAlertsSuppressAlways`
info	[Changelog] - New function `NewAlertRuleRecommendationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AlertRuleRecommendationsClient, error)`
info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByResourcePager(string, *AlertRuleRecommendationsClientListByResourceOptions) *runtime.Pager[AlertRuleRecommendationsClientListByResourceResponse]`
info	[Changelog] - New function `*AlertRuleRecommendationsClient.NewListByTargetTypePager(string, *AlertRuleRecommendationsClientListByTargetTypeOptions) *runtime.Pager[AlertRuleRecommendationsClientListByTargetTypeResponse]`
info	[Changelog] - New function `*ClientFactory.NewAlertRuleRecommendationsClient() *AlertRuleRecommendationsClient`
info	[Changelog] - New function `*ClientFactory.NewPrometheusRuleGroupsClient() *PrometheusRuleGroupsClient`
info	[Changelog] - New function `*CorrelateAlerts.GetAction() *Action`
info	[Changelog] - New function `NewPrometheusRuleGroupsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PrometheusRuleGroupsClient, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.CreateOrUpdate(context.Context, string, string, PrometheusRuleGroupResource, *PrometheusRuleGroupsClientCreateOrUpdateOptions) (PrometheusRuleGroupsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Delete(context.Context, string, string, *PrometheusRuleGroupsClientDeleteOptions) (PrometheusRuleGroupsClientDeleteResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Get(context.Context, string, string, *PrometheusRuleGroupsClientGetOptions) (PrometheusRuleGroupsClientGetResponse, error)`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListByResourceGroupPager(string, *PrometheusRuleGroupsClientListByResourceGroupOptions) *runtime.Pager[PrometheusRuleGroupsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.NewListBySubscriptionPager(*PrometheusRuleGroupsClientListBySubscriptionOptions) *runtime.Pager[PrometheusRuleGroupsClientListBySubscriptionResponse]`
info	[Changelog] - New function `*PrometheusRuleGroupsClient.Update(context.Context, string, string, PrometheusRuleGroupResourcePatchParameters, *PrometheusRuleGroupsClientUpdateOptions) (PrometheusRuleGroupsClientUpdateResponse, error)`
info	[Changelog] - New struct `AlertRuleRecommendationProperties`
info	[Changelog] - New struct `AlertRuleRecommendationResource`
info	[Changelog] - New struct `AlertRuleRecommendationsListResponse`
info	[Changelog] - New struct `Comments`
info	[Changelog] - New struct `CorrelateAlerts`
info	[Changelog] - New struct `CorrelateBy`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponseAutoGenerated3`
info	[Changelog] - New struct `PrometheusRule`
info	[Changelog] - New struct `PrometheusRuleGroupAction`
info	[Changelog] - New struct `PrometheusRuleGroupProperties`
info	[Changelog] - New struct `PrometheusRuleGroupResource`
info	[Changelog] - New struct `PrometheusRuleGroupResourceCollection`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParameters`
info	[Changelog] - New struct `PrometheusRuleGroupResourcePatchParametersProperties`
info	[Changelog] - New struct `PrometheusRuleResolveConfiguration`
info	[Changelog] - New struct `ProxyResource`
info	[Changelog] - New struct `ResourceAutoGenerated`
info	[Changelog] - New struct `RuleArmTemplate`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 97 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from fba7ffa. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️alertsmanagement [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs]Release - Generate from fba7ffa. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

❌Az.alertsmanagement.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.alertsmanagement.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-18T12:51:04Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/alertsmanagement/armalertsmanagement	https://apiview.dev/Assemblies/Review/8b4acb12cdcf4a17868c7f8ad96e2abf

openapi-workflow-bot · 2023-04-18T12:58:29Z

Hi @noneumar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

...023-05-01-privatepreview/examples/AlertProcessingRules_Create_or_update_add_correlation.json

msyyc · 2023-06-06T09:30:08Z

@noneumar Please follow #23601 (comment) then architect will review the PR.

noneumar · 2023-06-07T05:58:29Z

Regarding:
#23601 (comment)
The breaking change is due to using apiversion from commontypes.
@msyyc Can you please continue with the PR? thank you

msyyc · 2023-06-07T06:09:22Z

Regarding: #23601 (comment) The breaking change is due to using apiversion from commontypes. @msyyc Can you please continue with the PR? thank you

@mikekistler The PR uses common-types for api-version instead of self-definition but it causes breaking alert of CI. Could you help approve it? Thanks!

mikekistler · 2023-06-07T11:36:22Z

All issues flagged as breaking changes appear benign.

msyyc · 2023-06-19T05:56:34Z

@tadelesh please help confirm Go breaking.

…version preview/2023-05-01-privatepreview (Azure#23601) * Adds base for updating Microsoft.AlertsManagement from version stable/2021-08-08 to version 2023-05-01-privatepreview * Updates readme * Updates API version in new specs and examples * added correlation example * Updated the example according to the discussion. * Continue after discussion * Removed targe region * Removed the target region * Modified correlationInterval * Fixed after a review. * Fixed file path * removed 'private' from apiversion * cont * fixed model validation * cont * Cont. * run prettier * Added "x-ms-identifiers" * Fixed avocade * fixed readme * fixed avocado * Continue * updated readmy * Modified "SuppressAll" to "SuppressAlways"

noneumar and others added 4 commits April 17, 2023 11:57

Adds base for updating Microsoft.AlertsManagement from version stable…

80a5d11

…/2021-08-08 to version 2023-05-01-privatepreview

Updates readme

b6c048a

Updates API version in new specs and examples

ecc0e6d

added correlation example

b1ac829

noneumar requested review from ofirmanor and orieldar as code owners April 18, 2023 12:50

openapi-assignment-bot bot assigned msyyc Apr 18, 2023

ghost added the Alerts Management label Apr 18, 2023

noneumar marked this pull request as draft April 18, 2023 12:53

azure-sdk mentioned this pull request Apr 18, 2023

[AutoPR sdk/resourcemanager/alertsmanagement/armalertsmanagement] [Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-05-01-privatepreview azure-sdk/azure-sdk-for-go#5377

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 18, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager labels Apr 18, 2023

azure-sdk mentioned this pull request Apr 18, 2023

[AutoPR track2_azure-mgmt-alertsmanagement] [Hub Generated] Review request for Microsoft.AlertsManagement to add version preview/2023-05-01-privatepreview azure-sdk/azure-sdk-for-python#3331

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 18, 2023

noneumar commented Apr 18, 2023

View reviewed changes