Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2023-03-01 to sync with RPSaaSMaster #23495

Conversation

priyjain358
Copy link
Member

@priyjain358 priyjain358 commented Apr 10, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
      Updating existing version due to missed changes earlier
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @priyjain358 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 10, 2023

    Swagger Validation Report

    ️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    clusters.json 2023-03-01(45526ed) 2023-03-01(main)
    Rule Message
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'clusterType' in response that was not found in the old version.
    New: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    Old: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'manufacturer' in response that was not found in the old version.
    New: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    Old: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    1045 - AddedOptionalProperty The new version has a new optional property 'clusterType' that was not found in the old version.
    New: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    Old: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    1045 - AddedOptionalProperty The new version has a new optional property 'manufacturer' that was not found in the old version.
    New: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    Old: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L744:7
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-03 package-2023-03(45526ed) package-2023-03(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L922
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L934
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L937
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L943
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L960
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L963
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Microsoft.AzureStackHCI/stable/2023-03-01/clusters.json#L980
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 10, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    azure-sdk-for-python-track2 - track2_azure-mgmt-azurestackhci - 8.0.0b2
    +	Model ArcSetting no longer has parameter created_at
    +	Model ArcSetting no longer has parameter created_by
    +	Model ArcSetting no longer has parameter created_by_type
    +	Model ArcSetting no longer has parameter last_modified_at
    +	Model ArcSetting no longer has parameter last_modified_by
    +	Model ArcSetting no longer has parameter last_modified_by_type
    +	Model Cluster no longer has parameter created_at
    +	Model Cluster no longer has parameter created_by
    +	Model Cluster no longer has parameter created_by_type
    +	Model Cluster no longer has parameter last_modified_at
    +	Model Cluster no longer has parameter last_modified_by
    +	Model Cluster no longer has parameter last_modified_by_type
    +	Model Extension no longer has parameter created_at
    +	Model Extension no longer has parameter created_by
    +	Model Extension no longer has parameter created_by_type
    +	Model Extension no longer has parameter last_modified_at
    +	Model Extension no longer has parameter last_modified_by
    +	Model Extension no longer has parameter last_modified_by_type
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5042eea. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-azurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation ArcSettingsOperations.begin_initialize_disable_process
      info	[Changelog]   - Added operation ArcSettingsOperations.consent_and_install_default_extensions
      info	[Changelog]   - Added operation ClustersOperations.begin_extend_software_assurance_benefit
      info	[Changelog]   - Added operation ExtensionsOperations.begin_upgrade
      info	[Changelog]   - Added operation group OffersOperations
      info	[Changelog]   - Added operation group PublishersOperations
      info	[Changelog]   - Added operation group SkusOperations
      info	[Changelog]   - Added operation group UpdateRunsOperations
      info	[Changelog]   - Added operation group UpdateSummariesOperations
      info	[Changelog]   - Added operation group UpdatesOperations
      info	[Changelog]   - Model ArcSetting has a new parameter default_extensions
      info	[Changelog]   - Model ArcSetting has a new parameter system_data
      info	[Changelog]   - Model Cluster has a new parameter principal_id
      info	[Changelog]   - Model Cluster has a new parameter resource_provider_object_id
      info	[Changelog]   - Model Cluster has a new parameter software_assurance_properties
      info	[Changelog]   - Model Cluster has a new parameter system_data
      info	[Changelog]   - Model Cluster has a new parameter tenant_id
      info	[Changelog]   - Model Cluster has a new parameter type_identity_type
      info	[Changelog]   - Model Cluster has a new parameter user_assigned_identities
      info	[Changelog]   - Model ClusterNode has a new parameter ehc_resource_id
      info	[Changelog]   - Model ClusterNode has a new parameter last_licensing_timestamp
      info	[Changelog]   - Model ClusterNode has a new parameter node_type
      info	[Changelog]   - Model ClusterNode has a new parameter os_display_version
      info	[Changelog]   - Model ClusterPatch has a new parameter principal_id
      info	[Changelog]   - Model ClusterPatch has a new parameter tenant_id
      info	[Changelog]   - Model ClusterPatch has a new parameter type
      info	[Changelog]   - Model ClusterPatch has a new parameter user_assigned_identities
      info	[Changelog]   - Model ClusterReportedProperties has a new parameter cluster_type
      info	[Changelog]   - Model ClusterReportedProperties has a new parameter manufacturer
      info	[Changelog]   - Model ClusterReportedProperties has a new parameter supported_capabilities
      info	[Changelog]   - Model Extension has a new parameter enable_automatic_upgrade
      info	[Changelog]   - Model Extension has a new parameter managed_by
      info	[Changelog]   - Model Extension has a new parameter system_data
      info	[Changelog]   - Model PerNodeExtensionState has a new parameter instance_view
      info	[Changelog]   - Model PerNodeExtensionState has a new parameter type_handler_version
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ArcSetting no longer has parameter created_at
      info	[Changelog]   - Model ArcSetting no longer has parameter created_by
      info	[Changelog]   - Model ArcSetting no longer has parameter created_by_type
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_at
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_by
      info	[Changelog]   - Model ArcSetting no longer has parameter last_modified_by_type
      info	[Changelog]   - Model Cluster no longer has parameter created_at
      info	[Changelog]   - Model Cluster no longer has parameter created_by
      info	[Changelog]   - Model Cluster no longer has parameter created_by_type
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_at
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_by
      info	[Changelog]   - Model Cluster no longer has parameter last_modified_by_type
      info	[Changelog]   - Model Extension no longer has parameter created_at
      info	[Changelog]   - Model Extension no longer has parameter created_by
      info	[Changelog]   - Model Extension no longer has parameter created_by_type
      info	[Changelog]   - Model Extension no longer has parameter last_modified_at
      info	[Changelog]   - Model Extension no longer has parameter last_modified_by
      info	[Changelog]   - Model Extension no longer has parameter last_modified_by_type
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5042eea. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-azurestackhci [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5042eea. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/azurestackhci/armazurestackhci [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ArcSettingAggregateStateAccepted`, `ArcSettingAggregateStateDisableInProgress`, `ArcSettingAggregateStateProvisioning` added to enum type `ArcSettingAggregateState`
      info	[Changelog] - New value `ExtensionAggregateStateAccepted`, `ExtensionAggregateStateProvisioning`, `ExtensionAggregateStateUpgradeFailedRollbackSucceeded` added to enum type `ExtensionAggregateState`
      info	[Changelog] - New value `NodeArcStateAccepted`, `NodeArcStateDisableInProgress`, `NodeArcStateInProgress`, `NodeArcStatePartiallyConnected`, `NodeArcStatePartiallySucceeded`, `NodeArcStateProvisioning` added to enum type `NodeArcState`
      info	[Changelog] - New value `NodeExtensionStateAccepted`, `NodeExtensionStateInProgress`, `NodeExtensionStatePartiallyConnected`, `NodeExtensionStatePartiallySucceeded`, `NodeExtensionStateProvisioning` added to enum type `NodeExtensionState`
      info	[Changelog] - New value `ProvisioningStateConnected`, `ProvisioningStateCreating`, `ProvisioningStateDeleted`, `ProvisioningStateDeleting`, `ProvisioningStateDisableInProgress`, `ProvisioningStateDisconnected`, `ProvisioningStateError`, `ProvisioningStateInProgress`, `ProvisioningStateMoving`, `ProvisioningStateNotSpecified`, `ProvisioningStatePartiallyConnected`, `ProvisioningStatePartiallySucceeded`, `ProvisioningStateUpdating` added to enum type `ProvisioningState`
      info	[Changelog] - New value `StatusFailed`, `StatusInProgress`, `StatusNotSpecified`, `StatusSucceeded` added to enum type `Status`
      info	[Changelog] - New enum type `AvailabilityType` with values `AvailabilityTypeLocal`, `AvailabilityTypeNotify`, `AvailabilityTypeOnline`
      info	[Changelog] - New enum type `ClusterNodeType` with values `ClusterNodeTypeFirstParty`, `ClusterNodeTypeThirdParty`
      info	[Changelog] - New enum type `ExtensionManagedBy` with values `ExtensionManagedByAzure`, `ExtensionManagedByUser`
      info	[Changelog] - New enum type `HealthState` with values `HealthStateError`, `HealthStateFailure`, `HealthStateInProgress`, `HealthStateSuccess`, `HealthStateUnknown`, `HealthStateWarning`
      info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
      info	[Changelog] - New enum type `RebootRequirement` with values `RebootRequirementFalse`, `RebootRequirementTrue`, `RebootRequirementUnknown`
      info	[Changelog] - New enum type `Severity` with values `SeverityCritical`, `SeverityHidden`, `SeverityInformational`, `SeverityWarning`
      info	[Changelog] - New enum type `SoftwareAssuranceIntent` with values `SoftwareAssuranceIntentDisable`, `SoftwareAssuranceIntentEnable`
      info	[Changelog] - New enum type `SoftwareAssuranceStatus` with values `SoftwareAssuranceStatusDisabled`, `SoftwareAssuranceStatusEnabled`
      info	[Changelog] - New enum type `State` with values `StateDownloadFailed`, `StateDownloading`, `StateHasPrerequisite`, `StateHealthCheckFailed`, `StateHealthChecking`, `StateInstallationFailed`, `StateInstalled`, `StateInstalling`, `StateInvalid`, `StateNotApplicableBecauseAnotherUpdateIsInProgress`, `StateObsolete`, `StatePreparationFailed`, `StatePreparing`, `StateReady`, `StateReadyToInstall`, `StateRecalled`, `StateScanFailed`, `StateScanInProgress`
      info	[Changelog] - New enum type `StatusLevelTypes` with values `StatusLevelTypesError`, `StatusLevelTypesInfo`, `StatusLevelTypesWarning`
      info	[Changelog] - New enum type `UpdateRunPropertiesState` with values `UpdateRunPropertiesStateFailed`, `UpdateRunPropertiesStateInProgress`, `UpdateRunPropertiesStateSucceeded`, `UpdateRunPropertiesStateUnknown`
      info	[Changelog] - New enum type `UpdateSummariesPropertiesState` with values `UpdateSummariesPropertiesStateAppliedSuccessfully`, `UpdateSummariesPropertiesStateNeedsAttention`, `UpdateSummariesPropertiesStatePreparationFailed`, `UpdateSummariesPropertiesStatePreparationInProgress`, `UpdateSummariesPropertiesStateUnknown`, `UpdateSummariesPropertiesStateUpdateAvailable`, `UpdateSummariesPropertiesStateUpdateFailed`, `UpdateSummariesPropertiesStateUpdateInProgress`
      info	[Changelog] - New function `*ArcSettingsClient.ConsentAndInstallDefaultExtensions(context.Context, string, string, string, *ArcSettingsClientConsentAndInstallDefaultExtensionsOptions) (ArcSettingsClientConsentAndInstallDefaultExtensionsResponse, error)`
      info	[Changelog] - New function `*ArcSettingsClient.BeginInitializeDisableProcess(context.Context, string, string, string, *ArcSettingsClientBeginInitializeDisableProcessOptions) (*runtime.Poller[ArcSettingsClientInitializeDisableProcessResponse], error)`
      info	[Changelog] - New function `*ClientFactory.NewOffersClient() *OffersClient`
      info	[Changelog] - New function `*ClientFactory.NewPublishersClient() *PublishersClient`
      info	[Changelog] - New function `*ClientFactory.NewSKUsClient() *SKUsClient`
      info	[Changelog] - New function `*ClientFactory.NewUpdateRunsClient() *UpdateRunsClient`
      info	[Changelog] - New function `*ClientFactory.NewUpdateSummariesClient() *UpdateSummariesClient`
      info	[Changelog] - New function `*ClientFactory.NewUpdatesClient() *UpdatesClient`
      info	[Changelog] - New function `*ClustersClient.BeginExtendSoftwareAssuranceBenefit(context.Context, string, string, SoftwareAssuranceChangeRequest, *ClustersClientBeginExtendSoftwareAssuranceBenefitOptions) (*runtime.Poller[ClustersClientExtendSoftwareAssuranceBenefitResponse], error)`
      info	[Changelog] - New function `*ExtensionsClient.BeginUpgrade(context.Context, string, string, string, string, ExtensionUpgradeParameters, *ExtensionsClientBeginUpgradeOptions) (*runtime.Poller[ExtensionsClientUpgradeResponse], error)`
      info	[Changelog] - New function `NewOffersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*OffersClient, error)`
      info	[Changelog] - New function `*OffersClient.Get(context.Context, string, string, string, string, *OffersClientGetOptions) (OffersClientGetResponse, error)`
      info	[Changelog] - New function `*OffersClient.NewListByClusterPager(string, string, *OffersClientListByClusterOptions) *runtime.Pager[OffersClientListByClusterResponse]`
      info	[Changelog] - New function `*OffersClient.NewListByPublisherPager(string, string, string, *OffersClientListByPublisherOptions) *runtime.Pager[OffersClientListByPublisherResponse]`
      info	[Changelog] - New function `NewPublishersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*PublishersClient, error)`
      info	[Changelog] - New function `*PublishersClient.Get(context.Context, string, string, string, *PublishersClientGetOptions) (PublishersClientGetResponse, error)`
      info	[Changelog] - New function `*PublishersClient.NewListByClusterPager(string, string, *PublishersClientListByClusterOptions) *runtime.Pager[PublishersClientListByClusterResponse]`
      info	[Changelog] - New function `NewSKUsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*SKUsClient, error)`
      info	[Changelog] - New function `*SKUsClient.Get(context.Context, string, string, string, string, string, *SKUsClientGetOptions) (SKUsClientGetResponse, error)`
      info	[Changelog] - New function `*SKUsClient.NewListByOfferPager(string, string, string, string, *SKUsClientListByOfferOptions) *runtime.Pager[SKUsClientListByOfferResponse]`
      info	[Changelog] - New function `NewUpdateRunsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateRunsClient, error)`
      info	[Changelog] - New function `*UpdateRunsClient.BeginDelete(context.Context, string, string, string, string, *UpdateRunsClientBeginDeleteOptions) (*runtime.Poller[UpdateRunsClientDeleteResponse], error)`
      info	[Changelog] - New function `*UpdateRunsClient.Get(context.Context, string, string, string, string, *UpdateRunsClientGetOptions) (UpdateRunsClientGetResponse, error)`
      info	[Changelog] - New function `*UpdateRunsClient.NewListPager(string, string, string, *UpdateRunsClientListOptions) *runtime.Pager[UpdateRunsClientListResponse]`
      info	[Changelog] - New function `*UpdateRunsClient.Put(context.Context, string, string, string, string, UpdateRun, *UpdateRunsClientPutOptions) (UpdateRunsClientPutResponse, error)`
      info	[Changelog] - New function `NewUpdateSummariesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdateSummariesClient, error)`
      info	[Changelog] - New function `*UpdateSummariesClient.BeginDelete(context.Context, string, string, *UpdateSummariesClientBeginDeleteOptions) (*runtime.Poller[UpdateSummariesClientDeleteResponse], error)`
      info	[Changelog] - New function `*UpdateSummariesClient.Get(context.Context, string, string, *UpdateSummariesClientGetOptions) (UpdateSummariesClientGetResponse, error)`
      info	[Changelog] - New function `*UpdateSummariesClient.NewListPager(string, string, *UpdateSummariesClientListOptions) *runtime.Pager[UpdateSummariesClientListResponse]`
      info	[Changelog] - New function `*UpdateSummariesClient.Put(context.Context, string, string, UpdateSummaries, *UpdateSummariesClientPutOptions) (UpdateSummariesClientPutResponse, error)`
      info	[Changelog] - New function `NewUpdatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UpdatesClient, error)`
      info	[Changelog] - New function `*UpdatesClient.BeginDelete(context.Context, string, string, string, *UpdatesClientBeginDeleteOptions) (*runtime.Poller[UpdatesClientDeleteResponse], error)`
      info	[Changelog] - New function `*UpdatesClient.Get(context.Context, string, string, string, *UpdatesClientGetOptions) (UpdatesClientGetResponse, error)`
      info	[Changelog] - New function `*UpdatesClient.NewListPager(string, string, *UpdatesClientListOptions) *runtime.Pager[UpdatesClientListResponse]`
      info	[Changelog] - New function `*UpdatesClient.BeginPost(context.Context, string, string, string, *UpdatesClientBeginPostOptions) (*runtime.Poller[UpdatesClientPostResponse], error)`
      info	[Changelog] - New function `*UpdatesClient.Put(context.Context, string, string, string, Update, *UpdatesClientPutOptions) (UpdatesClientPutResponse, error)`
      info	[Changelog] - New struct `DefaultExtensionDetails`
      info	[Changelog] - New struct `ExtensionInstanceView`
      info	[Changelog] - New struct `ExtensionInstanceViewStatus`
      info	[Changelog] - New struct `ExtensionUpgradeParameters`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `Offer`
      info	[Changelog] - New struct `OfferList`
      info	[Changelog] - New struct `OfferProperties`
      info	[Changelog] - New struct `PackageVersionInfo`
      info	[Changelog] - New struct `PrecheckResult`
      info	[Changelog] - New struct `PrecheckResultTags`
      info	[Changelog] - New struct `Publisher`
      info	[Changelog] - New struct `PublisherList`
      info	[Changelog] - New struct `PublisherProperties`
      info	[Changelog] - New struct `SKU`
      info	[Changelog] - New struct `SKUList`
      info	[Changelog] - New struct `SKUMappings`
      info	[Changelog] - New struct `SKUProperties`
      info	[Changelog] - New struct `SoftwareAssuranceChangeRequest`
      info	[Changelog] - New struct `SoftwareAssuranceChangeRequestProperties`
      info	[Changelog] - New struct `SoftwareAssuranceProperties`
      info	[Changelog] - New struct `Step`
      info	[Changelog] - New struct `Update`
      info	[Changelog] - New struct `UpdateList`
      info	[Changelog] - New struct `UpdatePrerequisite`
      info	[Changelog] - New struct `UpdateProperties`
      info	[Changelog] - New struct `UpdateRun`
      info	[Changelog] - New struct `UpdateRunList`
      info	[Changelog] - New struct `UpdateRunProperties`
      info	[Changelog] - New struct `UpdateStateProperties`
      info	[Changelog] - New struct `UpdateSummaries`
      info	[Changelog] - New struct `UpdateSummariesList`
      info	[Changelog] - New struct `UpdateSummariesProperties`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `DefaultExtensions` in struct `ArcSettingProperties`
      info	[Changelog] - New field `Identity` in struct `Cluster`
      info	[Changelog] - New field `EhcResourceID` in struct `ClusterNode`
      info	[Changelog] - New field `LastLicensingTimestamp` in struct `ClusterNode`
      info	[Changelog] - New field `NodeType` in struct `ClusterNode`
      info	[Changelog] - New field `OSDisplayVersion` in struct `ClusterNode`
      info	[Changelog] - New field `Identity` in struct `ClusterPatch`
      info	[Changelog] - New field `ResourceProviderObjectID` in struct `ClusterProperties`
      info	[Changelog] - New field `SoftwareAssuranceProperties` in struct `ClusterProperties`
      info	[Changelog] - New field `ClusterType` in struct `ClusterReportedProperties`
      info	[Changelog] - New field `Manufacturer` in struct `ClusterReportedProperties`
      info	[Changelog] - New field `SupportedCapabilities` in struct `ClusterReportedProperties`
      info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `ExtensionParameters`
      info	[Changelog] - New field `ManagedBy` in struct `ExtensionProperties`
      info	[Changelog] - New field `InstanceView` in struct `PerNodeExtensionState`
      info	[Changelog] - New field `TypeHandlerVersion` in struct `PerNodeExtensionState`
      info	[Changelog] - New field `SystemData` in struct `ProxyResource`
      info	[Changelog] - New field `SystemData` in struct `Resource`
      info	[Changelog] - New field `SystemData` in struct `TrackedResource`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 224 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5042eea. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-azurestackhci [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias OffersListByClusterResponse
      info	[Changelog]   - Added Type Alias OffersListByPublisherNextResponse
      info	[Changelog]   - Added Type Alias OffersListByPublisherResponse
      info	[Changelog]   - Added Type Alias PublishersGetResponse
      info	[Changelog]   - Added Type Alias PublishersListByClusterNextResponse
      info	[Changelog]   - Added Type Alias PublishersListByClusterResponse
      info	[Changelog]   - Added Type Alias RebootRequirement
      info	[Changelog]   - Added Type Alias Severity
      info	[Changelog]   - Added Type Alias SkusGetResponse
      info	[Changelog]   - Added Type Alias SkusListByOfferNextResponse
      info	[Changelog]   - Added Type Alias SkusListByOfferResponse
      info	[Changelog]   - Added Type Alias SoftwareAssuranceIntent
      info	[Changelog]   - Added Type Alias SoftwareAssuranceStatus
      info	[Changelog]   - Added Type Alias State
      info	[Changelog]   - Added Type Alias StatusLevelTypes
      info	[Changelog]   - Added Type Alias UpdateRunPropertiesState
      info	[Changelog]   - Added Type Alias UpdateRunsGetResponse
      info	[Changelog]   - Added Type Alias UpdateRunsListNextResponse
      info	[Changelog]   - Added Type Alias UpdateRunsListResponse
      info	[Changelog]   - Added Type Alias UpdateRunsPutResponse
      info	[Changelog]   - Added Type Alias UpdatesGetResponse
      info	[Changelog]   - Added Type Alias UpdatesListNextResponse
      info	[Changelog]   - Added Type Alias UpdatesListResponse
      info	[Changelog]   - Added Type Alias UpdatesPutResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesGetResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesListNextResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesListResponse
      info	[Changelog]   - Added Type Alias UpdateSummariesPropertiesState
      info	[Changelog]   - Added Type Alias UpdateSummariesPutResponse
      info	[Changelog]   - Interface ArcSetting has a new optional parameter defaultExtensions
      info	[Changelog]   - Interface Cluster has a new optional parameter principalId
      info	[Changelog]   - Interface Cluster has a new optional parameter resourceProviderObjectId
      info	[Changelog]   - Interface Cluster has a new optional parameter softwareAssuranceProperties
      info	[Changelog]   - Interface Cluster has a new optional parameter tenantId
      info	[Changelog]   - Interface Cluster has a new optional parameter typeIdentityType
      info	[Changelog]   - Interface Cluster has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface ClusterNode has a new optional parameter ehcResourceId
      info	[Changelog]   - Interface ClusterNode has a new optional parameter lastLicensingTimestamp
      info	[Changelog]   - Interface ClusterNode has a new optional parameter nodeType
      info	[Changelog]   - Interface ClusterNode has a new optional parameter osDisplayVersion
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter principalId
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter tenantId
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter type
      info	[Changelog]   - Interface ClusterPatch has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface ClusterReportedProperties has a new optional parameter clusterType
      info	[Changelog]   - Interface ClusterReportedProperties has a new optional parameter manufacturer
      info	[Changelog]   - Interface ClusterReportedProperties has a new optional parameter supportedCapabilities
      info	[Changelog]   - Interface Extension has a new optional parameter enableAutomaticUpgrade
      info	[Changelog]   - Interface Extension has a new optional parameter managedBy
      info	[Changelog]   - Interface PerNodeExtensionState has a new optional parameter instanceView
      info	[Changelog]   - Interface PerNodeExtensionState has a new optional parameter typeHandlerVersion
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownAvailabilityType
      info	[Changelog]   - Added Enum KnownClusterNodeType
      info	[Changelog]   - Added Enum KnownExtensionManagedBy
      info	[Changelog]   - Added Enum KnownHealthState
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
      info	[Changelog]   - Added Enum KnownRebootRequirement
      info	[Changelog]   - Added Enum KnownSeverity
      info	[Changelog]   - Added Enum KnownSoftwareAssuranceIntent
      info	[Changelog]   - Added Enum KnownSoftwareAssuranceStatus
      info	[Changelog]   - Added Enum KnownState
      info	[Changelog]   - Added Enum KnownStatusLevelTypes
      info	[Changelog]   - Added Enum KnownUpdateRunPropertiesState
      info	[Changelog]   - Added Enum KnownUpdateSummariesPropertiesState
      info	[Changelog]   - Enum KnownArcSettingAggregateState has a new value Accepted
      info	[Changelog]   - Enum KnownArcSettingAggregateState has a new value DisableInProgress
      info	[Changelog]   - Enum KnownArcSettingAggregateState has a new value Provisioning
      info	[Changelog]   - Enum KnownExtensionAggregateState has a new value Accepted
      info	[Changelog]   - Enum KnownExtensionAggregateState has a new value Provisioning
      info	[Changelog]   - Enum KnownExtensionAggregateState has a new value UpgradeFailedRollbackSucceeded
      info	[Changelog]   - Enum KnownNodeArcState has a new value Accepted
      info	[Changelog]   - Enum KnownNodeArcState has a new value DisableInProgress
      info	[Changelog]   - Enum KnownNodeArcState has a new value InProgress
      info	[Changelog]   - Enum KnownNodeArcState has a new value PartiallyConnected
      info	[Changelog]   - Enum KnownNodeArcState has a new value PartiallySucceeded
      info	[Changelog]   - Enum KnownNodeArcState has a new value Provisioning
      info	[Changelog]   - Enum KnownNodeExtensionState has a new value Accepted
      info	[Changelog]   - Enum KnownNodeExtensionState has a new value InProgress
      info	[Changelog]   - Enum KnownNodeExtensionState has a new value PartiallyConnected
      info	[Changelog]   - Enum KnownNodeExtensionState has a new value PartiallySucceeded
      info	[Changelog]   - Enum KnownNodeExtensionState has a new value Provisioning
      info	[Changelog]   - Enum KnownProvisioningState has a new value Connected
      info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
      info	[Changelog]   - Enum KnownProvisioningState has a new value Deleted
      info	[Changelog]   - Enum KnownProvisioningState has a new value Deleting
      info	[Changelog]   - Enum KnownProvisioningState has a new value DisableInProgress
      info	[Changelog]   - Enum KnownProvisioningState has a new value Disconnected
      info	[Changelog]   - Enum KnownProvisioningState has a new value Error
      info	[Changelog]   - Enum KnownProvisioningState has a new value InProgress
      info	[Changelog]   - Enum KnownProvisioningState has a new value Moving
      info	[Changelog]   - Enum KnownProvisioningState has a new value NotSpecified
      info	[Changelog]   - Enum KnownProvisioningState has a new value PartiallyConnected
      info	[Changelog]   - Enum KnownProvisioningState has a new value PartiallySucceeded
      info	[Changelog]   - Enum KnownProvisioningState has a new value Updating
      info	[Changelog]   - Enum KnownStatus has a new value Failed
      info	[Changelog]   - Enum KnownStatus has a new value InProgress
      info	[Changelog]   - Enum KnownStatus has a new value NotSpecified
      info	[Changelog]   - Enum KnownStatus has a new value Succeeded
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Interface ArcSetting no longer has parameter createdAt
      info	[Changelog]   - Interface ArcSetting no longer has parameter createdBy
      info	[Changelog]   - Interface ArcSetting no longer has parameter createdByType
      info	[Changelog]   - Interface ArcSetting no longer has parameter lastModifiedAt
      info	[Changelog]   - Interface ArcSetting no longer has parameter lastModifiedBy
      info	[Changelog]   - Interface ArcSetting no longer has parameter lastModifiedByType
      info	[Changelog]   - Interface Cluster no longer has parameter createdAt
      info	[Changelog]   - Interface Cluster no longer has parameter createdBy
      info	[Changelog]   - Interface Cluster no longer has parameter createdByType
      info	[Changelog]   - Interface Cluster no longer has parameter lastModifiedAt
      info	[Changelog]   - Interface Cluster no longer has parameter lastModifiedBy
      info	[Changelog]   - Interface Cluster no longer has parameter lastModifiedByType
      info	[Changelog]   - Interface Extension no longer has parameter createdAt
      info	[Changelog]   - Interface Extension no longer has parameter createdBy
      info	[Changelog]   - Interface Extension no longer has parameter createdByType
      info	[Changelog]   - Interface Extension no longer has parameter lastModifiedAt
      info	[Changelog]   - Interface Extension no longer has parameter lastModifiedBy
      info	[Changelog]   - Interface Extension no longer has parameter lastModifiedByType
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 5042eea. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️azurestackhci [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 5042eea. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.azurestackhci.DefaultTag [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the ArcReview label Apr 10, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 10, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/azurestackhci/armazurestackhci https://apiview.dev/Assemblies/Review/d0520a5197bb4f7f9dc29a6c454e6095
    JavaScript @azure/arm-azurestackhci https://apiview.dev/Assemblies/Review/161d060fb45c434281e0bd16e8cff558

    @openapi-workflow-bot
    Copy link

    Hi @priyjain358 and @arcboard, one or more change(s) have been detected in your Arc enabled VM's or Arc enabled Server's RPs. Please review the changes and ensure that no gaps have been introduced with respect to the ARM API modeling consistency across Azure Arc and Azure Compute. For further details, see guidelines at Consistency in ARM Modeling. To approve the change(s), set the label to ArcSignedOff. If you have any questions, please mail to [email protected].

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 10, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @priyjain358 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @priyjain358
    Copy link
    Member Author

    There were some changes that were missed while raising a Pr to the public repo. These changes already exist in the private repo : https://github.com/Azure/azure-rest-api-specs-pr/pull/11574
    This API version was rolled out to Public cloud only a few days ago and hasn't been rolled out to sovereign Clouds yet. Hence, we are hoping to go ahead without creating a new API version

    @chunyu3
    Copy link
    Member

    chunyu3 commented Apr 10, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @priyjain358 priyjain358 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 11, 2023
    @chunyu3 chunyu3 added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 11, 2023
    @openapi-workflow-bot
    Copy link

    Hi @priyjain358, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 12, 2023
    @raych1
    Copy link
    Member

    raych1 commented Apr 13, 2023

    There were some changes that were missed while raising a Pr to the public repo. These changes already exist in the private repo : Azure/azure-rest-api-specs-pr#11574 This API version was rolled out to Public cloud only a few days ago and hasn't been rolled out to sovereign Clouds yet. Hence, we are hoping to go ahead without creating a new API version

    @chunyu3 , I confirmed that the changes in this PR were already signed off by ARM by above PR.

    @chunyu3 chunyu3 merged commit 5042eea into Azure:main Apr 13, 2023
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    * Adds base for updating Microsoft.AzureStackHCI from version stable/2023-02-01 to version 2023-03-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Consent and Disable APIs added
    
    * add managed by for extensions
    
    * prettier fix
    
    * Update cluster resource json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ArcReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript NewApiVersionRequired resource-manager RPaaS
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants