[Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' #23479

elisauhura · 2023-04-07T08:56:10Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

elisauhura · 2023-04-07T08:56:11Z

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/11877

openapi-workflow-bot · 2023-04-07T08:56:14Z

Hi, @elisauhura Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-07T08:56:15Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
Pipeline.json	2018-06-01(3046799)	2018-06-01(main)

Rule	Message
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'setSystemVariable' that was not found in the old version. New: stable/2018-06-01/entityTypes/Pipeline.json#L7173:7 Old: stable/2018-06-01/entityTypes/Pipeline.json#L7173:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 1 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2018-06	package-2018-06(3046799)	package-2018-06(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: stable/2018-06-01/entityTypes/Pipeline.json#L7182

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
`❌` MissingTypeObject	The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
`❌` MissingTypeObject	The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
`❌` MissingTypeObject	The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
`❌` MissingTypeObject	The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
`❌` MissingTypeObject	The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5196
`❌` MissingTypeObject	The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5215
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5266
`❌` MissingTypeObject	The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5285
`❌` MissingTypeObject	The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5304
`❌` MissingTypeObject	The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5343
`❌` MissingTypeObject	The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5362
`❌` MissingTypeObject	The schema 'HDInsightStreamingActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5423
`❌` MissingTypeObject	The schema 'HDInsightStreamingActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5442
`❌` MissingTypeObject	The schema 'HDInsightSparkActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5527
`❌` MissingTypeObject	The schema 'HDInsightSparkActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5546
`❌` MissingTypeObject	The schema 'ExecuteSSISPackageActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5596
`❌` MissingTypeObject	The schema 'ExecuteSSISPackageActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5615
`❌` MissingTypeObject	The schema 'CustomActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5915
`❌` MissingTypeObject	The schema 'CustomActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5934
`❌` MissingTypeObject	The schema 'CustomActivityReferenceObject' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5974
`❌` MissingTypeObject	The schema 'SqlServerStoredProcedureActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5999
`❌` MissingTypeObject	The schema 'SqlServerStoredProcedureActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6019
`❌` MissingTypeObject	The schema 'ExecutePipelineActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6035
`❌` MissingTypeObject	The schema 'ExecutePipelineActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6071
`❌` MissingTypeObject	The schema 'DeleteActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6091
`❌` MissingTypeObject	The schema 'DeleteActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6110
`❌` IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6117
`❌` MissingTypeObject	The schema 'AzureDataExplorerCommandActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6143

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-07T08:56:15Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-datafactory - Approved - 12.0.0

+	Type of parameter enablePartitionDiscovery of interface AzureBlobFSReadSettings is changed from boolean to any
+	Type of parameter enablePartitionDiscovery of interface AzureDataLakeStoreReadSettings is changed from boolean to any

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:759
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 759 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.DataFactory [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-datafactory [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model IntegrationRuntimeDataFlowProperties has a new parameter custom_properties
info	[Changelog]   - Model SetVariableActivity has a new parameter set_system_variable

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.

️✔️azure-resourcemanager-datafactory [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/datafactory/armdatafactory [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - Type of `AzureBlobFSReadSettings.EnablePartitionDiscovery` has been changed from `*bool` to `any`
info	[Changelog] - Type of `AzureDataLakeStoreReadSettings.EnablePartitionDiscovery` has been changed from `*bool` to `any`
info	[Changelog] - New struct `IntegrationRuntimeDataFlowPropertiesCustomPropertiesItem`
info	[Changelog] - New field `CustomProperties` in struct `IntegrationRuntimeDataFlowProperties`
info	[Changelog] - New field `SetSystemVariable` in struct `SetVariableActivityTypeProperties`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 4 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-datafactory [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-datafactory-12.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface IntegrationRuntimeDataFlowPropertiesCustomPropertiesItem
info	[Changelog]   - Interface IntegrationRuntimeDataFlowProperties has a new optional parameter customProperties
info	[Changelog]   - Interface SetVariableActivity has a new optional parameter setSystemVariable
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Type of parameter enablePartitionDiscovery of interface AzureBlobFSReadSettings is changed from boolean to any
info	[Changelog]   - Type of parameter enablePartitionDiscovery of interface AzureDataLakeStoreReadSettings is changed from boolean to any

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 5eb162a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️datafactory [View full logs] [Release Schema Changes]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from 5eb162a. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.datafactory.DefaultTag [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-07T08:56:16Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/datafactory/armdatafactory	https://apiview.dev/Assemblies/Review/b9496b5fa0964b1097cd4b3804b77c0d
Java	azure-resourcemanager-datafactory	Create ApiView failed. Please ask PR assignee for help
JavaScript	@azure/arm-datafactory	https://apiview.dev/Assemblies/Review/432457319f324b0e98566856ef71bbbc

elisauhura · 2023-04-17T17:15:21Z

@lirenhe, Breaking changes exception is approved as observable in the private PR.

raych1 · 2023-04-18T02:59:16Z

/azp run

azure-pipelines · 2023-04-18T02:59:25Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2023-04-18T03:07:27Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

lirenhe · 2023-04-18T03:16:07Z

The JS breaking change is not related to this PR. cc @qiaozha

lirenhe · 2023-04-18T03:17:24Z

Breaking change was approved in the private repo.

…wagger' (Azure#23479) * [AutoSync] 4abf9f4813 Add property to enable Set Pipeline Run Output. * [AutoSync] e1270606a9 Adjust naming --------- Co-authored-by: swagger-automation <[email protected]>

AzureRestAPISpecReview added 2 commits March 28, 2023 20:11

[AutoSync] 4abf9f4813 Add property to enable Set Pipeline Run Output.

937fa15

[AutoSync] e1270606a9 Adjust naming

3046799

elisauhura requested review from Frey-Wang, zhangyd2015 and davidzhaoyue as code owners April 7, 2023 08:56

openapi-assignment-bot bot assigned lirenhe Apr 7, 2023

ghost added the Data Factory label Apr 7, 2023

azure-sdk mentioned this pull request Apr 7, 2023

[AutoPR sdk/resourcemanager/datafactory/armdatafactory] [Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' azure-sdk/azure-sdk-for-go#5218

Closed

AzureRestAPISpecReview added the resource-manager label Apr 7, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 7, 2023

AzureRestAPISpecReview added the NewApiVersionRequired label Apr 18, 2023

lirenhe added Approved-SdkBreakingChange-JavaScript Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels Apr 18, 2023

lirenhe approved these changes Apr 18, 2023

View reviewed changes

lirenhe merged commit 5eb162a into main Apr 18, 2023

lirenhe deleted the published/Azure/azure-rest-api-specs-pr/datafactory/eldasilva/updateSwagger branch April 18, 2023 03:18

azure-sdk mentioned this pull request Apr 18, 2023

[ReleasePR sdk/resourcemanager/datafactory/armdatafactory] [Hub Generated] Publish private branch 'datafactory/zheyuanzhang/lakehouse_swagger' Azure/azure-sdk-for-go#19053

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 18, 2023

elisauhura mentioned this pull request Apr 19, 2023

Sync ADF changes into Synapses: Add setSystemVariable #23619

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' #23479

[Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' #23479

elisauhura commented Apr 7, 2023

elisauhura commented Apr 7, 2023

openapi-workflow-bot bot commented Apr 7, 2023

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

elisauhura commented Apr 17, 2023

raych1 commented Apr 18, 2023

azure-pipelines bot commented Apr 18, 2023

openapi-workflow-bot bot commented Apr 18, 2023

lirenhe commented Apr 18, 2023 •

edited

Loading

lirenhe commented Apr 18, 2023

[Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' #23479

[Hub Generated] Publish private branch 'datafactory/eldasilva/updateSwagger' #23479

Conversation

elisauhura commented Apr 7, 2023

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

elisauhura commented Apr 7, 2023

openapi-workflow-bot bot commented Apr 7, 2023

openapi-pipeline-app bot commented Apr 7, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 7, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 7, 2023 • edited Loading

Generated ApiView

elisauhura commented Apr 17, 2023

raych1 commented Apr 18, 2023

azure-pipelines bot commented Apr 18, 2023

openapi-workflow-bot bot commented Apr 18, 2023

lirenhe commented Apr 18, 2023 • edited Loading

lirenhe commented Apr 18, 2023

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 7, 2023 •

edited

Loading

lirenhe commented Apr 18, 2023 •

edited

Loading