Mvad update

[mikekistler]

This PR updates the TypeSpec for AnomalyDetector to the latest TypeSpec and Azure.Core versions. It also fixes some minor issues in the API definition. Some details:

Fixes:

• topContributorCount is optional with default of 10
• Fix x-ms-error-code header
• Suppress camel case warnings on some properties
• remove @fixed from enums
• removed language emitters from tspconfig.yaml
• Marked status and diagnosticsInfo as readOnly in ModelInfo
• removed readOnly from resultId in response-only models
• Added documentation string to auth model
• Added suppressions and comments on operations that don't use Azure core operation templates
• Replaced skip and top parameters with Azure.Core definitions.

[openapi-workflow-bot]

Hi, @mikekistler Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 21 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
openapi.json	v1.1(f646fdc)	v1.1(main)

Rule	Message
❌ 1014 - RemovingHeader	The new version removs a required header 'operation-id'. Old: AnomalyDetector/stable/v1.1/openapi.json#L315:15
❌ 1014 - RemovingHeader	The new version removs a required header 'operation-location'. Old: AnomalyDetector/stable/v1.1/openapi.json#L319:15
❌ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: AnomalyDetector/stable/v1.1/openapi.json#L1052:7 Old: AnomalyDetector/stable/v1.1/openapi.json#L1078:7
❌ 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: AnomalyDetector/stable/v1.1/openapi.json#L1182:7 Old: AnomalyDetector/stable/v1.1/openapi.json#L1208:7
❌ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L163:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L163:11
❌ 1027 - DefaultValueChanged	The new version has a different default value than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L1062:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L1088:9
❌ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: AnomalyDetector/stable/v1.1/openapi.json#L1024:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L1049:9
❌ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: AnomalyDetector/stable/v1.1/openapi.json#L552:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L578:9
❌ 1034 - AddedRequiredProperty	The new version has new required property 'code, message' that was not found in the old version. New: AnomalyDetector/stable/v1.1/openapi.json#L419:13 Old: AnomalyDetector/stable/v1.1/openapi.json#L429:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'code, message' that was not found in the old version. New: AnomalyDetector/stable/v1.1/openapi.json#L462:13 Old: AnomalyDetector/stable/v1.1/openapi.json#L472:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'code, message' that was not found in the old version. New: AnomalyDetector/stable/v1.1/openapi.json#L505:13 Old: AnomalyDetector/stable/v1.1/openapi.json#L515:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'code, message' that was not found in the old version. New: AnomalyDetector/stable/v1.1/openapi.json#L1180:5 Old: AnomalyDetector/stable/v1.1/openapi.json#L1206:5
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L957:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L982:9
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L533:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L559:9
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L788:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L815:9
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L1346:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L1368:9
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L1418:9 Old: AnomalyDetector/stable/v1.1/openapi.json#L1440:9
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L519:5 Old: AnomalyDetector/stable/v1.1/openapi.json#L545:5
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L892:5 Old: AnomalyDetector/stable/v1.1/openapi.json#L917:5
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L990:5 Old: AnomalyDetector/stable/v1.1/openapi.json#L1015:5
❌ 1047 - XmsEnumChanged	The new version has a different x-ms-enum 'modelAsString' than the previous one. New: AnomalyDetector/stable/v1.1/openapi.json#L1259:5 Old: AnomalyDetector/stable/v1.1/openapi.json#L1281:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
release_1_1	release_1_1(f646fdc)	release_1_1(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L71
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L113
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L160
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L203
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L239
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L280
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Multivariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L340
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L390
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L433
❌ OperationIdNounVerb	Per the Noun_Verb convention for Operation Ids, the noun 'Univariate' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: AnomalyDetector/stable/v1.1/openapi.json#L476
⚠️ VersionConvention	API version should be a date in YYYY-MM-DD format, optionally suffixed with '-preview'. Location: AnomalyDetector/stable/v1.1/openapi.json#L5
⚠️ PageableOperation	Based on the response model schema, operation 'Multivariate_GetMultivariateBatchDetectionResult' might be pageable. Consider adding the x-ms-pageable extension. Location: AnomalyDetector/stable/v1.1/openapi.json#L70
⚠️ PaginationResponse	Operation might be pageable. Consider adding the x-ms-pageable extension. Location: AnomalyDetector/stable/v1.1/openapi.json#L70
⚠️ VersionPolicy	Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L74
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L75
⚠️ ErrorResponse	Error response schema should contain an object property named error. Location: AnomalyDetector/stable/v1.1/openapi.json#L99
⚠️ VersionPolicy	Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L116
⚠️ Post201Response	Using post for a create operation is discouraged. Location: AnomalyDetector/stable/v1.1/openapi.json#L128
⚠️ ErrorResponse	Error response schema should contain an object property named error. Location: AnomalyDetector/stable/v1.1/openapi.json#L148
⚠️ VersionPolicy	Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L163
⚠️ PaginationResponse	Response body schema of pageable response should contain top-level array property value Location: AnomalyDetector/stable/v1.1/openapi.json#L174
⚠️ ErrorResponse	Error response schema should contain an object property named error. Location: AnomalyDetector/stable/v1.1/openapi.json#L186
⚠️ VersionPolicy	Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L206
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L207
⚠️ ErrorResponse	Error response schema should contain an object property named error. Location: AnomalyDetector/stable/v1.1/openapi.json#L227
⚠️ VersionPolicy	Operation does not define an 'api-version' query parameter. Location: AnomalyDetector/stable/v1.1/openapi.json#L242
⚠️ PathParameterSchema	Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: AnomalyDetector/stable/v1.1/openapi.json#L243
⚠️ ErrorResponse	Error response schema should contain an object property named error. Location: AnomalyDetector/stable/v1.1/openapi.json#L266
⚠️ LroExtension	Operations with a 202 response should specify x-ms-long-running-operation: true. Location: AnomalyDetector/stable/v1.1/openapi.json#L279
⚠️ PaginationResponse	Operation might be pageable. Consider adding the x-ms-pageable extension. Location: AnomalyDetector/stable/v1.1/openapi.json#L279

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️❌TypeSpec Validation: 10 Errors, 7 Warnings failed [Detail]

Rule	Message
❌ unknown-identifier	Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L9
❌ unknown-identifier	Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L10
❌ unknown-identifier	Unknown identifier Cadl Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93
❌ unknown-decorator	Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/finetune.tsp#L93
❌ unknown-identifier	Unknown identifier route Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27
❌ unknown-decorator	Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L27
❌ unknown-identifier	Unknown identifier get Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28
❌ unknown-decorator	Unknown decorator Location: specification/cognitiveservices/OpenAI.Authoring/model.routes.tsp#L28
❌ MissingExamplesDirectory	"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Authoring, please ensure the 'examples' is added in the PR."
❌ MissingExamplesDirectory	"details":"The 'examples' directory is missing in the typespec folder specification/cognitiveservices/OpenAI.Inference, please ensure the 'examples' is added in the PR."
⚠️ deprecated: Deprecated	@versionedDependency is deprecated. Use @useDependency instead. Location: specification/cognitiveservices/OpenAI.Authoring/main.tsp#L23
⚠️ deprecated: Deprecated	@versionedDependency is deprecated. Use @useDependency instead. Location: specification/cognitiveservices/OpenAI.Inference/main.tsp#L34
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/AnomalyDetector, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Authoring, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'output-file' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."
⚠️ MissingTypeSpecProjectConfig	"details":"The configuration 'azure-resource-provider-folder' for '@azure-tools/typespec-autorest' is missing in the tspconfig.yaml under folder specification/cognitiveservices/OpenAI.Inference, please ensure it is added in the configuration of the emitter '@azure-tools/typespec-autorest'."

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

• ❌Code Generator Failed [Logs]Release - Generate from 665a816. SDK Automation 14.0.0

  command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
  command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mException: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/Invoke-GenerateAndBuildV2.ps1:133
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 133 | �[0m             �[36;1mthrow "Not provide service name or namespace."�[0m
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mNot provide service name or namespace.
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1
  warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 665a816. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  warn		specification/cognitiveservices/data-plane/AnomalyDetector/readme.md skipped due to azure-sdk-for-python not found in swagger-to-sdk
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh] npm notice
  cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
  cmderr	[automation_generate.sh] npm notice
  warn	No file changes detected after generation
  warn	No package detected after generation

️⚠️ azure-sdk-for-java warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 665a816. SDK Automation 14.0.0

  command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
  warn		specification/cognitiveservices/data-plane/AnomalyDetector/readme.md skipped due to azure-sdk-for-java not found in swagger-to-sdk
  command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  warn	No file changes detected after generation
  warn	No package detected after generation

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Swagger	v1.1	https://apiview.dev/Assemblies/Review/4adc90e5f381403e8cd4c8c1d591e350

[openapi-workflow-bot]

Hi @mikekistler, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

[openapi-workflow-bot]

Hi @mikekistler, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

[mikekistler]

Another improvement that would be nice is to add @doc strings on some of the enums, like:

enum AlignMode {
  "Inner",
  "Outer",
}

Those @doc strings will improve developer experience with descriptions for each value in the generated REST API Docs and generated SDKs.

FillNAMethod is another enum that would benefit from @doc on the values.

[heaths]

@mikekistler there's several required checks failures:

• Add "Detectory" to /custom-words.txt, if that is indeed a word.
• A bunch of samples are missing properties declared in swagger. We could override, but this will just continue to be a problem. But maybe that's not the focus here. Let me know.
• There are a lot of breaking changes to review. Is this PR a correct? Given this is all in main - since we won't use version subdirs for TypeSpec - is this a constant problem we're going to face unless validation is fixed?

[heaths]

Approving breaking changes which are either intentional, or because validation was case-sensitive when it shouldn't have been e.g., HTTP headers are case-insensitive by specification.