Fix bug where ReplicationRoles was exposing unsupported roles #23294

ambrahma · 2023-03-26T15:05:53Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
  Update ReplicationRole entity to remove unsupported replication roles which were exposed as part of Server properties.
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

Raised breaking change review https://msazure.visualstudio.com/One/_workitems/edit/17690672

openapi-workflow-bot · 2023-03-26T15:05:56Z

Hi, @ambrahma Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-03-26T15:05:56Z

Swagger Validation Report

️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
FlexibleServers.json	2022-03-08-preview(eb00a45)	2022-03-08-preview(main)
FlexibleServers.json	2022-12-01(eb00a45)	2022-12-01(main)

Rule	Message
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L508:9 Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L508:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L634:9 Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L634:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L814:5 Old: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L814:5
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L513:9 Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L513:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L639:9 Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L639:9
`❌` 1019 - RemovedEnumValue	The new version is removing enum value(s) 'Secondary, WalReplica, SyncReplica, GeoSyncReplica' from the old version. New: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L835:5 Old: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L835:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-flexibleserver-2022-12-01	package-flexibleserver-2022-12-01(eb00a45)	package-flexibleserver-2022-12-01(main)
package-flexibleserver-2022-03-preview	package-flexibleserver-2022-03-preview(eb00a45)	package-flexibleserver-2022-03-preview(main)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` LongRunningResponseStatusCode	A 'put' operation 'Servers_Create' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L38
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L100
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L100
`❌` LongRunningResponseStatusCode	A 'put' operation 'Servers_Create' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L38
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L100
⚠️ PreviewVersionOverOneYear	The API version:2022-03-08-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L6
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L569
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L724
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-preview/FlexibleServers.json#L728
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: Microsoft.DBforPostgreSQL/stable/2022-12-01/FlexibleServers.json#L574

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-26T15:05:58Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/postgresql/armpostgresql - 3.0.0

+	Struct `CloudError` has been removed

❌azure-sdk-for-go - sdk/resourcemanager/postgresql/armpostgresqlflexibleservers - 3.0.0

+	Const `ArmServerKeyTypeSystemAssigned` from type alias `ArmServerKeyType` has been removed
+	Const `ReplicationRoleGeoSyncReplica`, `ReplicationRoleSecondary`, `ReplicationRoleSyncReplica`, `ReplicationRoleWalReplica` from type alias `ReplicationRole` has been removed

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.PostgreSql [View full logs] [Release SDK Changes] Breaking Change Detected

Azure.ResourceManager.PostgreSql.1.2.0-alpha.20230403.1.nupkg

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.Secondary.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.SyncReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole Azure.ResourceManager.PostgreSql.FlexibleServers.Models.PostgreSqlFlexibleServerReplicationRole.WalReplica.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0],
info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.PostgreSql/Debug/netstandard2.0/Azure.ResourceManager.PostgreSql.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/postgresql/Azure.ResourceManager.PostgreSql/src/Azure.ResourceManager.PostgreSql.csproj::TargetFramework=netstandard2.0]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-rdbms [View full logs] [Release SDK Changes]
- azure-mgmt-rdbms-10.2.0b6.zip
- azure_mgmt_rdbms-10.2.0b6-py3-none-any.whl
```
info	[Changelog]
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-postgresqlflexibleserver [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/postgresql/armpostgresql [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️sdk/resourcemanager/postgresql/armpostgresqlflexibleservers [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `ArmServerKeyTypeSystemAssigned` from type alias `ArmServerKeyType` has been removed
info	[Changelog] - Const `ReplicationRoleGeoSyncReplica`, `ReplicationRoleSecondary`, `ReplicationRoleSyncReplica`, `ReplicationRoleWalReplica` from type alias `ReplicationRole` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `ArmServerKeyTypeSystemManaged` added to enum type `ArmServerKeyType`
info	[Changelog]
info	[Changelog] Total 5 breaking change(s), 1 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 07ced53. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️postgresql [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 07ced53. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.postgresql.DefaultTag [View full logs] [Release SDK Changes]
- Az.PostgreSql.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-03-26T15:05:58Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/postgresql/armpostgresql	https://apiview.dev/Assemblies/Review/61023ead9e8e4e308e8f651c3a54801a
Go	sdk/resourcemanager/postgresql/armpostgresqlflexibleservers	https://apiview.dev/Assemblies/Review/2ec19be6e3594e24a7117dfc8efb5eb3
Java	azure-resourcemanager-postgresqlflexibleserver	https://apiview.dev/Assemblies/Review/2a136309b11c43dc805ea90819de949c
.Net	Azure.ResourceManager.PostgreSql	https://apiview.dev/Assemblies/Review/13e4f79fb93b4fa3aa897f390ae83ba0

openapi-workflow-bot · 2023-03-26T15:28:16Z

Hi @ambrahma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

ambrahma · 2023-03-27T03:22:08Z

Hi @ambrahma, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

Breaking change review raised here https://msazure.visualstudio.com/One/_workitems/edit/17690672

…23294) * Fix bug where ReplicationRoles was exposing unsupported roles * Remove unsupported ReplicationRole from api version 2022-03-08-preview

Fix bug where ReplicationRoles was exposing unsupported roles

3912844

ghost added the PostgreSQL label Mar 26, 2023

openapi-pipeline-app bot added the CI-BreakingChange-Go label Mar 26, 2023

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Mar 26, 2023

Remove unsupported ReplicationRole from api version 2022-03-08-preview

eb00a45

ambrahma marked this pull request as ready for review March 27, 2023 03:23

openapi-assignment-bot bot assigned live1206 Mar 27, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 27, 2023

ambrahma assigned alanenriqueo and pradeepkintali Mar 28, 2023

alanenriqueo approved these changes Mar 28, 2023

View reviewed changes

live1206 approved these changes Apr 3, 2023

View reviewed changes

live1206 merged commit 07ced53 into main Apr 3, 2023

live1206 deleted the ambrahma/fix-external-facing-replicationrole branch April 3, 2023 02:30

qiaozha mentioned this pull request Apr 10, 2023

postgresql release Azure/azure-sdk-for-js#25504

Merged

Alancere mentioned this pull request Apr 11, 2023

[Release] sdk/resourcemanager/postgresql/armpostgresqlflexibleservers/3.0.0 Azure/azure-sdk-for-go#20603

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug where ReplicationRoles was exposing unsupported roles #23294

Fix bug where ReplicationRoles was exposing unsupported roles #23294

ambrahma commented Mar 26, 2023 •

edited

Loading

openapi-workflow-bot bot commented Mar 26, 2023

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading

openapi-workflow-bot bot commented Mar 26, 2023

ambrahma commented Mar 27, 2023

Fix bug where ReplicationRoles was exposing unsupported roles #23294

Fix bug where ReplicationRoles was exposing unsupported roles #23294

Conversation

ambrahma commented Mar 26, 2023 • edited Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 26, 2023

openapi-pipeline-app bot commented Mar 26, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 26, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Mar 26, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Mar 26, 2023

ambrahma commented Mar 27, 2023

ambrahma commented Mar 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading

openapi-pipeline-app bot commented Mar 26, 2023 •

edited

Loading