MFE April-preview 2023 staging #23165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @kseager Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @kseager your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
Hi @kseager, Your PR has some issues. Please fix the CI sequentially by following the order of
|
11 tasks
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
89c205b to
bdab23a
Compare
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
bdab23a to
a436e2d
Compare
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
b1ad756 to
b825018
Compare
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
b825018 to
2071549
Compare
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
|
Hi @kseager, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
OperationId should contain the verb: 'startpendingupload' in:'RegistryDataVersions_CreateOrGetPendingUpload'. Consider updating the operationId Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-04-01-preview/mfe.json:1861 in 2ec17c5. [](commit_id = 2ec17c5, deletion_comment = False) |
visingla-ms
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
0495e60 to
5df4721
Compare
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
5df4721 to
db5e75a
Compare
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
9ea9ff2 to
afbc110
Compare
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
kseager
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Why RegistryDataVersions_CreateOrGetStartPendingUpload, and not just RegistryDataVersions_StartPendingUpload ? Similarly for other startPendingUpload POST Action APIs? In reply to: 1489140695 Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-04-01-preview/mfe.json:1861 in 2ec17c5. [](commit_id = 2ec17c5, deletion_comment = False) |
These are still not addressed, for example, there are many newly added definitions which don't have Title or Description. And, there are other Linter errors. Please address these. Leaving this to author, as fixing these linter errors would result in better and more accurate swagger spec. |
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
from
c34b359 to
a4a3208
Compare
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
kseager
force-pushed
the
kaseager-april-preview-2023-staging
branch
2 times, most recently
from
8ca46b9 to
99b6eb8
Compare
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
ArcturusZhang
approved these changes
Apr 2, 2023
ArcturusZhang
merged commit b385702
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-04-01-preview
ArcturusZhang
pushed a commit
that referenced
this pull request
Apr 18, 2023
…023 04 01 preview (#23449) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * [Preview] Bring Back Scheduled Shutdown MLC models (#23040) * [Preview] Bring Back Scheduled Shutdown MLC models * update example json --------- Co-authored-by: Naman Agarwal <[email protected]> * add minLength:1 prop to required strings (#23108) * add parameter enableDataIsolation to workspace properties (#23061) * add parameter enableDataIsolation to workspace properties * minor change to re-run the test pipelines * minor comment change to trigger the test pipeline again --------- Co-authored-by: Mingwei He <[email protected]> * expose connection expiryTime in 2023-04-01-preview swagger (#23118) * Add Workspace Managed Network Swagger (#23283) * add managed network swagger * fix validation errors * address ARM comments * fix example * do not flatten outbound rules, need nested props --------- Co-authored-by: Josh Harrington <[email protected]> * Add Registries 2023-04-01-Preview Swagger (#23163) * x * fix spellcheck * update preview examples * update examples * fix for swagger modelvalidation gate * examples should be in camelCase * more fixes for pr gates * fix syntax * add registryNameParameter * addressing comments * fix one more location property * address comments * update PrivateEndpointConnectionProperties * git didn't push all of my changes * fix circular dependency * update * PATCH operation should have sku, identity properties --------- Co-authored-by: Komal Yadav <[email protected]> * MFE April-preview 2023 staging (#23165) * update mfe.json to latest * update preview examples * make it pretty * createOrUpload example touch-ups * pretty check * POST pendingUpload lint violation, description, and array * spell check fixes * featurestore updates + notification patch updates to align with jobs * fix feature examples * rename PendingUpload -> startPendingUpload + better description * prettier feature get/list.json * update Job-Update example * update descriptions * x-ms-secret-true, remove wasbs and pattern for registries * update examples to remove wasbsUri * update registry refrence and add pattern to featuresetname * temporarily add in registry reference * one more pattern add-on for featuresetname * remove wasbs since that is no longer a part of PR * bump * add empty secrets to examples - can show object but hide secret itself * original-uri -> azure-async-operation * createOrGetPendingUpload -> createOrGetStartPendingUpload * add ms-secret to uri to keep it from breaking relative to GA --------- Co-authored-by: Kayla Ames <[email protected]> * [HUB] update team configuration related properties (#23285) * [HUB] update team configuration related properties * Update description * fix merge issue * update workspace get operation example with managenetwork included (#23411) * custom words merge * swap to original-uri * v5->v3 * registryRenames * mlc update to align with v3 types * finish updating examples --------- Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Teddy Todorov <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Mingwei He <[email protected]> Co-authored-by: jiewe <[email protected]> Co-authored-by: Josh Harrington <[email protected]> Co-authored-by: Josh Harrington <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: ZhidaLiu <[email protected]>
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…023 04 01 preview (Azure#23449) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * [Preview] Bring Back Scheduled Shutdown MLC models (Azure#23040) * [Preview] Bring Back Scheduled Shutdown MLC models * update example json --------- Co-authored-by: Naman Agarwal <[email protected]> * add minLength:1 prop to required strings (Azure#23108) * add parameter enableDataIsolation to workspace properties (Azure#23061) * add parameter enableDataIsolation to workspace properties * minor change to re-run the test pipelines * minor comment change to trigger the test pipeline again --------- Co-authored-by: Mingwei He <[email protected]> * expose connection expiryTime in 2023-04-01-preview swagger (Azure#23118) * Add Workspace Managed Network Swagger (Azure#23283) * add managed network swagger * fix validation errors * address ARM comments * fix example * do not flatten outbound rules, need nested props --------- Co-authored-by: Josh Harrington <[email protected]> * Add Registries 2023-04-01-Preview Swagger (Azure#23163) * x * fix spellcheck * update preview examples * update examples * fix for swagger modelvalidation gate * examples should be in camelCase * more fixes for pr gates * fix syntax * add registryNameParameter * addressing comments * fix one more location property * address comments * update PrivateEndpointConnectionProperties * git didn't push all of my changes * fix circular dependency * update * PATCH operation should have sku, identity properties --------- Co-authored-by: Komal Yadav <[email protected]> * MFE April-preview 2023 staging (Azure#23165) * update mfe.json to latest * update preview examples * make it pretty * createOrUpload example touch-ups * pretty check * POST pendingUpload lint violation, description, and array * spell check fixes * featurestore updates + notification patch updates to align with jobs * fix feature examples * rename PendingUpload -> startPendingUpload + better description * prettier feature get/list.json * update Job-Update example * update descriptions * x-ms-secret-true, remove wasbs and pattern for registries * update examples to remove wasbsUri * update registry refrence and add pattern to featuresetname * temporarily add in registry reference * one more pattern add-on for featuresetname * remove wasbs since that is no longer a part of PR * bump * add empty secrets to examples - can show object but hide secret itself * original-uri -> azure-async-operation * createOrGetPendingUpload -> createOrGetStartPendingUpload * add ms-secret to uri to keep it from breaking relative to GA --------- Co-authored-by: Kayla Ames <[email protected]> * [HUB] update team configuration related properties (Azure#23285) * [HUB] update team configuration related properties * Update description * fix merge issue * update workspace get operation example with managenetwork included (Azure#23411) * custom words merge * swap to original-uri * v5->v3 * registryRenames * mlc update to align with v3 types * finish updating examples --------- Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Teddy Todorov <[email protected]> Co-authored-by: Ming <[email protected]> Co-authored-by: Mingwei He <[email protected]> Co-authored-by: jiewe <[email protected]> Co-authored-by: Josh Harrington <[email protected]> Co-authored-by: Josh Harrington <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: ZhidaLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.