Workspace Manager Configurations -April #22967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* odata fixes * add skip query * apim doc for filter * documentation
…stable/2022-06-01 (Azure#22619) * Base from version 2021-09-01-preview * adding 2022-06-01 for DCR, DCRA, and DCE * readme MD changes * fix examples * fix provisioning value list * deduplication for csharp track2 * custom-words * dedupe * modelerfour * undo readme changes * add new package in readme.md * fix readme.md * revert readme.md * add new package
* Fix Swagger Linter - 1 * Fix Swagger Linter - 2 * Fix Swagger Linter - 3 * Fix Swagger Linter - 4 * Update Location Value - HDInsight * Add "resourceGroups/rg1/" to 17 Location value * Update Location value Not confirmed but upgraded * Update pathToOperationResult to operationid --------- Co-authored-by: v-yuchenli <[email protected]>
|
Hi, @rheabansal Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|
️❌Breaking Change(Cross-Version): 10 Errors, 71 Warnings failed [Detail]
Only 0 items are rendered, please refer to log for more details.
The following breaking changes are detected by comparison with the latest stable version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
The following breaking changes are detected by comparison with the latest preview version:
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️🔄LintDiff inProgress [Detail]
️❌Avocado: 1 Errors, 9 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️❌CadlAPIView: 0 Errors, 1 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌ModelValidation: 317 Errors, 0 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
Only -1 items are listed, please refer to log for more details.
| Rule | Message |
|---|
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi @rheabansal, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Mar 8, 2023
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @rheabansal your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
rheabansal
changed the title
|
Hi! We have already received a sign off for this PR targeting the 2023 March preview: #21275. This PR is to target the 2023 April preview. |
rheabansal
added
the
DoNotMerge
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Co-authored-by: Yuchao Yan <[email protected]> Discussed with @Vibhuti-Sharma-Microsoft The operation ID will be fixed in subsequent change, since this version of swagger has already been merged in `azure-rest-api-specs-pr`.
This was referenced Mar 17, 2023
Closed
|
Hi, @rheabansal. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @rheabansal. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.