Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean properties which are never used #22423

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Clean properties which are never used #22423

merged 1 commit into from
Feb 7, 2023

Conversation

chinadragon0515
Copy link
Contributor

@chinadragon0515 chinadragon0515 commented Feb 2, 2023 •
edited by openapi-workflow-bot bot
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @chinadragon0515 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 4 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    ManagedEnvironments.json 2022-11-01-preview(990ed8b) 2022-10-01(main)
    ManagedEnvironments.json 2022-11-01-preview(990ed8b) 2022-06-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    ❌ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EnvironmentSkuProperties' removed or renamed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1043:3
    Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L751:3
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sku' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1134:7
    Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L857:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'runtimeSubnetId' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1083:7
    Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L794:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'outboundSettings' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1083:7
    Old: Microsoft.App/stable/2022-10-01/ManagedEnvironments.json#L794:7


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'EnvironmentSkuProperties' removed or renamed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1043:3
    Old: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L751:3
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sku' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1134:7
    Old: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L857:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'runtimeSubnetId' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1083:7
    Old: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L794:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'outboundSettings' renamed or removed?
    New: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L1083:7
    Old: Microsoft.App/preview/2022-06-01-preview/ManagedEnvironments.json#L794:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-preview-2022-11 package-preview-2022-11(990ed8b) package-preview-2022-11(release-app-Microsoft.App-2022-11-01-preview)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L101
    ❌ CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L147
    ❌ DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L208
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L237
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L278
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property type.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L278
    ❌ UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L278
    ❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L283
    ❌ LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L298
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Certificates_List' does not match the response definition in the individual GET operation 'Certificates_Get' .
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L316
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L316
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L366
    ❌ ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L366
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L594
    ❌ ResourceNameRestriction The resource name parameter 'managedCertificateName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L594
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'ManagedCertificates_List' does not match the response definition in the individual GET operation 'ManagedCertificates_Get' .
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L836
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L836
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L886
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L945
    ❌ ResourceNameRestriction The resource name parameter 'environmentName' should be defined with a 'pattern' restriction.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L992
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L26
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L66
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L109
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L147
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L154
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L208
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L215
    ⚠️ XmsLongRunningOperationOptions The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation.
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L257
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L264
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-11-01-preview/ManagedEnvironments.json#L324
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0-beta.2
    +	Field `OutboundSettings` of struct `VnetConfiguration` has been removed
+	Field `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
+	Field `SKU` of struct `ManagedEnvironment` has been removed
+	Struct `EnvironmentSKUProperties` has been removed
+	Struct `ManagedEnvironmentOutboundSettings` has been removed
+	Type alias `ManagedEnvironmentOutBoundType` has been removed
+	Type alias `SKUName` has been removed
    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - 2.0.0b2
    +	Model ManagedEnvironment no longer has parameter sku
+	Model VnetConfiguration no longer has parameter outbound_settings
+	Model VnetConfiguration no longer has parameter runtime_subnet_id
    ⚠️azure-sdk-for-js - @azure/arm-appcontainers - 2.0.0-beta.3
    +	Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
+	Interface VnetConfiguration no longer has parameter runtimeSubnetId
+	Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
+	Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-appcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group JobOperations
info	[Changelog]   - Added operation group JobsOperations
info	[Changelog]   - Added operation group ManagedCertificatesOperations
info	[Changelog]   - Model ContainerApp has a new parameter managed_by
info	[Changelog]   - Model Ingress has a new parameter sticky_sessions
info	[Changelog]   - Model ManagedEnvironment has a new parameter dapr_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter keda_configuration
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model ManagedEnvironment no longer has parameter sku
info	[Changelog]   - Model VnetConfiguration no longer has parameter outbound_settings
info	[Changelog]   - Model VnetConfiguration no longer has parameter runtime_subnet_id
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-appcontainers [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
info	[Changelog] - Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
info	[Changelog] - Type alias `ManagedEnvironmentOutBoundType` has been removed
info	[Changelog] - Type alias `SKUName` has been removed
info	[Changelog] - Struct `EnvironmentSKUProperties` has been removed
info	[Changelog] - Struct `ManagedEnvironmentOutboundSettings` has been removed
info	[Changelog] - Field `SKU` of struct `ManagedEnvironment` has been removed
info	[Changelog] - Field `OutboundSettings` of struct `VnetConfiguration` has been removed
info	[Changelog] - Field `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New type alias `Affinity` with values `AffinityNone`, `AffinitySticky`
info	[Changelog] - New type alias `IngressClientCertificateMode` with values `IngressClientCertificateModeAccept`, `IngressClientCertificateModeIgnore`, `IngressClientCertificateModeRequire`
info	[Changelog] - New type alias `JobProvisioningState` with values `JobProvisioningStateCanceled`, `JobProvisioningStateDeleting`, `JobProvisioningStateFailed`, `JobProvisioningStateInProgress`, `JobProvisioningStateSucceeded`
info	[Changelog] - New type alias `ManagedCertificateDomainControlValidation` with values `ManagedCertificateDomainControlValidationCNAME`, `ManagedCertificateDomainControlValidationHTTP`, `ManagedCertificateDomainControlValidationTXT`
info	[Changelog] - New type alias `TriggerType` with values `TriggerTypeEvent`, `TriggerTypeManual`, `TriggerTypeScheduled`
info	[Changelog] - New function `NewJobClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobClient, error)`
info	[Changelog] - New function `*JobClient.BeginCreateOrUpdate(context.Context, string, string, Job, *JobClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*JobClient.BeginDelete(context.Context, string, string, *JobClientBeginDeleteOptions) (*runtime.Poller[JobClientDeleteResponse], error)`
info	[Changelog] - New function `*JobClient.Get(context.Context, string, string, *JobClientGetOptions) (JobClientGetResponse, error)`
info	[Changelog] - New function `*JobClient.BeginRun(context.Context, string, string, *JobClientBeginRunOptions) (*runtime.Poller[JobClientRunResponse], error)`
info	[Changelog] - New function `*JobClient.BeginTerminate(context.Context, string, string, *JobClientBeginTerminateOptions) (*runtime.Poller[JobClientTerminateResponse], error)`
info	[Changelog] - New function `*JobClient.BeginUpdate(context.Context, string, string, JobPatchProperties, *JobClientBeginUpdateOptions) (*runtime.Poller[JobClientUpdateResponse], error)`
info	[Changelog] - New function `NewJobsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobsClient, error)`
info	[Changelog] - New function `*JobsClient.NewListByResourceGroupPager(string, *JobsClientListByResourceGroupOptions) *runtime.Pager[JobsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*JobsClient.NewListBySubscriptionPager(*JobsClientListBySubscriptionOptions) *runtime.Pager[JobsClientListBySubscriptionResponse]`
info	[Changelog] - New function `*JobsClient.ListSecrets(context.Context, string, string, *JobsClientListSecretsOptions) (JobsClientListSecretsResponse, error)`
info	[Changelog] - New function `NewManagedCertificatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedCertificatesClient, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.BeginCreateOrUpdate(context.Context, string, string, string, *ManagedCertificatesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedCertificatesClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Delete(context.Context, string, string, string, *ManagedCertificatesClientDeleteOptions) (ManagedCertificatesClientDeleteResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Get(context.Context, string, string, string, *ManagedCertificatesClientGetOptions) (ManagedCertificatesClientGetResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.NewListPager(string, string, *ManagedCertificatesClientListOptions) *runtime.Pager[ManagedCertificatesClientListResponse]`
info	[Changelog] - New function `*ManagedCertificatesClient.Update(context.Context, string, string, string, ManagedCertificatePatch, *ManagedCertificatesClientUpdateOptions) (ManagedCertificatesClientUpdateResponse, error)`
info	[Changelog] - New struct `CorsPolicy`
info	[Changelog] - New struct `DaprConfiguration`
info	[Changelog] - New struct `IngressStickySessions`
info	[Changelog] - New struct `Job`
info	[Changelog] - New struct `JobClient`
info	[Changelog] - New struct `JobClientCreateOrUpdateResponse`
info	[Changelog] - New struct `JobClientDeleteResponse`
info	[Changelog] - New struct `JobClientRunResponse`
info	[Changelog] - New struct `JobClientTerminateResponse`
info	[Changelog] - New struct `JobClientUpdateResponse`
info	[Changelog] - New struct `JobConfiguration`
info	[Changelog] - New struct `JobConfigurationManualTriggerConfig`
info	[Changelog] - New struct `JobConfigurationScheduleTriggerConfig`
info	[Changelog] - New struct `JobPatchProperties`
info	[Changelog] - New struct `JobPatchPropertiesProperties`
info	[Changelog] - New struct `JobProperties`
info	[Changelog] - New struct `JobSecretsCollection`
info	[Changelog] - New struct `JobTemplate`
info	[Changelog] - New struct `JobsClient`
info	[Changelog] - New struct `JobsClientListByResourceGroupResponse`
info	[Changelog] - New struct `JobsClientListBySubscriptionResponse`
info	[Changelog] - New struct `JobsCollection`
info	[Changelog] - New struct `KedaConfiguration`
info	[Changelog] - New struct `ManagedCertificate`
info	[Changelog] - New struct `ManagedCertificateCollection`
info	[Changelog] - New struct `ManagedCertificatePatch`
info	[Changelog] - New struct `ManagedCertificateProperties`
info	[Changelog] - New struct `ManagedCertificatesClient`
info	[Changelog] - New struct `ManagedCertificatesClientCreateOrUpdateResponse`
info	[Changelog] - New struct `ManagedCertificatesClientListResponse`
info	[Changelog] - New field `ManagedBy` in struct `ContainerApp`
info	[Changelog] - New field `LatestReadyRevisionName` in struct `ContainerAppProperties`
info	[Changelog] - New anonymous field `ContainerApp` in struct `ContainerAppsClientUpdateResponse`
info	[Changelog] - New field `ClientCertificateMode` in struct `Ingress`
info	[Changelog] - New field `CorsPolicy` in struct `Ingress`
info	[Changelog] - New field `StickySessions` in struct `Ingress`
info	[Changelog] - New field `Kind` in struct `ManagedEnvironment`
info	[Changelog] - New field `DaprConfiguration` in struct `ManagedEnvironmentProperties`
info	[Changelog] - New field `KedaConfiguration` in struct `ManagedEnvironmentProperties`
info	[Changelog] - New anonymous field `ManagedEnvironment` in struct `ManagedEnvironmentsClientUpdateResponse`
info	[Changelog]
info	[Changelog] Total 10 breaking change(s), 105 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface TcpScaleRule
info	[Changelog]   - Added Interface WorkloadProfile
info	[Changelog]   - Added Interface WorkloadProfileStates
info	[Changelog]   - Added Interface WorkloadProfileStatesCollection
info	[Changelog]   - Added Interface WorkloadProfileStatesProperties
info	[Changelog]   - Added Type Alias Action
info	[Changelog]   - Added Type Alias Affinity
info	[Changelog]   - Added Type Alias Applicability
info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetNextResponse
info	[Changelog]   - Added Type Alias AvailableWorkloadProfilesGetResponse
info	[Changelog]   - Added Type Alias BillingMetersGetResponse
info	[Changelog]   - Added Type Alias Category
info	[Changelog]   - Added Type Alias ConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCheckNameAvailabilityResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsDaprComponentsListSecretsResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
info	[Changelog]   - Added Type Alias ExtendedLocationTypes
info	[Changelog]   - Added Type Alias IngressClientCertificateMode
info	[Changelog]   - Added Type Alias JobCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobGetResponse
info	[Changelog]   - Added Type Alias JobProvisioningState
info	[Changelog]   - Added Type Alias JobsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias JobsListSecretsResponse
info	[Changelog]   - Added Type Alias JobUpdateResponse
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias TriggerType
info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
info	[Changelog]   - Interface ContainerApp has a new optional parameter managedBy
info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileType
info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter daprConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kedaConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
info	[Changelog]   - Interface Template has a new optional parameter initContainers
info	[Changelog]   - Added Enum KnownAction
info	[Changelog]   - Added Enum KnownAffinity
info	[Changelog]   - Added Enum KnownApplicability
info	[Changelog]   - Added Enum KnownCategory
info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Enum KnownExtendedLocationTypes
info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
info	[Changelog]   - Added Enum KnownJobProvisioningState
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
info	[Changelog]   - Added Enum KnownTriggerType
info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface VnetConfiguration no longer has parameter runtimeSubnetId
info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 3b33b97d9f7b58343f601ba3a49fa6f2bba0e361. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.ContainerAppsApi [View full logs]  [Preview SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 2, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.App https://apiview.dev/Assemblies/Review/12bc3f765eda47d4978d92092e5e300d
    Go sdk/resourcemanager/appcontainers/armappcontainers https://apiview.dev/Assemblies/Review/a80a9bcb51694952ae6828d18b25f713
    Java azure-resourcemanager-appcontainers Create ApiView failed. Please ask PR assignee for help
    JavaScript @azure/arm-appcontainers Create ApiView failed. Please ask PR assignee for help

    @chinadragon0515 chinadragon0515 force-pushed the release-app-Microsoft.App-2022-11-01-preview3 branch from 87da38d to 9820307 Compare February 2, 2023 05:16
    This was referenced Feb 2, 2023
    Closed
    Draft
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Feb 2, 2023
    @openapi-workflow-bot
    Copy link

    Hi @chinadragon0515, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @chinadragon0515, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    This was referenced Feb 2, 2023
    Closed
    Closed
    This was referenced Feb 2, 2023
    Closed
    Closed
    @chinadragon0515
    Copy link
    Contributor Author

    Create breaking review https://msazure.visualstudio.com/One/_workitems/edit/16986590

    @chinadragon0515 chinadragon0515 requested review from ruslany, howang-ms and najian and removed request for ruslany and howang-ms February 2, 2023 05:35
    @chinadragon0515 chinadragon0515 force-pushed the release-app-Microsoft.App-2022-11-01-preview3 branch from 9820307 to aafbc0b Compare February 2, 2023 05:50
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 6, 2023
    jijohn14
    jijohn14 approved these changes Feb 6, 2023
    View reviewed changes
    Copy link
    Member

    @jijohn14 jijohn14 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Need breaking change approval for main branch merge

    @chinadragon0515
    Copy link
    Contributor Author

    Breaking change is approved
    https://msazure.visualstudio.com/One/_workitems/edit/16986590

    @chinadragon0515 chinadragon0515 force-pushed the release-app-Microsoft.App-2022-11-01-preview3 branch from aafbc0b to 990ed8b Compare February 7, 2023 01:03
    @leni-msft leni-msft merged commit 27489e4 into Azure:release-app-Microsoft.App-2022-11-01-preview Feb 7, 2023
    @ebencarek ebencarek mentioned this pull request Feb 16, 2023
    Merged
    11 tasks
    @zhenqxuMSFT zhenqxuMSFT mentioned this pull request May 5, 2023
    Merged
    11 tasks
    @Zijian-Ju Zijian-Ju mentioned this pull request May 23, 2023
    Merged
    11 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jijohn14 jijohn14 jijohn14 approved these changes

    @leni-msft leni-msft leni-msft approved these changes

    @ruslany ruslany Awaiting requested review from ruslany

    @najian najian Awaiting requested review from najian

    Assignees

    @leni-msft leni-msft

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    5 participants
    @chinadragon0515 @leni-msft @jijohn14 @AzureRestAPISpecReview @mikekistler