Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Purview Workflow]Remove workflow dsar api #22323

Merged
merged 9 commits into from
Feb 13, 2023

Conversation

CordeliaGrey
Copy link
Member

@CordeliaGrey CordeliaGrey commented Jan 26, 2023

Data Plane API - Pull Request

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your engagement record.

  • Link to engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

  • Design Document:
  • Previous Open API Doc:
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

@CordeliaGrey CordeliaGrey requested review from mikekistler and a team as code owners January 26, 2023 13:07
@CordeliaGrey CordeliaGrey requested review from johanste and removed request for a team January 26, 2023 13:07
@openapi-workflow-bot
Copy link

Hi, @CordeliaGrey Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2023

    Swagger Validation Report

    ️❌BreakingChange: 35 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    purviewWorkflow.json 2022-05-01-preview(8b98b42) 2022-05-01-preview(main)

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/workflowtasks/{taskId}/claim-task' removed or restructured?
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L658:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/workflowtasks/{taskId}/release-task' removed or restructured?
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L700:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DsarTask' removed or renamed?
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L658:3
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L743:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DSARTaskDetail' removed or renamed?
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L658:3
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L743:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DSARTaskClaimCommand' removed or renamed?
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L658:3
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L743:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'DSARTaskReleaseCommand' removed or renamed?
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L658:3
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L743:3
    1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'userRequestIds' removed or renamed?
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1634:3
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1876:3
    1008 - ModifiedOperationId The operation id has been changed from 'UpdateTaskRequest' to 'UpdateTaskStatus'. This will impact generated code.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L616:7
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L617:7
    1019 - RemovedEnumValue The new version is removing enum value(s) 'when_dsar_deletion_is_requested, when_dsar_export_is_requested' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L741:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L830:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L847:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L938:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L879:15
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L970:15
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1022:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1113:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1078:13
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1171:13
    1019 - RemovedEnumValue The new version is removing enum value(s) 'dsarTask' from the old version.
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L399:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DsarTask' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1176:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1269:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1301:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1395:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'Not Started, In Progress' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1565:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1789:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'dsarTask' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1721:7
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1963:7
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1035:5
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1126:5
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1318:5
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1412:5
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DSARDelete, DSARExport' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1334:5
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1430:5
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DsarTask' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1176:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1269:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'approved, rejected, pending' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1431:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1529:9
    1019 - RemovedEnumValue The new version is removing enum value(s) 'DsarTask' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1176:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1269:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'requestor desc, requestor asc' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L412:11
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L415:11
    1020 - AddedEnumValue The new version is adding enum value(s) 'NotStarted, InProgress' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1565:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1789:9
    1020 - AddedEnumValue The new version is adding enum value(s) 'Approved, Rejected, Pending' from the old version.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1431:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1529:9
    1021 - AddedAdditionalProperties The new version adds an 'additionalProperties' element.
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1413:9
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L1511:9
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    New: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L682:7
    Old: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L767:7
    1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-05-01-preview package-2022-05-01-preview(8b98b42) package-2022-05-01-preview(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L48
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L53
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L74
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L89
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L96
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L110
    ⚠️ PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'CreateOrReplaceWorkflow' Request Model: 'parameters[1].schema' Response Model: 'responses[200].schema'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L118
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L123
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L130
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L153
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L166
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L173
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L184
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L199
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L226
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L236
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L241
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L294
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L309
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L319
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L330
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L345
    ⚠️ PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L355
    ⚠️ SuccessResponseBody All success responses except 202 & 204 should define a response body.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L369
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L372
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L382
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L387
    ⚠️ ErrorResponse Error response should contain a x-ms-error-code header.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L447
    ⚠️ OperationId OperationId should be of the form 'Noun_Verb'
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L462
    ⚠️ VersionPolicy Operation does not define an 'api-version' query parameter.
    Location: Azure.Analytics.Purview.Workflow/preview/2022-05-01-preview/purviewWorkflow.json#L468
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 3a1ca5a. SDK Automation 14.0.0
      Only show 24 items here, please refer to log for details.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.Analytics.Purview.Account [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.Analytics.Purview.Administration [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.Analytics.Purview.Catalog [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.Analytics.Purview.Scanning [View full logs]  [Release SDK Changes]
      info	[Changelog]
    • Azure.Analytics.Purview.Share [View full logs]  [Release SDK Changes]
      info	[Changelog]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 26, 2023

    Generated ApiView

    Language Package Name ApiView Link
    .Net Azure.Analytics.Purview.Share https://apiview.dev/Assemblies/Review/9b1aedd706394547af71490b4f389a2d

    @ghost ghost added the Purview label Jan 26, 2023
    @AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane labels Jan 26, 2023
    @openapi-workflow-bot
    Copy link

    Hi @CordeliaGrey, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 6, 2023
    Copy link
    Member

    @mikekistler mikekistler left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Looks good. 👍

    @mikekistler
    Copy link
    Member

    @tjprescott I think this is ready to merge. Would you please do the honors?

    @CordeliaGrey
    Copy link
    Member Author

    @mikekistler ,sorry for accidentally clicked request a reivew button, no new changes need to review, thanks.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane Purview
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants