Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listVault.json #22155

Merged
merged 30 commits into from
Jan 16, 2023
Merged

Update listVault.json #22155

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c374d7a
Update listVault.json
rahulalapati43 Jan 11, 2023
31c201e
Remove the preview API version for the enum
Jan 11, 2023
3f8c7e5
Delete Vault_Lists API specification
Jan 11, 2023
ee6e132
Added the Vaults_List swagger specification back.
Jan 11, 2023
615b245
Abstracted Vaults_List API into 2015-11-01 directory to Swagger Model…
Jan 12, 2023
f230b9e
Resolved unresolvable references.
Jan 12, 2023
034a13b
Reorganized the definitions.
Jan 12, 2023
0a250ae
Reorganized the 2015-11-01 directory under 2022-02-01-preview
Jan 12, 2023
d72d5e0
Moved the 2015-11-10 directory to stable.
Jan 12, 2023
590d490
Undo the abstraction changes.
Jan 12, 2023
6699b87
Readd the listVault.json.
Jan 12, 2023
b116a63
Added suppression directives for INVALID_REQUEST_PARAMETER and OBJECT…
Jan 12, 2023
d9c32da
Modify suppress rule.
Jan 12, 2023
645b325
Update the suppression directive.
Jan 12, 2023
a7dcbcb
Update suppression directive.
Jan 12, 2023
59957e7
Update suppression directive.
Jan 12, 2023
1d8bff0
Update suppression directives.
Jan 12, 2023
01f33ca
Updated suppression directive.
Jan 12, 2023
ece224e
Added suppression directives for INVALID_REQUEST_PARAMETER, OBJECT_MI…
Jan 12, 2023
409949a
Updated suppression directives.
Jan 13, 2023
68e2903
Updated suppression directives.
Jan 13, 2023
ae141f3
Merge branch 'Remove-API-Version-Changes' of https://github.com/Azure…
Jan 13, 2023
d85dcec
Updated suppression directives.
Jan 13, 2023
fde8b22
Updated suppression directives.
Jan 13, 2023
aa20053
Updated suppression directives.
Jan 14, 2023
7301f92
Added x-ms-validation rules to the api-version parameter.
Jan 15, 2023
09919d3
Updated suppression directives.
Jan 16, 2023
5bb3568
Added individual suppression directives.
Jan 16, 2023
eb0e90c
Removed where clause from the OBJECT_MISSING_REQUIRED_PROPERTY suppre…
Jan 16, 2023
e60abf3
Corrected yaml title for suppression directives.
Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...lt/resource-manager/Microsoft.KeyVault/preview/2022-02-01-preview/examples/listVault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"$filter": "resourceType eq 'Microsoft.KeyVault/vaults'",
"$top": 1,
"subscriptionId": "00000000-0000-0000-0000-000000000000",
"api-version": "2022-02-01-preview"
"api-version": "2015-11-01"
},
"responses": {
"200": {
Expand All @@ -17,7 +17,7 @@
"tags": {}
}
],
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resources?%24filter=resourceType+eq+%27Microsoft.KeyVault%2fvaults%27&%24top=4&api-version=2022-02-01-preview&%24skiptoken=eyJuZXh0UGFydGl0aW9uS2V5IjoiMSE4IVEwTTJNVGMtIiwibmV4dFJvd0tleSI6IjEhMTMyIU5rUTRSVEU1UXpJelFUWXdORGd4UmpoRlFrSXhNVGhFUXpNd01EZEROVVJmVkVkT1RDMU5TVU5TVDFOUFJsUTZNa1ZMUlZsV1FWVk1WRG95UmxaQlZVeFVVeTFUVTFKSExVcEpUVG95UkZSRlUxUTZNa1JXUVZWTVZDMVhSVk5VVlZNLSJ9"
"nextLink": "https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resources?%24filter=resourceType+eq+%27Microsoft.KeyVault%2fvaults%27&%24top=4&api-version=2015-11-01&%24skiptoken=eyJuZXh0UGFydGl0aW9uS2V5IjoiMSE4IVEwTTJNVGMtIiwibmV4dFJvd0tleSI6IjEhMTMyIU5rUTRSVEU1UXpJelFUWXdORGd4UmpoRlFrSXhNVGhFUXpNd01EZEROVVJmVkVkT1RDMU5TVU5TVDFOUFJsUTZNa1ZMUlZsV1FWVk1WRG95UmxaQlZVeFVVeTFUVTFKSExVcEpUVG95UkZSRlUxUTZNa1JXUVZWTVZDMVhSVk5VVlZNLSJ9"
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions ...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2022-02-01-preview/keyvault.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,8 +657,7 @@
"x-ms-api-version": false,
"type": "string",
"enum": [
"2015-11-01",
"2022-02-01-preview"
"2015-11-01"
],
"x-ms-enum": {
"name": "ResourceManagerApiVersions",
Expand Down
13 changes: 13 additions & 0 deletions specification/keyvault/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,24 @@ input-file:
directive:
- suppress:
- R3016 # The 'release_policy' property for KeyCreateParameters does not support camelCase.
- suppress:
- R3026 # The 'PrivateEndpointConnection' and 'PrivateLinkResource' sub-resources don't define PATCH as per Network Team's specification.
- suppress:
- R3025 # The 'PrivateLinkResource' is only accessible via List operation; does not define GET as per Network Team's specification.
- suppress:
- R4015 # The 'MHSMPrivateEndpointConnection' sub-resource doesn't define List as per Network Team's specification.
- suppress:
- R2005 # The 'ManagedHsms_PurgeDeleted' operation should not return a mix of 202 and syncronous return types (200, 201, 204) as directed by SDK team.
- suppress:
- R4009 # Vault object is the only one that need to be tracked with SystemData
- suppress: INVALID_REQUEST_PARAMETER
rahulalapati43 marked this conversation as resolved.
Show resolved Hide resolved
from: keyvault.json
reason: The Vaults_List API endpoint only supports version 2015-11-01.
- suppress: OBJECT_MISSING_REQUIRED_PROPERTY
from: keyvault.json
where:
rahulalapati43 marked this conversation as resolved.
Show resolved Hide resolved
- '$.paths["/subscriptions/{subscriptionId}/resources"].get'
reason: The Vaults_List API endpoint only supports version 2015-11-01.
```

---
Expand Down