Network Watcher S360 Correctness Fix for 2022-05-01 #21341

supriyajha-ms · 2022-10-31T02:17:29Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-10-31T02:17:32Z

Hi, @supriyajha-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-10-31T02:17:32Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.1)]	new version	base version
networkWatcher.json	2022-05-01(47a1c48)	2022-05-01(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2347:9 Old: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2347:9
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'details' in response that was not found in the old version. New: Microsoft.Network/stable/2022-05-01/network.json#L56:7 Old: Microsoft.Network/stable/2022-05-01/network.json#L39:7
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'innerError' in response that was not found in the old version. New: Microsoft.Network/stable/2022-05-01/network.json#L56:7 Old: Microsoft.Network/stable/2022-05-01/network.json#L39:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'runningOperationIds' that was not found in the old version. New: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2375:7 Old: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2375:7

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2022-05	package-2022-05(47a1c48)	package-2022-05(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2344
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2344
`❌` R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2344
`❌` R4037 - MissingTypeObject	The schema 'NetworkWatcher' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2354
`❌` R4037 - MissingTypeObject	The schema 'NetworkWatcherPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2374
`❌` R4037 - MissingTypeObject	The schema 'NetworkWatcherListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2392
`❌` R4037 - MissingTypeObject	The schema 'TopologyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2404
`❌` R4037 - MissingTypeObject	The schema 'Topology' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2421
`❌` R4037 - MissingTypeObject	The schema 'TopologyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2450
`❌` R4037 - MissingTypeObject	The schema 'TopologyAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2474
`❌` R4037 - MissingTypeObject	The schema 'VerificationIPFlowParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2499
`❌` R4037 - MissingTypeObject	The schema 'VerificationIPFlowResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2553
`❌` R4037 - MissingTypeObject	The schema 'NextHopParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2566
`❌` R4037 - MissingTypeObject	The schema 'NextHopResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2592
`❌` R4037 - MissingTypeObject	The schema 'SecurityGroupViewParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2621
`❌` R4037 - MissingTypeObject	The schema 'SecurityGroupViewResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2633
`❌` R4037 - MissingTypeObject	The schema 'SecurityGroupNetworkInterface' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2645
`❌` R4037 - MissingTypeObject	The schema 'SecurityRuleAssociations' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2658
`❌` R4037 - MissingTypeObject	The schema 'NetworkInterfaceAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2685
`❌` R4037 - MissingTypeObject	The schema 'SubnetAssociation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2702
`❌` R4037 - MissingTypeObject	The schema 'PacketCapture' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2719
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2732
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureStorageLocation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2816
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureFilter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2833
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2868
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2880
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureResultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2905
`❌` R4037 - MissingTypeObject	The schema 'PacketCaptureQueryStatusResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2920
`❌` R4037 - MissingTypeObject	The schema 'TroubleshootingParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2975
`❌` R4037 - MissingTypeObject	The schema 'QueryTroubleshootingParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2993

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️❌ModelValidation: 14 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L177:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L769:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherPacketCaptureDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L830:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherPacketCaptureStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1704:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1829:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1890:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorStart.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2264:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherFlowLogDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L177:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L769:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherPacketCaptureDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L830:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherPacketCaptureStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1704:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorDelete.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1829:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorStop.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L1890:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherConnectionMonitorStart.json
`❌` LRO_RESPONSE_HEADER	Long running operation should return location or azure-AsyncOperation in header but not provided Url: Microsoft.Network/stable/2022-05-01/networkWatcher.json#L2264:22 ExampleUrl: stable/2022-05-01/examples/NetworkWatcherFlowLogDelete.json

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-31T02:17:33Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/network/armnetwork - 3.0.0

+	Type of `ErrorResponse.Error` has been changed from `*ErrorDetails` to `*Error`

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Network [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.Network.25.0.0.nupkg
- Microsoft.Azure.Management.Network.25.0.0.symbols.nupkg

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:698
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 698 | �[0m … rtifacts += �[96mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:611
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m 611 | �[0m         �[96mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[96m     | �[91m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[91m�[96m     | �[91mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.Network [View full logs] [Release SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.2 -> 9.1.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.1.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-network [View full logs] [Release SDK Changes]
- azure-mgmt-network-22.1.0.zip
- azure_mgmt_network-22.1.0-py3-none-any.whl
```
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model NetworkWatcher has a new parameter running_operation_ids
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip available: 22.3 -> 22.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `DelegationProperties`
info	[Changelog] - New struct `PartnerManagedResourceProperties`
info	[Changelog] - New field `CustomBlockResponseBody` in struct `PolicySettings`
info	[Changelog] - New field `CustomBlockResponseStatusCode` in struct `PolicySettings`
info	[Changelog] - New field `DeploymentType` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `Delegation` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `PartnerManagedResource` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `VirtualNetwork` in struct `BackendAddressPoolPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 7 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-network [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-network-31.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface DdosProtectionPlansDeleteHeaders
info	[Changelog]   - Added Interface DelegationProperties
info	[Changelog]   - Added Interface PartnerManagedResourceProperties
info	[Changelog]   - Added Interface PublicIPAddressesDdosProtectionStatusHeaders
info	[Changelog]   - Added Interface PublicIPAddressesDeleteHeaders
info	[Changelog]   - Interface BackendAddressPool has a new optional parameter virtualNetwork
info	[Changelog]   - Interface DdosProtectionPlan has a new optional parameter publicIPAddresses
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter delegation
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter deploymentType
info	[Changelog]   - Interface NetworkVirtualAppliance has a new optional parameter partnerManagedResource
info	[Changelog]   - Interface PolicySettings has a new optional parameter customBlockResponseBody
info	[Changelog]   - Interface PolicySettings has a new optional parameter customBlockResponseStatusCode
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface DdosProtectionPlan no longer has parameter publicIpAddresses

️🔄 azure-resource-manager-schemas inProgress [Detail]

️❌ azure-powershell failed [Detail]

❌Failed [Logs]Release - Generate from e501ae8. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

❌Az.network [View full logs] [Release SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-10-31T02:17:33Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-10-31T02:31:00Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-10-31T02:31:00Z

Hi @supriyajha-ms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

raych1 · 2022-11-03T08:09:21Z

@supriyajha-ms , please add headers to response in examples to fix model validation errors.

raych1 · 2022-11-14T07:11:09Z

@supriyajha-ms , please add headers to response in examples to fix model validation errors.

Talked offline, these errors will be fixed in separate PR.

* Network Watcher S360 Correctness Fix for 2022-05-01 * prettier fix

Network Watcher S360 Correctness Fix for 2022-05-01

004c022

supriyajha-ms requested a review from MikhailTryakhov as a code owner October 31, 2022 02:17

openapi-assignment-bot bot assigned raych1 Oct 31, 2022

ghost added the Network label Oct 31, 2022

azure-sdk mentioned this pull request Oct 31, 2022

[AutoPR sdk/resourcemanager/network/armnetwork] Network Watcher S360 Correctness Fix for 2022-05-01 azure-sdk/azure-sdk-for-go#3379

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Oct 31, 2022

AzureRestAPISpecReview added CI-FixRequiredOnFailure NewApiVersionRequired resource-manager labels Oct 31, 2022

prettier fix

47a1c48

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 1, 2022

raych1 added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 3, 2022

raych1 approved these changes Nov 14, 2022

View reviewed changes

raych1 added the Approved-ModelValidation label Nov 14, 2022

raych1 merged commit e501ae8 into Azure:main Nov 14, 2022

azure-sdk mentioned this pull request Nov 14, 2022

[ReleasePR sdk/resourcemanager/network/armnetwork] Release network microsoft.network official 2023 06 01 Azure/azure-sdk-for-go#19013

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Nov 14, 2022

anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this pull request Dec 16, 2022

Network Watcher S360 Correctness Fix for 2022-05-01 (Azure#21341)

87a4f85

* Network Watcher S360 Correctness Fix for 2022-05-01 * prettier fix

kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this pull request Dec 21, 2022

Network Watcher S360 Correctness Fix for 2022-05-01 (Azure#21341)

ccfbb27

* Network Watcher S360 Correctness Fix for 2022-05-01 * prettier fix

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network Watcher S360 Correctness Fix for 2022-05-01 #21341

Network Watcher S360 Correctness Fix for 2022-05-01 #21341

supriyajha-ms commented Oct 31, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Oct 31, 2022

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading

openapi-workflow-bot bot commented Oct 31, 2022

openapi-workflow-bot bot commented Oct 31, 2022

raych1 commented Nov 3, 2022

raych1 commented Nov 14, 2022

Network Watcher S360 Correctness Fix for 2022-05-01 #21341

Network Watcher S360 Correctness Fix for 2022-05-01 #21341

Conversation

supriyajha-ms commented Oct 31, 2022 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Oct 31, 2022

openapi-pipeline-app bot commented Oct 31, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Oct 31, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Oct 31, 2022 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Oct 31, 2022

openapi-workflow-bot bot commented Oct 31, 2022

raych1 commented Nov 3, 2022

raych1 commented Nov 14, 2022

supriyajha-ms commented Oct 31, 2022 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading

openapi-pipeline-app bot commented Oct 31, 2022 •

edited

Loading