Add ConflictWithEnvironmentCustomDomain to CustomHostnameAnalysisResult #20816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @zhenqxuMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| ContainerApps.json | 2022-01-01-preview(2ccb77c) | 2022-01-01-preview(main) |
| ContainerApps.json | 2022-06-01-preview(2ccb77c) | 2022-06-01-preview(main) |
| ContainerApps.json | 2022-03-01(2ccb77c) | 2022-03-01(main) |
| Rule | Message |
|---|---|
|
The new version has a new read-only property 'conflictWithEnvironmentCustomDomain' in response that was not found in the old version. New: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L769:7 Old: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L769:7 |
|
The new version has a new read-only property 'conflictWithEnvironmentCustomDomain' in response that was not found in the old version. New: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L916:7 Old: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L916:7 |
|
The new version has a new read-only property 'conflictWithEnvironmentCustomDomain' in response that was not found in the old version. New: Microsoft.App/stable/2022-03-01/ContainerApps.json#L762:7 Old: Microsoft.App/stable/2022-03-01/ContainerApps.json#L762:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-2022-03 | package-2022-03(2ccb77c) | package-2022-03(main) |
| package-2022-01-01-preview | package-2022-01-01-preview(2ccb77c) | package-2022-01-01-preview(main) |
| package-preview-2022-06 | package-preview-2022-06(2ccb77c) | package-preview-2022-06(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: conflictWithEnvironmentCustomDomain Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L997 |
||
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: conflictWithEnvironmentCustomDomain Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L843 |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| The summary and description values should not be same. Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L148 |
|
| The summary and description values should not be same. Location: Microsoft.App/preview/2022-01-01-preview/ContainerApps.json#L209 |
|
| The summary and description values should not be same. Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L148 |
|
| The summary and description values should not be same. Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L212 |
|
| The summary and description values should not be same. Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L148 |
|
| The summary and description values should not be same. Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L209 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L637 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableApiLogging Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L686 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: external Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L701 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowInsecure Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L750 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: latestRevision Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L837 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isHostnameAlreadyVerified Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L922 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hasConflictOnManagedEnvironment Location: Microsoft.App/preview/2022-06-01-preview/ContainerApps.json#L992 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L562 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: external Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L598 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: allowInsecure Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L641 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: latestRevision Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L718 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isHostnameAlreadyVerified Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L768 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hasConflictOnManagedEnvironment Location: Microsoft.App/stable/2022-03-01/ContainerApps.json#L838 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️~[Staging] TrafficValidation succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/2ccb77ca5ef72261dab7a8a916ccad24eb39ea89/specification/app/resource-manager/readme.md#tag-package-preview-2022-06">app/resource-manager/readme.md#package-preview-2022-06
- "https://github.com/Azure/azure-rest-api-specs/blob/2ccb77ca5ef72261dab7a8a916ccad24eb39ea89/specification/app/resource-manager/readme.md#tag-package-2022-03">app/resource-manager/readme.md#package-2022-03
- "https://github.com/Azure/azure-rest-api-specs/blob/2ccb77ca5ef72261dab7a8a916ccad24eb39ea89/specification/app/resource-manager/readme.md#tag-package-2022-01-01-preview">app/resource-manager/readme.md#package-2022-01-01-preview
| Rule | Message |
|---|---|
| "readme":"app/resource-manager/readme.md", "tag":"package-preview-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
| "readme":"app/resource-manager/readme.md", "tag":"package-2022-03", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
| "readme":"app/resource-manager/readme.md", "tag":"package-2022-01-01-preview", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
NewApiVersionRequired reason: |
AzureRestAPISpecReview
added
ReadyForApiTest
This was referenced Sep 22, 2022
|
@leni-msft |
|
Hi @zhenqxuMSFT, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
JeffreyRichter
added
the
Approved-BreakingChange
leni-msft
approved these changes
Sep 28, 2022
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.