Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

Merged
merged 31 commits into from
Sep 26, 2022
Merged

[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01 #20680

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
d57bc32
Add comment to Change state parameters
Apr 10, 2022
22ac797
fix error
Apr 11, 2022
834ac0b
fix error
Apr 11, 2022
9a4e6f4
fix
Apr 11, 2022
d873e9e
fix
Apr 11, 2022
f69eff1
fix error
Apr 11, 2022
6a0aa9c
fix validations
Apr 27, 2022
d3d35ae
Merge branch 'main' into dev-alertsmanagement-Microsoft.AlertsManagem…
khaledaboasbe Apr 27, 2022
7ebf9df
add example for operation list command
May 15, 2022
53e8fbc
Merge branch 'dev-alertsmanagement-Microsoft.AlertsManagement-2019-03…
May 15, 2022
b701dc0
fix example
May 15, 2022
112af15
fix example
May 15, 2022
656afe5
fix
May 15, 2022
0d5b1ff
fix
May 15, 2022
4beeaec
delete json file
May 15, 2022
b11a37b
add origin parameter to operation defenition
May 16, 2022
9156c65
fix
May 16, 2022
1ef1936
fix
May 16, 2022
1f5078e
fix
May 16, 2022
f61f91a
delete unneccesary files
May 25, 2022
8145b84
revert packege-lock.json file changes
May 25, 2022
482351b
fix comment parameter to be comments
Sep 12, 2022
91e493d
Merge branch 'main' into dev-alertsmanagement-Microsoft.AlertsManagem…
khaledaboasbe Sep 13, 2022
7ac5025
Delete package-lock.json
khaledaboasbe Sep 13, 2022
0f5cf49
undelete package-lock.json
Sep 13, 2022
413cb66
fix comments object
Sep 20, 2022
ebe529d
run prettier
Sep 20, 2022
1308b5d
fix
Sep 20, 2022
2fedfc1
revert unncessary changes
Sep 20, 2022
4bbf1d6
LintdiffFix
Sep 21, 2022
227939f
run prettier
Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions ...ource-manager/Microsoft.AlertsManagement/preview/2019-05-05-preview/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@
"$ref": "#/parameters/newState"
},
{
"$ref": "#/parameters/comment"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not necessary -- please revert.

"$ref": "#/parameters/comments"
}
],
"responses": {
Expand Down Expand Up @@ -504,14 +504,19 @@
"modelAsString": true
}
},
"comment": {
"comments": {
"description": "reason of change alert state",
"name": "comment",
"name": "comments",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not needed -- please revert.

"in": "body",
"required": false,
"x-ms-parameter-location": "method",
"schema": {
"type": "string"
"type": "object",
"properties": {
"comments": {
"type": "string"
}
}
}
},
"alertState": {
Expand Down
13 changes: 9 additions & 4 deletions ...ement/resource-manager/Microsoft.AlertsManagement/stable/2019-03-01/AlertsManagement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
"$ref": "#/parameters/newState"
},
{
"$ref": "#/parameters/comment"
"$ref": "#/parameters/comments"
khaledaboasbe marked this conversation as resolved.
Show resolved Hide resolved
}
],
"responses": {
Expand Down Expand Up @@ -515,14 +515,19 @@
"modelAsString": true
}
},
"comment": {
"comments": {
"description": "reason of change alert state",
"name": "comment",
"name": "comments",
khaledaboasbe marked this conversation as resolved.
Show resolved Hide resolved
"in": "body",
"x-ms-parameter-location": "method",
"required": false,
khaledaboasbe marked this conversation as resolved.
Show resolved Hide resolved
"schema": {
"type": "string"
"type": "object",
"properties": {
"comments": {
"type": "string"
}
}
}
},
"alertState": {
Expand Down