Review request for Microsoft.ContainerService to add version 2022-08-02-preview #20487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w/2022-07-02-preview to version 2022-08-02-preview
…oundNAT (Azure#20407) * AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT * Change disableOutboundNAT to disableOutboundNat because of ARM format; Improve description. * Improve description
* added guardrails profile to specs * linter fix * added x-ms-enum * added guardrails definitions for versions route * linter fix, added custom word * fix * typo fix * fix for example * added object type * added object type * removed data field * changed descriptions * *
* add KubeProxyConfig to AKS NetworkProfile * remove extra comma, type: integer for *Seconds * add custom words * prettier * follow camel case ARM guidance * 2nd camel case standard
|
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
|
Hi, @FumingZhang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| managedClusters.json | 2022-07-02-preview(622b23e) | 2022-07-02-preview(main) |
️⚠️Breaking Change(Cross-Version): 17 Warnings warning [Detail]
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| managedClusters.json | 2022-08-02-preview(622b23e) | 2022-07-01(main) |
| managedClusters.json | 2022-08-02-preview(622b23e) | 2022-07-02-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-08 | package-preview-2022-08(622b23e) | default(main) |
| package-preview-2022-07 | package-preview-2022-07(622b23e) | package-preview-2022-07(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: disableOutboundNat Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L5956 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L37 |
|
The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L37 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L5620 |
|
The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L5742 |
| Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1268 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1271 |
|
| 'PUT' operation 'PrivateEndpointConnections_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1758 |
|
| 'PUT' operation 'PrivateEndpointConnections_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1725 |
|
| The operation 'ManagedClusters_GetCommandResult' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L2076 |
|
| The operation 'ManagedClusters_GetCommandResult' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L2037 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1859 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L2013 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1826 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1980 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1663 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1920 |
|
| Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1630 |
|
| Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1887 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L244 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L1967 |
|
| OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L244 |
|
| OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L1934 |
|
| The child tracked resource, 'agentPools' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3626 |
|
| The child tracked resource, 'commandResults' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L3998 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L5523 |
|
| The child tracked resource, 'trustedAccessRoleBindings' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-07-02-preview/managedClusters.json#L6857 |
|
| The child tracked resource, 'agentPools' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L3623 |
|
| The child tracked resource, 'commandResults' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L4070 |
|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L5646 |
|
| The child tracked resource, 'trustedAccessRoleBindings' with immediate parent 'ManagedCluster', must have a list by immediate parent operation. Location: Microsoft.ContainerService/preview/2022-08-02-preview/managedClusters.json#L6999 |
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/containerservice/resource-manager/readme.md json: Microsoft.ContainerService/preview/2019-10-27-preview/openShiftManagedClusters.json |
|
The default tag does not contain all APIs in this RP. Please make sure the missing API swaggers are in the default tag. readme: specification/containerservice/resource-manager/readme.md json: Microsoft.ContainerService/preview/2022-07-02-preview/fleets.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"\nfatal error: Failed to load step "step":"ManagedClusters_ListClusterAdminCredentials", "exampleFile":"../../2022-08-02-preview/examples/ManagedClustersListClusterCredentialResult.json": Example file is referenced by multiple operation: ManagedClusters_ListClusterAdminCredentials, ManagedClusters_ListClusterUserCredentials, ManagedClusters_ListClusterMonitoringUserCredentials ../../2022-08-02-preview/examples/ManagedClustersListClusterCredentialResult.json, \n" |
️⚠️~[Staging] TrafficValidation: 1 Warnings warning [Detail]
restlerResult: Request coverage (successful / total): 8 / 58 Attempted requests: 12 / 58
Traffic validation failed. Check pipeline artifact for restler output and detail report.
| Rule | Message |
|---|---|
| "Starting task Test...\nUsing python: 'python3' (Python 3.10.5)\nRequest coverage (successful / total): 8 / 58\nAttempted requests: 12 / 58\nNo bugs were found.\nTask Test succeeded.\nCollecting logs...\n" |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/622b23e370d86b99202823777fbf25253b083a45/specification/containerservice/resource-manager/readme.md#tag-package-preview-2022-07">containerservice/resource-manager/readme.md#package-preview-2022-07
- "https://github.com/Azure/azure-rest-api-specs/blob/622b23e370d86b99202823777fbf25253b083a45/specification/containerservice/resource-manager/readme.md#tag-package-preview-2022-08">containerservice/resource-manager/readme.md#package-preview-2022-08
| Rule | Message |
|---|---|
| "readme":"containerservice/resource-manager/readme.md", "tag":"package-preview-2022-08", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| "readme":"containerservice/resource-manager/readme.md", "tag":"package-preview-2022-07", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
ghost
added
the
Generated ApiView
|
|
Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Aug 31, 2022
Presumably an alternative would be to do something like we do for GET So if guardrails versions weren't nested under |
That one is incorrect as well since ideally all GET resources in ARM need to follow the ARM schema with the top level ARM properties like id, name and type. That one was probably missed during review. This would cause issues with clients that make the assumption for these properties. If you want to keep it free form I would suggest converting it to a POST .. i.e "POST .../listguardrailversions" Just as a side note Even for location based resources like the trustecaccessroles , there is an expectation that it has the type and name property which includes the location value. https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderRegistrationRoutingTypes.html#locationbased |
raosuhas
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
@raosuhas, I've forwarded you a mail where we explicitly asked about exactly this kind of API to the ARM API reviewers alias and were told that, provided the set of data is readonly (GET, no user PUT), the RP has flexibility to define it as "not a resource" and rather a static list of data. I don't think that solves your critique of it being under ManagedCluster (or does it?). But at least at the region level (like the TrustedAccessRoles API), I believe that pattern is allowed. |
FumingZhang
added
the
WaitForARMFeedback
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
…erties (Azure#20625) * removed guardrails-versions route, added guardrails profice to MC properties * removed unsued file for guardrails versions, removed unused custom word
palma21
approved these changes
Sep 9, 2022
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
This was referenced Sep 13, 2022
12 tasks
forteddyt
added a commit
to forteddyt/azure-rest-api-specs
that referenced
this pull request
Oct 5, 2022
* Workbooks correctness (#19984) * Workbooks correctness * add all types and examples * dev-Sentinel-2022-08-01 (#20290) * Adds base for updating Microsoft.SecurityInsights from version stable/2021-10-01 to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * Add MITRE support to alert rules models (#19757) * Update version * Fix lint diff error Co-authored-by: Lilyan Cohen <[email protected]> Co-authored-by: lilyanc02 <[email protected]> Co-authored-by: Lilyan Cohen <[email protected]> * fix incorrect discriminator value (#20300) * ACSS API Titles/Descriptions scrub (#20291) * ACSS API Titles/Descriptions scrub * Formatting and custom word ACSS Co-authored-by: Ashish Agrawal <[email protected]> * [Nginx] Specify host and schemes (#20305) * fix conditions - add action rule name filter (#19920) Co-authored-by: Khaled Abo Asbe <[email protected]> * Merging agrifood RP latest swagger for public preview readiness. (#20243) * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Adds base for updating Microsoft.AgFoodPlatform from version preview/2020-05-12-preview to version 2021-09-01-preview * Updates readme * Updates API version in new specs and examples * Private endpoint changes * updated examples * updated db update example * build fixes * changed common-types version * pr comments * minor update * Removed 202 response code from Put call * update examples * prettier fix * enum example fix * Incremental change of sensor feature * Adding support for operationResults api for farmbeats resource. * Making cosmetic changes to fix checks * Update readme.python.md pin the title for python SDK * Fixing one change * Rsolving comments Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Prabhav Gupta <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Dev resources microsoft.authorization 2022 08 01 preview akhe (#20118) * Adds base for updating Microsoft.Authorization from version preview/2020-07-01-preview to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * push the changes for the "variable" resource type * push the variable value changes * Fix the readme for microsoft.resources * fix static validation issues * attempt to fix linter/avocado errors * run prettier * try to fix the tags * redo tags for the variables * fix the scope issue causing autorest errors * try to fix the schema issues * fix the scopes for the examples back to container ids * try to revert spaces in readme.md * reorder resources * try excluding variable values sdk schema generation * re-add variable values * test push with the new autorest version * testing "any" for variable value column value type. * revert back to object * clarify register management group operation (#20224) * New API Path added "datawarehousequeries" in sqlpool (#19926) * Path datawarehousequeries added in sqlpool * Resolved Conflict - removed space * Changes in definitions * Changes in example-getdatawarehousequeries.json * added object in sqlpool * Updated datawarehousequeries json * modified sqlpool definitions * Removed properties in example json * added Removed items * added response in example json for dataWarehouseQueries * Added properties in definitions * updated mismatch type * modifications in id path * Properties changes * changed Value to Properties * properties to value changes * removed Nextlink * Removed array * updated description * Added type in response * chnages in responses * changes in readme * Null Changes * Changes in Readme added Datawarehousequeries * added missing tag in batch * Changed Value Object * Reversed type changes * Camel case changes * Camel Changes * Removed Extra Value Properties * Added Properties * Description Changes * resourceClass values * Added Custom Words Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * Update swagger-accuracy-report.md (#20295) * Enable custom skypetoken expiration for a 2nd API in the new 2022-10-01 version (#20039) * add optional custom token expiration to API that generates identity + skypetoken * update example * Update CommunicationIdentity.json * Update CommunicationIdentity.json * Update specification/communication/data-plane/Identity/stable/2022-10-01/CommunicationIdentity.json Co-authored-by: Mike Kistler <[email protected]> * Update CommunicationIdentity.json Co-authored-by: Mike Kistler <[email protected]> * AutoLd returning DetectedLanguage object instead of just string (#20318) * Making nextLink optional for Dynatrace.Observability (#20320) * Making nextLink optional * Making nextLink optional * swagger correctness (#20147) * swagger correctness * Resolved review comments * [Hub Generated] Publish private branch 'datafactory/mash/feature/GoogleSheets/swaggerNew' (#20337) * [AutoSync] 41dd785da9 GoogleSheets Swagger changes * [AutoSync] 41dd785da9 GoogleSheets Swagger changes Co-authored-by: swagger-automation <[email protected]> * Feature/barakkinarti/2022 07 20 preview (#20140) * [Hub Generated] Publish private branch 'dev-devcenter-Microsoft.DevCenter-2022-03-01-preview' (#20119) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * Squashed commit of the following: commit a4a717a783a6c5fb23e7f99a161fa100f5eb2d2c Author: tbyfield <[email protected]> Date: Mon May 16 18:33:25 2022 -0700 fixes commit 8c9e52c9be7632b815d28777c6ea4f7f5de9d515 Author: tbyfield <[email protected]> Date: Mon May 16 18:05:10 2022 -0700 Fixes commit 275c98f7d51c8395bf56c01d20ef09e7aec009c5 Author: tbyfield <[email protected]> Date: Mon May 16 17:11:17 2022 -0700 update custom-words commit 6bda486449adca9316186f7b81b8c0b6db8502ee Author: tbyfield <[email protected]> Date: Mon May 16 16:45:56 2022 -0700 Fix delete devbox response and example commit 39fb0c34240fec160b00882ce82ff69bcaf12f59 Author: tbyfield <[email protected]> Date: Mon May 16 16:37:39 2022 -0700 configure long running op commit ce68abe10e7767a29c9b5351a8e13ef9d8090d2d Author: tbyfield <[email protected]> Date: Mon May 2 22:52:32 2022 -0700 Renamed to 2022-03-01-preview. renamed fidalgo to devcenter. commit b17c3c1a034f15e6bea4d40e593ba0e0b3cc9c32 Author: tbyfield <[email protected]> Date: Tue Apr 19 22:22:55 2022 -0700 Fix spellcheck commit 850d105acda8fbc42d4898ee84d235bc9e370c88 Author: tbyfield <[email protected]> Date: Tue Apr 19 22:15:18 2022 -0700 Remove version created by typo commit 2039b67db5606a8c452081b99cb0a2dc2e236e72 Author: tbyfield <[email protected]> Date: Tue Apr 19 22:08:51 2022 -0700 Add 2021-09-01 API version commit d53853a21d7ed8a9c12635616ad2369aadee033c Author: tbyfield <[email protected]> Date: Tue Apr 19 20:53:20 2022 -0700 New Readme Config File commit 2ed34a01547eeec4da47662933b78fd0d7f02055 Author: tbyfield <[email protected]> Date: Tue Apr 19 20:53:20 2022 -0700 New Swagger Example Spec File commit 61e1f8d383c7408f52148587b270df04205d7542 Author: tbyfield <[email protected]> Date: Tue Apr 19 20:53:19 2022 -0700 New Swagger Spec File * Remove openapihub example file * api guideline related updates Added error code header, changed action path value * Add string validations * Swap post to get on remoteconnection * Update query parameters * Add required properties * add environments files * add environments to readme for package * Update patterns and host name * Restore schedules * Update hosts to use centralized params * Missed host ref * Add LocalAdministrator field to pool/devbox * follow action pattern, address additional pr feedback * add operation-location, remove 200 on LRO * Update owner to user to maintain consistency * Ensure examples match string patterns, run prettier, fix typos * Resolve a bunch of linting errors * Set userId param * Resolve readonly+required linting error (readonly items cannot be marked as required) * Example fixes * Fix casing * Return 200 response code for PUT, rename action body parameter * azure_auth -> AADToken * readonly -> required * Fix json * Fix again * Typo fix * Remove requireds that we need to null * Fix examples to remove fidalgo refs * Remove Rpaas subtype * Add readme files for required sdk codegen * Add 200 response workaround for LROs to environments dataplane * environments 200 LRO examples * Add 200 status code operations and examples * Add 200 and example for devbox delete * Move to plural operation names * Remove Fidalgo name Co-authored-by: tbyfield <[email protected]> Co-authored-by: Nick Depinet <[email protected]> Co-authored-by: Michael Stark <[email protected]> * S360 Fixes: Dev containerinstance microsoft.container instance 2021 09 01 (#20199) * Adding S360 fixes already made to newer API * Prettier run * Add missing option on delete call * Update recoveryservicesbackup readme.python.md (#20354) Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Review request for Microsoft.ContainerService to add version 2022-07-01 (#20285) * Adds base for updating Microsoft.ContainerService from version stable/2022-06-01 to version 2022-07-01 * Updates readme * Updates API version in new specs and examples * update readmes (#19871) * Add example of Azure KeyVault Secrets Provider Addon for 2022-07-01 (#19875) * add example of kv secret provider addon * fix lint * AKS OSSKU supports Windows options (#19976) * OSSKU supports Windows options * Improve description * add default for availableAgentPoolVersions (#19901) * sync PR #19592 ARM ID annotations for ContainerService * separate examples for list cluster credentials operations Co-authored-by: Shiqian Tao <[email protected]> * Updated Inbound NAT Pool and Nat Rule description (#20351) * Update PR template to select either data plane or control plane template (#20323) * Add section on improving RESTler coverage to Swagger accuracy report. (#20353) * add readme.java.md (#20378) * Remove default ReturnFaceId for Face Detection (#19894) * Remove default ReturnFaceId for Face Detection Change default value for the ReturnFaceId parameter in /detect operations from true to null. With the recent responsible AI changes, only approved customers have access to this parameter so it should not default to true. * Updating description for changed parameter * [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-08-01 (#20183) * Adds base for updating Microsoft.RecoveryServices from version stable/2022-05-01 to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * Added TrustedServiceByPassConfiguration in workspace (#20255) * Added trustedServiceByPassConfiguration to workspace * Model Validation Fix * Example changes * Added properties * Properties changes * Changes in workspace * Semantic validation fix * Properties changes * Added Object * Schema changes * response changes * Response revert Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * Update readme.python.md (#20386) * [Language] Add script parameter to Language Detection response (#20339) * add script param to detected language * update enum value * add to example * update enum name Co-authored-by: Akhila Yesantarao venkata <[email protected]> * [Cognitive Services - Language] 2022-07-01-preview swagger (#19558) * Language 2022-07-01-preview swagger * Update SuccessfulGetSupportedLanguages.json with fixes in dev * Update SuccessfulGetSupportedPrebuiltEntities.json with fixes in dev * Update SuccessfulGetSupportedLanguages.json with fixes in dev * fixing currency iso 4217 case error in analyzeconversations ISO4217 -> iso4217 * Update SuccessfulGetSupportedLanguages.json with fixes in dev * Update SuccessfulGetSupportedPrebuiltEntities.json with fixes in dev * Update SuccessfulGetSupportedLanguages.json with fixes in dev * Add back Conversations job cancel request * Add back fhir changes for healthcare * Add confidence score in healthcare relation and add healthcare example * prettier * fix HostParametersValidation * Add linting fixes * Fix screaming snake case for health entity category in july preview * Modify HealthcareEntityCategory to have pascal case values instead of SCREAMING_SNAKE_CASE in dev * Add linting fixes and missing change in dev * adjust indentation * Fix HealthCareEntityCateory for GA stable versions * Fix healthcare entity category in v3.1 example * Correct job id in example for health 3.1 * Modify Readme for July preview and remove readme within folder * Remove format int32 from few analyze text properties and update dev branch * Remove summarization int format * Revert "fixing currency iso 4217 case error in analyzeconversations" This reverts commit 1b5c97c761efd1b82e19da5d548a866b863e02f2. * Add abstractive summarization objects * Revert "Add abstractive summarization objects" This reverts commit 6eca2b499708e1e3777e14dd5c32096b01fbd702. * Add autolanguage detection and bringing to parity with dev * Add QnA swagger changes * Add QnA to Readme * Rename endpoint parameter back to Endpoint but keep format:uri * remove format uri * Update the CLU runtime swagger resolution kinds to match the service implementation. * Remove language code from URI * Update specification/cognitiveservices/data-plane/Language/preview/2022-07-01-preview/analyzetext.json Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * removing additional en-us from link in dev Co-authored-by: Kareem Yousef <[email protected]> Co-authored-by: FARHAD SHAKERIN <[email protected]> Co-authored-by: Aurgho Bhattacharjee <[email protected]> Co-authored-by: Yuantao Wang <[email protected]> Co-authored-by: Aurgho Bhattacharjee <[email protected]> Co-authored-by: Ahmed Ashour <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * Add package-composite-v5 tag to SqlVulnerabilityAssessment API (#19953) * Add package-composite-v5 tag to SqlVulnerabilityAssessment API * Fix duplicate ids for baseline APIs for SQL vulnerability assessment * Fix ids mix up * Fix duplicate ids for delete baseline rules * update read me * add directive to mitigate Go stuttering removal collision Co-authored-by: Ahmad Abas <[email protected]> Co-authored-by: tadelesh <[email protected]> * set disableLocalAuth to be read-only in swagger (#20358) Co-authored-by: Bingchen Li <[email protected]> * Add New Reco API Version (#20365) * add 22-03-01 preview api version * add new version to readme.md * fix array type new validation error * suppress operations API implementation * fix readme indentation * revert validation suppression * [DeviceUpdate] Update readme.python.md (#20401) * Update readme.python.md * Update readme.python.md * update (#20406) * [CLU Runtime] Introduce RegexKey type to the CLU ExtraInformation polymorphic list. (#20306) * Introduce RegexKey type to the CLU ExtraInformation polymorphic list. * Code review comments. * Code review comments. * [Cognitive Services - Language] Generate-QuestionAnswers API (#20326) * QnA Generation swagger and examples * parameter name changes and examples for flat qnas * example file rename useAnswerMarkedInContent * 2022-10-01-preview * pagination params for get request * 2 operations and qa instead of qna * examples moved to generate folder * replace prip version with pup * Correct copy paste error * DocumentKind GenerationDocument * documentKind in response documents * QnA to QA * revert CategoryType (#20423) * Added "isDevopsAuditEnabled" to sqlServer json (#20356) * Added "isDevopsAuditEnabled" to sqlServer json * Updated "isDevopsAuditEnabled" to GetWorkspaceManagedSqlServerBlobAuditingSettings json * [SQL] Bump ManagedDatabaseRestoreDetails and ManagedDatabase version in v5 tag (#19955) * Bump managedDatabaseRestoreDetails version * bump managed databases version as well * [Hub Generated] Publish private branch 'jarewert/public-devcenter-2022-09-01-preview' (#20349) * add or modify files * Updated title. * Switched to location for operation tracking. * Fixed title in other spec files. Co-authored-by: Jared Rewerts <[email protected]> * Add documentType parameter and possible enums for healthcare (#20329) Co-authored-by: Aurgho Bhattacharjee <[email protected]> * Updated response body to "SqlPoolOperationResults_GetLocationHeaderResult" sqlPool json (#20390) * GoogleSheets Synapse Swagger changes (#20332) * GoogleSheets Synapse Swagger changes * Comma fix * Added ModelRetrainDays field to ServiceConfiguration get and update (#20415) * [Hub Generated] Review request for Microsoft.HybridContainerService to add version preview/2022-05-01-preview (#20283) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Added the 2022-05-01-preview version of Microsoft.HybridContainerService * Corrected readme.md to remove older api versions, and added custom words * add x-ms-identifiers for hybriddatamanager (#19962) * add x-ms-identifiers for hybriddatamanager * Update hybriddata.json * update download restler config part (#20408) * update download restler config part * Added upload modified restler config and fix markdown format * Update documentation/swagger-accuracy-report.md Co-authored-by: Mike Kistler <[email protected]> Co-authored-by: Mike Kistler <[email protected]> * SKU schema update as per the ARM Contract (#20359) * sku schema update * remove required field * add x-ms identifier to capability * regenerate examples * sdk pipeline fix * [Hub Generated] Review request for Microsoft.Media to add version stable/2022-08-01 (#19778) * Adds base for updating Microsoft.Media from version stable/2021-11-01 to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * pushing new api version 2022-08-01 * fix avocado error * Update AssetsAndAssetFilters.json update hls setting description * Update AssetsAndAssetFilters.json changel roles to role * Update readme.md * Update read.md: add in missing ``` * Update readme.md: add correct default tag Co-authored-by: Sea Eun Lee <[email protected]> Co-authored-by: Ziwei Mao <[email protected]> * [Communication - Media composition] 2022-07-16-preview1 (#19026) * initial commit * . * add readmes * . * , * fix file name problem * . * . * . * prettier * add descriptions * . * . * . * address feedback * . * . * . * update input groups * [Nginx] Sync the swagger from RPSaaSMaster in azure-rest-api-specs-pr (#20311) * add x-ms-identifiers for hdinsight (#19957) * add x-ms-identifiers for hdinsight * Update cluster.json * [Hub Generated] Publish private branch 'appplatform/release/s209' (#20465) * [AutoSync] 056109218 feat(ACIS): Add UpdateAppInternalState operation * Update readme.python.md * Update readme.python.md * Update readme.md Co-authored-by: swagger-automation <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]> * add breaking change and oad rule mapping (#20021) * breaking change and oad rule mapping * small fix * use single category * Add CDN 2022 05 01 preview version (#18760) * Adds base for updating Microsoft.Cdn from version stable/2021-06-01 to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * Afd Migration Swagger updates * Addressing feedback * Fix validation errors * update sku type * Fixing some validation failures * Fix more validation issues * Fix alignment * Copied from stable version * Update api response * Update examples * update from older version * Copy from older version * Fix swagger lint * More swagger lint fixes * Update GenerateABasicApiScenario.md (#20496) * Move catch-all for data-plane codeowners to top of file (#20484) * SDK client library review feedback (#20482) * [AMS] Make primaryVerificationKey nullable (#20489) * Adding readme.java.md for agrifood (#20529) * Adding readme.java.md for agrifood * update * Update readme.java.md * Update readme.java.md Co-authored-by: Weidong Xu <[email protected]> * Add privacy verbiage to v7.3 write APIs (#20416) * [Maps - Tracking] Review request for Common to add version preview/1.0 [Hub Generated] (#20244) * Copy 1.0 to 2022-09-01-preview * Update version * Changes for 2022-09-01-preview version * modify agrifood readme.typescript.md (#20497) * modify agrifood readme.typescript.,d * Update readme.typescript.md Co-authored-by: Mary Gao <[email protected]> * swagger changes for NspAssociationReconcile and NspProfile (#20167) * remove private APIs * swagger changes for NspAssociationReconcile and NspProfile * remove check members, add reconcile * Add changes found in PS and CLI * validation changes * association name change Co-authored-by: Kaushal Kumar <[email protected]> Co-authored-by: Aastha Singh <[email protected]> * Annotated sqlserver WorkspaceManagedSqlServerSecurityAlertPolicy_Get to x-ms-mutability (#20533) * EdgeOrder 2022-05-01-preview (#19832) * initial commit * Update readme * Update swagger * fixes and examples * readme tag fix * Lint fix * Fix ChangedParameterOrder for $skipToken * Add privacy verbiage to 2021-10-01 API (#20453) * Add doc on authentication script for Restler (#20475) * Add doc on authentication script for Restler * Improve doc on authenticaion for RESTler * Update BigDataPools_Get properties to x-ms-mutability (#20540) * [Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2022-09-01 (#20426) * Adds base for updating Microsoft.AzureStackHCI from version stable/2022-05-01 to version 2022-09-01 * Updates readme * Updates API version in new specs and examples * Add Software Assurance API and properties 1)Add Enable Software Assurance Benefit API 2)Add SoftwareAssurance Properties in the Cluster 3)Add NodeType in the ClusterNode 4)Add OSDisplayVersion in the properties * Add read registeredSubscriptions permission in the list of operations * Fix Validation Failures * Address review comments Co-authored-by: Mark Cowlishaw <[email protected]> * [Synapse] Add TargetSparkConfiguration property for sjd and notebook (#20409) * add TargetSparkConfiguration property for sjd and notebook * prettier check * Adding 200 response to LRO operation (#20572) * Add GetSchemaByVersion API Route (#20115) * Add path for getting schema by version * Update examples * Fix parameter reference * Add format for int types * Adding IsVaultProtectedByResourceGuard to the BackupVault definition (#20470) * manual swagger fix * adding change to newer version * swagger fix * Empty-Commit * adding isVaultProtectedByResourceGuard in backupVault Co-authored-by: Charan MVS <[email protected]> * Updates the Suspend Backups description (#20575) * Add Identity With Delegations to Common Types (#19830) * add identity with delegations to common types * fix typo * changing definition order * fix reference path * [Stream Analytics] Fix S360 for auto-scale feature (#20090) * add new GetStreamingJobSKus api * add 'capacity' in 'sku' and let 'sku' out of 'properties' * change v1 definitions to v3 * fix api version * revert sku for create api * Revert "change v1 definitions to v3" This reverts commit a8687204a35bc2ce8d43bd3067da7a619216d6dc. * add 'x-ms-identifiers' * change operationId * [Hub Generated] Review request for Microsoft.DocumentDB to add version stable/2022-08-15 (#20405) * Adds base for updating Microsoft.DocumentDB from version stable/2022-05-15 to version 2022-08-15 * Updates readme * Updates API version in new specs and examples * rbac changes * cosmos-db: Add keysMetadata property to DatabaseAccount resource in 2022-08-15 stable. * update readme.md * Introduces 'EnablePartitionMerge' in DatabaseAccountProperties * Make keysMetadata properties read-only. * Add readOnly to keysMetadata. Co-authored-by: Erik Kühlmann Salazar <[email protected]> Co-authored-by: Srinikhil Naravamakula <[email protected]> Co-authored-by: ekuhlmann23 <[email protected]> * dev-Sentinel-2022-09-01-preview (#20391) * Adds base for updating Microsoft.SecurityInsights from version preview/2022-08-01-preview to version 2022-09-01-preview * Updates readme * Updates API version in new specs and examples * Add eventGroupingSettings to NRT alert rules (#20422) * Update AutomationRules.json (#20257) * Update AutomationRules.json * fix typo * prettier * fix linter errors * Update example file to show the 2 new condition types Co-authored-by: matanpa <[email protected]> Co-authored-by: ityankel <[email protected]> * Added missing property tenantid to Workspaces_Get workspaceRepositoryConfiguration (#20581) * Fixed many typos in Readme.MD (#20579) * [Hub Generated] Review request for Microsoft.Insights to add version stable/2022-06-15 (#19652) * Adds base for updating Microsoft.Insights from version stable/2021-08-01 to version 2022-06-15 * Updates readme * Updates API version in new specs and examples * Fixed package tag naming conflict * Separated SQR into package-2022-06-15-only * Fixed default package tag * Adding SQR 2022-06-15 version as part of package-2022-06 * Fixed default tag to be package-2022-06 * Added lenient-model-deduplication flag * Replaced common-types references to Resource,ErrorResponse with local definitions with different name * Renamed ErrorAdditionalInfo to ErrorResponseAdditionalInfo to avoid conflicts * Removed lenient-model-deduplication flag Co-authored-by: Avi Jerafi <[email protected]> * add x-ms-identifiers for hanaonazure (#19931) * add x-ms-identifiers for keyvault (#19982) * [Cognitive Services - Language] Adding Dynamic Classification to analyze-text sync Api (#20239) * Adding Zero Shot Api * adding loggingOptOut from inherting from base * Adding example * renaming from classes to categories * code review * corecting spelling * addinf model version in input and output * move from ZeroShot to Dynamic * updating example * referencing example * fix in indentation * [Synapse] Add release tag (#20492) * add release tag * fix lintdiff * fix lintdiff * fix lintdiff * [Language Detection] Make script field optional in API response (#20472) * make script field optional in response * update script to be string * make script as optional extensible enum * Add example for Latin script Co-authored-by: Akhila Yesantarao venkata <[email protected]> * Fixing 2018-09-01 Spec (#20309) * Fixing 2018-09-01 spec * Fixing styling * Changing to readOnly * Applying Baron's comments * Update readme.python.md Co-authored-by: Yuchao Yan <[email protected]> * Adding return/calculateRefund to Microsoft.Capacity 2022-03-01 (#20421) * Adding calculateRefund api * Return path * fix * Added Path and example (#20425) * Added Path and example * Parameter changes * Description added * value changes * Response changes * example changes * Property added * name changes * Definition changes * model validation * object added * Response/prettier changes Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * [Go Datafacotry] use direcitve to mitigate go sdk breaking (#20614) * Update readme.md (#20615) * Added Path and Properties (#20389) * Added Path and Properties * added type object * Properties changes * Checks Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * Add pagination to cost management Query API (#19609) * chore: create new preview version (2022-08-01) Copy last stable version (2021-10-01) into new preview version (2022-08-01) * chore: delete unmodified specifications * feat: add pagination to cost management query api * fix: fix avocado errors * fix: change parameter order on query APIs to avoid breaking change * [Cognitive - Language] Conversation API Async Update - Conversational Sentiment Analysis- API 2022-10-01-Preview (#19742) * Add conversational SA kind * Adding conversational SA task and result * Address the comments * Address the comments * Add example input and output * Drop sentence properties * Remove the sentence property * Remove the stringIndex Co-authored-by: Ranran Wang <[email protected]> * Fix hybridaks go repo name (#20633) * ervice Fabric Managed Clusters - api version 2022-08-01-preview (#20307) * initial commit copy from 2022-06-01-preview * update swagger and examples with new api version * update version on readme * remove UDWiseUpdate * add x-ms-arm-id-details Co-authored-by: Alfredo Santamaria Gomez <[email protected]> * Update hybridaks readme.python.md (#20635) Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * Added Path and Properties (#20580) Co-authored-by: VamshiKrishna Chirra (Quadrant Resource) <[email protected]> * [OperationalInsights] Added 201 return status to QueryPacks_CreateOrUpdate (#19674) * added 201 return status to QueryPacks_CreateOrUpdate * update return contract for QP: QueryPacks_CreateOrUpdate * added queryPackName as empty string to examples * removed redundent name from 201 response example * update QP swagger * [Microsoft.Cache] Add 200 response code to PrivateEndpointConnections_Put (#20620) * Add 200 response code to PrivateEndpointConnections_Put * Update Examples for 200 response code. * typo: verion -> verion (#20508) * Fix user-assigned identity type names (#20376) * Fix user-assigned identity type names * Add default tag to readme.md * Add a tag that covers both searchservice and searchindex specs and make that the default * Fix duplicated SearchError Co-authored-by: Shivangi Reja <[email protected]> * [Cognitive Services - Language - Text API][2022-10-01-preview] Add healthcare document type corrections and examples. (#20612) * Add healthcare document type corrections and examples. * Add example references to analyzetext * Fix document dynamic classfication example * Minor prettier check fixes * Add model version to reponse of dynamic classification example Co-authored-by: Aurgho Bhattacharjee <[email protected]> * [Schema Registry] Update code owners (#20666) * [Go] rename hybridaks to hybridcontainerservice (#20657) * Adding archive/unarchive to Microsoft.Capacity 2022-03-01 (#20574) * Adding archive/unarchive to Microsoft.Capacity 2022-03-01 * fix * format * update Synapse owner (#20565) * [Marketplace Catalog - Search] data plane api (#19292) * Added search data-plane * added marketplace catalog resource manager * fixed readme * Fixed Spec Linter validations * fixed all validation tools * fixed avo * fixed prettier check * fixed spelling * Removed resource-manager from data-plane branch * used v3 common types * dont use v1 types * fixed prettier * fixed code review comments * fixed validations * fixed prettier * added x-ms-error-code * updated "take" to "top" and collectionFormat to "csv" * small description fix * Removed not needed or used param * Change stable to preview and updated api version to 2022-06-23-preview * Removed autocomplete and facets from preview api and fixed descriptions * fixed enum validations * fix enum names in query * fixed descriptions * fixed example * fixed version * fixed typo * fixed spellings * market is required * fixed prettier * Fixed descriptions * Added csp state description * Rename categoryIds to labels * Added descriptions * fixed sku and vm arch type * fixed example * fixed readme api version * vm security types * fixed description * labels to categoryids * added search fields * pricing types values * added descriptions * fixed typos * enum values * added enum descriptions * added enum descriptions * fixed descriptions * fixed descriptions * Removed not documented fields * description * pricing types * fixed enum types * Removed categoryIds from planSummary Co-authored-by: Greg Oks <[email protected]> * [Language Text] Dedepublicate TaskState schema (#20676) * [Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 (#20383) * Initial Change * Added enum property * Fixed example files * Re-added property * Added x-ms-enum to enums * Ran prettier * Removed non-required property * Add format: duration to duration property (#20135) * Add format: duration to duration property * Fix formatting Co-authored-by: andrew <[email protected]> * Mark mandatory param as required (#20638) * Review request for Microsoft.ContainerService to add version 2022-08-02-preview (#20487) * Adds base for updating Microsoft.ContainerService from version preview/2022-07-02-preview to version 2022-08-02-preview * Updates readme * Updates API version in new specs and examples * sync changes from PR#19592 & PR#20145 (#20402) * update readme & remove fleets (#20388) * AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT (#20407) * AKS agent pool properties add AgentPoolWindowsProfile and DisableOutboundNAT * Change disableOutboundNAT to disableOutboundNat because of ARM format; Improve description. * Improve description * Added guardrails profile to specs (#20171) * added guardrails profile to specs * linter fix * added x-ms-enum * added guardrails definitions for versions route * linter fix, added custom word * fix * typo fix * fix for example * added object type * added object type * removed data field * changed descriptions * * * add "Mariner" for AKS os sku (#20420) * add KubeProxyConfig to AKS NetworkProfile (#20446) * add KubeProxyConfig to AKS NetworkProfile * remove extra comma, type: integer for *Seconds * add custom words * prettier * follow camel case ARM guidance * 2nd camel case standard * feat: add rest api spec for ip-based lb (#20392) * fix LroLocationHeader (#20491) * fix ProvisioningStateValidation (#20490) * Removed guardrailsVersions route, added guardrails profice to MC properties (#20625) * removed guardrails-versions route, added guardrails profice to MC properties * removed unsued file for guardrails versions, removed unused custom word Co-authored-by: Shiqian Tao <[email protected]> Co-authored-by: rsamigullin <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: Qi Ni <[email protected]> * Remove unused Microsoft.MobileNetwork 2022-01-01-preview API (#20641) * {AzureSecurityContacts} fixes Azure/azure-rest-api-specs#20364 (#20434) Currently, the azure python SDK supports version 2017-08-01-preview for security contacts. We need to update it to 2020-01-01-preview. fixes Azure/azure-rest-api-specs#20364 This request is forwarded from Azure/azure-sdk-for-python#25771 * Update readme.python.md (#20654) * Update readme.python.md (#20686) * update (#20688) * update sku uri (#20639) * [Hub Generated] Publish private branch 'dev-azure-kusto-Microsoft.Kusto-2022-07-07' (#20689) * Adds base for updating Microsoft.Kusto from version stable/2022-02-01 to version 2022-07-07 * Updates readme * Updates API version in new specs and examples * Changes * Update * Update readme.md * fix * Update readme.md * New line * Add Database CallerRole * Update example * "callerRole" : "Admin" * Prettier * update readme.typescript.md in hybridaks (#20655) * [Language Text] Fix SentimentResponse detected language (#20678) * [Language Text] Fix SentimentResponse detected language * add auto LD for healthcare * fix duplicate schema for JobState (#20684) * Fixing broken link for in feature state create post request (#20102) * Fixing broken link for in feature state create post request * Removing region specific path in URl Co-authored-by: tejitpabari <[email protected]> * [Language Text] Rename model name (#20694) * [Language Question Answering - Generate] Fix result, maxQACount and examples (#20679) * fix inconsistency in examples after swagger changes * fix answer tags * maxResultCount to maxQACount * Document -> GenerationDocument * [Microsoft.Capacity] Fixing API paths (#20671) * [Microsoft.Capacity] Fixing API paths * update * update example * Update recommendation short descriptions for problem and solution. (#20624) * Update recommendation short descriptions for problem and solution. * Fix verbiage on the new short description. * Update sample uuid for empty response. * Add example for List Operations. * Run prettier on ListOperations example. Co-authored-by: patrinid <[email protected]> * (ARMSubscription) fixes Azure/azure-sdk-for-go#18620 (#19870) * (ARMSubscription) fixes Azure/azure-sdk-for-go#18620 fixes #18620 The subscriptions Model struct includes a number of fields, but not all the fields available in the REST API according to the documentation. Specifically, the following fields are missing in the Go struct: tenantId - The subscription tenant ID. tags - The tags attached to the subscription. Note that these fields are returned by the API and are documented here: https://docs.microsoft.com/en-us/rest/api/resources/subscriptions/list?tabs=HTTP#subscription * Update subscriptions.json * {AzureSubscription} Fixes Azure/azure-sdk-for-go#18619 (#19919) fixes Azure/azure-sdk-for-go/18619 The TenantIDDescription struct returned by calls to TenantsClient.ListComplete contains only two fields: ID and TenantID: However, the underlying API returns many more useful fields, including countryCode, displayName, domains, tenantCategory defaultDomain and tenantType. It would be great if these fields could also be made accessible through the Go SDK. * [NetAppFiles] Anf 21478 update for 2022 05 01 (#20435) * add 2022-05-01 folder * udpate api-version * add 2022-05-01 changes * pretty * Remove location from vaults examples * custom word Showmount * udpate max for usageThreshold * descriptiopn usageThreshold * add cmk changes * add cmk changes, object * fix usageThreshold * regioninfo * remove regionInfo from 03 * snapshotid mutability * backupid mutability * pretty * missin x-ms-identifyer * [Compute] New Api Version 2022-07-02 (#20223) * New Api version 2022-07-02 * readme changes * version update * Adding diskControllerTypes and optimizedForFrequentAttach to resources (#19958) * add new api version * add examples for optimizedForFrequentAttach * adding diskcontrollertypes * adding example and removing unknown characters * removing unknown character * removing null * updating description * Fix examples and readme * fix based on target branch * add examples * remove bad files * fix readme * fix description for property * adding nvme to customwords.txt * Updating comment on NVME feature * Fixed swagger bugs (#4) * Fixed swagger bugs * Addressed comments * Updated description * Added performancePlus property * Updated description for performance plus * Addressed comments * Removed read Only property Co-authored-by: akashpargat <[email protected]> Co-authored-by: Sarah Rahman <[email protected]> Co-authored-by: Akash Pargat <[email protected]> Co-authored-by: akashpargat <[email protected]> * Readme.md correction * Adding examples * fix syntax * update common.json to common-types folder * example fixes * fix snapshot example Co-authored-by: chetmaddula <[email protected]> Co-authored-by: Sarah Rahman <[email protected]> Co-authored-by: Akash Pargat <[email protected]> Co-authored-by: akashpargat <[email protected]> Co-authored-by: Theodore Chang <[email protected]> * Add directive in readme.java.md to make redisConfiguration.additonalProperties as string to string map (#20715) * add directive in readme.java.md to make additonalProperties in redisConfiguration as Map<String, String> * clean up redis/resource-manager/readme.md * Move from preview to stable (#20693) * Move from preview to stable * Adjust readme.md package-preview-2022-07 -> package-2022-07 * fix path to ErrorResponse (#20706) * [Hub Generated] Review request for Microsoft.ResourceHealth to add version stable/2020-05-01 (#19956) * Fixing swagger to match actual responses * Fixing azure-sdk-for-net-track2 * Adding custom words * Fixing linting errors * [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2022-10-01-preview (#20685) * Adds base for updating Microsoft.CostManagement from version preview/2022-08-01-preview to version 2022-10-01-preview * Updates readme * Updates API version in new specs and examples * Adding New Settings API to Cost Management RP. * Updating the configurations * Adding taginheritance to custom words * Adding 200 response for update * removing x-ms-client-flatten = true * Implementing Discriminator Pattern for the settingType * MISC * Description updated * MISC * FIx Model Validations due to descriminator * Remove readonly property * Revert the readonly property * Adding Kind as discriminator property * MISC * MISC * Added "tenantId" property to workspace response (#20360) * Added "tenantId" property to workspace response * Fixed Model Validation errors * Fix Model validation format uuid errors * Fixed lint errors * Fix model validation error Expected type but found type object, Expected type string but found type object * Fix semantic validation error Expected type object but found type string * Fix Model validation error * Revert "Fix Model validation error" This reverts commit f3b67384368310f3125b19d3b8ca1b650bcb3591. * Fix Modelvalidation error * Changed location to string Resolved review comments * Resolved review comments * Resolve LRO location error * updated path from V2 to V1 (#20476) * updated path from V2 to V1 * Updated Model validation error of 202 status missing * Fix model validation error XmsEnumValidation, MissingXmsErrorResponse * Fixed lint error * Fix Model validation error * Fix lint error * Fix model validation error * Revert "Fix model validation error" This reverts commit f5087d0a72c48a7670b8235e003590230aeecd44. * Fix Semantic validation * Fix semantic validation error * Reverting User Assigned MI for Access Connector (#20698) * Reorder the swagger actions following relativePath_httpmethod (#20524) * Reorder the swagger actions following relativePath_httpmethod * Create HealthApi_GetServiceStatus.json * Add files via upload * Update webpubsub.json * Update HealthApi_GetServiceStatus.json * Update webpubsub.json * Fix sample failure * Add message * Prettier * avoid breaking change * resolve comments * clean up error body for HEAD * fix build failure * fix build failure * [Cognitive Services - Language - Text API] Enable resolutions for Named Entity Recognition (#20371) * Enable resolutions for Named Entity Recognition * Add sample * Remove risk field from Advisor 2020-01-01 stable. (#20628) Co-authored-by: patrinid <[email protected]> * [CosmosDB] Review request for Microsoft.DocumentDB to add version preview/2022-08-15-preview (#20419) * Adds base for updating Microsoft.DocumentDB from version preview/2022-05-15-preview to version 2022-08-15-preview * Updates readme * Updates API version in new specs and examples * adaptive RU sharedthroughput changes * add mongodb database redistribute throughput * InAccount Restore Examples for SQL database and container and MongoDB database and collection * fix example references for inaccount restore and pretify all example files * InAccount Restore fix example references * InAccount Restore fix createMode case in examples * InAccount Restore for SQL and MongoDB changes * Added keysMetadata readonly field changes and added EnablePartitionMerge changes Co-authored-by: Himanshu Sunil Dhawale <[email protected]> Co-authored-by: Dinesh Kumar Dhamotharan <[email protected]> * Update example LedgerUri (#20721) * patch fleets in 0802preview tag (#20713) * Update readme.md (#20741) * [Dynatrace][Mgmt] rename client name (#20742) * Update readme.python.md * Update readme.python.md Co-authored-by: Yuchao Yan <[email protected]> * Updated DatadogOrganizationProperties for reduce onboarding friction story | Datadog (#20022) * initial commit * updated new api version 2022-06-01 in all examples and datadog.json * updated 2 parameters of 'DatadogOrganizationProperties' to mandatory: - Name : Name of the Datadog organization - Id : Id of the Datadog organization * added datadogOrgID in 'datadogOrganizationProperties' In Request send for Create Monitor * added New Tag version details in all readme(s) wherever required * Change Mutability for DatadogOrganizationProperties => Id & Name (added read to x-ms-mutability) * reverted back changes from readme.go.md as these were used to serve track 1 SDK. Now latest api-version will not have track 1 Go SDK, but it will have track 2 SDK. * config (#20759) * remove the deduplication (#20756) * make compilationJobs name segment consistent and ARM spec conformant (#20588) * make compilationJobs name segment consistent and ARM spec conformant * update segment descriptions * update examples for property rename * Update containerservice for release (#20761) * Update containerservice for release * Update readme.md * Update readme.python.md Co-authored-by: Zhenbiao Wei (WICRESOFT NORTH AMERICA LTD) <[email protected]> * ComputeRP 2022-08-01 release (#20552) * add files to new version folder * update version references and readme tags * update common types version line and reference to common.json * add fetures for 2022-08-01 release * remove admin password for ModelValidation CI Co-authored-by: Theodore Chang <[email protected]> * Task 15221970 - ASE DataBoxEdge S360 Compliance (#20648) * [Microsoft.StorageSync] New API version 2022-06-01 (#20227) * Adds base for updating Microsoft.StorageSync from version stable/2020-09-01 to version 2022-06-01 * Updates readme * Updates API version in new specs and examples * Swagger API Spec Update for adding Low Disk Mode to Storage Sync (#19725) * Added Low Disk Mode property * Updated API Spec for introducing Low Disk Mode * Updated Examples for API Spec for Low Disk Mode * Updated Examples for Cloud Tiering Status (#19885) * [Microsoft.StorageSync] Add AFS file share metadata certificate public keys API to version 2022-06-01 (S360 compliance) (#20517) * Fix readme.md file so that tag information includes full API version 2022-06-01 * Add afs share metadata certificate public keys API https://portal.azure-devex-tools.com/amekpis/completeness/detail?errorId=DBF8D800-EB0B-48E0-B665-BC91CB1A17B9 * Fix casing of afssharemetadatacertificatepublickeys * Temporarily rename examples file to fix casing issue. * Fix casing of new example file Co-authored-by: ankushbindlish2 <[email protected]> Co-authored-by: Juan Carlos Juarez <[email protected]> * Network 2022 05 01 (#20695) * Adds base for updating Microsoft.Network from version stable/2022-01-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * add DisableTcpStateTracking on nic (#19734) Co-authored-by: Dan Tu <[email protected]> * Adding new VIP Swap APIs to support extension resource design (#19698) * Adding new VIP Swap APIs to support extension resource design * fixing validation checks * minor fix * Reverting changes * Minor fix to add a new line * fix description (#19987) Co-authored-by: Dan Tu <[email protected]> * Add BillingType Property to ExpressRoutePorts (#19932) * change port json * changes * add Virtual network gateway policy group api (#19766) * finish update on connection configuration references * resolve reference error * finish prettier * resolve sematic error * finish update change * enablePrivateLinkFastPath property for VirtualNetworkGatewayConnection resource (#20050) * Support for Per Rule Actions in Application Gateway WAF (#20027) * Adding changes for per rule actions * Fixing spaces * prettier fix * Addressing PR comments * Address review comments * Add ColoLocation to ExpressRoutePort result (#20033) * Add ColoLocation to ExpressRoutePort result * Fix automation code check error * Merge from network-2022-05-01 * Revert "Merge from network-2022-05-01" This reverts commit f0671a040b2bad684921f8f8ad4b53bb0f4b4a93. Co-authored-by: Jianqi Zhao <[email protected]> * DDoS Per IP SKU + Custom Policy Deprecation Swagger PR (#19985) * initial changes * example file changes * new files for new apis * adding a period * changing reference * prettier fixes * ddos fix * lint diff fixes * more lint diff errors * fixing operation id * changing bool to string enum * example changes * adding 202s as these are long running ops * examples Co-authored-by: Manas Chakka <[email protected]> * Adding UnhealthyThreshold property to LB health probes, and updated examples with new property (#20001) * Property to enable/disable OCSP revocation check on client certificate (#20301) * add new property to enable/disable OCSP revocation check on client certificate for MTLS * revert breaking change of updating enum property * Add new parameter asn, geo and expressRouteAdvertise to CustomIPPrefix for new 2022-05-01 nrp sdk version (#20266) * fix * fix * fix * fix * fix * fix Co-authored-by: Weiheng Li <[email protected]> * Network 2022-05-01 Azure Virtual Network Manager Contributions (#20440) * Add third NIP enum for avnm security admin config, AllowRulesOnly * add optional top parameters to various network manager post APIs * revise all example input subscriptions to all zero guid * change all top parameter max value to 100 * Revert "change all top parameter max value to 100" This reverts commit 12943d2f2b91b22f1dae232cb291a8551fedfdca. Co-authored-by: Jared Gorthy <[email protected]> * Alpelled waf manifest 05 01 2022 (#20047) * init * init * fix comments * fix err * try ref to appgw def * try ref to appgw def * try ref to appgw def * try ref to appgw def * update example * update example * update example * update state and action * update state and action * change ruleset name and add tiers * cammel case fix * cammel case fix * s_ruleid * s_RuleId * suppress s_RuleId camel case issue * suppress s_RuleId camel case issue * address comments * address comments * address comments * fix typo * cont fix * cont fix * cont fix * cont fix * cont fix * add pageable * add next link Co-authored-by: Alon Pelled <[email protected]> * Add prefixType property to CustomIPPrefix for NRP 2022-05-01 (#20486) * add prefixType parameter * add example * Adding swagger changes for routemaps feature (#20091) * initial changes for routemaps * run npm prettier script * adding examples * fixing validation errors * more validations * more fixes * trying to fix lint error * fix for match condition * renaming ActionType to fix lint * fix for python sdk generation * renaming Rule to RouteMapRule * modify examples to remove vnetroutes from non hub vnet conns * cleanup * Added Upper-case transform (#20674) Co-authored-by: dtuCloud <[email protected]> Co-authored-by: Dan Tu <[email protected]> Co-authored-by: shnaya434 <[email protected]> Co-authored-by: nimaller <[email protected]> Co-authored-by: tyrannicrex <[email protected]> Co-authored-by: Jesus Arango <[email protected]> Co-authored-by: Sindhu Aluguvelli <[email protected]> Co-authored-by: Jianqi Zhao <[email protected]> Co-authored-by: Jianqi Zhao <[email protected]> Co-authored-by: Manas Chakka <[email protected]> Co-authored-by: Manas Chakka <[email protected]> Co-authored-by: bhavanabheem <[email protected]> Co-authored-by: biaogao <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: Weiheng Li <[email protected]> Co-authored-by: jago2136 <[email protected]> Co-authored-by: Jared Gorthy <[email protected]> Co-authored-by: alon-microsoft <[email protected]> Co-authored-by: Alon Pelled <[email protected]> Co-authored-by: Eric Hoffmann <[email protected]> Co-authored-by: arganapathy <[email protected]> Co-authored-by: rahulbissa2727 <[email protected]> * Release Microsoft.SQL 2022-05-01-preview (#20743) * create a new branch for release * fix one line readme.md * fix lint error * [Hub Generated] Publish private branch 'release-security-Microsoft.Security-2022-08-01-preview' (#20730) * Adds base for updating Microsoft.Security from version preview/2022-05-01-preview to version 2022-08-01-preview * Updates readme * Updates API version in new specs and examples * update swagger * update readme * update readme tag * Added RDS to Swagger * remove empty configuration property * update exculsion tags Co-authored-by: Ameer Abu Zhaia <[email protected]> Co-authored-by: Ameer Abu Zhaia <[email protected]> Co-authored-by: Ofir Haviv <[email protected]> * [Nginx] Add readOnly for ProvisioningState (#20707) * [Nginx] Add readOnly for ProvisioningState * Update api version parameter * Bug Fix techniques field as readonly in fusion rule (#20668) * [Hub Generated] Review request for Microsoft.HardwareSecurityModules to add version stable/2021-11-30 (#20734) * changed dataType of isDataAction from string to boolean * changed dataType of isDataAction from string to boolean * Fix authentication script for RESTler (#20673) The last line of the authentication script was truncated -- probably a bad copy/paste. This fixes it. * [Hub Generated] Publish private branch 'datafactory/mitra/updatescripttoscriptlines' (#20781) * [AutoSync] ee38db2819 Update documentation with scriptLines * [AutoSync] ee38db2819 Update documentation with scriptLines Co-authored-by: swagger-automation <[email protected]> * Add default value for PublicNetworkAccess property (#20723) * Add default value for PublicNetworkAccess property * Default should be enabled * Add privacy verbiage to 2022-07-01 API (#20452) * modified the value of queryId from int to string (#20767) * OperationalInsights: 2022-10-01 stable version. (#20236) * OperationalInsights: 2022-10-01 stable version * Actual changes. * More fixes. * more changes. * Removing redundant breaking change. * Workspace identity: referencing standard types. * Referencing managed identity standard type, refactoring booleans into enum. * Fixing examples. * Removing duplicate resource. * Update Workspaces.json * Update Clusters.json * Revert "Update Clusters.json" This reverts commit 4eb99cf4699afeb95dc2bab1ee071c7d4f9ee2c5. * Revert "Update Workspaces.json" This reverts commit c16bc82f2ec8a35131c1ec54d2dca147eca929d1. * Returning to our identity implementation. * update readme.typescript (#20798) * Azure Health Bot - New API 2022-08-08 - Secrets management using ARM (#20310) * First commit - Copy older folder * Support fetching Azure Health Bots secrets and regenerate JWT API key using ARM operation. * Fixes based on validations. * Add schema. * Fix sample. * Fix. * Add "x-ms-secret": true, for a secret property. * Update readme.python.md * Update readme.python.md Co-authored-by: Yuchao Yan <[email protected]> * [Hub Generated] Review request for Creator to add version preview/2022-09-01-preview (#20653) * swagger doc updates for custom styling apis * rename style import and export to create and get * More docs updates * Fix validation errors * Update to defaultConfiguration * Add Content-Type in request headers * Minior updates on comments * remove extra produces * [Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-08-01 (#20056) * Adds base for updating Microsoft.RecoveryServices from version stable/2022-04-01 to version 2022-08-01 * Updates readme * Updates API version in new specs and examples * Update vaults.json * Update vaults.json Fixed Prettier error * [Hub Generated] Review request for Microsoft.CostManagement to add version preview/2022-10-05-preview (#20794) * Adds base for updating Microsoft.CostManagement from version preview/2022-10-01-preview to version 2022-10-05-preview * Updates readme * Updates API version in new specs and examples * New API added for preview * Fixed type references for Proxy Resource and ApiVersion * Removed the duplicate * Fixed Avocado errors * Readme updated * version restore * Version upgrade * Missing definitions * versions fixed for examples * Merge Microsoft.app 2022 06 01 preview to main (#20787) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <[email protected]> * Fix definition for customhostnameesult (#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (#19048) * Correct Probe enums (#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Mike Vu <[email protected]> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> * Fix description in all API versions (#19313) * Fix description for ManagedEnvironment.Internal property (#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <[email protected]> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <[email protected]> * Add custom domain configuration for managed environment (#20149) Co-authored-by: Mengjun Qin <[email protected]> * Add additional Dapr options (2022-06-01-preview) (#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small c…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Alread deployed to all global regions by 08/29.
ASAP, 09/01.
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.