Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview #19783

Merged
merged 2 commits into from
Jul 15, 2022
Merged

sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview #19783

merged 2 commits into from
Jul 15, 2022

Conversation

serbrech
Copy link
Member

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @serbrech Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 15, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-preview-2022-06 package-preview-2022-06(1f7bded) package-preview-2022-06(dev-containerservice-Microsoft.ContainerService-2022-06-02-preview)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'members' with immediate parent 'Fleet', must have a list by immediate parent operation.
    Location: Microsoft.ContainerService/preview/2022-06-02-preview/fleets.json#L697
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/1f7bded276ba77ec14e9b53e71bf0ee6a0ede7f3/specification/containerservice/resource-manager/readme.md#tag-package-preview-2022-06">containerservice/resource-manager/readme.md#package-preview-2022-06
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"containerservice/resource-manager/readme.md",
    "tag":"package-preview-2022-06",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 15, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armcontainerservice - 2.0.0-beta.2
    ️✔️azure-sdk-for-js - @azure/arm-containerservice - 17.0.0-beta.2
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 20.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-containerservice        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group FleetMembersOperations
info	[Changelog]   - Added operation group FleetsOperations
info	[Changelog]   - Model ManagedClusterSecurityProfile has a new parameter node_restriction
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]  
  
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]  
  
    • ️✔️Succeeded [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcontainerservice        [View full logs]         [Preview SDK Changes]      
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `FleetMemberProvisioningStateSucceeded`
info	[Changelog] - New const `FleetProvisioningStateSucceeded`
info	[Changelog] - New const `FleetMemberProvisioningStateFailed`
info	[Changelog] - New const `FleetProvisioningStateCanceled`
info	[Changelog] - New const `FleetMemberProvisioningStateUpdating`
info	[Changelog] - New const `FleetMemberProvisioningStateJoining`
info	[Changelog] - New const `FleetProvisioningStateDeleting`
info	[Changelog] - New const `FleetProvisioningStateUpdating`
info	[Changelog] - New const `FleetMemberProvisioningStateCanceled`
info	[Changelog] - New const `FleetProvisioningStateFailed`
info	[Changelog] - New const `FleetProvisioningStateCreating`
info	[Changelog] - New const `FleetMemberProvisioningStateLeaving`
info	[Changelog] - New function `*FleetMembersClient.BeginDelete(context.Context, string, string, string, *FleetMembersClientBeginDeleteOptions) (*runtime.Poller[FleetMembersClientDeleteResponse], error)`
info	[Changelog] - New function `PossibleFleetProvisioningStateValues() []FleetProvisioningState`
info	[Changelog] - New function `*FleetsClient.BeginCreateOrUpdate(context.Context, string, string, Fleet, *FleetsClientBeginCreateOrUpdateOptions) (*runtime.Poller[FleetsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*FleetMembersClient.BeginCreateOrUpdate(context.Context, string, string, string, FleetMember, *FleetMembersClientBeginCreateOrUpdateOptions) (*runtime.Poller[FleetMembersClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `NewFleetMembersClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FleetMembersClient, error)`
info	[Changelog] - New function `*FleetsClient.ListCredentials(context.Context, string, string, *FleetsClientListCredentialsOptions) (FleetsClientListCredentialsResponse, error)`
info	[Changelog] - New function `*FleetsClient.Get(context.Context, string, string, *FleetsClientGetOptions) (FleetsClientGetResponse, error)`
info	[Changelog] - New function `NewFleetsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FleetsClient, error)`
info	[Changelog] - New function `*FleetMembersClient.NewListByFleetPager(string, string, *FleetMembersClientListByFleetOptions) *runtime.Pager[FleetMembersClientListByFleetResponse]`
info	[Changelog] - New function `*FleetsClient.NewListByResourceGroupPager(string, *FleetsClientListByResourceGroupOptions) *runtime.Pager[FleetsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*FleetsClient.Update(context.Context, string, string, FleetPatch, *FleetsClientUpdateOptions) (FleetsClientUpdateResponse, error)`
info	[Changelog] - New function `*FleetMembersClient.Get(context.Context, string, string, string, *FleetMembersClientGetOptions) (FleetMembersClientGetResponse, error)`
info	[Changelog] - New function `*FleetsClient.BeginDelete(context.Context, string, string, *FleetsClientBeginDeleteOptions) (*runtime.Poller[FleetsClientDeleteResponse], error)`
info	[Changelog] - New function `*FleetsClient.NewListPager(*FleetsClientListOptions) *runtime.Pager[FleetsClientListResponse]`
info	[Changelog] - New function `PossibleFleetMemberProvisioningStateValues() []FleetMemberProvisioningState`
info	[Changelog] - New struct `AzureEntityResource`
info	[Changelog] - New struct `ErrorAdditionalInfo`
info	[Changelog] - New struct `ErrorDetail`
info	[Changelog] - New struct `ErrorResponse`
info	[Changelog] - New struct `Fleet`
info	[Changelog] - New struct `FleetCredentialResult`
info	[Changelog] - New struct `FleetCredentialResults`
info	[Changelog] - New struct `FleetHubProfile`
info	[Changelog] - New struct `FleetListResult`
info	[Changelog] - New struct `FleetMember`
info	[Changelog] - New struct `FleetMemberProperties`
info	[Changelog] - New struct `FleetMembersClient`
info	[Changelog] - New struct `FleetMembersClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `FleetMembersClientBeginDeleteOptions`
info	[Changelog] - New struct `FleetMembersClientCreateOrUpdateResponse`
info	[Changelog] - New struct `FleetMembersClientDeleteResponse`
info	[Changelog] - New struct `FleetMembersClientGetOptions`
info	[Changelog] - New struct `FleetMembersClientGetResponse`
info	[Changelog] - New struct `FleetMembersClientListByFleetOptions`
info	[Changelog] - New struct `FleetMembersClientListByFleetResponse`
info	[Changelog] - New struct `FleetMembersListResult`
info	[Changelog] - New struct `FleetPatch`
info	[Changelog] - New struct `FleetProperties`
info	[Changelog] - New struct `FleetsClient`
info	[Changelog] - New struct `FleetsClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `FleetsClientBeginDeleteOptions`
info	[Changelog] - New struct `FleetsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `FleetsClientDeleteResponse`
info	[Changelog] - New struct `FleetsClientGetOptions`
info	[Changelog] - New struct `FleetsClientGetResponse`
info	[Changelog] - New struct `FleetsClientListByResourceGroupOptions`
info	[Changelog] - New struct `FleetsClientListByResourceGroupResponse`
info	[Changelog] - New struct `FleetsClientListCredentialsOptions`
info	[Changelog] - New struct `FleetsClientListCredentialsResponse`
info	[Changelog] - New struct `FleetsClientListOptions`
info	[Changelog] - New struct `FleetsClientListResponse`
info	[Changelog] - New struct `FleetsClientUpdateOptions`
info	[Changelog] - New struct `FleetsClientUpdateResponse`
info	[Changelog] - New struct `ManagedClusterSecurityProfileNodeRestriction`
info	[Changelog] - New field `NodeRestriction` in struct `ManagedClusterSecurityProfile`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 106 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerservice        [View full logs]         [Preview SDK Changes]        Breaking Change Detected
            Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface FleetsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface FleetsDeleteOptionalParams
info	[Changelog]   - Added Interface FleetsGetOptionalParams
info	[Changelog]   - Added Interface FleetsListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface FleetsListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface FleetsListCredentialsOptionalParams
info	[Changelog]   - Added Interface FleetsListNextOptionalParams
info	[Changelog]   - Added Interface FleetsListOptionalParams
info	[Changelog]   - Added Interface FleetsUpdateOptionalParams
info	[Changelog]   - Added Interface ManagedClusterIngressProfile
info	[Changelog]   - Added Interface ManagedClusterIngressProfileWebAppRouting
info	[Changelog]   - Added Interface ManagedClusterOidcIssuerProfile
info	[Changelog]   - Added Interface ManagedClusterPropertiesForSnapshot
info	[Changelog]   - Added Interface ManagedClusterSecurityProfileDefender
info	[Changelog]   - Added Interface ManagedClusterSecurityProfileDefenderSecurityMonitoring
info	[Changelog]   - Added Interface ManagedClusterSecurityProfileNodeRestriction
info	[Changelog]   - Added Interface ManagedClusterSecurityProfileWorkloadIdentity
info	[Changelog]   - Added Interface ManagedClusterSnapshotListResult
info	[Changelog]   - Added Interface ManagedClusterSnapshotsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsDeleteOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsGetOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListNextOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsListOptionalParams
info	[Changelog]   - Added Interface ManagedClusterSnapshotsUpdateTagsOptionalParams
info	[Changelog]   - Added Interface ManagedClustersRotateServiceAccountSigningKeysOptionalParams
info	[Changelog]   - Added Interface ManagedClusterStorageProfileBlobCSIDriver
info	[Changelog]   - Added Interface ManagedClusterWorkloadAutoScalerProfile
info	[Changelog]   - Added Interface ManagedClusterWorkloadAutoScalerProfileKeda
info	[Changelog]   - Added Interface NetworkProfileForSnapshot
info	[Changelog]   - Added Interface TrustedAccessRole
info	[Changelog]   - Added Interface TrustedAccessRoleBindingListResult
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsDeleteOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsGetOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleBindingsListOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRoleListResult
info	[Changelog]   - Added Interface TrustedAccessRoleRule
info	[Changelog]   - Added Interface TrustedAccessRolesListNextOptionalParams
info	[Changelog]   - Added Interface TrustedAccessRolesListOptionalParams
info	[Changelog]   - Added Type Alias AzureEntityResource
info	[Changelog]   - Added Type Alias Fleet
info	[Changelog]   - Added Type Alias FleetMember
info	[Changelog]   - Added Type Alias FleetMemberProvisioningState
info	[Changelog]   - Added Type Alias FleetMembersCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FleetMembersGetResponse
info	[Changelog]   - Added Type Alias FleetMembersListByFleetNextResponse
info	[Changelog]   - Added Type Alias FleetMembersListByFleetResponse
info	[Changelog]   - Added Type Alias FleetProvisioningState
info	[Changelog]   - Added Type Alias FleetsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias FleetsGetResponse
info	[Changelog]   - Added Type Alias FleetsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias FleetsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias FleetsListCredentialsResponse
info	[Changelog]   - Added Type Alias FleetsListNextResponse
info	[Changelog]   - Added Type Alias FleetsListResponse
info	[Changelog]   - Added Type Alias FleetsUpdateResponse
info	[Changelog]   - Added Type Alias KeyVaultNetworkAccessTypes
info	[Changelog]   - Added Type Alias ManagedClusterSnapshot
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsGetResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListNextResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsListResponse
info	[Changelog]   - Added Type Alias ManagedClusterSnapshotsUpdateTagsResponse
info	[Changelog]   - Added Type Alias NetworkPluginMode
info	[Changelog]   - Added Type Alias TrustedAccessRoleBinding
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsGetResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRoleBindingsListResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListNextResponse
info	[Changelog]   - Added Type Alias TrustedAccessRolesListResponse
info	[Changelog]   - Interface AgentPoolsDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter networkPluginMode
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter capacityReservationGroupID
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter enableCustomCATrust
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter hostGroupID
info	[Changelog]   - Interface ManagedClusterAgentPoolProfileProperties has a new optional parameter messageOfTheDay
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter enableVnetIntegration
info	[Changelog]   - Interface ManagedClusterAPIServerAccessProfile has a new optional parameter subnetId
info	[Changelog]   - Interface ManagedClusterHttpProxyConfig has a new optional parameter effectiveNoProxy
info	[Changelog]   - Interface ManagedClustersDeleteOptionalParams has a new optional parameter ignorePodDisruptionBudget
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter azureKeyVaultKms
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter defender
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter nodeRestriction
info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter workloadIdentity
info	[Changelog]   - Interface ManagedClusterStorageProfile has a new optional parameter blobCSIDriver
info	[Changelog]   - Interface ManagedClusterStorageProfileDiskCSIDriver has a new optional parameter version
info	[Changelog]   - Class ContainerServiceClient has a new parameter fleetMembers
info	[Changelog]   - Class ContainerServiceClient has a new parameter fleets
info	[Changelog]   - Class ContainerServiceClient has a new parameter managedClusterSnapshots
info	[Changelog]   - Class ContainerServiceClient has a new parameter trustedAccessRoleBindings
info	[Changelog]   - Class ContainerServiceClient has a new parameter trustedAccessRoles
info	[Changelog]   - Type Alias AgentPool has a new parameter messageOfTheDay
info	[Changelog]   - Type Alias AgentPool has a new parameter enableCustomCATrust
info	[Changelog]   - Type Alias AgentPool has a new parameter capacityReservationGroupID
info	[Changelog]   - Type Alias AgentPool has a new parameter hostGroupID
info	[Changelog]   - Type Alias ManagedCluster has a new parameter creationData
info	[Changelog]   - Type Alias ManagedCluster has a new parameter oidcIssuerProfile
info	[Changelog]   - Type Alias ManagedCluster has a new parameter enableNamespaceResources
info	[Changelog]   - Type Alias ManagedCluster has a new parameter ingressProfile
info	[Changelog]   - Type Alias ManagedCluster has a new parameter workloadAutoScalerProfile
info	[Changelog]   - Added Enum KnownFleetMemberProvisioningState
info	[Changelog]   - Added Enum KnownFleetProvisioningState
info	[Changelog]   - Added Enum KnownKeyVaultNetworkAccessTypes
info	[Changelog]   - Added Enum KnownNetworkPluginMode
info	[Changelog]   - Added Enum KnownTrustedAccessRoleBindingProvisioningState
info	[Changelog]   - Enum KnownNetworkPlugin has a new value None
info	[Changelog]   - Enum KnownOssku has a new value Windows2019
info	[Changelog]   - Enum KnownOssku has a new value Windows2022
info	[Changelog]   - Enum KnownSnapshotType has a new value ManagedCluster
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ManagedClusterSecurityProfile no longer has parameter azureDefender
    ️❌ azure-sdk-for-net failed [Detail]   
  
    • ❌Failed [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/containerservice/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'ResourceIdentityType' and different values: SystemAssigned,UserAssigned,None vs. SystemAssigned
cmderr	[Autorest]    at AutoRest.Modeler.ObjectBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/ObjectBuilder.cs:line 150
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.ParentBuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 217
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 48
cmderr	[Autorest]    at AutoRest.Modeler.SchemaBuilder.BuildServiceType(String serviceTypeName, Boolean required) in /opt/vsts/work/1/s/src/SchemaBuilder.cs:line 133
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.BuildCompositeTypes() in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 348
cmderr	[Autorest]    at AutoRest.Modeler.SwaggerModeler.Build(ServiceDefinition serviceDefinition) in /opt/vsts/work/1/s/src/SwaggerModeler.cs:line 66
cmderr	[Autorest]    at AutoRest.Modeler.Program.<ProcessInternal>d2.MoveNext() in /opt/vsts/work/1/s/src/Program.cs:line 60
cmderr	[Autorest] --- End of stack trace from previous location where exception was thrown ---
cmderr	[Autorest]    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
cmderr	[Autorest]    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
cmderr	[Autorest]    at NewPlugin.<Process>d15.MoveNext()
cmderr	[Autorest] FATAL: csharp/imodeler1 - FAILED
cmderr	[Autorest] FATAL: Error: Plugin imodeler1 reported failure.
cmderr	[Autorest]   Error: Plugin imodeler1 reported failure.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed
    ️⚠️ azure-resource-manager-schemas warning [Detail]   
  
    • ⚠️Warning [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️containerservice        [View full logs]         [Preview Schema Changes]      
    ️❌ azure-powershell failed [Detail]   
  
    • ❌Failed [Logs] Generate from affd925c95fc12a580f40627ddeacca2b3d627a9. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.containerservice        [View full logs]         [Preview SDK Changes]      
    Posted by Swagger Pipeline | How to fix these errors?
          		
    
    
      

    
    


        
    

            

            
    
              
            
    
        
    
      
    

      
    
            
  
    
    
  
    
    

  
    
  
    


        
    

    


    



    


      
    
  
            
    
    
    
      
    
    
    
    

      

          @serbrech
serbrech




        changed the title
Ster/address comments fleet

sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview


      Jul 15, 2022

    
    
  
    


  
    
  
    
    
  
    

  
    
      
    
  This was referenced Jul 15, 2022

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Draft

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



      
    

    


    
  


  
    
      
   Closed

  
    

    



  
    

    

    


  
    
  
    
    
  
    

  
    
      
    
    @azure-sdk
azure-sdk



    mentioned this pull request
    
      Jul 15, 2022
    

    


    
  


  
    
      
   Closed

  
    

    




  
    

    




    

      
    
  
        
    
  
    
      
    
  FumingZhang
  
    
  
              
    
            
                  FumingZhang
  

            

            approved these changes


            
                
                  Jul 15, 2022
                
            
            
          
    

          
    


              
    View reviewed changes
  


          
    

    

    
          
    
  
  
  
                  
    
                        
    
  
    
    
    
        
    
    

  


      
          
  
      
            Copy link

  
    
              
    
    
  
    

  
    
      

  
  Member


      

  
    

  
    
    
    
      @FumingZhang

      
            FumingZhang
  

      

      

      left a comment




      
    
    

  
    

    
                    

                        
    
  
    
  
 
    
  
    

    
    Choose a reason for hiding this comment
    

    
    
      The reason will be displayed to describe this comment to others. Learn more.
    
    

    
    
      
      

    

  

    

  
    
    
      
    LGTM
    
    
    
      
  

    


                      
    
                    
  
    
    
  
    
    

  
    
  
    


    
                        
    
                      
                    
    


    

    

    
      
    
  
  
  
    

    

      
    

    



    

      
    
  
          
    
  
    
    
  
    
  
    


        @FumingZhang
  FumingZhang



        merged commit dc0d153
      into

      
  
    dev-containerservice-Microsoft.ContainerService-2022-06-02-preview
  


    Jul 15, 2022

  
    

    


    

  
    
  
  
    
  
          @FumingZhang
  FumingZhang


    
    deleted the
    
      
        ster/address-comments-fleet
    
    branch

    July 15, 2022 08:02    
    

    

    
  

    
  
    
  
  
    
    
  honghr 

      pushed a commit
      that referenced
      this pull request

    
      Jul 20, 2022
    
    
    
      

    
  
    
    
    
      

    
  
    
      
        @FumingZhang
      
        @serbrech
        
    
      
        @lht6
      
        @haitch
  
    

    


      
    
        
          Review request for Microsoft.ContainerService to add version 2022-06-…
        

          
            
          

      
    

      
    
          

    
    
    

  

    


      
    

      
    
      
    

      
      
    
        
          3b2a6bb
        
      
    
    
    
  
    
    
    
      
    …02-preview (#19653)

* Adds base for updating Microsoft.ContainerService from version preview/2022-05-02-preview to version 2022-06-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (#19422)

* Containerservice 2022 06 02 preview fleet (#19541)

* add fleets and fleet members resource types

* remove clusterLocation

* wording

* don't flatten  hubprofile

* extra comma

* fix patch example

* Fix violated rule R4041 for 2022-06-02-preview managedCluster swagger (#19582)

* remove useless directive

* fix R4041

* fix

* add node restriction to swagger (#19587)

* aks fleet list credentials api (#19559)

* add fleet list credential api

* tweaks

* fix example filename

* fix casing

* add resourceId on hubProfile

* drop the new field, keep it as internal field

* fix duplicate shema error

* different name for fleet credential results

* use xms-identifier on the array items

* prettier fi

Co-authored-by: Stephane Erbrech <[email protected]>

* sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview (#19783)

* address fleet comments

* add example for nadditional status code

* Add missing `x-ms-long-running-operation-options` for delete operations in fleet-related API (#19787)

* add final-state-via

* fix final state to location header

Co-authored-by: Stéphane Erbrech <[email protected]>
Co-authored-by: lht6 <[email protected]>
Co-authored-by: Haitao Chen <[email protected]>
    
    
    

    

    
    
  
    

    

  
  



    





  
  
    
    
    
      

      
    



    
    

    
    
      
    
              
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  

    

      
    
    
    
  
    


    
  
              

    


      
    
  
    
    
    
    
    
  
    
    Reviewers
  
    

    


        
    
          

  
      @FumingZhang
  
    FumingZhang



          
            
              
            
          
          FumingZhang approved these changes

        
    
      
    
          

  
      @palma21
  
    palma21


                Awaiting requested review from palma21


        
      
    
      
    
          

  
      @matthchr
  
    matthchr


                Awaiting requested review from matthchr


        
      
    

      
    


    


    
    
  
    

      
  
    
    Assignees
  
    


        

      
    
        

  
      @jianyexi
  
    jianyexi
    

      
    
    



    


      

    
  


  
    
    Labels
  
    


    
    
      

    CI-BreakingChange-JavaScript



    


    


      

  
    
    
    
        
    
    Projects
  
    

        
    

    

    None yet




      
    


      

    
  
    
    
  
    
    Milestone
  
    

      No milestone


    


    
      
          

    
  
    
    
      
    
        
    
    
    Development
  
    


          


    Successfully merging this pull request may close these issues.
    


  


            
  
    

    

        
          

    

  
      
    
  
    
    
    
      3 participants
    
    
    
    
        
          @serbrech 
        
          @FumingZhang 
        
          @jianyexi