Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Publish private branch 'jiyu/appconfig_1101' #19732

Merged

Conversation

jiayi11
Copy link
Contributor

@jiayi11 jiayi11 commented Jul 11, 2022

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. July/August
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. July
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@jiayi11
Copy link
Contributor Author

jiayi11 commented Jul 11, 2022

The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/5037

@openapi-workflow-bot
Copy link

Hi, @jiayi11 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 16 Errors, 24 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    appconfiguration.json 2022-03-01(44b4918) 2020-06-01(main)
    appconfiguration.json 2022-03-01(44b4918) 2021-10-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/ListKeys' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L365:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/RegenerateKey' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L417:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AppConfiguration/configurationStores/{configStoreName}/listKeyValue' removed or restructured?
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L507:5
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ListKeyValueParameters' removed or renamed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1420:3
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L861:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2143:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1365:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2143:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1365:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'key' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'label' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'value' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'contentType' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'eTag' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'lastModified' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'locked' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1791:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1193:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1381:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'tags' renamed or removed?
    New: common-types/resource-management/v2/types.json#L13:7
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L1381:7
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L49:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L49:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L98:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L98:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L143:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L143:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L198:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L198:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L248:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L245:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L304:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L301:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L356:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L350:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L502:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L496:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L543:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L588:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L595:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L640:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L657:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L702:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L708:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L753:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L751:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L796:13
    ⚠️ 1026 - TypeChanged The new version has a different type 'object' than the previous one ''.
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L803:13
    Old: Microsoft.AppConfiguration/stable/2020-06-01/appconfiguration.json#L848:13


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'enablePurgeProtection' renamed or removed?
    New: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1638:7
    Old: Microsoft.AppConfiguration/preview/2021-10-01-preview/appconfiguration.json#L1420:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2022-03-01-preview package-2022-03-01-preview(44b4918) default(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    R4037 - MissingTypeObject The schema 'ErrorDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2116
    R4037 - MissingTypeObject The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2150
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1902
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enablePurgeProtection
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1537
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: fillGapWithZero
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2026
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: purgeProtectionEnabled
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L2419
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L559
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L606
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L868
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'KeyValues_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L915
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameAvailable
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1191
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ConfigurationStores_CheckNameNotAvailable
    Location: Microsoft.AppConfiguration/preview/2022-03-01-preview/appconfiguration.json#L1191
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/44b49188f49c2bd9bc3d974845b97c8b66729bbe/specification/appconfiguration/resource-manager/readme.md#tag-package-2022-03-01-preview">appconfiguration/resource-manager/readme.md#package-2022-03-01-preview
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ UnkownSecurityScheme "readme":"appconfiguration/resource-manager/readme.md",
    "tag":"package-2022-03-01-preview",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 11, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armappconfiguration - Approved - 2.0.0
    +	Field `KeyValueParameters` of struct `KeyValuesClientCreateOrUpdateOptions` has been removed
    +	Function `*KeyValuesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *KeyValuesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, KeyValue, *KeyValuesClientCreateOrUpdateOptions)`
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-appconfiguration - 2.1.0
    ️✔️azure-sdk-for-go - armworkloads - Approved - 0.2.1
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0e1a982. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-appconfiguration [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0e1a982. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh]  @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-appconfiguration [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0e1a982. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armappconfiguration [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*KeyValuesClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, *KeyValuesClientCreateOrUpdateOptions)` to `(context.Context, string, string, string, KeyValue, *KeyValuesClientCreateOrUpdateOptions)`
      info	[Changelog] - Field `KeyValueParameters` of struct `KeyValuesClientCreateOrUpdateOptions` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 0e1a982. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️appconfiguration [View full logs]  [Release Schema Changes]
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 0e1a982. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.AppConfiguration [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @jiayi11, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @jiayi11, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi, @jiayi11 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @jiayi11 jiayi11 force-pushed the published/jiayi11/azure-rest-api-specs-pr/jiyu/appconfig_1101 branch from 37ebfd2 to 075abe3 Compare July 11, 2022 23:49
    @jiayi11
    Copy link
    Contributor Author

    jiayi11 commented Jul 12, 2022

    The breaking changes are approved as in the private pr: https://github.com/Azure/azure-rest-api-specs-pr/pull/5037

    @raych1 raych1 removed their assignment Jul 12, 2022
    @mentat9
    Copy link
    Member

    mentat9 commented Jul 12, 2022

    APIs moving from private repo. Original PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/5037.

    @mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 12, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 12, 2022
    @jiayi11
    Copy link
    Contributor Author

    jiayi11 commented Jul 18, 2022

    Hi @honghr, could you please take a look at the pr?

    @honghr
    Copy link
    Contributor

    honghr commented Jul 20, 2022

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 20, 2022
    @honghr honghr added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 20, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants