Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace - fix swagger #19663

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Marketplace - fix swagger #19663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30b0f63
SingleOperation - add id prop
saviesacov Jul 3, 2022
b13d0fd
fix approveAllItems & approveAllItemsModifiedAt
saviesacov Jul 4, 2022
4b490ae
fix examples
saviesacov Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ion/marketplace/resource-manager/Microsoft.Marketplace/stable/2022-03-01/Marketplace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1925,12 +1925,12 @@
"description": "Indicating whether all subscriptions are selected (=true) or not (=false).",
"type": "boolean"
},
"allItemsApproved": {
"approveAllItems": {
"description": "Indicating whether all items are approved for this collection (=true) or not (=false).",
"type": "boolean",
"readOnly": true
ArcturusZhang marked this conversation as resolved.
Show resolved Hide resolved
},
"allItemsApprovedModifiedAt": {
"approveAllItemsModifiedAt": {
"description": "Gets the modified date of all items approved.",
ArcturusZhang marked this conversation as resolved.
Show resolved Hide resolved
"format": "date-time",
"type": "string",
Expand Down Expand Up @@ -3230,6 +3230,10 @@
"description": "Microsoft.Marketplace REST API operation",
"type": "object",
"properties": {
"id": {
"description": "Operation ID",
"type": "string"
},
Comment on lines +3233 to +3236
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding this new property, but I did not see any examples are updated accordingly?
Could you please add at least one of the example to show what is the actual value of this "id'?

"name": {
"description": "Operation name: {provider}/{resource}/{operation}",
"type": "string"
Expand Down
4 changes: 2 additions & 2 deletions ...ce/resource-manager/Microsoft.Marketplace/stable/2022-03-01/examples/ApproveAllItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"collectionName": "Global",
"claim": "",
"allSubscriptions": false,
"allItemsApproved": true,
"allItemsApprovedModifiedAt": "2022-03-07T14:30:58.566Z",
"approveAllItems": true,
"approveAllItemsModifiedAt": "2022-03-07T14:30:58.566Z",
"subscriptionsList": [
"57a5024d-2b80-4434-a37a-445e74a032bb",
"c4b603f7-4449-4b98-8077-571e17a661c1"
Expand Down
4 changes: 2 additions & 2 deletions ...anager/Microsoft.Marketplace/stable/2022-03-01/examples/CreatePrivateStoreCollection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"collectionName": "Test Collection",
"claim": "",
"allSubscriptions": false,
"allItemsApproved": false,
"allItemsApprovedModifiedAt": null,
"approveAllItems": false,
"approveAllItemsModifiedAt": null,
"subscriptionsList": [
"b340914e-353d-453a-85fb-8f9b65b51f91",
"f2baa04d-5bfc-461b-b6d8-61b403c9ec48"
Expand Down
4 changes: 2 additions & 2 deletions ...urce-manager/Microsoft.Marketplace/stable/2022-03-01/examples/DisableApproveAllItems.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
"collectionName": "Global",
"claim": "",
"allSubscriptions": false,
"allItemsApproved": false,
"allItemsApprovedModifiedAt": "2022-03-07T14:30:58.566Z",
"approveAllItems": false,
"approveAllItemsModifiedAt": "2022-03-07T14:30:58.566Z",
"subscriptionsList": [
"57a5024d-2b80-4434-a37a-445e74a032bb",
"c4b603f7-4449-4b98-8077-571e17a661c1"
Expand Down
4 changes: 2 additions & 2 deletions ...e-manager/Microsoft.Marketplace/stable/2022-03-01/examples/GetPrivateStoreCollection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"collectionName": "Default Collection",
"claim": "",
"allSubscriptions": true,
"allItemsApproved": false,
"allItemsApprovedModifiedAt": null,
"approveAllItems": false,
"approveAllItemsModifiedAt": null,
"subscriptionsList": [],
"enabled": true,
"numberOfOffers": 1
Expand Down
8 changes: 4 additions & 4 deletions ...ager/Microsoft.Marketplace/stable/2022-03-01/examples/GetPrivateStoreCollectionsList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
"collectionName": "Default Collection",
"claim": "",
"allSubscriptions": true,
"allItemsApproved": false,
"allItemsApprovedModifiedAt": null,
"approveAllItems": false,
"approveAllItemsModifiedAt": null,
"subscriptionsList": [],
"enabled": true,
"numberOfOffers": 2
Expand All @@ -41,8 +41,8 @@
"collectionName": "Dev collection",
"claim": "",
"allSubscriptions": false,
"allItemsApproved": true,
"allItemsApprovedModifiedAt": "2022-04-25T07:53:01.9685921Z",
"approveAllItems": true,
"approveAllItemsModifiedAt": "2022-04-25T07:53:01.9685921Z",
"subscriptionsList": [
"7c927b63-59cf-4a0f-9d13-41e11f1ddf76"
],
Expand Down
4 changes: 3 additions & 1 deletion ...manager/Microsoft.Marketplace/stable/2022-03-01/examples/UpsertOfferWithMultiContext.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
"createdAt": "2022-03-05T13:55:33.351Z",
"modifiedAt": "2021-04-22T14:17:41.8520203Z",
"specificPlanIdsLimitation": [
"log4file"
"log4db",
"log4file",
"log4web"
],
"updateSuppressedDueIdempotence": true,
"iconFileUris": {
Expand Down