Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct integrationRuntime lint errors in Synapse #19638

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

yanjungao718
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @yanjungao718 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 30, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.9.6)] new version base version
    integrationRuntime.json 2021-05-01(8e9ea8a) 2021-05-01(main)
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v1.13.0) new version base version
    package-2021-05 package-2021-05(8e9ea8a) package-2021-05(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    R4037 - MissingTypeObject The schema 'ManagedIntegrationRuntimeOperationResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1997
    R4037 - MissingTypeObject The schema 'ManagedIntegrationRuntimeNode' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2040
    R4037 - MissingTypeObject The schema 'ManagedIntegrationRuntimeError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2076
    R4037 - MissingTypeObject The schema 'SelfHostedIntegrationRuntimeNode' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2293
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2870
    R4037 - MissingTypeObject The schema 'IntegrationRuntimeStatusResponse' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2929
    R4041 - XmsIdentifierValidation Missing identifier id in array item property
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1548
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2878
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2937
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L2958
    ⚠️ R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L780
    ⚠️ R2010 - LongRunningOperationsOptionsValidator A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1059
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'IntegrationRuntimes_ListOutboundNetworkDependenciesEndpoints' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1170
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationRuntimeNodeIpAddressModel'. Consider using the plural form of 'IntegrationRuntimeNodeIpAddress' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L275
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationRuntimeAuthKeysModel'. Consider using the plural form of 'IntegrationRuntimeAuthKeys' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L839
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationRuntimeAuthKeysModel'. Consider using the plural form of 'IntegrationRuntimeAuthKeys' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L901
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationRuntimeMonitoringDataModel'. Consider using the plural form of 'IntegrationRuntimeMonitoringData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L954
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'IntegrationRuntimeStatusModel'. Consider using the plural form of 'IntegrationRuntimeStatus' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1118
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'IntegrationRuntimes_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L25
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'IntegrationRuntimes_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L85
    ⚠️ R4009 - RequiredReadOnlySystemData The response of operation:'IntegrationRuntimes_Create' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L146
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Stop integration runtime
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1267
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Stop integration runtime
    Location: Microsoft.Synapse/stable/2021-05-01/integrationRuntime.json#L1320
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateEndpointConnectionForPrivateLinkHubBasic > properties > properties)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Autorest completed in 18.26s. 0 files generated."


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.0.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.1.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.2.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.3.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.4.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.5.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.6.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.7.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.8.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.9.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.10.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.11.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.12.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.13.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.14.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.15.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.16.suppress which is deprecated and will be removed in the future."
    ⚠️ DeprecatedConfig "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Using directive.17.suppress which is deprecated and will be removed in the future."
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OperationResource_Common > properties > status)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > OperationResource_Common > properties > error)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateLinkServiceProxyBase > properties > remotePrivateLinkServiceConnectionState)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateLinkServiceProxyBase > properties > remotePrivateEndpointConnection)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateEndpointConnectionForPrivateLinkHubBasic > properties > properties)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateEndpointConnectionBasic > properties > properties)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateEndpointConnectionProxyBase > properties > remotePrivateEndpoint)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    ⚠️ IgnoredPropertyNextToRef "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"Semantic violation: Sibling values alongside $ref will be ignored. See https://github.com/Azure/autorest/blob/main/docs/openapi/howto/$ref-siblings.md for allowed values (components > schemas > PrivateEndpointConnectionForPrivateLinkHubProxyBase > properties > remotePrivateEndpoint)\n keys: [ \u001b[32m'type'\u001b[39m ]"
    💬 "readme":"synapse/resource-manager/readme.md",
    "tag":"package-2021-05",
    "details":"AutoRest core version selected from configuration: ^3.2.0."
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 30, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armdatafactory - 2.0.0
    ️✔️azure-sdk-for-go - armsynapse - 0.5.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.7.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b5
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️🔄 azure-sdk-for-java inProgress [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 3278e89b361d68980a6ade53c746da9365f3aca3. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armdatafactory [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `LinkedServiceReference.Type` has been changed from `*LinkedServiceReferenceType` to `*Type`
      info	[Changelog] - Const `LinkedServiceReferenceTypeLinkedServiceReference` has been removed
      info	[Changelog] - Function `PossibleLinkedServiceReferenceTypeValues` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `TypeLinkedServiceReference`
      info	[Changelog] - New function `PossibleTypeValues() []Type`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 2 additive change(s).
    • ️✔️armsynapse [View full logs]  [Preview SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️🔄 azure-sdk-for-js inProgress [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️🔄 azure-powershell inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @yanjungao718, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @yanjungao718, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-pipeline-app
    Copy link

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄Breaking Change(Cross-Version) inProgress [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️🔄Avocado inProgress [Detail]
    ️🔄ApiReadinessCheck inProgress [Detail]
    ️🔄ModelValidation inProgress [Detail]
    ️🔄SemanticValidation inProgress [Detail]
    ️⌛PoliCheck pending [Detail]
    ️⌛SDK Track2 Validation pending [Detail]
    ️⌛PrettierCheck pending [Detail]
    ️⌛SpellCheck pending [Detail]
    ️🔄Lint(RPaaS) inProgress [Detail]
    ️🔄CadlValidation inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jul 1, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - armdatafactory - 2.0.0
    ️✔️azure-sdk-for-go - armsynapse - 0.5.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.7.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b5
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 652ea17. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Failure during batch task - {"tag":"$(tag)"} -- false.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 652ea17. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
      info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsListResult
      info	[Changelog]   - Added Interface DedicatedSQLminimalTlsSettingsPatchInfo
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
      info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
      info	[Changelog]   - Added Type Alias DedicatedSQLminimalTlsSettings
      info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
      info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
      info	[Changelog]   - Class SynapseManagementClient has a new parameter workspaceManagedSqlServerDedicatedSQLMinimalTlsSettings
      info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 652ea17. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 652ea17. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armsynapse [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 652ea17. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️synapse [View full logs
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 652ea17. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.synapse [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @yanjungao718 yanjungao718 changed the title correct integrationRuntime lint errors in ADF and Synapse correct integrationRuntime lint errors in Synapse Jul 1, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants