Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update billing.json #19444

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Update billing.json #19444

merged 1 commit into from
Jun 16, 2022

Conversation

janakiramachandran
Copy link
Contributor

@janakiramachandran janakiramachandran commented Jun 14, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @janakiramachandran Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R3015 - EnumMustHaveType Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6459
    R3015 - EnumMustHaveType Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6472
    R3015 - EnumMustHaveType Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6912
    R3015 - EnumMustHaveType Enum must define its type and 'object' type is not allowed due to Autorest refuse to parse it.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7135
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3538
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3710
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4673
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4807
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4889
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L4971
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L5102
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Billing/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3949
    R4037 - MissingTypeObject The schema 'CustomerListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L5609
    R4037 - MissingTypeObject The schema 'CustomerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L5643
    R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L5823
    R4037 - MissingTypeObject The schema 'RecipientTransferDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6041
    R4037 - MissingTypeObject The schema 'TransferDetailsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6059
    R4037 - MissingTypeObject The schema 'TransferProductRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6077
    R4037 - MissingTypeObject The schema 'BillingAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6269
    R4037 - MissingTypeObject The schema 'BillingAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6303
    R4037 - MissingTypeObject The schema 'BillingAccountUpdateRequest' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6391
    R4037 - MissingTypeObject The schema 'BillingPropertyProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6417
    R4037 - MissingTypeObject The schema 'Enrollment' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6521
    R4037 - MissingTypeObject The schema 'EnrollmentPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6571
    R4037 - MissingTypeObject The schema 'DepartmentListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6596
    R4037 - MissingTypeObject The schema 'DepartmentProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6630
    R4037 - MissingTypeObject The schema 'EnrollmentAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6654
    R4037 - MissingTypeObject The schema 'EnrollmentAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6688
    R4037 - MissingTypeObject The schema 'InstructionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6723
    R4037 - MissingTypeObject The schema 'BillingProfileListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L6741
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/billing/resource-manager/readme.md
    tag: specification/billing/resource-manager/readme.md#tag-package-2020-05
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 7 Errors, 0 Warnings failed [Detail]
    Rule Message
    INVALID_FORMAT Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7860:27
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionsListByCustomer.json#L43:33
    INVALID_FORMAT Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7860:27
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionsListByBillingAccount.json#L40:33
    INVALID_FORMAT Object didn't pass validation for format date-time: 2018-02-30T17:32:28Z
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7424:33
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionInvoicesList.json#L49:39
    INVALID_FORMAT Object didn't pass validation for format date-time: 2018-02-30T17:32:28Z
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7424:33
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionInvoice.json#L27:35
    INVALID_FORMAT Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7860:27
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionsListByBillingProfile.json#L41:33
    INVALID_FORMAT Object didn't pass validation for format uuid: 6b96d3f2-9008-4a9d-912f-6b96d3f2
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L7860:27
    ExampleUrl: preview/2019-10-01-preview/examples/BillingSubscriptionsListByInvoiceSection.json#L42:33
    XMS_EXAMPLE_NOTFOUND_ERROR x-ms-example not found in Operations_List.
    Url: Microsoft.Billing/preview/2019-10-01-preview/billing.json#L3950:14
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - armbilling - 0.5.1
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-billing - 6.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/billing/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-billing [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model Agreement has a new parameter billing_profile_info
      info	[Changelog]   - Model BillingProfileListResult has a new parameter total_count
      info	[Changelog]   - Model BillingSubscription has a new parameter suspension_reasons
      info	[Changelog]   - Model InvoiceListResult has a new parameter total_count
      info	[Changelog]   - Model InvoiceSection has a new parameter tags
      info	[Changelog]   - Model ProductsListResult has a new parameter total_count
      info	[Changelog]   - Model TransactionListResult has a new parameter total_count
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-billing [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armbilling [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh]  @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-billing [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface BillingProfileInfo
      info	[Changelog]   - Added Interface OperationsErrorDetails
      info	[Changelog]   - Added Interface OperationsErrorResponse
      info	[Changelog]   - Interface BillingProfileListResult has a new optional parameter totalCount
      info	[Changelog]   - Type Alias Agreement has a new parameter billingProfileInfo
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from bf10d88. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
    • ️✔️billing [View full logs
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from bf10d88. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Billing [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @janakiramachandran, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants