Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] Update readme.python.md #19136

Merged
merged 1 commit into from
May 19, 2022
Merged

[KeyVault] Update readme.python.md #19136

merged 1 commit into from
May 19, 2022

Conversation

BigCat20196
Copy link
Contributor

@BigCat20196 BigCat20196 requested a review from msyyc as a code owner May 19, 2022 06:32
@openapi-workflow-bot
Copy link

Hi, @BigCat20196 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 19, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armkeyvault - 1.1.0-beta.1
    ️✔️azure-sdk-for-go - keyvault/mgmt/2021-10-01/keyvault - v64.1.0
    ❌azure-sdk-for-go - keyvault/mgmt/2019-09-01/keyvault - v64.1.0
    +	Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
    ️✔️azure-sdk-for-go - keyvault/mgmt/2018-02-14/keyvault - v64.1.0
    ️✔️azure-sdk-for-go - keyvault/mgmt/2016-10-01/keyvault - v64.1.0
    ️✔️azure-sdk-for-go - keyvault/mgmt/2015-06-01/keyvault - v64.1.0
    ❌azure-sdk-for-go - preview/keyvault/mgmt/2020-04-01-preview/keyvault - v64.1.0
    +	Field `ActionRequired` of struct `PrivateLinkServiceConnectionState` has been removed
    ❌azure-sdk-for-python-track2 - track2_azure-mgmt-keyvault - 9.3.0
    +	Model Key no longer has parameter release_policy
+	Model Key no longer has parameter rotation_policy
+	Model KeyProperties no longer has parameter release_policy
+	Model KeyProperties no longer has parameter rotation_policy
    ️⚠️ azure-sdk-for-net-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
warn	No file changes detected after generation
warn	Skip detect changed packages
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-keyvault [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Key no longer has parameter release_policy
info	[Changelog]   - Model Key no longer has parameter rotation_policy
info	[Changelog]   - Model KeyProperties no longer has parameter release_policy
info	[Changelog]   - Model KeyProperties no longer has parameter rotation_policy
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-keyvault-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️keyvault/mgmt/2021-10-01/keyvault [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️keyvault/mgmt/2019-09-01/keyvault [View full logs] 
      Only show 20 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `VaultProvisioningStateRegisteringDNS`
info	[Changelog] - New const `VaultProvisioningStateSucceeded`
info	[Changelog] - New function `PossibleVaultProvisioningStateValues() []VaultProvisioningState`
info	[Changelog] - New struct `DimensionProperties`
info	[Changelog] - New struct `MetricSpecification`
info	[Changelog] - New field `PurgeProtectionEnabled` in struct `DeletedVaultProperties`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `ProvisioningState` in struct `VaultProperties`
info	[Changelog] - New field `HsmPoolResourceID` in struct `VaultProperties`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `IgnoreMissingVnetServiceEndpoint` in struct `VirtualNetworkRule`
info	[Changelog] - New field `MetricSpecifications` in struct `ServiceSpecification`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `ID` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
    • ️✔️keyvault/mgmt/2018-02-14/keyvault [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️keyvault/mgmt/2016-10-01/keyvault [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️keyvault/mgmt/2015-06-01/keyvault [View full logs]  
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/keyvault/mgmt/2020-04-01-preview/keyvault [View full logs] 
      Only show 20 items here, please refer to log for details.
      info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `VaultProvisioningStateSucceeded`
info	[Changelog] - New const `VaultProvisioningStateRegisteringDNS`
info	[Changelog] - New function `PossibleVaultProvisioningStateValues() []VaultProvisioningState`
info	[Changelog] - New struct `DimensionProperties`
info	[Changelog] - New struct `MetricSpecification`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `ID` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `Etag` in struct `PrivateEndpointConnectionItem`
info	[Changelog] - New field `IsDataAction` in struct `Operation`
info	[Changelog] - New field `ActionsRequired` in struct `PrivateLinkServiceConnectionState`
info	[Changelog] - New field `HsmPoolResourceID` in struct `VaultProperties`
info	[Changelog] - New field `ProvisioningState` in struct `VaultProperties`
info	[Changelog] - New field `IgnoreMissingVnetServiceEndpoint` in struct `VirtualNetworkRule`
info	[Changelog] - New field `PurgeProtectionEnabled` in struct `DeletedVaultProperties`
info	[Changelog] - New field `MetricSpecifications` in struct `ServiceSpecification`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 15 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armkeyvault [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `KeyPermissionsRotate`
info	[Changelog] - New const `KeyRotationPolicyActionTypeRotate`
info	[Changelog] - New const `KeyRotationPolicyActionTypeNotify`
info	[Changelog] - New const `JSONWebKeyOperationRelease`
info	[Changelog] - New const `KeyPermissionsGetrotationpolicy`
info	[Changelog] - New const `KeyPermissionsRelease`
info	[Changelog] - New const `KeyPermissionsSetrotationpolicy`
info	[Changelog] - New function `KeyReleasePolicy.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `RotationPolicy.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*KeyReleasePolicy.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `PossibleKeyRotationPolicyActionTypeValues() []KeyRotationPolicyActionType`
info	[Changelog] - New struct `Action`
info	[Changelog] - New struct `KeyReleasePolicy`
info	[Changelog] - New struct `KeyRotationPolicyAttributes`
info	[Changelog] - New struct `LifetimeAction`
info	[Changelog] - New struct `RotationPolicy`
info	[Changelog] - New struct `Trigger`
info	[Changelog] - New field `ReleasePolicy` in struct `KeyProperties`
info	[Changelog] - New field `RotationPolicy` in struct `KeyProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 24 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] WARN deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-keyvault [View full logs]  [Release SDK Changes] 
      info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface Action
info	[Changelog]   - Added Interface KeyReleasePolicy
info	[Changelog]   - Added Interface KeyRotationPolicyAttributes
info	[Changelog]   - Added Interface LifetimeAction
info	[Changelog]   - Added Interface RotationPolicy
info	[Changelog]   - Added Interface Trigger
info	[Changelog]   - Added Type Alias KeyRotationPolicyActionType
info	[Changelog]   - Interface KeyProperties has a new optional parameter releasePolicy
info	[Changelog]   - Interface KeyProperties has a new optional parameter rotationPolicy
info	[Changelog]   - Type Alias Key has a new parameter rotationPolicy
info	[Changelog]   - Type Alias Key has a new parameter releasePolicy
info	[Changelog]   - Enum KnownJsonWebKeyOperation has a new value Release
info	[Changelog]   - Enum KnownKeyPermissions has a new value Getrotationpolicy
info	[Changelog]   - Enum KnownKeyPermissions has a new value Release
info	[Changelog]   - Enum KnownKeyPermissions has a new value Rotate
info	[Changelog]   - Enum KnownKeyPermissions has a new value Setrotationpolicy
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ee8a0a6. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️keyvault [View full logs] 
    ️❌ azure-powershell failed [Detail]
    • ❌Failed [Logs]Release - Generate from ee8a0a6. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ❌Az.keyvault [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced May 19, 2022
    Closed
    Closed
    Closed
    This was referenced May 19, 2022
    Closed
    Closed
    Closed
    @msyyc msyyc merged commit ee8a0a6 into main May 19, 2022
    @msyyc msyyc deleted the BigCat20196-patch-4 branch May 19, 2022 06:50
    This was referenced May 19, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @msyyc msyyc msyyc approved these changes

    Assignees

    @lirenhe lirenhe

    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @BigCat20196 @msyyc @lirenhe