Azure Traffic Collector changes #18927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukulkarni1
requested review from
msyyc,
BigCat20196,
ArcturusZhang and
qiaozha
as code owners
|
Hi, @kukulkarni1 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'collectorPolicies' with immediate parent 'AzureTrafficCollector', must have a list by immediate parent operation. Location: Microsoft.NetworkFunction/preview/2021-09-01-preview/AzureTrafficCollector.json#L757 |
|
| The child tracked resource, 'collectorPolicies' with immediate parent 'AzureTrafficCollector', must have a list by immediate parent operation. Location: Microsoft.NetworkFunction/stable/2022-05-01/AzureTrafficCollector.json#L757 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.NetworkFunction/preview/2021-09-01-preview/AzureTrafficCollector.json#L942 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.NetworkFunction/stable/2022-05-01/AzureTrafficCollector.json#L942 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌PoliCheck: 0 Errors, 0 Warnings failed [Detail]
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
Hi, @kukulkarni1 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Swagger Generation Artifacts
|
|
Hi @kukulkarni1, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @msyyc, @BigCat20196, @ArcturusZhang, @qiaozha, could you help us understand the context of RequiredReadOnlySystemData and XmsIdentifierValidation? We are not sure if we need to include the systemData tags since we are using NFVRP. Is this a mandatory tag? Also what's the use case for XmsIdentifierValidation? Is this only needed for custom object array types, or is it needed for string and int arrays as well? |
|
Hi @kukulkarni1, python sdk has been generated successfully. |
|
Thanks @BigCat20196. Could you help us understand why "Swagger LintDiff" and " |
rkmanda
reviewed
May 12, 2022
...urce-manager/Microsoft.NetworkFunction/preview/2021-09-01-preview/AzureTrafficCollector.json
Show resolved
Hide resolved
rkmanda
reviewed
May 12, 2022
...urce-manager/Microsoft.NetworkFunction/preview/2021-09-01-preview/AzureTrafficCollector.json
Show resolved
Hide resolved
rkmanda
reviewed
May 12, 2022
...urce-manager/Microsoft.NetworkFunction/preview/2021-09-01-preview/AzureTrafficCollector.json
Outdated
Show resolved
Hide resolved
rkmanda
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
…rest-api-specs into AzureTrafficCollector
rkmanda
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Azure Traffic Collector changes * spell check and prettier fix * avocado, model validation fixes * lint fixes * lint fixes for array item id * undo arrayitem lint fixes * Update readme.md * Update readme.python.md * updated swagger * updated swagger * updated swagger * updated swagger * updated swagger Co-authored-by: Jiefeng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Approved PR for private repo: https://github.com/Azure/azure-rest-api-specs-pr/pull/4405
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.