Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase Microsoft.SQL in Main Branch #18428

Merged
merged 29 commits into from
Mar 29, 2022
Merged

Rebase Microsoft.SQL in Main Branch #18428

merged 29 commits into from
Mar 29, 2022

Conversation

ericshape
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

zhenglaizhang and others added 11 commits December 20, 2021 15:17
@zhenglaizhang
Adds base for updating Microsoft.Sql from version preview/2021-08-01-…
65d8d57 
…preview to version 2021-11-01-preview
@zhenglaizhang
Updates readme
e29afcf
@zhenglaizhang
Updates API version in new specs and examples
f3c6886
@zhenglaizhang
update sql default tag to composite-v5 (Azure#17143)
2b0d064
@msdogra
Updated Blob Auditing API Files (Azure#17355)
d78851a 
* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>
@srmarkov
Adding swagger for endpoint certificates (Azure#17156)
8d8d8c1 
* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request
@cohen-uriel-ms
Microsoft.Sql - adding Database and Server AdvancedThreatProtection A…
06be8b7 
…PIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files
@markonikolicmicrosoft @ericshape
Adding ManagedServerDnsAliases API endpoints (Azure#18008)
14236e9 
* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <[email protected]>
@cicovic-andrija-msft
Add 201 response example so SQL clients can work correctly (Azure#18121)
43bbc37
@imadan1996
Add examples for cross sub restore (Azure#18135)
a76c0b4
@ericshape
Release Microsoft.sql 2021 11 01 preview (Azure#18005)
d07d484 
* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret
@ericshape ericshape requested a review from raych1 March 28, 2022 07:51
@openapi-workflow-bot
Copy link

Hi, @ericshape Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️❌LintDiff: 190 Errors, 36 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 0 items are listed, please refer to log for more details.

    Rule Message


    The following errors/warnings exist before current PR submission:

    Only 0 items are listed, please refer to log for more details.

    Rule Message
    ️❌Avocado: 110 Errors, 1 Warnings failed [Detail]

    Only 0 items are listed, please refer to log for more details.

    Rule Message
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]

    Only 0 items are listed, please refer to log for more details.

    Rule Message
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
    ️❌SDK Track2 Validation: 1 Errors, 0 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:

    Only 0 items are listed, please refer to log for more details.

    Rule Message
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 28, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @ericshape ericshape changed the title Dev sql microsoft.sql 2021 11 01 preview Catch up with the Main Branch in dev sql 2021-11-01-preview Mar 28, 2022
    @openapi-workflow-bot
    Copy link

    Hi @ericshape, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Mar 28, 2022
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    Draft
    @ericshape ericshape requested a review from jamestao as a code owner March 29, 2022 05:39
    @ericshape ericshape changed the title Rebase with the Main Branch in dev sql 2021-11-01-preview Rebase and release Microsoft.SQL in Main Branch Mar 29, 2022
    @ericshape ericshape changed the base branch from main to dev-sql-Microsoft.Sql-2021-11-01-preview March 29, 2022 05:46
    @ericshape ericshape changed the title Rebase and release Microsoft.SQL in Main Branch Rebase Microsoft.SQL in Main Branch Mar 29, 2022
    This was referenced Mar 29, 2022
    Closed
    Closed
    Closed
    Closed
    @ericshape ericshape changed the base branch from dev-sql-Microsoft.Sql-2021-11-01-preview to main March 29, 2022 06:12
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Mar 29, 2022
    Closed
    @raych1 raych1 merged commit bbf6b22 into Azure:main Mar 29, 2022
    This was referenced Mar 29, 2022
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    visingl pushed a commit that referenced this pull request Mar 30, 2022
    @ericshape @zhenglaizhang
    @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996 @visingl
    Rebase Microsoft.SQL in Main Branch (#18428)
    c4f919c 
    * Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <[email protected]>

* Add 201 response example so SQL clients can work correctly (#18121)

* Add examples for cross sub restore (#18135)

* Release Microsoft.sql 2021 11 01 preview (#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (#17143)

* Updated Blob Auditing API Files (#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: msdogra <[email protected]>
Co-authored-by: Mukesh Dogra <[email protected]>
Co-authored-by: srmarkov <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: Marko Nikolic <[email protected]>
Co-authored-by: Andrija Cicovic <[email protected]>
Co-authored-by: Ishan Rajesh Madan <[email protected]>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022
    @ericshape @zhenglaizhang
    @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996 @FredericHeem
    Rebase Microsoft.SQL in Main Branch (Azure#18428)
    47a0dfe 
    * Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* Adding ManagedServerDnsAliases API endpoints (Azure#18008)

* change

* Update readme.md

* error 201

* Revert "Update readme.md"

This reverts commit ceff39a.

* Revert "error 201"

This reverts commit 759fa4f.

* Fixed bad reverts

Co-authored-by: Ji Wang <[email protected]>

* Add 201 response example so SQL clients can work correctly (Azure#18121)

* Add examples for cross sub restore (Azure#18135)

* Release Microsoft.sql 2021 11 01 preview (Azure#18005)

* update swagger files and example files

* update readme.md

* address the pipeline error.

* update the reference.

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

* Adds base for updating Microsoft.Sql from version preview/2021-08-01-preview to version 2021-11-01-preview

* Updates readme

* Updates API version in new specs and examples

* update sql default tag to composite-v5 (Azure#17143)

* Updated Blob Auditing API Files (Azure#17355)

* Updated Blob Auditing API Files

* Fixed new property name case

* fixing x-ms-enum lint warning

Co-authored-by: Mukesh Dogra <[email protected]>

* Adding swagger for endpoint certificates (Azure#17156)

* Adding swagger for endpoint certificates

* Fix the year

* Fix build error on the pull request

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs (Azure#17881)

* Microsoft.Sql - adding Database and Server AdvancedThreatProtection APIs

* Fix to Swagger ModelValidation failures

* Removing the 201 from Database Upsert operation since it is not a long running operation.

* Change the name of the API to AdvancedThreatProtectionSettings

* Fix to the renaming to AdvancedThreatProtectionSettings

* Remove old files

* update swagger files and example files

* update readme.md

* address the pipeline error.

* resolove the conflict

* address the pipeline error

* address x-ms-secret comments

* update error message

* revert the deleted legacy files; avoid breaking changes.

* remove example files and reference.

* remove secret

Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: msdogra <[email protected]>
Co-authored-by: Mukesh Dogra <[email protected]>
Co-authored-by: srmarkov <[email protected]>
Co-authored-by: Uriel Cohen <[email protected]>
Co-authored-by: Marko Nikolic <[email protected]>
Co-authored-by: Andrija Cicovic <[email protected]>
Co-authored-by: Ishan Rajesh Madan <[email protected]>
    @ericshape ericshape deleted the dev-sql-Microsoft.Sql-2021-11-01-preview branch May 31, 2022 23:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @raych1 raych1 raych1 approved these changes

    @jamestao jamestao Awaiting requested review from jamestao jamestao is a code owner

    Assignees

    @raych1 raych1

    Labels
    Approved-Avocado Approved-LintDiff Approved-ModelValidation CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript CI-FixRequiredOnFailure
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    10 participants
    @ericshape @raych1 @josefree @zhenglaizhang @msdogra @srmarkov @cohen-uriel-ms @markonikolicmicrosoft @cicovic-andrija-msft @imadan1996