Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-ms-arm-id-details extension to select resources #18318

Closed
wants to merge 13 commits into from

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented Mar 18, 2022

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify: Document ARM ID references for a few key services:
  2. When are you targeting to deploy the new service/feature to public regions? N/A
  3. When do you expect to publish the swagger? N/A
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

This adds some new x-ms-arm-id-details extensions to various RPs Swagger for fields that are ARM references. This is not comprehensive and may not cover all references in all Swaggers. The intent is to bootstrap some important references for some important resources. See Azure/autorest#4150 and the extension documentation. Where there were multiple Swaggers for a service all less than ~1yr old, I made the update for all of the Swaggers within the last year, not just the latest.

I will be working with @leni-msft on linter rules that will help improve the quality of this annotation across all service Swaggers, this is just a starting point.

This was referenced Jun 22, 2022
@jianyexi
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matthchr
Copy link
Member Author

matthchr commented Jul 26, 2022

This has been superseded by the PRs mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants