[Hub Generated] Review request for Microsoft.Marketplace to add version stable/2022-03-01

[saviesacov]

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No refresh required for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

• Removing API(s) in a stable version
• Removing properties in a stable version
• Removing API version(s) in a stable version
• Updating API in a stable or public preview version with Breaking Change Validation errors
• Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @saviesacov Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-workflow-bot]

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armmarketplace - 1.1.0

️❌ azure-sdk-for-net failed [Detail]

• ❌Failed [Logs]Release - Generate from 03a173e. SDK Automation 14.0.0

  warn	Skip initScript due to not configured
  command	sudo apt-get install -y dotnet-sdk-6.0
  command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/marketplace/resource-manager/readme.md
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] realpath(): Permission denied
  cmderr	[Autorest] No usable version of the libssl was found
  cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
  cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
  cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
  error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
  warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 03a173e. SDK Automation 14.0.0

  command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️armmarketplace [View full logs]  [Release SDK Changes]

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog] - New function `*PrivateStoreCollectionClient.ApproveAllItems(context.Context, string, string, *PrivateStoreCollectionClientApproveAllItemsOptions) (PrivateStoreCollectionClientApproveAllItemsResponse, error)`
  info	[Changelog] - New function `*PrivateStoreClient.AnyExistingOffersInTheCollections(context.Context, string, *PrivateStoreClientAnyExistingOffersInTheCollectionsOptions) (PrivateStoreClientAnyExistingOffersInTheCollectionsResponse, error)`
  info	[Changelog] - New function `*PrivateStoreCollectionClient.DisableApproveAllItems(context.Context, string, string, *PrivateStoreCollectionClientDisableApproveAllItemsOptions) (PrivateStoreCollectionClientDisableApproveAllItemsResponse, error)`
  info	[Changelog] - New function `*PrivateStoreCollectionOfferClient.UpsertOfferWithMultiContext(context.Context, string, string, string, *PrivateStoreCollectionOfferClientUpsertOfferWithMultiContextOptions) (PrivateStoreCollectionOfferClientUpsertOfferWithMultiContextResponse, error)`
  info	[Changelog] - New function `*PrivateStoreClient.QueryUserOffers(context.Context, string, *PrivateStoreClientQueryUserOffersOptions) (PrivateStoreClientQueryUserOffersResponse, error)`
  info	[Changelog] - New struct `AnyExistingOffersInTheCollectionsResponse`
  info	[Changelog] - New struct `ContextAndPlansDetails`
  info	[Changelog] - New struct `MultiContextAndPlansPayload`
  info	[Changelog] - New struct `MultiContextAndPlansProperties`
  info	[Changelog] - New struct `PrivateStoreClientAnyExistingOffersInTheCollectionsOptions`
  info	[Changelog] - New struct `PrivateStoreClientAnyExistingOffersInTheCollectionsResponse`
  info	[Changelog] - New struct `PrivateStoreClientQueryUserOffersOptions`
  info	[Changelog] - New struct `PrivateStoreClientQueryUserOffersResponse`
  info	[Changelog] - New struct `PrivateStoreCollectionClientApproveAllItemsOptions`
  info	[Changelog] - New struct `PrivateStoreCollectionClientApproveAllItemsResponse`
  info	[Changelog] - New struct `PrivateStoreCollectionClientDisableApproveAllItemsOptions`
  info	[Changelog] - New struct `PrivateStoreCollectionClientDisableApproveAllItemsResponse`
  info	[Changelog] - New struct `PrivateStoreCollectionOfferClientUpsertOfferWithMultiContextOptions`
  info	[Changelog] - New struct `PrivateStoreCollectionOfferClientUpsertOfferWithMultiContextResponse`
  info	[Changelog] - New struct `QueryUserOffersDetails`
  info	[Changelog] - New struct `QueryUserOffersProperties`
  info	[Changelog] - New field `SubscriptionIDs` in struct `QueryApprovedPlans`
  info	[Changelog] - New field `AllItemsApproved` in struct `CollectionProperties`
  info	[Changelog] - New field `AllItemsApprovedModifiedAt` in struct `CollectionProperties`
  info	[Changelog] - New field `Icon` in struct `AdminRequestApprovalProperties`
  info	[Changelog]
  info	[Changelog] Total 0 breaking change(s), 40 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from 03a173e. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh] WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️marketplace [View full logs]  [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from 03a173e. SDK Automation 14.0.0

  command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
  command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

• ️✔️Az.MarketplaceRpService [View full logs]  [Release SDK Changes]
  • Az.MarketplaceRpService.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

[saviesacov]

/azp run unifiedPipeline

[azure-pipelines]

No pipelines are associated with this pull request.

[saviesacov]

/azp run unifiedPipeline

[azure-pipelines]

No pipelines are associated with this pull request.

[openapi-workflow-bot]

Hi, @saviesacov your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

[mentat9]

@saviesacov - Set this PR to Open and send email to the current ARM API Review oncall when you are ready for ARM review.

[mentat9]

@saviesacov - ARM reviewers don't have permissions to approve or merge PRs: we only review your REST APIs for ARM consistency. Your PR is already signed off by ARM, so you will work with your PR's assignee (@jianyexi) to finish review.

[ghost]

Hi, @saviesacov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

[openapi-workflow-bot]

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

[saviesacov]

Hello @jianyexi, the new APIs of 2022-03-01 are deployed to production.
Would you please allow merging?

[jianyexi]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).