-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix violated rule R4037 for 2022-02-02-preview managedCluster swagger #18116
Conversation
Hi, @FumingZhang Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi @FumingZhang, Your PR has some issues. Please fix the CI sequentially by following the order of
|
da20685
to
d19eab5
Compare
Hi @weidongxu-microsoft, could you please help review and merge this PR? The PR aims to fix the "MissingTypeObject" issue. |
38acb70
into
Azure:dev-containerservice-Microsoft.ContainerService-2022-02-02-preview
…02-preview (#18150) * Adds base for updating Microsoft.ContainerService from version preview/2022-01-02-preview to version 2022-02-02-preview * Updates readme * Updates API version in new specs and examples * Add key management service profile of a managed cluster for version 2022-02-02-preview (#17955) * Add key management service profile of a managed cluster for version 2022-02-02-preview * add kmsProfile * update after api review * add more details in description * update for comments * add mc snapshot api (#17974) * add mc snapshot api * fix format * add mc snapshot type * define type for enums * add properties for example * Update readmes for the 2022-02-02-preview dev branch of container service (#17889) * update readme * remove useless -only tags * remove nested property in allOf for 2022-02-02-preview managedClusters (#18063) * Fix credential format typo in 0102 preview (#18117) * add missing type object (#18116) * Update several common definitions according to arm feedback for container service 2022-02-02-preview (#18206) * update definition of serveral parameters and system data * update definition of Resource and move property location to sub resources * add missing tags property for prev Resource * fix for compatibility * fix definition name Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Tongyao Si <[email protected]>
…02-preview (Azure#18150) * Adds base for updating Microsoft.ContainerService from version preview/2022-01-02-preview to version 2022-02-02-preview * Updates readme * Updates API version in new specs and examples * Add key management service profile of a managed cluster for version 2022-02-02-preview (Azure#17955) * Add key management service profile of a managed cluster for version 2022-02-02-preview * add kmsProfile * update after api review * add more details in description * update for comments * add mc snapshot api (Azure#17974) * add mc snapshot api * fix format * add mc snapshot type * define type for enums * add properties for example * Update readmes for the 2022-02-02-preview dev branch of container service (Azure#17889) * update readme * remove useless -only tags * remove nested property in allOf for 2022-02-02-preview managedClusters (Azure#18063) * Fix credential format typo in 0102 preview (Azure#18117) * add missing type object (Azure#18116) * Update several common definitions according to arm feedback for container service 2022-02-02-preview (Azure#18206) * update definition of serveral parameters and system data * update definition of Resource and move property location to sub resources * add missing tags property for prev Resource * fix for compatibility * fix definition name Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Qingqing <[email protected]> Co-authored-by: Tongyao Si <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Fix the violated rule R4037 (MissingTypeObject/SDKViolation) in preview/2022-02-02-preview managedCluster.
"type": "object"
.Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.