Add xms-ids for PowerBIPrivateLinks #17973

LinglingTong · 2022-02-23T23:26:03Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify

About this Change

APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-23T23:26:07Z

Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-02-23T23:26:08Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2020-06-01/powerbiprivatelinks.json compared with base:stable/2020-06-01/powerbiprivatelinks.json

️️✔️LintDiff succeeded [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- powerbiprivatelinks/resource-manager/readme.md tag:package-2020-06-01
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- powerbiprivatelinks/resource-manager/readme.md tag:package-2020-06-01

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R2018 - XmsEnumValidation	The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.PowerBI/stable/2020-06-01/powerbiprivatelinks.json#L1033

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

powerbiprivatelinks/resource-manager/readme.md#package-2020-06-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-23T23:26:08Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-02-23T23:26:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armpowerbiprivatelinks - 0.3.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-powerbiprivatelinks - first release

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from eda5eda. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.0 -> 8.6.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-powerbiprivatelinks [View full logs] [Release SDK Changes]
- azure-mgmt-powerbiprivatelinks-1.0.0b1.zip
- azure_mgmt_powerbiprivatelinks-1.0.0b1-py3-none-any.whl
```
info	[Changelog]   - Initial Release
```

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from eda5eda. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-powerbiprivatelinks [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from eda5eda. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpowerbiprivatelinks [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `map[string]interface{}` to `interface{}`
info	[Changelog] - Function `GroupConnectivityInformation.MarshalJSON` has been removed
info	[Changelog] - Function `PrivateLinkServiceProxy.MarshalJSON` has been removed
info	[Changelog] - Function `PrivateLinkServiceConnection.MarshalJSON` has been removed
info	[Changelog] - Struct `ErrorResponse` has been removed
info	[Changelog] - Struct `GroupConnectivityInformation` has been removed
info	[Changelog] - Struct `PrivateLinkConnectionDetail` has been removed
info	[Changelog] - Struct `PrivateLinkServiceConnection` has been removed
info	[Changelog] - Struct `PrivateLinkServiceProxy` has been removed
info	[Changelog] - Struct `RemotePrivateEndpointConnection` has been removed
info	[Changelog]
info	[Changelog] Total 16 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from eda5eda. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-powerbiprivatelinks [View full logs] [Release SDK Changes]
- azure-arm-powerbiprivatelinks-1.0.0.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from eda5eda. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️powerbiprivatelinks [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2022-03-13T16:02:23Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-03-13T16:43:37Z

@jianyexi there is only a couple lines of change in this PR. Could you help with reviewing the code and merging the changes? Thanks!

ghost · 2022-04-03T16:02:46Z

Hi, @LinglingTong. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

LinglingTong · 2022-04-04T02:42:54Z

@jianyexi there is only a couple lines of change in this PR. Could you help with reviewing the code and merging the changes? Thanks!

Ping @jianyexi, could you help to take a look? Thanks!

add xms-ids for PowerBIPrivateLinks

1633ae9

openapi-assignment-bot bot assigned raych1 Feb 23, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Feb 23, 2022

raych1 assigned jianyexi and unassigned raych1 Feb 24, 2022

ghost added the no-recent-activity label Mar 13, 2022

ghost removed the no-recent-activity label Mar 13, 2022

ghost added no-recent-activity and removed no-recent-activity labels Apr 3, 2022

jianyexi approved these changes Apr 5, 2022

View reviewed changes

jianyexi merged commit eda5eda into Azure:main Apr 5, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request May 16, 2022

add xms-ids for PowerBIPrivateLinks (Azure#17973)

7b386ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xms-ids for PowerBIPrivateLinks #17973

Add xms-ids for PowerBIPrivateLinks #17973

LinglingTong commented Feb 23, 2022

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

Breaking Changes Tracking

ghost commented Mar 13, 2022

LinglingTong commented Mar 13, 2022

ghost commented Apr 3, 2022

LinglingTong commented Apr 4, 2022

Add xms-ids for PowerBIPrivateLinks #17973

Add xms-ids for PowerBIPrivateLinks #17973

Conversation

LinglingTong commented Feb 23, 2022

Changelog

About this Change

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 • edited Loading

Swagger Validation Report

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

ghost commented Mar 13, 2022

LinglingTong commented Mar 13, 2022

ghost commented Apr 3, 2022

LinglingTong commented Apr 4, 2022

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading