Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EasyAuth configuration APIs for ContainerApp #17492

Merged
merged 10 commits into from
Feb 9, 2022

Conversation

erich-wang
Copy link
Member

@erich-wang erich-wang commented Jan 25, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @erich-wang Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'authConfigs' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-01-01-preview/EasyAuthConfigs.json#L235


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L792
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L290
    ⚠️ R2015 - ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.App/preview/2022-01-01-preview/CommonDefinitions.json#L1
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L19
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L66
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L118
    ⚠️ R2023 - SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L179
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ContainerAppsRevisionReplicas_ListReplicas' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L281
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'ManagedEnvironmentsStorages_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L19
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'CertificateModel'. Consider using the plural form of 'Certificate' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L369
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'CertificateModel'. Consider using the plural form of 'Certificate' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L421
    ⚠️ R2063 - OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'CertificateModel'. Consider using the plural form of 'Certificate' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironments.json#L481
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'sourcecontrols' with immediate parent 'ContainerApp', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-01-01-preview/SourceControls.json#L264
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'storages' with immediate parent 'ManagedEnvironment', must have a list by immediate parent operation.
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L281
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UserAssignedIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: common-types/resource-management/v3/managedidentity.json#L21
    ⚠️ R3017 - GuidUsage Guid used in model definition 'ManagedServiceIdentity' for property 'principalId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: common-types/resource-management/v3/managedidentity.json#L53
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: ready
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L554
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: started
    Location: Microsoft.App/preview/2022-01-01-preview/ContainerAppsRevisions.json#L558
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List environments storages by subscription
    Location: Microsoft.App/preview/2022-01-01-preview/ManagedEnvironmentsStorages.json#L225
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️🔄SDK Track2 Validation inProgress [Detail]
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 25, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armapp - 0.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-app - first release
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 5bd1cf5d987ef2d968bbcd96deeb4e3df3226554. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-app [View full logs]  [Preview SDK Changes]
      info	[Changelog]   - Initial Release
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 5bd1cf5d987ef2d968bbcd96deeb4e3df3226554. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2022-02-09 06:29:48 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-app"
      cmderr	[generate.py] 2022-02-09 06:29:48 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2022-02-09 06:29:48 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/app/azure-resourcemanager-app --java.namespace=com.azure.resourcemanager.app   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/app/resource-manager/readme.md
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [POM][Skip] pom already has module azure-resourcemanager-app
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2022-02-09 06:30:16 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-app [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG Got artifact_id: azure-resourcemanager-app
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG Got artifact: azure-resourcemanager-app-1.0.0-beta.1-sources.jar
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG Got artifact: azure-resourcemanager-app-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG Match jar package: azure-resourcemanager-app-1.0.0-beta.1.jar
      cmderr	[Inst] 2022-02-09 06:31:22 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17492/azure-sdk-for-java/azure-resourcemanager-app/azure-resourcemanager-app-1.0.0-beta.1.jar\" -o azure-resourcemanager-app-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-app -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-app-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 5bd1cf5d987ef2d968bbcd96deeb4e3df3226554. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armapp [View full logs]  [Preview SDK Changes]
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientDeletePoller`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientDeletePollerResponse`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientDeleteResponse`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientGetOptions`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientGetResponse`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientGetResult`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientListByContainerAppOptions`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientListByContainerAppPager`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientListByContainerAppResponse`
      info	[Changelog] - New struct `ContainerAppsSourceControlsClientListByContainerAppResult`
      info	[Changelog] - New struct `ContainerResources`
      info	[Changelog] - New struct `CustomDomain`
      info	[Changelog] - New struct `CustomHostnameAnalysisResult`
      info	[Changelog] - New struct `CustomHostnameAnalysisResultProperties`
      info	[Changelog] - New struct `CustomScaleRule`
      info	[Changelog] - New struct `Dapr`
      info	[Changelog] - New struct `DefaultErrorResponse`
      info	[Changelog] - New struct `DefaultErrorResponseError`
      info	[Changelog] - New struct `DefaultErrorResponseErrorDetailsItem`
      info	[Changelog] - New struct `EnvironmentVar`
      info	[Changelog] - New struct `Facebook`
      info	[Changelog] - New struct `GitHub`
      info	[Changelog] - New struct `GithubActionConfiguration`
      info	[Changelog] - New struct `GlobalValidation`
      info	[Changelog] - New struct `Google`
      info	[Changelog] - New struct `HTTPScaleRule`
      info	[Changelog] - New struct `HTTPSettings`
      info	[Changelog] - New struct `HTTPSettingsRoute`
      info	[Changelog] - New struct `IdentityProviders`
      info	[Changelog] - New struct `Ingress`
      info	[Changelog] - New struct `LegacyMicrosoftAccount`
      info	[Changelog] - New struct `LogAnalyticsConfiguration`
      info	[Changelog] - New struct `Login`
      info	[Changelog] - New struct `LoginRoute`
      info	[Changelog] - New struct `LoginScopes`
      info	[Changelog] - New struct `LogsConfiguration`
      info	[Changelog] - New struct `ManagedEnvironment`
      info	[Changelog] - New struct `ManagedEnvironmentPatch`
      info	[Changelog] - New struct `ManagedEnvironmentProperties`
      info	[Changelog] - New struct `ManagedEnvironmentStorage`
      info	[Changelog] - New struct `ManagedEnvironmentStorageProperties`
      info	[Changelog] - New struct `ManagedEnvironmentStoragesCollection`
      info	[Changelog] - New struct `ManagedEnvironmentsClient`
      info	[Changelog] - New struct `ManagedEnvironmentsClientBeginCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientBeginDeleteOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePoller`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdatePollerResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientCreateOrUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePoller`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeletePollerResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientDeleteResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientGetResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupPager`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListByResourceGroupResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionPager`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientListBySubscriptionResult`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsClientUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsCollection`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClient`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientCreateOrUpdateResult`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientDeleteResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientGetResult`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListOptions`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResponse`
      info	[Changelog] - New struct `ManagedEnvironmentsStoragesClientListResult`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `OperationDetail`
      info	[Changelog] - New struct `OperationDisplay`
      info	[Changelog] - New struct `OperationsClient`
      info	[Changelog] - New struct `OperationsClientListOptions`
      info	[Changelog] - New struct `OperationsClientListPager`
      info	[Changelog] - New struct `OperationsClientListResponse`
      info	[Changelog] - New struct `OperationsClientListResult`
      info	[Changelog] - New struct `ProxyResource`
      info	[Changelog] - New struct `QueueScaleRule`
      info	[Changelog] - New struct `Registration`
      info	[Changelog] - New struct `RegistryCredentials`
      info	[Changelog] - New struct `RegistryInfo`
      info	[Changelog] - New struct `Replica`
      info	[Changelog] - New struct `ReplicaCollection`
      info	[Changelog] - New struct `ReplicaContainer`
      info	[Changelog] - New struct `ReplicaProperties`
      info	[Changelog] - New struct `Resource`
      info	[Changelog] - New struct `Revision`
      info	[Changelog] - New struct `RevisionCollection`
      info	[Changelog] - New struct `RevisionProperties`
      info	[Changelog] - New struct `Scale`
      info	[Changelog] - New struct `ScaleRule`
      info	[Changelog] - New struct `ScaleRuleAuth`
      info	[Changelog] - New struct `Secret`
      info	[Changelog] - New struct `SecretsCollection`
      info	[Changelog] - New struct `SourceControl`
      info	[Changelog] - New struct `SourceControlCollection`
      info	[Changelog] - New struct `SourceControlProperties`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New struct `Template`
      info	[Changelog] - New struct `TrackedResource`
      info	[Changelog] - New struct `TrafficWeight`
      info	[Changelog] - New struct `Twitter`
      info	[Changelog] - New struct `TwitterRegistration`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New struct `VnetConfiguration`
      info	[Changelog] - New struct `Volume`
      info	[Changelog] - New struct `VolumeMount`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 729 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs] Generate from 5bd1cf5d987ef2d968bbcd96deeb4e3df3226554. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️track2_@azure/arm-app [View full logs]  [Preview SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 5bd1cf5d987ef2d968bbcd96deeb4e3df3226554. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @erich-wang, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @erich-wang erich-wang marked this pull request as ready for review January 25, 2022 14:32
    @openapi-workflow-bot
    Copy link

    Hi, @erich-wang your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2022
    @Juliehzl Juliehzl requested a review from ruslany January 27, 2022 11:19
    @mentat9 mentat9 added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2022
    @mentat9
    Copy link
    Member

    mentat9 commented Jan 29, 2022

    @erich-wang, I left some comments. Please add the WaitForARMFeedback or WaitForARMRevisit label when you are ready for revisit: that will notify the current oncall that your PR is ready for revisit.

    @erich-wang
    Copy link
    Member Author

    erich-wang commented Jan 30, 2022

    @mentat9 , thanks for the detail comments and explanation, I've addressed all the comments, please take another look.

    @annikel
    Copy link
    Contributor

    annikel commented Feb 2, 2022

    I can see that Azure Static Web Apps is not mentioned in the IdentityProviders. We will need to query and update this IndetityProvider.

    @erich-wang
    Copy link
    Member Author

    I can see that Azure Static Web Apps is not mentioned in the IdentityProviders. We will need to query and update this IndetityProvider.

    The Identity Provider for Static Web App will be covered in the near future.

    Copy link

    @raosuhas raosuhas left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @raosuhas raosuhas added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForReviewRevisit labels Feb 4, 2022
    @raosuhas
    Copy link

    raosuhas commented Feb 4, 2022

    for the enums consider if you want to rename. Cause the true false scheme you have choosen does not provide much flexibility. I do not want to block the PR on this comment though , if you want to fix it you can fix and check in.

    @raych1 raych1 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 8, 2022
    @ruslany ruslany removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 8, 2022
    @raych1 raych1 merged commit dc85b17 into Azure:Microsoft.App-2022-01-01-preview Feb 9, 2022
    akning-ms pushed a commit that referenced this pull request Feb 16, 2022
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * Adding new API version 2022-01-01-preview for the new service Microsoft.App (#17135)
    
    * Adding swagger and examples
    
    * Fix samples
    
    * Fix linting errors
    
    * fix errors
    
    * fix more errors
    
    * prettier fixes
    
    * Fix the VNET properties
    
    * fix the vnet props
    
    * Attempt to remove x-ms-identifiers
    
    * Add x-ms-identifiers back
    
    * Revert "Add x-ms-identifiers back"
    
    This reverts commit 44525ab.
    
    * Addsourcecontrolapis (#17287)
    
    * add sourcecontrol apis
    
    * remove space
    
    * prettier fix
    
    * typo
    
    * avocado fix
    
    * lint fix
    
    * add replicas apis (#17501)
    
    * Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (#17479)
    
    * Remove dapr components from the ContainerApp object
    
    * Fix example
    
    * add descriptions
    
    * fix
    
    * change the auto-rest parameters
    
    * Support volume mounts for containerApp (#17530)
    
    * add volume mounts
    
    * add identifier
    
    * refine volume definition
    
    * Fix samples (#17534)
    
    * Adding managed identity (#17569)
    
    * Adding managed identity
    
    * prettier fix.
    
    * Microsof.app 2022 01 01 preview/add custom domains (#17385)
    
    * add support for Custom domains and certificates
    
    * add Certificates
    
    * Ccertificate as child resource of Managed Env.
    
    * Support default custom domain
    
    * PUT/DELETE certificate are not long-running
    
    * Add Custom Domain Verification Id
    
    * domains for all revisions and adding examples
    
    * missing examples
    
    * one more missing example
    
    * Examples+missing paths
    
    * Adding missing envelope properties
    
    * Addressing PR comments
    
    * Removing AKV and Free cert related properties
    
    * Prettier and semantic validation fixes
    
    * Fixing semantic validations and examples
    
    * More fixes
    
    * Addressing more PR comments
    
    * Updating examples
    
    * fixing type
    
    * fixing types
    
    * Extra properties and responses
    
    * misplaced response
    
    * whitespace
    
    * fix security section
    
    * fixing ManageEnvironment securityDefinitions
    
    * add 204 delete response
    
    * Removing virtual IP and IP Based option
    
    * change modelAsString
    
    * Addressing ARM PR comments
    
    * Removing 404 response from example
    
    * renaming custom hostname analysis operation
    
    * mark certificate as tracked resource
    
    * fix sample
    
    * Use Certificate Id instead of Certificate name
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    
    * Add new properties for ContainerApp (#17483)
    
    * add ephemeral storage
    
    * add outbound ip
    
    * add listsecrets
    
    * fix CI
    
    * fix example
    
    * fix
    
    * add identifier
    
    * fix
    
    * add example
    
    * mars as secret
    
    * Add storages operation for managedEnvironment (#17545)
    
    * add storage
    
    * fix
    
    * fix typo
    
    * Add EasyAuth configuration APIs for ContainerApp (#17492)
    
    * Add Easy Auth Config related APIs for ContainerApp
    
    * Use common type ProxyResource
    
    * Update description
    
    * update per validation
    
    * typo fix
    
    * fix validation error
    
    * Update sample and description
    
    * Update because ARM prefer string than boolean
    
    * Add static web identity provider
    
    * Add container probes (#17535)
    
    * Add container probes
    
    * minor fix
    
    * Use execute instead of exec'd, add identifier
    
    * remove exec from preview
    
    * use integer instead of intorstring
    
    * Add `internal` property under VnetConfiguration for internalOnly environments (#17656)
    
    * Add internal property under VnetConfiguration for internalOnly environments
    
    * Update examples
    
    * Add Dapr Components collection APIs (#17552)
    
    * Add daprComponents
    
    * update readme
    
    * Fix linting errors
    
    * More lint fixes
    
    * prettier fixes
    
    * make dapr component a tracked resource
    
    * fix the patch
    
    * fix lint errors
    
    * Revert "fix lint errors"
    
    This reverts commit 045f1d9.
    
    * Revert "fix the patch"
    
    This reverts commit 1452110.
    
    * Revert "make dapr component a tracked resource"
    
    This reverts commit 239268e.
    
    * Fix linter issues
    
    * fix wrong fix
    
    * fix linter
    
    * fix the operationids (#17809)
    
    * correct resource name (#17846)
    
    * Add custom open id providers support (#17855)
    
    * Add custom open id providers support
    
    * Update description
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    Co-authored-by: Vini Soto <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: Sanchit Mehta <[email protected]>
    grizzlytheodore added a commit that referenced this pull request Feb 22, 2022
    * [CapacityRP] [S360] Fix R3007 Linter Error in Microsoft.Capacity (#17711)
    
    * change 200 response for PUT/PATCH
    
    * add integer type and remove extra fields to pass model check
    
    * add id, name, type to GET/PUT/PATCH 200 response
    
    * run prettier
    
    * change x-ms-long-running-operation-options
    
    * updated an error response for the rename API on v2020-09-01 (#17850)
    
    Co-authored-by: Ochi <[email protected]>
    
    * Microsoft.App version 2022-01-01-preview (#17820)
    
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * Adding new API version 2022-01-01-preview for the new service Microsoft.App (#17135)
    
    * Adding swagger and examples
    
    * Fix samples
    
    * Fix linting errors
    
    * fix errors
    
    * fix more errors
    
    * prettier fixes
    
    * Fix the VNET properties
    
    * fix the vnet props
    
    * Attempt to remove x-ms-identifiers
    
    * Add x-ms-identifiers back
    
    * Revert "Add x-ms-identifiers back"
    
    This reverts commit 44525ab.
    
    * Addsourcecontrolapis (#17287)
    
    * add sourcecontrol apis
    
    * remove space
    
    * prettier fix
    
    * typo
    
    * avocado fix
    
    * lint fix
    
    * add replicas apis (#17501)
    
    * Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (#17479)
    
    * Remove dapr components from the ContainerApp object
    
    * Fix example
    
    * add descriptions
    
    * fix
    
    * change the auto-rest parameters
    
    * Support volume mounts for containerApp (#17530)
    
    * add volume mounts
    
    * add identifier
    
    * refine volume definition
    
    * Fix samples (#17534)
    
    * Adding managed identity (#17569)
    
    * Adding managed identity
    
    * prettier fix.
    
    * Microsof.app 2022 01 01 preview/add custom domains (#17385)
    
    * add support for Custom domains and certificates
    
    * add Certificates
    
    * Ccertificate as child resource of Managed Env.
    
    * Support default custom domain
    
    * PUT/DELETE certificate are not long-running
    
    * Add Custom Domain Verification Id
    
    * domains for all revisions and adding examples
    
    * missing examples
    
    * one more missing example
    
    * Examples+missing paths
    
    * Adding missing envelope properties
    
    * Addressing PR comments
    
    * Removing AKV and Free cert related properties
    
    * Prettier and semantic validation fixes
    
    * Fixing semantic validations and examples
    
    * More fixes
    
    * Addressing more PR comments
    
    * Updating examples
    
    * fixing type
    
    * fixing types
    
    * Extra properties and responses
    
    * misplaced response
    
    * whitespace
    
    * fix security section
    
    * fixing ManageEnvironment securityDefinitions
    
    * add 204 delete response
    
    * Removing virtual IP and IP Based option
    
    * change modelAsString
    
    * Addressing ARM PR comments
    
    * Removing 404 response from example
    
    * renaming custom hostname analysis operation
    
    * mark certificate as tracked resource
    
    * fix sample
    
    * Use Certificate Id instead of Certificate name
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    
    * Add new properties for ContainerApp (#17483)
    
    * add ephemeral storage
    
    * add outbound ip
    
    * add listsecrets
    
    * fix CI
    
    * fix example
    
    * fix
    
    * add identifier
    
    * fix
    
    * add example
    
    * mars as secret
    
    * Add storages operation for managedEnvironment (#17545)
    
    * add storage
    
    * fix
    
    * fix typo
    
    * Add EasyAuth configuration APIs for ContainerApp (#17492)
    
    * Add Easy Auth Config related APIs for ContainerApp
    
    * Use common type ProxyResource
    
    * Update description
    
    * update per validation
    
    * typo fix
    
    * fix validation error
    
    * Update sample and description
    
    * Update because ARM prefer string than boolean
    
    * Add static web identity provider
    
    * Add container probes (#17535)
    
    * Add container probes
    
    * minor fix
    
    * Use execute instead of exec'd, add identifier
    
    * remove exec from preview
    
    * use integer instead of intorstring
    
    * Add `internal` property under VnetConfiguration for internalOnly environments (#17656)
    
    * Add internal property under VnetConfiguration for internalOnly environments
    
    * Update examples
    
    * Add Dapr Components collection APIs (#17552)
    
    * Add daprComponents
    
    * update readme
    
    * Fix linting errors
    
    * More lint fixes
    
    * prettier fixes
    
    * make dapr component a tracked resource
    
    * fix the patch
    
    * fix lint errors
    
    * Revert "fix lint errors"
    
    This reverts commit 045f1d9.
    
    * Revert "fix the patch"
    
    This reverts commit 1452110.
    
    * Revert "make dapr component a tracked resource"
    
    This reverts commit 239268e.
    
    * Fix linter issues
    
    * fix wrong fix
    
    * fix linter
    
    * fix the operationids (#17809)
    
    * correct resource name (#17846)
    
    * Add custom open id providers support (#17855)
    
    * Add custom open id providers support
    
    * Update description
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    Co-authored-by: Vini Soto <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: Sanchit Mehta <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.Security to add version preview/2021-07-01-preview (#17460)
    
    * .
    
    * .
    
    * Add x-ms-identifiers for dataprotection (#17817)
    
    * Adding supported clouds param (#17580)
    
    * Add x-ms-identifiers for datalake-analytics (#17756)
    
    * Fixed Storage File Copy Ignore Readonly (#17867)
    
    * Add aliases to 2021-04-30-preview swagger for Azure search (#17253)
    
    * Add aliases to 2021-04-30-preview swagger for Azure search
    
    * add example for aliases in GetServiceStats
    
    * prettier changes
    
    * fix examples to use aliasName
    
    * add discriminator to LexicalNormalizer to fix validation error
    
    * fix validation error because of duration string
    
    Co-authored-by: Robert Lee <[email protected]>
    
    * Manually moving DataCollectionRules from Private PR. (#17845)
    
    * Create readme.md
    
    * Create post_IngestUsingDataCollectionRule.json
    
    * Create DataCollectionRules.json
    
    * Use AuthConfig instead of EasyAuth for all public API/Document (#17885)
    
    * Initial commit for new version and new child resource type extended l… (#17681)
    
    * Initial commit for new version and new child resource type extended location
    
    New version: 2021-08-31-preview
    New child resource type: resource sync rule
    
    * Fix lint check errors and cross version breaking changes validation issues
    
    * Try to fix Cross-Version Breaking Changes
    
    * Revert changes to previous stable version
    
    * Remove "x-ms-identifiers" definition which will cause golang sdk generation error
    
    * Address review comments, revert unnecessary changes
    
    * Try fix breaking error
    
    * Revert changes which fix lint error but will cause cross version breaking changes
    
    * Fix lintdiff validation issue and also add back two updates for this version only
    
    * Update descriptions of properties of resource sync rules.
    
    * Update description of the resource sync rules API
    
    * Update description of resource sync rules selector property
    
    * Update description of matchExpressions
    
    * Update description of targetResourceGroup
    
    * Fix a required LintDiff check
    
    Adding "x-ms-identifiers": [] to matchExpressionsList
    
    * Add title to readme.typescript.md
    
    * Update specification/extendedlocation/resource-manager/readme.typescript.md
    
    * Revert cross version breacking changes
    
    Co-authored-by: Wei Dong <[email protected]>
    
    * [Go] Add batch tag 20220217 (#17886)
    
    * plural (#17876)
    
    * add property (#17878)
    
    * [CosmosDB][2021-11-15-preview]Add enableMaterializedViews property to DB Account API's (#17864)
    
    * Added enableMaterializedViews property for DB account CRUD API's
    
    * revert package-lock.json
    
    * revert package-lock
    
    * update examples with enableMaterializedViews property
    
    * updated example
    
    * trigger
    
    * trigger
    
    Co-authored-by: Yuchao Yan <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.SqlVirtualMachine to add version preview/2021-11-01-preview (#17252)
    
    * Adds base for updating Microsoft.SqlVirtualMachine from version preview/2017-03-01-preview to version 2021-11-01-preview
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add 2021-11-01 swagger
    
    * add missing files, spellcheck, add MAXDOP to custom-words
    
    * prettier check
    
    * fix model validation errors
    
    * fix swagger avocado failures, SDK azure-sdk-for-net failures due to DaysOfWeek
    
    * add system data to AvailabilityGroupListener, SqlVirtualMachineGroup, SqlVirtualMachine
    
    * update list operation for 2021-11-01
    
    * add ms-identifier to address lintdiff R4041
    
    * remove x-ms-identifiers property as it is not available yet on .net sdk
    
    * add SqlVirtualMachines_StartAssessment
    
    * update ResourceIdentity enum from IdentityTypeWithNone to IdentityType
    
    * update list operations json
    
    * prettier check
    
    * re-add ms-identifier to address lintdiff R4041
    
    * Add Swagger spec of MICROSOFT.DASHBOARD for Public Preview (#17667)
    
    * Add Swagger spec of MICROSOFT.DASHBOARD for Public Preview
    
    * Add sdk files
    
    * Use ErrorResponse from common-types
    
    * Update GrafanaResource to follow TrackedResources from common-types
    
    * Update specification/dashboard/resource-manager/readme.typescript.md
    
    Co-authored-by: Wei Dong <[email protected]>
    
    * Update specification/dashboard/resource-manager/readme.typescript.md
    
    Co-authored-by: Wei Dong <[email protected]>
    
    * Update specification/dashboard/resource-manager/readme.csharp.md
    
    Co-authored-by: Wei Dong <[email protected]>
    
    * Remove location from PATCH
    
    * Refer to OperationList from common types
    
    * Fix Swagger ModelValidation error
    
    * Remove GrafanaResourcePropertiesUpdateParameters
    
    * Update specification/dashboard/resource-manager/readme.md
    
    Co-authored-by: Wei Dong <[email protected]>
    
    * Update readme.python.md
    
    * Update specification/dashboard/resource-manager/readme.go.md
    
    * Update specification/dashboard/resource-manager/readme.md
    
    * Update readme.python.md
    
    * Update readme.md
    
    * Update specification/dashboard/resource-manager/readme.csharp.md
    
    Co-authored-by: Wei Dong <[email protected]>
    Co-authored-by: Jiefeng Chen <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    
    * Users/sharathm/putmodelapi (#17386)
    
    * Put Model api for Personalizer
    
    * Moved api to v1.1-preview.3 and renamed api from model to signedmodel
    
    * Change api to allowed downloading signed and unsigned models.
    
    * Updates to add new parameter for signed for Get model api
    
    * Renamed example file reference
    
    * Fixed errors in model validation.
    
    * Fixed errors from prettier check.
    
    * Changed examples to match the generated files.
    
    * Manual updates to address breaking change issues
    
    * Updated as per feedback from api review meeting
    
    * Added description for Ocp-Apim-Subscription-Key
    
    * Renamed Evaluation_Apply to Evaluations_Apply
    
    * Reverting back the renaming operation since it was done in error.
    
    * Add description for body parameter of model/put call
    
    Co-authored-by: Decision Service <[email protected]>
    
    * Adding xms identifiers for RPs (#17753)
    
    * Adding x-ms-identifiers for AD Hybrid Health Service
    
    * remove added properties
    
    * Adding xms-identifiers for AlertsManagement
    
    * revert changes related to files outside resource-manager
    
    * Adding xms-ids for ApiManagement
    
    * adding xms-ids for AzureData
    
    * Adding xms-ids for COnfidentialLedger
    
    * Adding xms ids for Confluent
    
    * Adding xms-ids for CostManagement
    
    * Adding xms ids for DataBox
    
    * Adding xms ids for DataBricks
    
    * fix typos
    
    * Corrections after rebasing
    
    * corrections after rebase
    
    * fixing invalid format errors
    
    * changing the format to uuid for all Ids
    
    * prettier fix
    
    * prettier fix 2
    
    * reverting package files to main
    
    * revert noisy prettifier changes
    
    * revert some format changes in adhybrid
    
    * reverting noisy changes
    
    * removing adhybrid and alerts management
    
    * remove azuredata
    
    * remove apimanagement files from this PR
    
    * fix examples (#17698)
    
    * Adding xms-ids for Compute (#17633)
    
    * Adding xms-ids for Compute
    
    * porting changes to a newer gallery version
    
    * S360 fix. (#17719)
    
    * Add x-ms-identifiers to servicelinker/resource-manager. (#17778)
    
    Co-authored-by: Steven Vukelich <[email protected]>
    
    * swagger correctness fix for INVALID RESPONSE CODE. (#17750)
    
    Co-authored-by: Priyankar Gupta <[email protected]>
    
    * [Confidential Ledger] Example fixes and Swagger changes to accommodate CLI / PowerShell generation (#17695)
    
    * add swagger generation code for azcli
    
    * fiddle with ordering because the cli-extension codegen did not seem to run
    
    * remove comment
    
    * update readme files as in latest docs
    
    * fix example for cli test case generation
    
    * spec fixes for codegen
    
    * update documentation
    
    * fix example
    
    * Update readme.python.md
    
    * Update readme.md
    
    Co-authored-by: Yuchao Yan <[email protected]>
    
    * added missing enum (#17828)
    
    * Update comment.yml (#17875)
    
    * Update pull_request_assignment.yml (#17901)
    
    * Mobile Network REST API Specification (#17730)
    
    * Mobile Network REST API Specification
    
    * Removed API versions 2020-06-01-preview and 2021-04-01-preview. Have only the API version 2022-01-01-preview in Public
    
    * Addressed Swagger Avocado and Swagger SpellCheck Errors
    
    * Addressed Parameters Order Errors
    
    * Merge azure-rest-api-specs-pr branch ssivathas/mobilenetwork-public-api into satravi/mobilenetwork-rest-api-specs
    
    * Removed Unreferenced JSON Files
    
    * Added support for Static IP Addressing to PMN
    
    * Addressed Swagger PrettierCheck Errors
    
    * Addressed Swagger ModelValidation Errors
    
    * change go config to track 2
    
    * Updated the API versions in SDK README files
    
    * Update readme.python.md
    
    * Update readme.md
    
    * Updated ActivationState to ConfigurationState
    
    * Addressed XmsIdentifierValidation Errors
    
    * Addressed DescriptionAndTitleMissing Errors
    
    * Generic name for N2 and N3 Interface attributes to support 4G Networks
    
    * Generic name for N6 Interface attribute to support 4G Networks
    
    * Generic name for N6 Interface attribute to support 4G Networks
    
    Co-authored-by: ArcturusZhang <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.DataProtection to add version stable/2022-01-01 (#17261)
    
    * Adds base for updating Microsoft.DataProtection from version stable/2021-07-01 to version 2022-01-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * stop protection changes
    
    * Composite configure protection and restore changes
    
    * Adding new routes and API for operationStatus
    
    * Changes to Azure-AsyncOperation in examples
    
    * Fixing swagger correctness issue
    
    * prettier fix
    
    * Fixing Lint Diff error
    
    * Updating example for list operations API
    
    * Composite configure protection changes
    
    * FIxing OAV error
    
    * Swagger validation fixes
    
    * Swagger validation fixes
    
    * Swagger validation fixes
    
    * Swagger validation fixes
    
    * Swagger validation fixes
    
    * PR feedback changes
    
    * PR feedback changes
    
    Co-authored-by: amchandn <[email protected]>
    Co-authored-by: Pratima Upadhyay <[email protected]>
    
    * [Hub Generated] Review request for Microsoft.SecurityInsights to add version preview/2021-10-01-preview (#17837)
    
    * extract MicrosoftSecurityProductName to enum
    
    * extract AlertRuleTemplateStatus to enum
    
    * define FusionAlertRuleTemplateProperties
    
    * add back nested properties
    
    * add flatten to mitre and fusion properties objects
    
    * change position of required
    
    * define MicrosoftSecurityIncidentCreationAlertRuleTemplateProperties
    
    * align required + add flatten
    
    * fix AlertSeverity ref
    
    * align type to avoid breaking change
    
    * add type for MicrosoftSecurityIncidentCreationAlertRuleTemplateProperties
    
    * Add x-ms-identifiers for WebApps (#17536)
    
    * Add x-ms-identifiers for WebApps
    
    * Run prettifier
    
    * Resolve PR review comment
    
    * add x-ms-enum for resourcehealth (#17425)
    
    * dnsresolver-add-typescript.md (#17873)
    
    * [Data Factory] Support rest-based connectors in Synapse (I) (#17922)
    
    * Enable excel in public swagger
    
    * update
    
    * rollback dataflow change
    
    * Support rest-based connectors in Synapse (I)
    
    Co-authored-by: zhanyu2014 <[email protected]>
    
    * Update PULL_REQUEST_TEMPLATE.md (#17928)
    
    * fix publicnetworkaccess for preview in sb (#17464)
    
    * Add publicnetworkaccess to preview (#17463)
    
    * add x-ms-enum to policyinsights (#17424)
    
    * add x-ms-enum to policyinsights
    
    * fix casing
    
    * resolve comments
    
    * resolve comments
    
    * resolve comment
    
    * align the parameters in all the polluted files
    
    * Revert "[Communication] Adding 2022-02-01 NetworkTraversal API version for General Availability (#16946)" (#17911)
    
    This reverts commit 1824478.
    
    * Autorest related fix to data-plane API of Azure Load Testing (#17705)
    
    * Add description to formData in loadtest data-plane API
    
    * Modify description for loadtest upload route in data-plane API
    
    Co-authored-by: sbudhi-msft <[email protected]>
    Co-authored-by: Ochirkhuyag <[email protected]>
    Co-authored-by: Ochi <[email protected]>
    Co-authored-by: Ruslan Yakushev <[email protected]>
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    Co-authored-by: Vini Soto <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: Sanchit Mehta <[email protected]>
    Co-authored-by: kerend <[email protected]>
    Co-authored-by: Yanming Tang <[email protected]>
    Co-authored-by: Or Avital <[email protected]>
    Co-authored-by: Sean McCullough <[email protected]>
    Co-authored-by: Robert Lee <[email protected]>
    Co-authored-by: Robert Lee <[email protected]>
    Co-authored-by: rajrame <[email protected]>
    Co-authored-by: Lei Li <[email protected]>
    Co-authored-by: Wei Dong <[email protected]>
    Co-authored-by: Jiahui Peng <[email protected]>
    Co-authored-by: Ajay Parulekar <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Co-authored-by: Rachel Kim <[email protected]>
    Co-authored-by: Jinghua Zhu <[email protected]>
    Co-authored-by: Jiefeng Chen <[email protected]>
    Co-authored-by: Sharath Malladi <[email protected]>
    Co-authored-by: Decision Service <[email protected]>
    Co-authored-by: agalerrotaru <[email protected]>
    Co-authored-by: Samir Solanki <[email protected]>
    Co-authored-by: vayada <[email protected]>
    Co-authored-by: Steven Vukelich <[email protected]>
    Co-authored-by: Steven Vukelich <[email protected]>
    Co-authored-by: priyankarking <[email protected]>
    Co-authored-by: Priyankar Gupta <[email protected]>
    Co-authored-by: Lyndon Shi <[email protected]>
    Co-authored-by: Jorge Cotillo <[email protected]>
    Co-authored-by: Ruoxuan Wang <[email protected]>
    Co-authored-by: satravi <[email protected]>
    Co-authored-by: ArcturusZhang <[email protected]>
    Co-authored-by: pratikjoshi14 <[email protected]>
    Co-authored-by: amchandn <[email protected]>
    Co-authored-by: Pratima Upadhyay <[email protected]>
    Co-authored-by: laithhisham <[email protected]>
    Co-authored-by: colawwj <[email protected]>
    Co-authored-by: yuzhangyi <[email protected]>
    Co-authored-by: zhanyu2014 <[email protected]>
    Co-authored-by: Petr Švihlík <[email protected]>
    Co-authored-by: apraovjr <[email protected]>
    Co-authored-by: Andrew Peacock <[email protected]>
    Co-authored-by: Harshan B <[email protected]>
    FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022
    * New Swagger Spec File
    
    * New Swagger Example Spec File
    
    * New Readme Config File
    
    * New Azure AZ Readme Config File
    
    * New Azure CLI Readme Config File
    
    * New Go Language Readme Config File
    
    * New Python Language Readme Config File
    
    * New Typescript Language Readme Config File
    
    * New C# Language Readme Config File
    
    * Adding new API version 2022-01-01-preview for the new service Microsoft.App (Azure#17135)
    
    * Adding swagger and examples
    
    * Fix samples
    
    * Fix linting errors
    
    * fix errors
    
    * fix more errors
    
    * prettier fixes
    
    * Fix the VNET properties
    
    * fix the vnet props
    
    * Attempt to remove x-ms-identifiers
    
    * Add x-ms-identifiers back
    
    * Revert "Add x-ms-identifiers back"
    
    This reverts commit 44525ab.
    
    * Addsourcecontrolapis (Azure#17287)
    
    * add sourcecontrol apis
    
    * remove space
    
    * prettier fix
    
    * typo
    
    * avocado fix
    
    * lint fix
    
    * add replicas apis (Azure#17501)
    
    * Remove Dapr components from ContainerApp spec. Not breaking because the version hasn't been released yet. (Azure#17479)
    
    * Remove dapr components from the ContainerApp object
    
    * Fix example
    
    * add descriptions
    
    * fix
    
    * change the auto-rest parameters
    
    * Support volume mounts for containerApp (Azure#17530)
    
    * add volume mounts
    
    * add identifier
    
    * refine volume definition
    
    * Fix samples (Azure#17534)
    
    * Adding managed identity (Azure#17569)
    
    * Adding managed identity
    
    * prettier fix.
    
    * Microsof.app 2022 01 01 preview/add custom domains (Azure#17385)
    
    * add support for Custom domains and certificates
    
    * add Certificates
    
    * Ccertificate as child resource of Managed Env.
    
    * Support default custom domain
    
    * PUT/DELETE certificate are not long-running
    
    * Add Custom Domain Verification Id
    
    * domains for all revisions and adding examples
    
    * missing examples
    
    * one more missing example
    
    * Examples+missing paths
    
    * Adding missing envelope properties
    
    * Addressing PR comments
    
    * Removing AKV and Free cert related properties
    
    * Prettier and semantic validation fixes
    
    * Fixing semantic validations and examples
    
    * More fixes
    
    * Addressing more PR comments
    
    * Updating examples
    
    * fixing type
    
    * fixing types
    
    * Extra properties and responses
    
    * misplaced response
    
    * whitespace
    
    * fix security section
    
    * fixing ManageEnvironment securityDefinitions
    
    * add 204 delete response
    
    * Removing virtual IP and IP Based option
    
    * change modelAsString
    
    * Addressing ARM PR comments
    
    * Removing 404 response from example
    
    * renaming custom hostname analysis operation
    
    * mark certificate as tracked resource
    
    * fix sample
    
    * Use Certificate Id instead of Certificate name
    
    Co-authored-by: Ruslan Yakushev 🚴 <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    
    * Add new properties for ContainerApp (Azure#17483)
    
    * add ephemeral storage
    
    * add outbound ip
    
    * add listsecrets
    
    * fix CI
    
    * fix example
    
    * fix
    
    * add identifier
    
    * fix
    
    * add example
    
    * mars as secret
    
    * Add storages operation for managedEnvironment (Azure#17545)
    
    * add storage
    
    * fix
    
    * fix typo
    
    * Add EasyAuth configuration APIs for ContainerApp (Azure#17492)
    
    * Add Easy Auth Config related APIs for ContainerApp
    
    * Use common type ProxyResource
    
    * Update description
    
    * update per validation
    
    * typo fix
    
    * fix validation error
    
    * Update sample and description
    
    * Update because ARM prefer string than boolean
    
    * Add static web identity provider
    
    * Add container probes (Azure#17535)
    
    * Add container probes
    
    * minor fix
    
    * Use execute instead of exec'd, add identifier
    
    * remove exec from preview
    
    * use integer instead of intorstring
    
    * Add `internal` property under VnetConfiguration for internalOnly environments (Azure#17656)
    
    * Add internal property under VnetConfiguration for internalOnly environments
    
    * Update examples
    
    * Add Dapr Components collection APIs (Azure#17552)
    
    * Add daprComponents
    
    * update readme
    
    * Fix linting errors
    
    * More lint fixes
    
    * prettier fixes
    
    * make dapr component a tracked resource
    
    * fix the patch
    
    * fix lint errors
    
    * Revert "fix lint errors"
    
    This reverts commit 045f1d9.
    
    * Revert "fix the patch"
    
    This reverts commit 1452110.
    
    * Revert "make dapr component a tracked resource"
    
    This reverts commit 239268e.
    
    * Fix linter issues
    
    * fix wrong fix
    
    * fix linter
    
    * fix the operationids (Azure#17809)
    
    * correct resource name (Azure#17846)
    
    * Add custom open id providers support (Azure#17855)
    
    * Add custom open id providers support
    
    * Update description
    
    Co-authored-by: Xingjian Wang <[email protected]>
    Co-authored-by: Zunli Hu <[email protected]>
    Co-authored-by: Vaclav Turecek <[email protected]>
    Co-authored-by: Vini Soto <[email protected]>
    Co-authored-by: vinisoto <[email protected]>
    Co-authored-by: erich-wang <[email protected]>
    Co-authored-by: Mike Vu <[email protected]>
    Co-authored-by: Sanchit Mehta <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants