-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger changes for setting minimalTlsVersion for workspace sql server post workspace creation #17476
Conversation
…ew and stable folders
Hi, @naresh-polu Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1192:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1321:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1192:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1321:5 |
️❌
LintDiff: 4 Errors, 3 Warnings failed [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.1 )
Rule | Message |
---|---|
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1193 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1268 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1193 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1268 |
'PUT' operation 'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1194 |
|
'PUT' operation 'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1194 |
|
'PUT' operation 'WorkspaceManagedSqlServerDedicatedSQLminimalTlsSettings_Update' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1194 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L81 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerExtendedBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L204 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerExtendedBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L260 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerSecurityAlertPolicy_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L383 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerSecurityAlertPolicy_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L439 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L562 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerVulnerabilityAssessments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L618 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerEncryptionProtector_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L802 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerEncryptionProtector_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L861 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerRecoverableSqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1141 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L25 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L81 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerExtendedBlobAuditingPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L204 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerExtendedBlobAuditingPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L260 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerSecurityAlertPolicy_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L383 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerSecurityAlertPolicy_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L439 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerVulnerabilityAssessments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L562 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerVulnerabilityAssessments_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L618 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerEncryptionProtector_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L802 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerEncryptionProtector_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L861 |
R4009 - RequiredReadOnlySystemData |
The response of operation:'WorkspaceManagedSqlServerRecoverableSqlPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1141 |
R4037 - MissingTypeObject |
The schema 'ServerUsage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1846 |
R4037 - MissingTypeObject |
The schema 'ServerUsageListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1889 |
R4037 - MissingTypeObject |
The schema 'ServerUsage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1850 |
R4037 - MissingTypeObject |
The schema 'ServerUsage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1850 |
R4037 - MissingTypeObject |
The schema 'ServerUsageListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1893 |
R4037 - MissingTypeObject |
The schema 'ServerUsageListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1893 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json#L1891 |
R4041 - XmsIdentifierValidation |
Missing identifier id in array item property Location: Microsoft.Synapse/stable/2021-06-01/sqlServer.json#L1895 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Thank you for your contribution naresh-polu! We will review the pull request and get back to you soon. |
Hi @naresh-polu, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
Hi, @naresh-polu your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
@naresh-polu, set this PR to Open and send email to the current ARM API Review oncall when you are ready for ARM review. |
Azure Pipelines successfully started running 1 pipeline(s). |
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json
Show resolved
Hide resolved
API itself is fine, breaking changes still need to be followed up on and changes will probably end up in a new API version |
...ication/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/sqlServer.json
Show resolved
Hide resolved
Hi, @naresh-polu. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
…r post workspace creation (Azure#17476) * Checking in the swagger related changes to dedicated sql minial tls settings support * Updated the ms-examples related to minimal tls settings in both preview and stable folders * Fixing the swagger validation errors * Fixing the swagger model validation errors * Updated ms-examples and swagger files after review * Updated swagger files to include additional property * Fixing the swagger prettier check * Fixing the swagger model validation errors * Updated the ms-examples related to patch and changes in swagger files * Updated the swagger files for fixing few of the code review comments * Updated the swagger files for fixing few of the code review comments * Updated the swagger files for fixing few of the code review comments * Updated the swagger files and ms-examples for fixing code review comments * Updated the swagger files for fixing code review comments * Updated the swagger files for fixing code review comments
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.