-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SubscriptionRP v2020-09-01 for s360 #17318
Conversation
Hi, @Ochirkhuyag Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L85 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L154 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L58 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L91 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L118 |
R4010 - RequiredDefaultResponse |
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L148 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Subscription/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L130 |
R4037 - MissingTypeObject |
The schema 'Location' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L163 |
R4037 - MissingTypeObject |
The schema 'LocationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L198 |
R4037 - MissingTypeObject |
The schema 'Subscription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L210 |
R4037 - MissingTypeObject |
The schema 'SubscriptionPolicies' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L254 |
R4037 - MissingTypeObject |
The schema 'SubscriptionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L283 |
R4037 - MissingTypeObject |
The schema 'TenantIdDescription' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L302 |
R4037 - MissingTypeObject |
The schema 'TenantListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2016-06-01/subscriptions.json#L317 |
R4037 - MissingTypeObject |
The schema 'CanceledSubscriptionId' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L349 |
R4037 - MissingTypeObject |
The schema 'RenamedSubscriptionId' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L359 |
R4037 - MissingTypeObject |
The schema 'EnabledSubscriptionId' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L369 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L389 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L413 |
R4037 - MissingTypeObject |
The schema 'PutAliasRequestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L445 |
R4037 - MissingTypeObject |
The schema 'PutAliasResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L478 |
R4037 - MissingTypeObject |
The schema 'PutAliasResponseProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L503 |
R4037 - MissingTypeObject |
The schema 'PutAliasListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L526 |
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L439 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L496 |
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Alias_Create' Request Model: 'PutAliasRequest' Response Model: 'PutAliasResponse' Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L164 |
|
Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L131 |
|
Based on the response model schema, operation 'Alias_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L283 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L24 |
|
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'SubscriptionModel'. Consider using the plural form of 'Subscription' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Subscription/stable/2020-09-01/subscriptions.json#L60 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/subscription/resource-manager/readme.md tag: specification/subscription/resource-manager/readme.md#tag-package-2021-10 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @Ochirkhuyag, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @Ochirkhuyag, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
NewApiVersionRequired reason: |
* Updated SubscriptionRP v2020-09-01 for s360 * Model validation errors are fixed Co-authored-by: Ochi <[email protected]>
* Updated SubscriptionRP v2020-09-01 for s360 * Model validation errors are fixed Co-authored-by: Ochi <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.