Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hub Generated] Review request for Microsoft.Authorization to add version preview/2021-11-16-preview #17200

Merged
merged 23 commits into from
Jan 20, 2022
Merged

[Hub Generated] Review request for Microsoft.Authorization to add version preview/2021-11-16-preview #17200

merged 23 commits into from
Jan 20, 2022

Conversation

leherpel
Copy link
Contributor

@leherpel leherpel commented Jan 2, 2022 •
edited
Loading

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @leherpel Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 2, 2022 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 1 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R4030 - UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: DeleteAccessReview
    Location: Microsoft.Authorization/preview/2021-11-16-preview/authorization-AccessReviewCalls.json#L427
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand] 
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand] 
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 2, 2022 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌SDK Breaking Change Tracking failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-python-track2 warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-js warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @leherpel, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Jan 2, 2022
    Closed
    Closed
    Closed
    Draft
    Closed
    @leherpel
    Copy link
    Contributor Author

    leherpel commented Jan 3, 2022

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-workflow-bot
    Copy link

    Hi @leherpel, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @leherpel leherpel marked this pull request as ready for review January 6, 2022 03:21
    @leherpel leherpel requested a review from stankovski as a code owner January 6, 2022 03:21
    @openapi-pipeline-app
    Copy link

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️⌛LintDiff pending [Detail]
    ️🔄Avocado inProgress [Detail]
    ️⌛~[Staging] ApiReadinessCheck pending [Detail]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛CredScan pending [Detail]
    ️⌛SDK Track2 Validation pending [Detail]
    ️⌛PrettierCheck pending [Detail]
    ️⌛SpellCheck pending [Detail]
    ️⌛Lint(RPaaS) pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @jorgecotillo jorgecotillo added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 18, 2022
    @ruowan ruowan merged commit 8579a6e into Azure:main Jan 20, 2022
    This was referenced Jan 20, 2022
    Closed
    Merged
    Closed
    Closed
    Closed
    Closed
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    @leherpel @mstrisoline
    [Hub Generated] Review request for Microsoft.Authorization to add ver…
    aad0fb3 
    …sion preview/2021-11-16-preview (Azure#17200)

* Adds base for updating Microsoft.Authorization from version preview/2021-07-01-preview to version 2021-11-16-preview

* Updates readme

* Updates API version in new specs and examples

* Adding access review history definition models and methods

* Semantic validation fixes

* Fix linting issues

* Uneeded pagable

* More linter fixes

* More linter issue fixes

* Ran prettier

* Ran prettier

* Lint and model validation fixes

* Adding nextlink

* Fix broken SDK

* Revert "Fix broken SDK"

This reverts commit 040d220.

* Make generating a downloadable uri a post instead of patch

* Making generateDownloadUri it's own api

* Adding delete history definition by Id

* Added post per instance and added body to Put

* Fixing validation errors

* downloadUri readonly and only returned by POST
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    @leherpel @LeiWang3
    [Hub Generated] Review request for Microsoft.Authorization to add ver…
    8e88144 
    …sion preview/2021-11-16-preview (Azure#17200)

* Adds base for updating Microsoft.Authorization from version preview/2021-07-01-preview to version 2021-11-16-preview

* Updates readme

* Updates API version in new specs and examples

* Adding access review history definition models and methods

* Semantic validation fixes

* Fix linting issues

* Uneeded pagable

* More linter fixes

* More linter issue fixes

* Ran prettier

* Ran prettier

* Lint and model validation fixes

* Adding nextlink

* Fix broken SDK

* Revert "Fix broken SDK"

This reverts commit 040d220.

* Make generating a downloadable uri a post instead of patch

* Making generateDownloadUri it's own api

* Adding delete history definition by Id

* Added post per instance and added body to Put

* Fixing validation errors

* downloadUri readonly and only returned by POST
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jorgecotillo jorgecotillo jorgecotillo left review comments

    @ruowan ruowan ruowan approved these changes

    @stankovski stankovski Awaiting requested review from stankovski stankovski is a code owner

    Assignees

    @ruowan ruowan

    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @leherpel @jorgecotillo @ruowan