Swagger Fixes for Container App, KubeEnvironments spec #16793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmehta
requested review from
00Kai0,
jsntcy,
msyyc,
naveedaz and
RAY-316
as code owners
|
Hi, @sanchitmehta Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response in the GET collection operation 'AppServicePlans_ListVnets' does not match the response definition in the individual GET operation 'AppServicePlans_GetVnetFromServerFarm' . Location: Microsoft.Web/stable/2021-03-01/AppServicePlans.json#L884 |
| Per the Noun_Verb convention for Operation Ids, the noun 'DeletedWebApps' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/DeletedWebApps.json#L106 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L281 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L334 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L954 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Diagnostics.json#L1014 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L102 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L405 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/Recommendations.json#L712 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L118 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L161 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L206 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L267 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L313 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L375 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L432 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L488 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L558 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L608 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L660 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L718 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L781 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L844 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L901 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L955 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1009 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1066 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1125 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1206 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'StaticSites' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-03-01/StaticSites.json#L1267 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-03-01/KubeEnvironments.json compared with base:stable/2021-02-01/KubeEnvironments.json
️🔄SDK Track2 Validation inProgress [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi @sanchitmehta, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 17, 2021
…hub.com/sanchitmehta/azure-rest-api-specs into user/sanmeht/containerapp-swagger-fixes
sanchitmehta
changed the title
|
@weidongxu-microsoft @naveedaz can you please take a look? |
weidongxu-microsoft
approved these changes
Nov 22, 2021
specification/web/resource-manager/Microsoft.Web/stable/2021-03-01/ContainerApps.json
Show resolved
Hide resolved
|
@weidongxu-microsoft, @naveedaz are you able to merge this PR? I don't have access to merge. |
weidongxu-microsoft
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <[email protected]> * Fix status codes for syncfunctiontriggers (#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (#15917) * ops Co-authored-by: Naveed Aziz <[email protected]> * User/jennylaw/containerapp (#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix #2 Co-authored-by: Jenny Lawrance <[email protected]> * Add long running extension for restart (#16791) * Remove unused API from ANT95 swagger (#16901) * Address PR comments (#17019) * Fixing PR comments (#17127) * Remove Certificate Hostname bindings API (#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <[email protected]> Co-authored-by: SatishRanjan <[email protected]> Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Connor McMahon <[email protected]> Co-authored-by: JennyLawrance <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* Adds base for updating Microsoft.Web from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * Introduce enterpriseGradeCdnStatus to StaticSites.json (Azure#16080) * Update StaticSites.json * Update StaticSites.json * Onedeploy API swapper spec (Azure#15985) * Onedeploy API swapper spec * Adding onedeploy custom keyword * Formatting onedeploy api indentation Formatting onedeploy api indentation * prettifier Co-authored-by: Calvin Chan <[email protected]> * Fix status codes for syncfunctiontriggers (Azure#16413) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web (Azure#16427) * Add GET endpoint at /config/authsettingsv2 for Microsoft.Web * Fix duplicate operation ids * Swagger for ASD Transfer out (Azure#16000) * Add domain transfer out to swagger * Prettifier * Add 202 response for webapp restart * Add certificate listHostnameBindingsOfCertificate * Formatting * Swagger for listHostnameBindings endpoint (Azure#16516) * Swagger for listHostnameBindings endpoint * Re-add Microsoft.CertificateRegistration and Microsoft.DomainRegistration APIs since they do not get pulled in by OpenApiHub (Azure#15917) * ops Co-authored-by: Naveed Aziz <[email protected]> * User/jennylaw/containerapp (Azure#16657) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Add custom hostname sites endpoint (Azure#16745) * Add custom hostname sites endpoint * Fix models * Swagger Fixes for Container App, KubeEnvironments spec (Azure#16793) * Pre-Prettier-commit * Adding missing file * Prettier fixes * Add missing definitions * Fix intendation in readme.md * add suppressions * Fix Kube Environments 2021-03-01 contract + add list secrets api to Container Apps Swagger * Fix sercret read property * Prettier fix * Model fix * Prettier Fix Azure#2 Co-authored-by: Jenny Lawrance <[email protected]> * Add long running extension for restart (Azure#16791) * Remove unused API from ANT95 swagger (Azure#16901) * Address PR comments (Azure#17019) * Fixing PR comments (Azure#17127) * Remove Certificate Hostname bindings API (Azure#17204) * Remove Certificate Hostname bindings API * Remove examples file as well Co-authored-by: mkarmark <[email protected]> Co-authored-by: SatishRanjan <[email protected]> Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Connor McMahon <[email protected]> Co-authored-by: JennyLawrance <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.