Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vm size properties for vm scale set #16723

Merged
merged 6 commits into from
Dec 16, 2021
Merged

Added vm size properties for vm scale set #16723

merged 6 commits into from
Dec 16, 2021

Conversation

raktdas
Copy link
Contributor

@raktdas raktdas commented Nov 9, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @raktdas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 9, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Nov 9, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    "vmSizeProperties": {
    "vCPUsAvailable": 1,
    "vCPUsPerCore": 1
    }

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We should add a separate example file for GetVirtualMachineWithVMSizeProperties as vmSizeProperties is optional and is not part of the basic VM api response unless the user created the VM with vmSizeProperties.

    },
    "proximityPlacementGroup": {
    "id": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/proximityPlacementGroups/my-ppg01"
    },

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    No need to add PPG references.

    @openapi-workflow-bot
    Copy link

    Hi @raktdas, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    @grizzlytheodore grizzlytheodore added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 3, 2021
    @grizzlytheodore
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @grizzlytheodore grizzlytheodore merged commit 8745de5 into Azure:feature/cplat-2021-11-01 Dec 16, 2021
    grizzlytheodore added a commit that referenced this pull request Jan 3, 2022
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    ArcturusZhang added a commit that referenced this pull request Jan 19, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (#16813)" (#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (#16544)
    
    * Downmerging change from Azure:main (#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041)
    
    * save (#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - #10190
    
    * add vmss filter to list  (#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (#16570)" (#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (#16813)" (#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (#16544)
    
    * Added CVM settings for version 2021-11-01 (#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (#17041)
    
    * save (#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - #10190
    
    * add vmss filter to list  (#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (#16590)" (#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    mstrisoline pushed a commit to mstrisoline/azure-rest-api-specs that referenced this pull request Feb 1, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Downmerging change from Azure:main (Azure#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * suppress bodyTopLevelProperties
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * add suppression for required properties
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Downmerging change from Azure:main (Azure#16654)
    
    Co-authored-by: Avinash Akka <[email protected]>
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * fix CI failures, and run prettier on added examples
    
    * for credscan. change password example
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * make new api call long-running-operation
    
    * compute folder with pre-population
    
    * fix examples folder
    
    * fix an example file
    
    * update compute to match last version
    
    * run prettier fix examples
    
    * change capitalization
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663)
    
    This reverts commit 70a8729.
    
    * sync with last version
    
    * add missing examples
    
    * Add VMSS filter to List VMs (Azure#16813)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956)
    
    This reverts commit 231fd22.
    
    * Remove impossible state from example (Azure#16544)
    
    * Added CVM settings for version 2021-11-01 (Azure#16622)
    
    * Added CVM settings
    
    * added examples
    
    * Add CMK examples
    
    * fixed typo
    
    * fixed file name
    
    * prettier check
    
    * removed a br
    
    * changed to VMDiskSecurityProfile
    
    * type as object
    
    * Added vm size properties for vm scale set (Azure#16723)
    
    * Added vm size properties
    
    * Added get examples
    
    * Added example for vm size properties
    
    * Added example for vm size properties
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)
    
    * KV changes
    
    * adding allowExtensionOperation
    
    * fixing examples
    
    * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535)
    
    * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539)
    
    * add creationTime to properties for VM, VMSS, CR, DH resources + remove
    required location for Resources
    
    * rename creationTime to timeCreated
    
    * examples for timeCreated
    
    * add minimum api-version to descriptions for timeCreated
    
    * add GetVirtualMachineScaleSet example
    
    * reformat example
    
    Co-authored-by: Chase Van Buskirk <[email protected]>
    
    * DedicatedHost Reboot Feature (Azure#16737)
    
    * added new feature to compute.json
    
    * added example for my feature
    
    * prettier check on the reboot example
    
    * fixed names of parameters in example file:
    
    * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are
    
    * added cloud error to the reboot
    
    * fixed default error, it was in the wrong spot
    
    * moved reboot to end of specs
    
    * moved older swagger files to 2021-11-01
    
    * reverted previous commit
    
    * renamed reboot to restart as per sameers comment
    
    * updated description as per sameers comment
    
    * updated api version to 2021-11-01 per sameers comment
    
    * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041)
    
    * save (Azure#17091)
    
    Co-authored-by: Theodore Chang <[email protected]>
    
    * Update compute.json (Azure#16482)
    
    When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update.
    
    More details about the issue can be found here - Azure#10190
    
    * add vmss filter to list  (Azure#16957)
    
    * change1 for change file
    
    * change description
    
    * change description
    
    Co-authored-by: LexieXie <[email protected]>
    
    * move Kashif's change to 2021-11-01
    
    * fix CI failures, and run prettier on added examples
    
    * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121)
    
    This reverts commit 220cfd0.
    
    * for credscan. change password example
    
    * make new api call long-running-operation
    
    * Update readme.python.md
    
    * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682)
    
    * RRP changes in swagger
    
    * Fix conflicts
    
    * fix validations
    
    * Fix instance view
    
    * change instance view
    
    * Fix example
    
    * Fix prettier
    
    * Fix and modify description
    
    * Review comments
    
    * update Repair action to enum and update readme
    
    * rebase to main since 2021-08-01 merged. update readme
    
    * update x-ms-enum name for RepairType
    
    * add default response to operations
    
    * update
    
    * put back 'required' tag for Resource.Location property
    and use a new object for VM_LIST return object
    
    * fix json format
    
    * update examples
    
    * run prettier on updated examples
    
    * update example for credScan
    
    * add VirtualMachineResource for toplevel property suppression.
    
    * lint diff errors
    
    * lint diff fix update
    
    * remove change for VMextensions.location bug
    
    * return readme file and examples before vm.vmextension.location change
    
    Co-authored-by: sukodava <[email protected]>
    Co-authored-by: Dapeng Zhang <[email protected]>
    Co-authored-by: xielexie <[email protected]>
    Co-authored-by: Mike Richmond <[email protected]>
    Co-authored-by: Avinash <[email protected]>
    Co-authored-by: Avinash Akka <[email protected]>
    Co-authored-by: ms-saypaul <[email protected]>
    Co-authored-by: Raktima Das <[email protected]>
    Co-authored-by: kamusta-msft <[email protected]>
    Co-authored-by: frank-pang-msft <[email protected]>
    Co-authored-by: Chase VanBuskirk <[email protected]>
    Co-authored-by: Chase Van Buskirk <[email protected]>
    Co-authored-by: vbhasker-msft <[email protected]>
    Co-authored-by: avjai <[email protected]>
    Co-authored-by: kangsun-ctrl <[email protected]>
    Co-authored-by: karthikka4820 <[email protected]>
    Co-authored-by: LexieXie <[email protected]>
    Co-authored-by: Yuchao Yan <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go Compute DoNotMerge <valid label in PR review process> use to hold merge after approval
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants