Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Media to add version preview/2021-11-01-preview #16312

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[Hub Generated] Review request for Microsoft.Media to add version preview/2021-11-01-preview #16312

merged 1 commit into from
Oct 8, 2021

Conversation

giakas
Copy link
Contributor

@giakas giakas commented Oct 8, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @giakas Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'disableVideoPreviewImage' renamed or removed?
    New: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L866:7
    Old: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L866:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1570:7
    Old: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1570:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1685:7
    Old: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1686:7
    ️⚠️LintDiff: 2 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'OperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1570
    ⚠️ R2007 - LongRunningOperationsWithLongRunningExtension The operation 'VideoAnalyzerOperationResults_Get' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1685


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L289
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L906
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VideoAnalyzers_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L937
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1200
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1295
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VideoAnalyzers_ListBySubscription' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L1786
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'edgeModules' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/EdgeModules.json#L75
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pipelineTopologies' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L896
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'livePipelines' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1108
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pipelineJobs' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1291
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'LivePipeline', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1323
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'PipelineJob', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/PipelineTopologies.json#L1344
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L103
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L20
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationStatuses' with immediate parent 'PrivateEndpointConnection', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L811
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'operationResults' with immediate parent 'PrivateEndpointConnection', must have a list by immediate parent operation.
    Location: common-types/resource-management/v3/privatelinks.json#L20
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'videos' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L412
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'accessPolicies' with immediate parent 'VideoAnalyzer', must have a list by immediate parent operation.
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L428
    ⚠️ R3017 - GuidUsage Guid used in model definition 'EdgeModuleProperties' for property 'edgeModuleId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/preview/2021-11-01-preview/EdgeModules.json#L32
    ⚠️ R3017 - GuidUsage Guid used in model definition 'UserAssignedManagedIdentity' for property 'clientId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L621
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: toBeExportedForShoebox
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L64
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enableRegionalMdmAccount
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L193
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.Media/preview/2021-11-01-preview/VideoAnalyzers.json#L293
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: common-types/resource-management/v3/types.json#L626
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: canStream
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L72
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: hasData
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L76
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isInUse
    Location: Microsoft.Media/preview/2021-11-01-preview/Videos.json#L80
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Oct 8, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-videoanalyzer - 1.0.0b2
    ️✔️azure-sdk-for-go - preview/videoanalyzer/mgmt/2021-05-01-preview/videoanalyzer - v58.0.0
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07d1718. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-videoanalyzer [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model VideoEntity has a new parameter content_urls
      info	[Changelog]   - Model VideoEntity has a new parameter archival
      info	[Changelog]   - Model ProxyResource has a new parameter system_data
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter public_network_access
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter private_endpoint_connections
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter network_access_control
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter provisioning_state
      info	[Changelog]   - Model VideoAnalyzerUpdate has a new parameter iot_hubs
      info	[Changelog]   - Model Resource has a new parameter system_data
      info	[Changelog]   - Model VideoAnalyzer has a new parameter public_network_access
      info	[Changelog]   - Model VideoAnalyzer has a new parameter private_endpoint_connections
      info	[Changelog]   - Model VideoAnalyzer has a new parameter network_access_control
      info	[Changelog]   - Model VideoAnalyzer has a new parameter provisioning_state
      info	[Changelog]   - Model VideoAnalyzer has a new parameter iot_hubs
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]   - Added operation VideosOperations.list_content_token
      info	[Changelog]   - Added operation VideoAnalyzersOperations.begin_create_or_update
      info	[Changelog]   - Added operation VideoAnalyzersOperations.begin_update
      info	[Changelog]   - Added operation group PipelineJobOperationStatusesOperations
      info	[Changelog]   - Added operation group LivePipelinesOperations
      info	[Changelog]   - Added operation group OperationStatusesOperations
      info	[Changelog]   - Added operation group LivePipelineOperationStatusesOperations
      info	[Changelog]   - Added operation group PipelineTopologiesOperations
      info	[Changelog]   - Added operation group PipelineJobsOperations
      info	[Changelog]   - Added operation group VideoAnalyzerOperationResultsOperations
      info	[Changelog]   - Added operation group PrivateLinkResourcesOperations
      info	[Changelog]   - Added operation group PrivateEndpointConnectionsOperations
      info	[Changelog]   - Added operation group VideoAnalyzerOperationStatusesOperations
      info	[Changelog]   - Added operation group OperationResultsOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter id of model StorageAccount is now required
      info	[Changelog]   - Operation EdgeModulesOperations.list has a new signature
      info	[Changelog]   - Operation EdgeModulesOperations.list has a new signature
      info	[Changelog]   - Model VideoFlags no longer has parameter is_recording
      info	[Changelog]   - Model VideoFlags has a new required parameter is_in_use
      info	[Changelog]   - Model VideoEntity no longer has parameter streaming
      info	[Changelog]   - Removed operation VideosOperations.list_streaming_token
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.sync_storage_keys
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.update
      info	[Changelog]   - Removed operation VideoAnalyzersOperations.create_or_update
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07d1718. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-08 03:07:44 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-videoanalyzer;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-08 03:07:44 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-08 03:07:44 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/videoanalyzer/azure-resourcemanager-videoanalyzer --java.namespace=com.azure.resourcemanager.videoanalyzer   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/videoanalyzer/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-videoanalyzer
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Skip] pom already has module azure-resourcemanager-videoanalyzer
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Skip] pom already has module sdk/videoanalyzer
      cmderr	[generate.py] 2021-10-08 03:08:19 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-videoanalyzer [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Got artifact_id: azure-resourcemanager-videoanalyzer
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Got artifact: azure-resourcemanager-videoanalyzer-1.0.0-beta.3-javadoc.jar
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Got artifact: azure-resourcemanager-videoanalyzer-1.0.0-beta.3-sources.jar
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Got artifact: azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG Match jar package: azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-08 03:10:03 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16312/azure-sdk-for-java/azure-resourcemanager-videoanalyzer/azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar\" -o azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-videoanalyzer -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-videoanalyzer-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 07d1718. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/videoanalyzer/mgmt/2021-05-01-preview/videoanalyzer [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 07d1718. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/videoanalyzer/resource-manager/readme.md
    • ️✔️@azure/arm-videoanalyzer [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/videoAnalyzer.js → ./dist/arm-videoanalyzer.js...
      cmderr	[npmPack] created ./dist/arm-videoanalyzer.js in 596ms
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 07d1718. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @giakas, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @akning-ms
    Copy link
    Contributor

    The PR is fixing some mistake which merged 7 days ago. as no any SDK released. so breaking change review is not required.

    @akning-ms akning-ms added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 8, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants