Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqlpoolcreatemodefix01 #16199

Merged
merged 6 commits into from
Oct 9, 2021
Merged

Sqlpoolcreatemodefix01 #16199

merged 6 commits into from
Oct 9, 2021

Conversation

sravan251
Copy link

@sravan251 sravan251 commented Sep 28, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @sravan251 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 28, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.

    ️🔄LintDiff inProgress [Detail]
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/synapse/resource-manager/readme.md
    tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Synapses label Sep 28, 2021
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 28, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - 2.1.0b1
    azure-sdk-for-go - synapse/mgmt/2021-03-01/synapse - v58.0.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - synapse/mgmt/2020-12-01/synapse - v58.0.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/v1.0/synapse - v58.0.0
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/2021-06-01-preview/synapse - v58.0.0
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    azure-sdk-for-go - preview/synapse/mgmt/2019-06-01-preview/synapse - v58.0.0
    +	Const `Default` type has been changed from `VulnerabilityAssessmentPolicyBaselineName` to `CreateMode`
    +	Const `Master` has been removed
    +	Field `HaveLibraryRequirementsChanged` of struct `BigDataPoolResourceProperties` has been removed
    +	Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f8aa8bc. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
    • ️✔️@azure/arm-synapse [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/synapseManagementClient.js → ./dist/arm-synapse.js...
      cmderr	[npmPack] created ./dist/arm-synapse.js in 1.5s
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f8aa8bc. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-10-09 02:09:45 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-synapse;1.0.0-beta.2;1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-09 02:09:45 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.3"
      cmderr	[generate.py] 2021-10-09 02:09:45 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/synapse/azure-resourcemanager-synapse --java.namespace=com.azure.resourcemanager.synapse   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/synapse/resource-manager/readme.md
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Skip] pom already has module azure-resourcemanager-synapse
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Skip] pom already has module sdk/synapse
      cmderr	[generate.py] 2021-10-09 02:10:59 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-synapse [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG Got artifact_id: azure-resourcemanager-synapse
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.3-javadoc.jar
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG Got artifact: azure-resourcemanager-synapse-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG Match jar package: azure-resourcemanager-synapse-1.0.0-beta.3.jar
      cmderr	[Inst] 2021-10-09 02:15:05 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/16199/azure-sdk-for-java/azure-resourcemanager-synapse/azure-resourcemanager-synapse-1.0.0-beta.3.jar\" -o azure-resourcemanager-synapse-1.0.0-beta.3.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-synapse -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-synapse-1.0.0-beta.3.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f8aa8bc. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-synapse [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation group KustoOperationsOperations
      info	[Changelog]   - Added operation group KustoPoolDataConnectionsOperations
      info	[Changelog]   - Added operation group KustoPoolDatabasesOperations
      info	[Changelog]   - Added operation group KustoPoolOperations
      info	[Changelog]   - Added operation group KustoPoolChildResourceOperations
      info	[Changelog]   - Added operation group KustoPoolDatabasePrincipalAssignmentsOperations
      info	[Changelog]   - Added operation group KustoPoolPrincipalAssignmentsOperations
      info	[Changelog]   - Added operation group KustoPoolsOperations
      info	[Changelog]   - Added operation group KustoPoolAttachedDatabaseConfigurationsOperations
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from f8aa8bc. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️synapse/mgmt/2021-03-01/synapse [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - Const `Master` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `Restore`
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedFPGA`
      info	[Changelog] - New const `Recovery`
      info	[Changelog] - New const `NodeSizeFamilyHardwareAcceleratedGPU`
      info	[Changelog] - New const `PointInTimeRestore`
      info	[Changelog] - New const `VulnerabilityAssessmentPolicyBaselineNameDefault`
      info	[Changelog] - New const `VulnerabilityAssessmentPolicyBaselineNameMaster`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsPreparer(context.Context, string, string, string) (*http.Request, error)`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsResponder(*http.Response) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 21 additive change(s).
      info	[Changelog]
    • ️✔️synapse/mgmt/2020-12-01/synapse [View full logsBreaking Change Detected
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New function `NewLibraryClient(string) LibraryClient`
      info	[Changelog] - New function `*LibraryResource.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `NewLibraryListResponseIterator(LibraryListResponsePage) LibraryListResponseIterator`
      info	[Changelog] - New function `LibraryListResponsePage.Values() []LibraryResource`
      info	[Changelog] - New function `*LibraryListResponsePage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpointsSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewLibraryListResponsePage(LibraryListResponse, func(context.Context, LibraryListResponse) (LibraryListResponse, error)) LibraryListResponsePage`
      info	[Changelog] - New function `LibraryListResponsePage.NotDone() bool`
      info	[Changelog] - New function `IntegrationRuntimesClient.ListOutboundNetworkDependenciesEndpoints(context.Context, string, string, string) (IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse, error)`
      info	[Changelog] - New function `LibraryListResponseIterator.Value() LibraryResource`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesCategoryEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpoint`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointDetails`
      info	[Changelog] - New struct `IntegrationRuntimeOutboundNetworkDependenciesEndpointsResponse`
      info	[Changelog] - New struct `LibrariesClient`
      info	[Changelog] - New struct `LibraryClient`
      info	[Changelog] - New struct `LibraryListResponse`
      info	[Changelog] - New struct `LibraryListResponseIterator`
      info	[Changelog] - New struct `LibraryListResponsePage`
      info	[Changelog] - New struct `LibraryResource`
      info	[Changelog] - New field `SubnetID` in struct `IntegrationRuntimeVNetProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 61 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/v1.0/synapse [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `CreateModeRecovery`
      info	[Changelog] - New const `CreateModeDefault`
      info	[Changelog] - New const `CreateModeRestore`
      info	[Changelog] - New const `CreateModePointInTimeRestore`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 5 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/2021-06-01-preview/synapse [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SQLPoolResourceProperties.CreateMode` has been changed from `*string` to `CreateMode`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `CreateModeRecovery`
      info	[Changelog] - New const `CreateModePointInTimeRestore`
      info	[Changelog] - New const `CreateModeRestore`
      info	[Changelog] - New const `CreateModeDefault`
      info	[Changelog] - New function `PossibleCreateModeValues() []CreateMode`
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/synapse/mgmt/2019-06-01-preview/synapse [View full logsBreaking Change Detected
      Only show 24 items here, please refer to log for details.
      info	[Changelog] - New struct `SQLPoolRecommendedSensitivityLabelsClient`
      info	[Changelog] - New struct `SensitivityLabelUpdate`
      info	[Changelog] - New struct `SensitivityLabelUpdateList`
      info	[Changelog] - New struct `SensitivityLabelUpdateProperties`
      info	[Changelog] - New field `LastSucceededTimestamp` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `CustomLibraries` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `CacheSize` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `DynamicExecutorAllocation` in struct `BigDataPoolResourceProperties`
      info	[Changelog] - New field `ManagedBy` in struct `SensitivityLabel`
      info	[Changelog] - New field `IsComputed` in struct `SQLPoolColumnProperties`
      info	[Changelog] - New field `ClientSecret` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `LastCommitID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `TenantID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `ClientID` in struct `WorkspaceRepositoryConfiguration`
      info	[Changelog] - New field `Cleanup` in struct `IntegrationRuntimeDataFlowProperties`
      info	[Changelog] - New field `SchemaName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `Rank` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `TableName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `ColumnName` in struct `SensitivityLabelProperties`
      info	[Changelog] - New field `ManagedVirtualNetwork` in struct `ManagedIntegrationRuntime`
      info	[Changelog] - New field `AdlaResourceID` in struct `WorkspaceProperties`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 128 additive change(s).
      info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from f8aa8bc. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️synapse [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @wonner
    Copy link
    Contributor

    wonner commented Sep 29, 2021

    @sravan251
    Copy link
    Author

    Better to add enum definition. https://github.com/stankovski/AutoRest/blob/master/Documentation/swagger-extensions.md#x-ms-enum

    Enum is code change on RP side and a breaking change to SDK.

    @wonner
    Copy link
    Contributor

    wonner commented Sep 30, 2021

    Better to add enum definition. https://github.com/stankovski/AutoRest/blob/master/Documentation/swagger-extensions.md#x-ms-enum

    Enum is code change on RP side and a breaking change to SDK.

    If you set "modelAsString": true, it will not be a breaking change.

    @sravan251
    Copy link
    Author

    Better to add enum definition. https://github.com/stankovski/AutoRest/blob/master/Documentation/swagger-extensions.md#x-ms-enum

    Enum is code change on RP side and a breaking change to SDK.

    If you set "modelAsString": true, it will not be a breaking change.

    Fixed

    jovannikolov-msft pushed a commit to jovannikolov-msft/azure-rest-api-specs that referenced this pull request Dec 1, 2021
    * Added correct description for sqlpool createMode description
    
    * Added correct description for sqlpool createMode description
    
    * Added correct description for sqlpool createMode description
    
    * Modified  createMode as Enum and modelAsString
    
    * prettier fix
    
    Co-authored-by: Sravan Thupili <[email protected]>
    LeiWang3 pushed a commit to LeiWang3/azure-rest-api-specs that referenced this pull request Mar 31, 2022
    * Added correct description for sqlpool createMode description
    
    * Added correct description for sqlpool createMode description
    
    * Added correct description for sqlpool createMode description
    
    * Modified  createMode as Enum and modelAsString
    
    * prettier fix
    
    Co-authored-by: Sravan Thupili <[email protected]>
    @JackTn JackTn deleted the sqlpoolcreatemodefix01 branch June 16, 2022 00:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    5 participants