Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge]Dev/srmarkov/server trust certificatesv2 #15883

Conversation

srmarkov
Copy link
Member

@srmarkov srmarkov commented Sep 1, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    The deployment is targeting the end of 2021
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    The swagger should be published with the 2021-05-01 version
  4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@srmarkov srmarkov requested a review from bcham as a code owner September 1, 2021 11:50
@openapi-workflow-bot
Copy link

Hi, @srmarkov Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R2020 - RequiredPropertiesMissingInResourceModel Model definition 'FirewallRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
    Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L308
    R2020 - RequiredPropertiesMissingInResourceModel Model definition 'ProxyResourceWithWritableName' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly.
    Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L298
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseVulnerabilityAssessmentRuleBaselines.json#L252
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseVulnerabilityAssessments.json#L198
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionBackups.json#L269
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionBackups.json#L769
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionManagedInstanceBackups.json#L121
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionManagedInstanceBackups.json#L467
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseSensitivityLabels.json#L256
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessmentRuleBaselines.json#L264
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessments.json#L207
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstanceAdministrators.json#L217
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstanceVulnerabilityAssessments.json#L189
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/RestorePoints.json#L207
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/SensitivityLabels.json#L611
    R4011 - DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
    Location: Microsoft.Sql/preview/2021-05-01-preview/ServerVulnerabilityAssessments.json#L189
    R4015 - NestedResourcesMustHaveListOperation The nested resource 'DatabaseVulnerabilityAssessmentRuleBaseline' does not have list operation, please add it.
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessmentRuleBaselines.json#L313
    R4015 - NestedResourcesMustHaveListOperation The nested resource 'ManagedInstanceQuery' does not have list operation, please add it.
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseQueries.json#L165
    R4015 - NestedResourcesMustHaveListOperation The nested resource 'ManagedDatabaseRestoreDetailsResult' does not have list operation, please add it.
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseRestoreDetails.json#L140
    R4018 - OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.Sql/operations' does not match the ARM specification. Please standardize the schema.
    Location: Microsoft.Sql/preview/2021-05-01-preview/Operations.json#L19
    R4019 - GetCollectionResponseSchema The response in the GET collection operation 'DatabaseAdvisors_ListByDatabase' does not match the response definition in the individual GET operation 'DatabaseAdvisors_Get' .
    Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseAdvisors.json#L19
    R4019 - GetCollectionResponseSchema The response in the GET collection operation 'ServerAdvisors_ListByServer' does not match the response definition in the individual GET operation 'ServerAdvisors_Get' .
    Location: Microsoft.Sql/preview/2021-05-01-preview/ServerAdvisors.json#L19
    R4019 - GetCollectionResponseSchema The response in the GET collection operation 'DatabaseRecommendedActions_ListByDatabaseAdvisor' does not match the response definition in the individual GET operation 'DatabaseRecommendedActions_Get' .
    Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseRecommendedActions.json#L19
    R4035 - PrivateEndpointResourceSchemaValidation The private endpoint model 'ManagedInstancePrivateLinkListResult' schema does not conform to the common type definition.
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstancePrivateLinkResources.json#L109
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ManagedInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstances.json#L381
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'FirewallRules_Replace' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L217
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstancePrivateLinkResources.json#L156
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstances.json#L863
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Sql/preview/2021-05-01-preview/PrivateLinkResources.json#L164
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Sql/preview/2021-05-01-preview/Servers.json#L605
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/sql/resource-manager/readme.md
    tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    AutorestCore/Exception "readme":"sql/resource-manager/readme.md",
    "tag":"package-preview-2021-05",
    "details":"Error: Plugin pre-namer reported failure."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Sep 1, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️[Staging] SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-sql - 3.0.1
    ️✔️azure-sdk-for-go - sql/mgmt/2014-04-01/sql - v57.4.0
    ️✔️azure-sdk-for-go - preview/sql/mgmt/v5.0/sql - v57.4.0
    ⚠️azure-sdk-for-go - preview/sql/mgmt/v4.0/sql - v57.4.0
    +	Const `All` type has been changed from `DatabaseState1` to `DatabaseState`
    +	Const `DatabaseState2All` has been removed
    +	Const `DatabaseState2Deleted` has been removed
    +	Const `DatabaseState2Live` has been removed
    +	Const `DatabaseState3All` has been removed
    +	Const `DatabaseState3Deleted` has been removed
    +	Const `DatabaseState3Live` has been removed
    +	Const `DatabaseState4All` has been removed
    +	Const `DatabaseState4Deleted` has been removed
    +	Const `DatabaseState4Live` has been removed
    +	Const `DatabaseState5All` has been removed
    +	Const `DatabaseState5Deleted` has been removed
    +	Const `DatabaseState5Live` has been removed
    +	Const `DatabaseState6All` has been removed
    +	Const `DatabaseState6Deleted` has been removed
    +	Const `DatabaseState6Live` has been removed
    +	Const `Deleted` type has been changed from `DatabaseState1` to `DatabaseState`
    +	Const `Geo` type has been changed from `SecondaryType` to `BackupStorageRedundancy`
    +	Const `Live` type has been changed from `DatabaseState1` to `DatabaseState`
    +	Const `LongTermRetentionDatabaseStateAll` has been removed
    +	Const `LongTermRetentionDatabaseStateDeleted` has been removed
    +	Const `LongTermRetentionDatabaseStateLive` has been removed
    +	Const `Named` has been removed
    +	Field `StorageAccountType` of struct `DatabaseProperties` has been removed
    +	Function `*BackupLongTermRetentionPoliciesCreateOrUpdateFuture.UnmarshalJSON` has been removed
    +	Function `*BackupLongTermRetentionPolicy.UnmarshalJSON` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdatePreparer` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdateResponder` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdateSender` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.CreateOrUpdate` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.GetPreparer` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.GetResponder` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.GetSender` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.Get` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.ListByDatabasePreparer` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.ListByDatabaseResponder` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.ListByDatabaseSender` has been removed
    +	Function `BackupLongTermRetentionPoliciesClient.ListByDatabase` has been removed
    +	Function `BackupLongTermRetentionPolicy.MarshalJSON` has been removed
    +	Function `LongTermRetentionBackupsClient.ListByDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByDatabase` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByLocationComplete` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByLocationPreparer` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByLocation` parameter(s) have been changed from `(context.Context, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupDatabase` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocationComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocationPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupLocation` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupServerComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupServerPreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByResourceGroupServer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByServerComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByServerPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionBackupsClient.ListByServer` parameter(s) have been changed from `(context.Context, string, string, *bool, LongTermRetentionDatabaseState)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByDatabase` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState1)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstanceComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstancePreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByInstance` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState2)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocationComplete` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocationPreparer` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByLocation` parameter(s) have been changed from `(context.Context, string, *bool, DatabaseState3)` to `(context.Context, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabaseComplete` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabasePreparer` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupDatabase` parameter(s) have been changed from `(context.Context, string, string, string, string, *bool, DatabaseState4)` to `(context.Context, string, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstanceComplete` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstancePreparer` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupInstance` parameter(s) have been changed from `(context.Context, string, string, string, *bool, DatabaseState5)` to `(context.Context, string, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocationComplete` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocationPreparer` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `LongTermRetentionManagedInstanceBackupsClient.ListByResourceGroupLocation` parameter(s) have been changed from `(context.Context, string, string, *bool, DatabaseState6)` to `(context.Context, string, string, *bool, DatabaseState)`
    +	Function `NewBackupLongTermRetentionPoliciesClientWithBaseURI` has been removed
    +	Function `NewBackupLongTermRetentionPoliciesClient` has been removed
    +	Function `PossibleDatabaseState1Values` has been removed
    +	Function `PossibleDatabaseState2Values` has been removed
    +	Function `PossibleDatabaseState3Values` has been removed
    +	Function `PossibleDatabaseState4Values` has been removed
    +	Function `PossibleDatabaseState5Values` has been removed
    +	Function `PossibleDatabaseState6Values` has been removed
    +	Function `PossibleLongTermRetentionDatabaseStateValues` has been removed
    +	Function `SystemData.MarshalJSON` has been removed
    +	Struct `BackupLongTermRetentionPoliciesClient` has been removed
    +	Struct `BackupLongTermRetentionPoliciesCreateOrUpdateFuture` has been removed
    +	Struct `BackupLongTermRetentionPolicy` has been removed
    +	Struct `LongTermRetentionPolicyProperties` has been removed
    ⚠️azure-sdk-for-go - preview/sql/mgmt/v3.0/sql - v57.4.0
    +	Const `Average` has been removed
    +	Const `Count` type has been changed from `PrimaryAggregationType` to `QueryMetricUnitType`
    +	Const `Maximum` has been removed
    +	Const `Minimum` has been removed
    +	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
    +	Const `Total` has been removed
    +	Function `*ManagedDatabaseRestoreDetailsResult.UnmarshalJSON` has been removed
    +	Function `ManagedDatabaseRestoreDetailsClient.GetPreparer` has been removed
    +	Function `ManagedDatabaseRestoreDetailsClient.GetResponder` has been removed
    +	Function `ManagedDatabaseRestoreDetailsClient.GetSender` has been removed
    +	Function `ManagedDatabaseRestoreDetailsClient.Get` has been removed
    +	Function `ManagedDatabaseRestoreDetailsProperties.MarshalJSON` has been removed
    +	Function `ManagedDatabaseRestoreDetailsResult.MarshalJSON` has been removed
    +	Function `NewManagedDatabaseRestoreDetailsClientWithBaseURI` has been removed
    +	Function `NewManagedDatabaseRestoreDetailsClient` has been removed
    +	Struct `ManagedDatabaseRestoreDetailsClient` has been removed
    +	Struct `ManagedDatabaseRestoreDetailsProperties` has been removed
    +	Struct `ManagedDatabaseRestoreDetailsResult` has been removed
    ⚠️azure-sdk-for-go - preview/sql/mgmt/2018-06-01-preview/sql - v57.4.0
    +	Const `Critical` has been removed
    +	Const `High` has been removed
    +	Const `Low` has been removed
    +	Const `Medium` has been removed
    +	Const `None` type has been changed from `SensitivityLabelRank` to `IdentityType`
    ️✔️azure-sdk-for-go - preview/sql/mgmt/2017-10-01-preview/sql - v57.4.0
    ⚠️azure-sdk-for-go - preview/sql/mgmt/2017-03-01-preview/sql - v57.4.0
    +	Const `Average` has been removed
    +	Const `Count` type has been changed from `PrimaryAggregationType` to `UnitDefinitionType`
    +	Const `Maximum` has been removed
    +	Const `Minimum` has been removed
    +	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
    +	Const `Total` has been removed
    +	Const `UnitDefinitionTypeBytesPerSecond` has been removed
    +	Const `UnitDefinitionTypeBytes` has been removed
    +	Const `UnitDefinitionTypeCountPerSecond` has been removed
    +	Const `UnitDefinitionTypeCount` has been removed
    +	Const `UnitDefinitionTypePercent` has been removed
    +	Const `UnitDefinitionTypeSeconds` has been removed
    ⚠️azure-sdk-for-go - preview/sql/mgmt/2015-05-01-preview/sql - v57.4.0
    +	Const `Average` has been removed
    +	Const `Count` type has been changed from `PrimaryAggregationType` to `UnitDefinitionType`
    +	Const `Maximum` has been removed
    +	Const `Minimum` has been removed
    +	Const `None` type has been changed from `PrimaryAggregationType` to `IdentityType`
    +	Const `Total` has been removed
    +	Const `UnitDefinitionTypeBytesPerSecond` has been removed
    +	Const `UnitDefinitionTypeBytes` has been removed
    +	Const `UnitDefinitionTypeCountPerSecond` has been removed
    +	Const `UnitDefinitionTypeCount` has been removed
    +	Const `UnitDefinitionTypePercent` has been removed
    +	Const `UnitDefinitionTypeSeconds` has been removed
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Sql [View full logs]  [Preview SDK Changes]
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
      cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-sql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-sql [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-09-27 16:55:19 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
      cmderr	[generate.py] 2021-09-27 16:55:19 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-09-27 16:55:19 INFO autorest --version=3.6.0 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [POM][Skip] pom already has module azure-resourcemanager-sql-generated
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-09-27 16:57:25 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Preview SDK Changes]
      cmderr	[Inst] 2021-09-27 17:02:24 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
      cmderr	[Inst] 2021-09-27 17:02:24 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-09-27 17:02:24 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-27 17:02:24 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-09-27 17:02:24 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15883/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sql/mgmt/2014-04-01/sql [View full logs]  [Preview SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/v5.0/sql [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/v4.0/sql [View full logsBreaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New struct `LongTermRetentionPoliciesClient`
      info	[Changelog] - New struct `LongTermRetentionPoliciesCreateOrUpdateFuture`
      info	[Changelog] - New struct `LongTermRetentionPolicy`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResult`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResultIterator`
      info	[Changelog] - New struct `LongTermRetentionPolicyListResultPage`
      info	[Changelog] - New struct `UpdateLongTermRetentionBackupParameters`
      info	[Changelog] - New struct `UpdateLongTermRetentionBackupParametersProperties`
      info	[Changelog] - New field `BackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
      info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `LongTermRetentionBackupProperties`
      info	[Changelog] - New field `RequestedBackupStorageRedundancy` in struct `DatabaseProperties`
      info	[Changelog] - New field `CurrentBackupStorageRedundancy` in struct `DatabaseProperties`
      info	[Changelog]
      info	[Changelog] Total 93 breaking change(s), 111 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/v3.0/sql [View full logsBreaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointConnectionProperties`
      info	[Changelog] - New struct `ManagedInstancePrivateEndpointProperty`
      info	[Changelog] - New struct `QueryMetricInterval`
      info	[Changelog] - New struct `QueryMetricProperties`
      info	[Changelog] - New struct `QueryStatisticsProperties`
      info	[Changelog] - New struct `TopQueries`
      info	[Changelog] - New struct `TopQueriesListResult`
      info	[Changelog] - New struct `TopQueriesListResultIterator`
      info	[Changelog] - New struct `TopQueriesListResultPage`
      info	[Changelog] - New field `PrivateEndpointConnections` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `ZoneRedundant` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `Identity` in struct `ManagedInstanceUpdate`
      info	[Changelog]
      info	[Changelog] Total 21 breaking change(s), 73 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2018-06-01-preview/sql [View full logsBreaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - Const `Medium` has been removed
      info	[Changelog] - Const `Low` has been removed
      info	[Changelog] - Const `Critical` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `SensitivityLabelRankLow`
      info	[Changelog] - New const `SensitivityLabelRankCritical`
      info	[Changelog] - New const `SensitivityLabelRankMedium`
      info	[Changelog] - New const `SensitivityLabelRankHigh`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `SensitivityLabelRankNone`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2017-10-01-preview/sql [View full logs
      info	[Changelog] No exported changes
    • ️✔️preview/sql/mgmt/2017-03-01-preview/sql [View full logsBreaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `Seconds`
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    • ️✔️preview/sql/mgmt/2015-05-01-preview/sql [View full logsBreaking Change Detected
      Only show 15 items here, please refer to log for details.
      info	[Changelog] - New const `PrimaryAggregationTypeMaximum`
      info	[Changelog] - New const `PrimaryAggregationTypeCount`
      info	[Changelog] - New const `CountPerSecond`
      info	[Changelog] - New const `Percent`
      info	[Changelog] - New const `Seconds`
      info	[Changelog] - New const `PrimaryAggregationTypeMinimum`
      info	[Changelog] - New const `UserAssigned`
      info	[Changelog] - New const `PrimaryAggregationTypeAverage`
      info	[Changelog] - New const `BytesPerSecond`
      info	[Changelog] - New const `PrimaryAggregationTypeNone`
      info	[Changelog] - New const `Bytes`
      info	[Changelog] - New const `PrimaryAggregationTypeTotal`
      info	[Changelog]
      info	[Changelog] Total 12 breaking change(s), 12 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    • ️✔️@azure/arm-sql [View full logs]  [Preview SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
      cmderr	[npmPack] created ./dist/arm-sql.js in 2.1s
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs] Generate from 7662251ae7ed55b4b32f2b1a4385352d5185f513. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @srmarkov, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Copy link
    Contributor

    @ericshape ericshape left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @zhenglaizhang
    Copy link
    Contributor

    @ArcturusZhang pls help check go SDK breaking changes

    @zhenglaizhang
    Copy link
    Contributor

    @ArcturusZhang pls help check go SDK breaking changes

    It's not targeted to main, so we can ignore the SDK breaking changes

    @zhenglaizhang zhenglaizhang added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Sep 7, 2021
    @ghost
    Copy link

    ghost commented Sep 26, 2021

    Hi, @srmarkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Sep 26, 2021
    @ericshape ericshape changed the base branch from dev-sql-Microsoft.Sql-2021-05-01-preview to dev-sql-Microsoft.Sql-2021-05-01-preview-mi-stop September 27, 2021 16:48
    @ghost ghost removed the no-recent-activity label Sep 27, 2021
    @ericshape ericshape changed the base branch from dev-sql-Microsoft.Sql-2021-05-01-preview-mi-stop to dev-sql-Microsoft.Sql-2021-05-01-preview-release September 27, 2021 16:48
    @ericshape ericshape changed the base branch from dev-sql-Microsoft.Sql-2021-05-01-preview-release to dev-sql-Microsoft.Sql-2021-05-01-preview September 27, 2021 16:49
    @ericshape
    Copy link
    Contributor

    close due to we have another all-in-one PR to cover it: #16184

    @ericshape ericshape closed this Sep 27, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates CI-BreakingChange-Go SQL
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants