-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge]Dev/srmarkov/server trust certificatesv2 #15883
[Do not merge]Dev/srmarkov/server trust certificatesv2 #15883
Conversation
Hi, @srmarkov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R2020 - RequiredPropertiesMissingInResourceModel |
Model definition 'FirewallRule' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L308 |
R2020 - RequiredPropertiesMissingInResourceModel |
Model definition 'ProxyResourceWithWritableName' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L298 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseVulnerabilityAssessmentRuleBaselines.json#L252 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseVulnerabilityAssessments.json#L198 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionBackups.json#L269 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionBackups.json#L769 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionManagedInstanceBackups.json#L121 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/LongTermRetentionManagedInstanceBackups.json#L467 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseSensitivityLabels.json#L256 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessmentRuleBaselines.json#L264 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessments.json#L207 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstanceAdministrators.json#L217 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstanceVulnerabilityAssessments.json#L189 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/RestorePoints.json#L207 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/SensitivityLabels.json#L611 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.Sql/preview/2021-05-01-preview/ServerVulnerabilityAssessments.json#L189 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'DatabaseVulnerabilityAssessmentRuleBaseline' does not have list operation, please add it. Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseVulnerabilityAssessmentRuleBaselines.json#L313 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'ManagedInstanceQuery' does not have list operation, please add it. Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseQueries.json#L165 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'ManagedDatabaseRestoreDetailsResult' does not have list operation, please add it. Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedDatabaseRestoreDetails.json#L140 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Sql/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Sql/preview/2021-05-01-preview/Operations.json#L19 |
R4019 - GetCollectionResponseSchema |
The response in the GET collection operation 'DatabaseAdvisors_ListByDatabase' does not match the response definition in the individual GET operation 'DatabaseAdvisors_Get' . Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseAdvisors.json#L19 |
R4019 - GetCollectionResponseSchema |
The response in the GET collection operation 'ServerAdvisors_ListByServer' does not match the response definition in the individual GET operation 'ServerAdvisors_Get' . Location: Microsoft.Sql/preview/2021-05-01-preview/ServerAdvisors.json#L19 |
R4019 - GetCollectionResponseSchema |
The response in the GET collection operation 'DatabaseRecommendedActions_ListByDatabaseAdvisor' does not match the response definition in the individual GET operation 'DatabaseRecommendedActions_Get' . Location: Microsoft.Sql/preview/2021-05-01-preview/DatabaseRecommendedActions.json#L19 |
R4035 - PrivateEndpointResourceSchemaValidation |
The private endpoint model 'ManagedInstancePrivateLinkListResult' schema does not conform to the common type definition. Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstancePrivateLinkResources.json#L109 |
Per the Noun_Verb convention for Operation Ids, the noun 'ManagedInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstances.json#L381 |
|
'PUT' operation 'FirewallRules_Replace' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Sql/preview/2021-05-01-preview/FirewallRules.json#L217 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstancePrivateLinkResources.json#L156 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Sql/preview/2021-05-01-preview/ManagedInstances.json#L863 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Sql/preview/2021-05-01-preview/PrivateLinkResources.json#L164 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Sql/preview/2021-05-01-preview/Servers.json#L605 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v5 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail]
- The following tags are being changed in this PR
Rule | Message |
---|---|
AutorestCore/Exception |
"readme":"sql/resource-manager/readme.md", "tag":"package-preview-2021-05", "details":"Error: Plugin pre-namer reported failure." |
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
Hi @srmarkov, Your PR has some issues. Please fix the CI sequentially by following the order of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ArcturusZhang pls help check go SDK breaking changes |
It's not targeted to main, so we can ignore the SDK breaking changes |
Hi, @srmarkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
close due to we have another all-in-one PR to cover it: #16184 |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
The deployment is targeting the end of 2021
The swagger should be published with the 2021-05-01 version
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.