-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Features 2021-07-01: Bug Fix. Update api version parameter. #15851
Conversation
Hi, @diwudd Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Features/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Features/stable/2021-07-01/features.json#L39 |
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Since operation 'ListOperations' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Features/stable/2021-07-01/features.json#L44 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/features.json#L329 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.Features/stable/2021-07-01/SubscriptionFeatureRegistration.json#L267 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-features-2021-07",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-features-2021-07",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"resources/resource-manager/readme.md",
"tag":"package-features-2021-07",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi, @diwudd your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
9705cd2
to
7b5a758
Compare
No API change. Approving. |
Thank you for approving. Can you please help merge it as I don't have the permission? |
@ArcturusZhang , @msyyc , can you confirm on the potential breaking change for GO/Python SDK? |
approve for python |
Thank you for reviewing! Can you please help merge the PR if it looks good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.