-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eventhubs] Increase MaximumThroughputUnits to 40 #15619
[eventhubs] Increase MaximumThroughputUnits to 40 #15619
Conversation
Hi, @mikhailshilkov Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
R2026 - AvoidAnonymousTypes |
Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L759 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2018-01-01-preview/disasterRecoveryConfigs.json#L217 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/stable/2017-04-01/disasterRecoveryConfigs.json#L217 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2021-06-01-preview/disasterRecoveryConfigs.json#L217 |
R4011 - DeleteOperationResponses |
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2021-01-01-preview/disasterRecoveryConfigs.json#L217 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214 |
R4013 - IntegerTypeMustHaveFormat |
The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204 |
R4017 - TopLevelResourcesListBySubscription |
The top-level resource 'Cluster' does not have list by subscription operation, please add it. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L330 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2018-01-01-preview/operations.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/stable/2017-04-01/operations.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2021-06-01-preview/operations.json#L37 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2021-01-01-preview/operations.json#L37 |
R4037 - MissingTypeObject |
The schema 'AvailableClustersList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/AvailableClusterRegions-preview.json#L75 |
R4037 - MissingTypeObject |
The schema 'AvailableCluster' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/AvailableClusterRegions-preview.json#L87 |
R4037 - MissingTypeObject |
The schema 'Cluster' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L330 |
R4037 - MissingTypeObject |
The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L336 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-06-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-06-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2018-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2018-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"profile-hybrid-2020-09-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"profile-hybrid-2020-09-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️
[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Thank you for your contribution mikhailshilkov! We will review the pull request and get back to you soon. |
Hi @mikhailshilkov, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Is increasing a maximum value considered a breaking change? The action shows "The new version has a more constraining 'maximum' value than the previous one." which seems wrong. Anyway, I think the API does allow the full range. |
Hi, @mikhailshilkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Please review this PR |
Hi, @mikhailshilkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Fixed in #15233 |
The actual limit on maximum Throughput Units is 40 (and the API / UI will allow you to select up to 40): https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-quotas#basic-vs-standard-vs-premium-vs-dedicated-tiers but the API spec states that the limit is 20. This PR increases it to 40 for all API versions.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.