compute 2021-04-01 release #14939
Closed
compute 2021-04-01 release #14939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolve merge conflicts after branch recreation * Fix Lint error
grizzlytheodore
requested review from
dkulkarni-ms,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
ghost
added
the
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-04-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 4 Errors, 4 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-04-01/compute.json compared with base:preview/2016-04-30-preview/compute.json
- current:stable/2021-04-01/compute.json compared with base:stable/2021-03-01/compute.json
- current:stable/2021-04-01/runCommands.json compared with base:stable/2021-03-01/runCommands.json
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌[Staging] SDK Track2 Validation: 2 Errors, 0 Warnings failed [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Duplicate Schema named PurchasePlan -- properties.promotionCode: undefined => "$ref":"#/components/schemas/schemas:1443", "description":"The Offer Promotion Code." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"Error: Plugin prechecker reported failure." |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"compute/resource-manager/readme.md", "tag":"package-2021-04-01-only", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=227371&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
️❌[Staging] SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 21.0.0+ Model PublicIPAddressSku has a new signature
️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v55.3.0️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v55.3.0️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v55.3.0️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v55.3.0❌azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v55.3.0+ Field `PublicIPAddressSkuName` of struct `PublicIPAddressSku` has been removed + Field `PublicIPAddressSkuTier` of struct `PublicIPAddressSku` has been removed
❌azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v55.3.0+ Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
❌azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v55.3.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed + Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
❌azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v55.3.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed + Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
❌azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v55.3.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed + Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
❌azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v55.3.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
❌azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v55.3.0+ Field `ContentType` of struct `GalleryApplicationVersionPublishingProfile` has been removed + Field `FileName` of struct `UserArtifactSource` has been removed
️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v55.3.0️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v55.3.0️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v55.3.0❌azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v55.3.0+ Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v55.3.0️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. SDK Automation 14.0.0warn Skip initScript due to not configured command sudo apt-get install -y dotnet-sdk-5.0 command autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied cmderr [Autorest] realpath(): Permission denied
️✔️Microsoft.Azure.Management.Compute [View full logs] [Preview SDK Changes]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
⚠️Warning [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. SDK Automation 14.0.0command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
️✔️track2_azure-mgmt-compute [View full logs] [Preview SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation DiskRestorePointOperations.begin_grant_access info [Changelog] - Added operation DiskRestorePointOperations.begin_revoke_access info [Changelog] info [Changelog] **Breaking changes** info [Changelog] info [Changelog] - Model PublicIPAddressSku has a new signature
️⚠️ azure-sdk-for-java warning [Detail]
⚠️Warning [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. SDK Automation 14.0.0command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json cmderr [generate.py] 2021-06-23 15:23:33 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-compute-generated" cmderr [generate.py] 2021-06-23 15:23:33 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1" cmderr [generate.py] 2021-06-23 15:23:33 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/compute/azure-resourcemanager-compute-generated --java.namespace=com.azure.resourcemanager.compute.generated --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/compute/resource-manager/readme.md cmderr [generate.py] 2021-06-23 15:25:20 INFO [CI][Success] Write to ci.yml cmderr [generate.py] 2021-06-23 15:25:20 INFO [POM][Process] dealing with pom.xml cmderr [generate.py] 2021-06-23 15:25:20 INFO [POM][Skip] pom already has module azure-resourcemanager-compute-generated cmderr [generate.py] 2021-06-23 15:25:20 INFO [POM][Success] Write to pom.xml cmderr [generate.py] 2021-06-23 15:25:20 INFO [POM][Process] dealing with root pom cmderr [generate.py] 2021-06-23 15:25:20 INFO [POM][Success] Write to root pom
️✔️azure-resourcemanager-compute-generated [View full logs] [Preview SDK Changes]- pom.xml
- azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1-javadoc.jar
cmderr [Inst] 2021-06-23 15:28:51 DEBUG Got artifact_id: azure-resourcemanager-compute-generated cmderr [Inst] 2021-06-23 15:28:51 DEBUG Got artifact: pom.xml cmderr [Inst] 2021-06-23 15:28:51 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar cmderr [Inst] 2021-06-23 15:28:51 DEBUG Got artifact: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-06-23 15:28:51 DEBUG Match jar package: azure-resourcemanager-compute-generated-1.0.0-beta.1.jar cmderr [Inst] 2021-06-23 15:28:51 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14939/azure-sdk-for-java/azure-resourcemanager-compute-generated/azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-compute-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-compute-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-compute-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true ```"}
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. SDK Automation 14.0.0warn Skip initScript due to not configured command autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/compute/resource-manager/readme.md
️✔️@azure/arm-compute [View full logs] [Preview SDK Changes]cmderr [npmPack] loaded rollup.config.js with warnings cmderr [npmPack] (!) Unused external imports cmderr [npmPack] default imported from external module 'rollup' but never used cmderr [npmPack] ./esm/computeManagementClient.js → ./dist/arm-compute.js... cmderr [npmPack] created ./dist/arm-compute.js in 1.3s
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
️✔️Succeeded [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. SDK Automation 14.0.0command sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs] [Preview SDK Changes]info [Changelog] This is a new package
️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs]info [Changelog] No exported changes
️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs]info [Changelog] No exported changes
️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs]info [Changelog] No exported changes
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2021-03-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `DiskRestorePointRevokeAccessFuture` info [Changelog] - New field `Tier` in struct `PublicIPAddressSku` info [Changelog] - New field `Name` in struct `PublicIPAddressSku` info [Changelog] info [Changelog] Total 1 breaking change(s), 15 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2020-12-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New function `DiskRestorePointClient.RevokeAccessResponder(*http.Response) (autorest.Response, error)` info [Changelog] - New struct `DiskRestorePointGrantAccessFuture` info [Changelog] - New struct `DiskRestorePointRevokeAccessFuture` info [Changelog] info [Changelog] Total 1 breaking change(s), 14 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2020-06-30/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `GroupByUserAgent` in struct `RequestRateByIntervalInput` info [Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetNetworkConfigurationProperties` info [Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties` info [Changelog] info [Changelog] Total 3 breaking change(s), 9 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2020-06-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput` info [Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] info [Changelog] Total 3 breaking change(s), 9 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2019-12-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `UserArtifactManage` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] info [Changelog] Total 3 breaking change(s), 4 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2019-07-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `UserArtifactManage` info [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
- Only show 6 items here, please refer to log for details.
️✔️compute/mgmt/2019-03-01/compute [View full logs] Breaking Change Detectedinfo [Changelog] - New struct `UserArtifactManage` info [Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource` info [Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile` info [Changelog] info [Changelog] Total 2 breaking change(s), 4 additive change(s). info [Changelog]
️✔️compute/mgmt/2018-10-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2018-06-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2018-04-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-12-01/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-09-01/skus [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2017-03-30/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2016-03-30/compute [View full logs]info [Changelog] No exported changes
️✔️compute/mgmt/2015-06-15/compute [View full logs]info [Changelog] No exported changes
️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs]info [Changelog] No exported changes
- Only show 6 items here, please refer to log for details.
️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs] Breaking Change Detectedinfo [Changelog] info [Changelog] ### New Content info [Changelog] info [Changelog] info [Changelog] Total 1 breaking change(s), 0 additive change(s). info [Changelog]
️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs]info [Changelog] No exported changes
️⚠️ azure-resource-manager-schemas warning [Detail]
⚠️Warning [Logs] Generate from f4f98a83ddb07512c9f73b7d7cfda439e12e7723. Schema Automation 14.0.0command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] cmderr [initScript.sh] The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] cmderr [initScript.sh] This is a one-time fix-up, please be patient... cmderr [initScript.sh] warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json warn No file changes detected after generation warn Skip detect changed packages
This was referenced Jun 22, 2021
Draft
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @grizzlytheodore your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
grizzlytheodore
changed the title
update example file also to fix breaking change naming issue.
|
'PublicIPAddressSku' related breaking changes were added to the 2021-03-01 version and approved by Jeffrey Richter. Shown here: #14782 |
ArcturusZhang
approved these changes
Jun 24, 2021
|
Hi @grizzlytheodore, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
We need swagger breaking change review board's sign off since we are having cross-version breaking changes. |
|
@ArcturusZhang the cross-version breaking changes flags are coming from comparing to 2016 version? |
Ah, sorry, I did not notice the version that we are comparing against is a preview version, and the api-version you are adding is stable, therefore this cross-version brekaing change can be ignored |
ArcturusZhang
approved these changes
Jun 25, 2021
|
I will merge this once ARM signed off |
|
These compute releases are usually collections of previously approved changes. Is that the case here? If so, are there any deltas between the numerous PRs this may have spawned from that were already approved? Are there additional changes here that weren't approved already? |
pilor
added
the
ARMChangesRequested
|
@pilor other changes in this PR are adding new API endpoints, adding new properties, and some descriptions being changed which are not considered breaking change for new API version. |
|
@pilor |
pilor
added
ARMSignedOff
|
@ArcturusZhang please merge! |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.