Private links #13945

tjegbejimba · 2021-04-15T00:04:06Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…into privateLinks

openapi-workflow-bot · 2021-04-15T00:04:08Z

Hi, @tjegbejimba Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-04-15T00:04:08Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-04-15T00:04:10Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 234 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- resources/resource-manager/readme.md tag:package-privatelinks-2020-05
Linted configuring files (Based on target branch, openapi-validator v1.10.0 , classic-openapi-validator v1.1.8 )
- resources/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Only 10 items are listed, please refer to log for more details.

Rule	Message
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkAssociation_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L127
⚠️ R1006 - PutInOperationName	'PUT' operation 'PrivateLinkAssociation_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L42

The following errors/warnings exist before current PR submission:

Only 10 items are listed, please refer to log for more details.

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L493
⚠️ R4021 - DescriptionAndTitleMissing	'error' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Authorization/stable/2020-05-01/privateLinks.json#L496

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 5 Warnings warning [Detail]

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ Modeler/MissingType	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2017-05", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2017-05-10/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
⚠️ Modeler/MissingType	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-09", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-09-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
⚠️ Modeler/MissingType	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-07", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-07-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
⚠️ Modeler/MissingType	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2016-02", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2016-02-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
⚠️ Modeler/MissingType	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2015-11", "details":"The schema 'DeploymentOperationProperties-statusMessage' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Resources/stable/2015-11-01/resources.json#/components/schemas/DeploymentOperationProperties-statusMessage"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-privatelinks-2020-05", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-privatelinks-2020-05", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PreCheck/DuplicateSchema	"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named Operation -- properties.display.$ref: undefined => "#/components/schemas/schemas:166" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named Operation-display -- properties.provider.description: undefined => "Service provider: Microsoft.Resources", properties.description: undefined => "$ref":"#/components/schemas/schemas:170", "description":"Description of the operation." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named OperationListResult -- properties.value.$ref: undefined => "#/components/schemas/schemas:172", properties.value.description: undefined => "List of Microsoft.Resources operations." ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` PreCheck/DuplicateSchema	"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Duplicate Schema named ErrorResponse -- properties.error: "$ref":"#/components/schemas/schemas:161", "description":"The error details." =>, properties.code: undefined => "$ref":"#/components/schemas/schemas:539", "description":"The error code.", "readOnly":true, properties.message: undefined => "$ref":"#/components/schemas/schemas:540", "description":"The error message.", "readOnly":true, properties.target: undefined => "$ref":"#/components/schemas/schemas:541", "description":"The error target.", "readOnly":true, properties.details: undefined => "$ref":"#/components/schemas/schemas:542", "description":"The error details.", "readOnly":true, properties.additionalInfo: undefined => "$ref":"#/components/schemas/schemas:543", "description":"The error additional info.", "readOnly":true, title: undefined => "Error Response" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
`❌` AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"profile-hybrid-2019-03-01", "details":"Error: Plugin prechecker reported failure."
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-resources-2021-04", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-policy-2020-09", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-policy-2020-09", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-preview-2020-08", "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
💬 AutorestCore/Exception	"readme":"resources/resource-manager/readme.md", "tag":"package-preview-2020-08", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-04-15T00:04:11Z

Swagger Generation Artifacts

️❌[Staging] ApiDocPreview: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` RestBuild error	"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=220676&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 "

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-resource - 17.0.0

️🔄 azure-sdk-for-net inProgress [Detail]

️🔄 azure-sdk-for-python inProgress [Detail]

️🔄 azure-sdk-for-python-track2 inProgress [Detail]

️🔄 azure-sdk-for-java inProgress [Detail]

️❌ azure-sdk-for-go failed [Detail]

❌Failed [Logs] Generate from 3f2ecc207c66e8c99d1320de5b1baf342ab77437. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: sh ./initScript.sh
warn	File azure-sdk-for-go_tmp/initOutput.json not found to read
command	go run ./tools/generator/main.go automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-go/src/github.com/Azure/azure-sdk-for-go]: go run ./tools/generator/main.go automation
warn	Skip package processing as generation is failed

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 3f2ecc207c66e8c99d1320de5b1baf342ab77437. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/resources/resource-manager/readme.md

️✔️@azure/arm-features [View full logs] [Preview SDK Changes]

azure-arm-features-1.0.3.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/featureClient.js → ./dist/arm-features.js...
cmderr	[npmPack] created ./dist/arm-features.js in 147ms

️✔️@azure/arm-links [View full logs] [Preview SDK Changes]

azure-arm-links-1.0.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/managementLinkClient.js → ./dist/arm-links.js...
cmderr	[npmPack] created ./dist/arm-links.js in 165ms

️✔️@azure/arm-locks [View full logs] [Preview SDK Changes]

azure-arm-locks-1.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/managementLockClient.js → ./dist/arm-locks.js...
cmderr	[npmPack] created ./dist/arm-locks.js in 225ms

️✔️@azure/arm-managedapplications [View full logs] [Preview SDK Changes]

azure-arm-managedapplications-1.0.2.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/applicationClient.js → ./dist/arm-managedapplications.js...
cmderr	[npmPack] created ./dist/arm-managedapplications.js in 297ms

️✔️@azure/arm-policy [View full logs] [Preview SDK Changes]

azure-arm-policy-4.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/policyClient.js → ./dist/arm-policy.js...
cmderr	[npmPack] created ./dist/arm-policy.js in 401ms

️✔️@azure/arm-resources [View full logs] [Preview SDK Changes]

azure-arm-resources-4.1.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/resourceManagementClient.js → ./dist/arm-resources.js...
cmderr	[npmPack] created ./dist/arm-resources.js in 617ms

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 3f2ecc207c66e8c99d1320de5b1baf342ab77437. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] (node:2772) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, unlink '/home/vsts/work/1/s/azure-resource-manager-schemas/schemas/2020-08-01/Microsoft.Resources.json'
cmderr	[generateScript.sh] (Use `node --trace-warnings ...` to show where the warning was created)
cmderr	[generateScript.sh] (node:2772) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
cmderr	[generateScript.sh] (node:2772) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
warn	No file changes detected after generation

️✔️resources [View full logs] [Preview Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2021-04-15T00:11:26Z

Hi @tjegbejimba, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

raych1 · 2021-07-09T02:45:41Z

@tjegbejimba , how's the breaking change review progress?

tjegbejimba · 2021-07-14T15:48:50Z

@raych1 Breaking changes approved. Ready for merge

tjegbejimba added 7 commits March 17, 2021 12:59

remove name validation from client side

a8dd2f3

remove name check from deploymentScripts swagger

d94dfb5

Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs …

21147fb

…into privateLinks

create privateLinks swagger

d120664

add all private link commands

1cd0959

add PLA and RMPL capabilities to swagger

fdf3885

update privateLink swagger

f47d494

openapi-assignment-bot bot assigned raych1 Apr 15, 2021

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Apr 15, 2021

openapi-pipeline-app bot added CI-FixRequiredOnFailure and removed CI-FixRequiredOnFailure labels Apr 15, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Python label Apr 15, 2021

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 15, 2021

tjegbejimba added 2 commits June 30, 2021 10:57

add suppresion for list operation

29d4e86

fix prettier errors

b39e2de

fix package tag for privatelinks

9fb392c

ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 13, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 14, 2021

raych1 removed the CI-FixRequiredOnFailure label Jul 18, 2021

raych1 approved these changes Jul 18, 2021

View reviewed changes

raych1 merged commit 19707b7 into Azure:master Jul 18, 2021

tjegbejimba deleted the privateLinks branch July 19, 2021 18:11

tjegbejimba restored the privateLinks branch September 20, 2021 18:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Private links #13945

Private links #13945

tjegbejimba commented Apr 15, 2021

openapi-workflow-bot bot commented Apr 15, 2021

openapi-workflow-bot bot commented Apr 15, 2021

openapi-pipeline-app bot commented Apr 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 15, 2021 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 15, 2021

raych1 commented Jul 9, 2021

tjegbejimba commented Jul 14, 2021

Private links #13945

Private links #13945

Conversation

tjegbejimba commented Apr 15, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 15, 2021

openapi-workflow-bot bot commented Apr 15, 2021

openapi-pipeline-app bot commented Apr 15, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 15, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Apr 15, 2021

raych1 commented Jul 9, 2021

tjegbejimba commented Jul 14, 2021

openapi-pipeline-app bot commented Apr 15, 2021 •

edited

Loading

openapi-pipeline-app bot commented Apr 15, 2021 •

edited

Loading