[Hub Generated] Review request for Microsoft.StreamAnalytics to add version stable/2020-03-01 #13230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2020-03-01-preview to version 2020-03-01
|
Hi, @zesluo Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'privateEndpoints' with immediate parent 'Cluster', must have a list by immediate parent operation. Location: Microsoft.StreamAnalytics/stable/2020-03-01/privateEndpoints.json#L238 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.7)
- original: preview/2020-03-01-preview/clusters.json <---> new: stable/2020-03-01/clusters.json
- original: preview/2020-03-01-preview/privateEndpoints.json <---> new: stable/2020-03-01/privateEndpoints.json
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 19 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'Cluster' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'ClusterProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'ClusterListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'ClusterJob' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'ClusterJobListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'ClusterSku' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'PrivateEndpoint' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'PrivateEndpointProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'PrivateLinkServiceConnection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"streamanalytics/resource-manager/readme.md", "tag":"package-2020-03", "details":"The schema 'PrivateLinkServiceConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Mar 2, 2021
|
@msyyc Python build fail, but seems not about spec. |
weidongxu-microsoft
approved these changes
Mar 2, 2021
|
@msyyc Python build fail, but seems not about spec. |
Thanks for your reply! I also found this, related to permission. Any idea about them? |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @zesluo your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @weidongxu-microsoft |
|
idear1203
added
DoNotMerge
|
Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued. |
|
Only version changed from the preview verions, marking ARMApproved. |
chiragg4u
added
ARMSignedOff
weidongxu-microsoft
added
the
Approved-OkToMerge
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Thank you @weidongxu-microsoft for driving this! |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It seems like a decode error in python script. We are trying to fix it. |
|
@00Kai0 kaihui is helping on the issue and we will try to fix it ASAP. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi, @zesluo. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @zesluo. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
swagger ready before 03/19
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.