2021 preview sb #13214
Merged
2021 preview sb #13214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @apraovjr Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The child tracked resource, 'privateEndpointConnections' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'disasterRecoveryConfigs' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'authorizationRules' with immediate parent 'ArmDisasterRecovery', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'migrationConfigurations' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'AuthorizationRules' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'authorizationRules' with immediate parent 'SBQueue', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'authorizationRules' with immediate parent 'SBTopic', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'queues' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'topics' with immediate parent 'SBNamespace', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
|
| The child tracked resource, 'rules' with immediate parent 'SBSubscription', must have a list by immediate parent operation. Location: Microsoft.ServiceBus/preview/2021-01-01-preview/CheckNameAvailability.json#L83 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️[Staging] Cross Version BreakingChange (Base on preview version): 4 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.7)
- original: preview/2018-01-01-preview/AuthorizationRules.json <---> new: preview/2021-01-01-preview/AuthorizationRules.json
- original: preview/2018-01-01-preview/CheckNameAvailability.json <---> new: preview/2021-01-01-preview/CheckNameAvailability.json
- original: preview/2018-01-01-preview/DisasterRecoveryConfig.json <---> new: preview/2021-01-01-preview/DisasterRecoveryConfig.json
- original: preview/2018-01-01-preview/Queue.json <---> new: preview/2021-01-01-preview/Queue.json
- original: preview/2018-01-01-preview/Rules.json <---> new: preview/2021-01-01-preview/Rules.json
- original: preview/2018-01-01-preview/migrationconfigs.json <---> new: preview/2021-01-01-preview/migrationconfigs.json
- original: preview/2018-01-01-preview/namespace-preview.json <---> new: preview/2021-01-01-preview/namespace-preview.json
- original: preview/2018-01-01-preview/networksets.json <---> new: preview/2021-01-01-preview/networksets.json
- original: preview/2018-01-01-preview/operations.json <---> new: preview/2021-01-01-preview/operations.json
- original: preview/2018-01-01-preview/subscriptions.json <---> new: preview/2021-01-01-preview/subscriptions.json
- original: preview/2018-01-01-preview/topics.json <---> new: preview/2021-01-01-preview/topics.json
| Rule | Message |
|---|---|
| The new version has a different type 'array' than the previous one ''. New: Microsoft.ServiceBus/preview/2021-01-01-preview/namespace-preview.json#L827:9 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json#L786:9 |
|
| The new version has a different default value than the previous one. New: Microsoft.ServiceBus/preview/2021-01-01-preview/namespace-preview.json#L782:9 Old: Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json#L768:9 |
|
| The new version is missing a property found in the old version. Was 'keyName' renamed or removed? Old: Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json#L806:7 |
|
| The new version is missing a property found in the old version. Was 'keyVaultUri' renamed or removed? Old: Microsoft.ServiceBus/preview/2018-01-01-preview/namespace-preview.json#L806:7 |
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 3 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.7)
- original: stable/2017-04-01/AuthorizationRules.json <---> new: preview/2021-01-01-preview/AuthorizationRules.json
- original: stable/2017-04-01/CheckNameAvailability.json <---> new: preview/2021-01-01-preview/CheckNameAvailability.json
- original: stable/2017-04-01/DisasterRecoveryConfig.json <---> new: preview/2021-01-01-preview/DisasterRecoveryConfig.json
- original: stable/2017-04-01/Queue.json <---> new: preview/2021-01-01-preview/Queue.json
- original: stable/2017-04-01/Rules.json <---> new: preview/2021-01-01-preview/Rules.json
- original: stable/2017-04-01/migrationconfigs.json <---> new: preview/2021-01-01-preview/migrationconfigs.json
- original: stable/2017-04-01/networksets.json <---> new: preview/2021-01-01-preview/networksets.json
- original: stable/2017-04-01/operations.json <---> new: preview/2021-01-01-preview/operations.json
- original: stable/2017-04-01/subscriptions.json <---> new: preview/2021-01-01-preview/subscriptions.json
- original: stable/2017-04-01/topics.json <---> new: preview/2021-01-01-preview/topics.json
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/AuthorizationRules' removed or restructured? Old: Microsoft.ServiceBus/stable/2017-04-01/DisasterRecoveryConfig.json#L357:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/AuthorizationRules/{authorizationRuleName}' removed or restructured? Old: Microsoft.ServiceBus/stable/2017-04-01/DisasterRecoveryConfig.json#L408:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfigs/{alias}/AuthorizationRules/{authorizationRuleName}/listKeys' removed or restructured? Old: Microsoft.ServiceBus/stable/2017-04-01/DisasterRecoveryConfig.json#L459:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 60 Warnings warning [Detail]
Only 10 items are listed, please refer to log for more details.
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'ResourceNamespacePatch' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'SBNamespaceListResult' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'SBNamespace' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'SBNamespaceUpdateParameters' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'SBNamespaceProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'Identity' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'Encryption' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'KeyVaultProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'PrivateEndpointConnection' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"servicebus/resource-manager/readme.md", "tag":"package-2021-01-preview", "details":"The schema 'PrivateEndpointConnectionProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=201181&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Run.ps1 failed with exit code 1 " |
|
Hi, @apraovjr your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @qianwens |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi @apraovjr, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
@chiragg4u For review and approval |
This was referenced Mar 1, 2021
chiragg4u
reviewed
Mar 2, 2021
| @@ -189,6 +189,59 @@ | |||
| } | |||
| }, | |||
| "description": "The resource management error additional info." | |||
| }, | |||
| "systemData": { | |||
There was a problem hiding this comment.
systemData [](start = 5, length = 10)
Same comment as in the other PR. Recommend referring to common definitions "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/..."
chiragg4u
added
ARMSignedOff
|
@weidongxu-microsoft For review and approval |
|
@apraovjr , can you add swagger-to-sdk:
- repo: azure-sdk-for-net
- repo: azure-sdk-for-python
- repo: azure-sdk-for-python-track2We need to active python track2 pipeline now. |
|
Is there anything new for 'package-2021-01-preview' compared with '2018-01-preview'. The changelog tools do not new operations or other new things compared with azure-mgmt-servicebus==2.0.0.
|
|
@00Kai0 There is error during codegen. Do you know what is the reason? |
|
@msyyc @apraovjr , we should add |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@qianwens Could you please approve and merge the PR? |
qianwens
approved these changes
Mar 16, 2021
This was referenced Mar 16, 2021
Closed
Closed
26 tasks
MirzaSikander
pushed a commit
to MirzaSikander/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2021
* Add 2018 files as base commit * Change files for 2021 in base files * swagger fix lintdiff errors * Add private endpoint connection property and refresh get example * add python2 in readme * Add checknamespaceavailability 2018 as base commit * Change checknamespaceavaibility for 2021-preview * fix track2 pipeline issue * fix lintdiff error * fix spell check
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Add 2018 files as base commit * Change files for 2021 in base files * swagger fix lintdiff errors * Add private endpoint connection property and refresh get example * add python2 in readme * Add checknamespaceavailability 2018 as base commit * Change checknamespaceavaibility for 2021-preview * fix track2 pipeline issue * fix lintdiff error * fix spell check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.