Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the server version enum for MariaDB swagger #13031

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

Suna-MS
Copy link
Contributor

@Suna-MS Suna-MS commented Feb 18, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @Suna-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 18, 2021

    Swagger Validation Report

    ️❌BreakingChange: 6 Errors, 0 Warnings failed [Detail]

    Rule Message
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1612:9
    Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1612:9
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1863:13
    Old: Microsoft.DBforMariaDB/preview/2018-06-01-preview/mariadb.json#L1863:13
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1984:9
    Old: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L1984:9
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L2234:13
    Old: Microsoft.DBforMariaDB/preview/2018-06-01-privatepreview/mariadb.json#L2234:13
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1701:9
    Old: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1701:9
    1019 - RemovedEnumValue The new version is removing enum value(s) '5.6, 5.7' from the old version.
    New: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1923:13
    Old: Microsoft.DBforMariaDB/stable/2018-06-01/mariadb.json#L1923:13
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mariadb/resource-manager/readme.md
    tag: specification/mariadb/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 5 Errors, 212 Warnings failed [Detail] Only 10 items are listed, please refer to log for more details.

    Rule Message
    PreCheck/DuplicateSchema "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-privatepreview",
    "details":"Duplicate Schema named CloudError -- properties.error.$ref: undefined => "#/components/schemas/schemas:223" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    PreCheck/DuplicateSchema "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-privatepreview",
    "details":"Duplicate Schema named CloudErrorBody -- properties.details.$ref: undefined => "#/components/schemas/schemas:227" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-privatepreview",
    "details":"Error: Plugin prechecker reported failure."
    PreCheck/DuplicateSchema "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2020-01-01",
    "details":"Duplicate Schema named CloudError -- properties.error.description: undefined => "Error message" ; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    AutorestCore/Exception "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2020-01-01",
    "details":"Error: Plugin prechecker reported failure."
    ⚠️ PreCheck/SchemaMissingType "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-preview",
    "details":"The schema 'ServerProperties' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-preview",
    "details":"The schema 'StorageProfile' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-preview",
    "details":"The schema 'ServerPropertiesForCreate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-preview",
    "details":"The schema 'ServerPropertiesForDefaultCreate' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ⚠️ PreCheck/SchemaMissingType "readme":"mariadb/resource-manager/readme.md",
    "tag":"package-2018-06-01-preview",
    "details":"The schema 'ServerPropertiesForRestore' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 18, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47789d0. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️mariadb/mgmt/2020-01-01/mariadb [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.Next() error`
      info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
      info	[Changelog] - New function `RecoverableServersClient.Get(context.Context, string, string) (RecoverableServerResource, error)`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Value() ServerSecurityAlertPolicy`
      info	[Changelog] - New function `PossibleQueryPerformanceInsightResetDataResultStateValues() []QueryPerformanceInsightResetDataResultState`
      info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
      info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
      info	[Changelog] - New function `RecoverableServersClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurations(context.Context, string, string, ConfigurationListResult) (ServerParametersListUpdateConfigurationsFuture, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
      info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.List(context.Context, string, string) (PerformanceTierListResult, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
      info	[Changelog] - New function `*RecoverableServerResource.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsSender(*http.Request) (ServerParametersListUpdateConfigurationsFuture, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
      info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightData(context.Context, string, string) (QueryPerformanceInsightResetDataResult, error)`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataResponder(*http.Response) (QueryPerformanceInsightResetDataResult, error)`
      info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
      info	[Changelog] - New function `NewRecoverableServersClient(string) RecoverableServersClient`
      info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerResponder(*http.Response) (ServerSecurityAlertPolicyListResult, error)`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
      info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 68 additive change(s).
      info	[Changelog]
    • ️✔️mariadb/mgmt/2018-06-01/mariadb [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 60 items here, please refer to log for details.
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.NextWithContext(context.Context) error`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.NotDone() bool`
      info	[Changelog] - New function `RecoverableServersClient.GetResponder(*http.Response) (RecoverableServerResource, error)`
      info	[Changelog] - New function `NewServerBasedPerformanceTierClient(string) ServerBasedPerformanceTierClient`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Response() ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurations(context.Context, string, string, ConfigurationListResult) (ServerParametersListUpdateConfigurationsFuture, error)`
      info	[Changelog] - New function `RecoverableServersClient.Get(context.Context, string, string) (RecoverableServerResource, error)`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultPage.Next() error`
      info	[Changelog] - New function `NewServerParametersClient(string) ServerParametersClient`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightData(context.Context, string, string) (QueryPerformanceInsightResetDataResult, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Response() ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerComplete(context.Context, string, string) (ServerSecurityAlertPolicyListResultIterator, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListResponder(*http.Response) (PerformanceTierListResult, error)`
      info	[Changelog] - New function `RecoverableServersClient.GetPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `NewServerParametersClientWithBaseURI(string, string) ServerParametersClient`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.Value() ServerSecurityAlertPolicy`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.List(context.Context, string, string) (PerformanceTierListResult, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServer(context.Context, string, string) (ServerSecurityAlertPolicyListResultPage, error)`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewServerBasedPerformanceTierClientWithBaseURI(string, string) ServerBasedPerformanceTierClient`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsSender(*http.Request) (ServerParametersListUpdateConfigurationsFuture, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.NextWithContext(context.Context) error`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResult.IsEmpty() bool`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataResponder(*http.Response) (QueryPerformanceInsightResetDataResult, error)`
      info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultPage(ServerSecurityAlertPolicyListResult, func(context.Context, ServerSecurityAlertPolicyListResult) (ServerSecurityAlertPolicyListResult, error)) ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New function `RecoverableServersClient.GetSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultPage.Values() []ServerSecurityAlertPolicy`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsResponder(*http.Response) (ConfigurationListResult, error)`
      info	[Changelog] - New function `NewServerSecurityAlertPolicyListResultIterator(ServerSecurityAlertPolicyListResultPage) ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New function `BaseClient.ResetQueryPerformanceInsightDataSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `ServerParametersClient.ListUpdateConfigurationsPreparer(context.Context, string, string, ConfigurationListResult) (*http.Request, error)`
      info	[Changelog] - New function `ServerSecurityAlertPoliciesClient.ListByServerSender(*http.Request) (*http.Response, error)`
      info	[Changelog] - New function `NewRecoverableServersClient(string) RecoverableServersClient`
      info	[Changelog] - New function `*ServerSecurityAlertPolicyListResultIterator.Next() error`
      info	[Changelog] - New function `NewRecoverableServersClientWithBaseURI(string, string) RecoverableServersClient`
      info	[Changelog] - New function `PossibleQueryPerformanceInsightResetDataResultStateValues() []QueryPerformanceInsightResetDataResultState`
      info	[Changelog] - New function `RecoverableServerResource.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `ServerBasedPerformanceTierClient.ListPreparer(context.Context, string, string) (*http.Request, error)`
      info	[Changelog] - New function `ServerSecurityAlertPolicyListResultIterator.NotDone() bool`
      info	[Changelog] - New struct `QueryPerformanceInsightResetDataResult`
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 68 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47789d0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.MariaDB [View full logs]  [Release SDK Changes]
      warn	Skip artifact folder because it doesn't exist: artifacts/packages
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47789d0. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-rdbms [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model LogFile has a new parameter log_file_type
      info	[Changelog]   - Model Server has a new parameter server_tags
      info	[Changelog]   - Added operation DatabasesOperations.delete
      info	[Changelog]   - Added operation DatabasesOperations.create_or_update
      info	[Changelog]   - Added operation ServerAdministratorsOperations.delete
      info	[Changelog]   - Added operation ServerAdministratorsOperations.create_or_update
      info	[Changelog]   - Added operation ConfigurationsOperations.update
      info	[Changelog]   - Added operation ServerSecurityAlertPoliciesOperations.create_or_update
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.update_tags
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.delete
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.create_or_update
      info	[Changelog]   - Added operation ServerKeysOperations.delete
      info	[Changelog]   - Added operation ServerKeysOperations.create_or_update
      info	[Changelog]   - Added operation FirewallRulesOperations.delete
      info	[Changelog]   - Added operation FirewallRulesOperations.create_or_update
      info	[Changelog]   - Added operation VirtualNetworkRulesOperations.delete
      info	[Changelog]   - Added operation VirtualNetworkRulesOperations.create_or_update
      info	[Changelog]   - Added operation MySQLManagementClientOperationsMixin.create_recommended_action_session
      info	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.reset_query_performance_insight_data
      info	[Changelog]   - Added operation MariaDBManagementClientOperationsMixin.create_recommended_action_session
      info	[Changelog]   - Added operation ServersOperations.delete
      info	[Changelog]   - Added operation ServersOperations.update
      info	[Changelog]   - Added operation ServersOperations.create
      info	[Changelog]   - Added operation ServersOperations.start
      info	[Changelog]   - Added operation ServersOperations.restart
      info	[Changelog]   - Added operation ServersOperations.stop
      info	[Changelog]   - Added operation group RecoverableServersOperations
      info	[Changelog]   - Added operation group ServerBasedPerformanceTierOperations
      info	[Changelog]   - Added operation group ServerParametersOperations
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Parameter administrator_type of model ServerAdministratorResource is now required
      info	[Changelog]   - Parameter tenant_id of model ServerAdministratorResource is now required
      info	[Changelog]   - Parameter login of model ServerAdministratorResource is now required
      info	[Changelog]   - Parameter sid of model ServerAdministratorResource is now required
      info	[Changelog]   - Parameter virtual_network_subnet_id of model VirtualNetworkRule is now required
      info	[Changelog]   - Parameter server_key_type of model ServerKey is now required
      info	[Changelog]   - Parameter state of model ServerSecurityAlertPolicy is now required
      info	[Changelog]   - Operation WaitStatisticsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation WaitStatisticsOperations.get has a new signature
      info	[Changelog]   - Operation VirtualNetworkRulesOperations.list_by_server has a new signature
      info	[Changelog]   - Operation VirtualNetworkRulesOperations.get has a new signature
      info	[Changelog]   - Operation TopQueryStatisticsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation TopQueryStatisticsOperations.get has a new signature
      info	[Changelog]   - Operation ServerKeysOperations.list has a new signature
      info	[Changelog]   - Operation ServerKeysOperations.get has a new signature
      info	[Changelog]   - Operation ServerAdministratorsOperations.list has a new signature
      info	[Changelog]   - Operation ServerAdministratorsOperations.get has a new signature
      info	[Changelog]   - Operation ReplicasOperations.list_by_server has a new signature
      info	[Changelog]   - Operation RecommendedActionsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation RecommendedActionsOperations.get has a new signature
      info	[Changelog]   - Operation QueryTextsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation QueryTextsOperations.get has a new signature
      info	[Changelog]   - Operation PrivateLinkResourcesOperations.list_by_server has a new signature
      info	[Changelog]   - Operation PrivateLinkResourcesOperations.get has a new signature
      info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation PrivateEndpointConnectionsOperations.get has a new signature
      info	[Changelog]   - Operation LogFilesOperations.list_by_server has a new signature
      info	[Changelog]   - Operation LocationBasedRecommendedActionSessionsResultOperations.list has a new signature
      info	[Changelog]   - Operation LocationBasedRecommendedActionSessionsOperationStatusOperations.get has a new signature
      info	[Changelog]   - Operation LocationBasedPerformanceTierOperations.list has a new signature
      info	[Changelog]   - Operation LocationBasedCapabilitiesOperations.execute has a new signature
      info	[Changelog]   - Operation FirewallRulesOperations.list_by_server has a new signature
      info	[Changelog]   - Operation FirewallRulesOperations.get has a new signature
      info	[Changelog]   - Operation DatabasesOperations.list_by_server has a new signature
      info	[Changelog]   - Operation DatabasesOperations.get has a new signature
      info	[Changelog]   - Operation ConfigurationsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation ConfigurationsOperations.get has a new signature
      info	[Changelog]   - Operation AdvisorsOperations.list_by_server has a new signature
      info	[Changelog]   - Operation AdvisorsOperations.get has a new signature
      info	[Changelog]   - Model ConfigurationListResult no longer has parameter next_link
      info	[Changelog]   - Model LogFile no longer has parameter type_properties_type
      info	[Changelog]   - Model Server no longer has parameter tags_properties_tags
      info	[Changelog]   - Operation CheckVirtualNetworkSubnetUsageOperations.execute has a new signature
      info	[Changelog]   - Operation Operations.list has a new signature
      info	[Changelog]   - Operation ServerSecurityAlertPoliciesOperations.get has a new signature
      info	[Changelog]   - Operation VirtualNetworkSubnetUsageOperations.execute has a new signature
      info	[Changelog]   - Operation CheckNameAvailabilityOperations.execute has a new signature
      info	[Changelog]   - Removed operation DatabasesOperations.begin_create_or_update
      info	[Changelog]   - Removed operation DatabasesOperations.begin_delete
      info	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_create_or_update
      info	[Changelog]   - Removed operation ServerAdministratorsOperations.begin_delete
      info	[Changelog]   - Removed operation ConfigurationsOperations.begin_update
      info	[Changelog]   - Removed operation ServerSecurityAlertPoliciesOperations.begin_create_or_update
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_create_or_update
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_update_tags
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.begin_delete
      info	[Changelog]   - Removed operation ServerKeysOperations.begin_create_or_update
      info	[Changelog]   - Removed operation ServerKeysOperations.begin_delete
      info	[Changelog]   - Removed operation FirewallRulesOperations.begin_create_or_update
      info	[Changelog]   - Removed operation FirewallRulesOperations.begin_delete
      info	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_create_or_update
      info	[Changelog]   - Removed operation VirtualNetworkRulesOperations.begin_delete
      info	[Changelog]   - Removed operation MySQLManagementClientOperationsMixin.begin_create_recommended_action_session
      info	[Changelog]   - Removed operation MariaDBManagementClientOperationsMixin.begin_create_recommended_action_session
      info	[Changelog]   - Removed operation ServersOperations.begin_restart
      info	[Changelog]   - Removed operation ServersOperations.begin_stop
      info	[Changelog]   - Removed operation ServersOperations.begin_create
      info	[Changelog]   - Removed operation ServersOperations.begin_update
      info	[Changelog]   - Removed operation ServersOperations.begin_start
      info	[Changelog]   - Removed operation ServersOperations.begin_delete
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47789d0. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-02-22 07:30:03 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-mariadb"
      cmderr	[generate.py] 2021-02-22 07:30:03 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-02-22 07:30:03 INFO autorest --version=3.0.6369 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/mariadb/azure-resourcemanager-mariadb --java.namespace=com.azure.resourcemanager.mariadb   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [POM][Skip] pom already has module azure-resourcemanager-mariadb
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-02-22 07:30:49 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-mariadb [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG Got artifact_id: azure-resourcemanager-mariadb
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG Got artifact: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG Match jar package: azure-resourcemanager-mariadb-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-02-22 07:33:48 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13031/azure-sdk-for-java/azure-resourcemanager-mariadb/azure-resourcemanager-mariadb-1.0.0-beta.1.jar\" -o azure-resourcemanager-mariadb-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-mariadb -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-mariadb-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47789d0. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
    • ️✔️mariadb [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  WARN [email protected] No repository field.
      cmderr	[resource-manager]  WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47789d0. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/mariadb/resource-manager/readme.md
    • ️✔️@azure/arm-mariadb [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/mariaDBManagementClient.js → ./dist/arm-mariadb.js...
      cmderr	[npmPack] created ./dist/arm-mariadb.js in 625ms
    ️🔄[Staging] ApiDocPreview inProgress [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @Suna-MS, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 19, 2021
    @Suna-MS
    Copy link
    Contributor Author

    Suna-MS commented Feb 20, 2021

    Hi @akning-ms, The breaking change was approved, could you please help merge this PR?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Go CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants