RoundTrip additional property and object additional property S360 fix by adding defaults and renaming respectively #12992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by adding defaults and renaming respectively
|
Hi, @dhawal777 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
|
| Rule | Message |
|---|---|
| "readme":"databox/resource-manager/readme.md", "tag":"package-2020-11", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
|
| "readme":"databox/resource-manager/readme.md", "tag":"package-2020-04", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
|
| "readme":"databox/resource-manager/readme.md", "tag":"package-2019-09", "details":"The schema 'CloudError' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'" |
|
| "readme":"databox/resource-manager/readme.md", "tag":"package-2019-09", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
|
| "readme":"databox/resource-manager/readme.md", "tag":"package-2018-01", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
In the Window Period to fix mismatches between swagger and service, when PR is labelled with “FixS360”, breaking change can be approved by PR assignee; the Azure Breaking Change Board is no longer required to approve the PR. Please ensure to clarify what s360 action items to be solved, and @ mention PR assignee for awareness. Please check this wiki Window to Fix Broken for more details. |
dhawal777
changed the title
|
Hi @dhawal777, Your PR has some issues. Please fix the CI sequentially by following the order of
|
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @dhawal777 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @allenjzhang |
|
Updating common properties across all version to avoid S360 in any version. Thanks |
dhawal777
changed the title
dhawal777
changed the title
|
/azp run |
|
Commenter does not have sufficient privileges for PR 12992 in repo Azure/azure-rest-api-specs |
openapi-pipeline-app
bot
added
CI-FixRequiredOnFailure
and removed
CI-FixRequiredOnFailure
labels
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hi @zhenglaizhang @allenjzhang , Kindly suggest if anything can be done on above queries, so that we can close few S60 post taking the suggestions and merging the PR. Thanks |
allenjzhang
added
Approved-BreakingChange
|
Waiting on feedback on the SDK breaking change due to the superfluous casing change. Otherwise looks fine. |
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
Feb 22, 2021
allenjzhang
approved these changes
Feb 22, 2021
This was referenced Feb 22, 2021
This was referenced Feb 25, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
… by adding defaults and renaming respectively (Azure#12992) * Swagger correctness issue fix(Additional Property not allowed) * Added custom-word * Removing unused properrty * Ignored Tera * Reverting not related changes * RoundTrip additional property and object additional property S360 fix by adding defaults and renaming respectively * Removed default * Removing some default in older version * Fixed model validation errors and added few more defaults * Fixed Sementic errors * Lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.