Bug fix to support ARM template deployments #12954

harshitha-akkaraju · 2021-02-11T16:16:09Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No, no need to refresh for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
- Reviewed the breaking change doc, since we are adding and removing a response code. It sounds like it will be a breaking change. Will schedule a meeting with the Breaking Change Review board.
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- Adding a new service
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to [Retirement of Previews]
Adding and removing a response code from PUT APIs for 2 resources.
(https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews))

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-02-11T16:16:12Z

Hi, @harshitha-akkaraju Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

zhenglaizhang · 2021-02-18T03:56:26Z

/azp run

openapi-pipeline-app · 2021-02-18T03:56:28Z

Swagger Validation Report

️❌BreakingChange: 4 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.8.6)
- original: preview/2020-03-15-preview/storagepool.json <---> new: preview/2020-03-15-preview/storagepool.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '201'. New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L198:11
`❌` 1011 - AddingResponseCode	The new version adds a response code '201'. New: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L441:11
`❌` 1012 - RemovedResponseCode	The new version removes the response code '202' Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L198:11
`❌` 1012 - RemovedResponseCode	The new version removes the response code '202' Old: Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json#L432:11

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- storagepool/resource-manager/readme.md tag:package-2020-03-15-preview
Linted configuring files (Based on target branch, openapi-validator v1.7.0 , classic-openapi-validator v1.1.5 )
- storagepool/resource-manager/readme.md tag:package-2020-03-15-preview

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️[Staging] SDK Track2 Validation: 6 Warnings warning [Detail]

The following tags are being changed in this PR

storagepool/resource-manager/readme.md#package-2020-03-15-preview

Rule	Message
⚠️ PreCheck/SchemaMissingType	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"The schema 'TrackedResource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"The schema 'Resource' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"The schema 'ProxyResource' with an undefined type and 'allOf'/'anyOf'/'oneOf' is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"The schema 'ErrorAdditionalInfo' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/SchemaMissingType	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"The schema 'ErrorResponse' with an undefined type and decalared properties is a bit ambigious. This has been auto-corrected to 'type:object'"
⚠️ PreCheck/CheckDuplicateSchemas	"readme":"storagepool/resource-manager/readme.md", "tag":"package-2020-03-15-preview", "details":"Checking for duplicate schemas, this could take a (long) while. Run with --verbose for more detail."

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-02-18T03:56:29Z

Swagger Generation Artifacts

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8f96985. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️preview/storagepool/mgmt/2020-03-15-preview/storagepool [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Const `Basic` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Const `Standard` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Const `Premium` type has been changed from `SkuTier` to `DiskPoolTier`
info	[Changelog] - Function `IscsiTargetsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, IscsiTarget)` to `(context.Context, string, string, string, IscsiTargetCreate)`
info	[Changelog] - Function `DiskPoolsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolCreate)`
info	[Changelog] - Function `IscsiTargetsClient.CreateOrUpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, string, IscsiTarget)` to `(context.Context, string, string, string, IscsiTargetCreate)`
info	[Changelog] - Function `DiskPoolsClient.UpdatePreparer` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolUpdate)`
info	[Changelog] - Function `DiskPoolsClient.UpdateSender` return value(s) have been changed from `(*http.Response, error)` to `(DiskPoolsUpdateFuture, error)`
info	[Changelog] - Function `DiskPoolsClient.Update` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolUpdate)`
info	[Changelog] - Function `DiskPoolsClient.Update` return value(s) have been changed from `(DiskPool, error)` to `(DiskPoolsUpdateFuture, error)`
info	[Changelog] - Function `DiskPoolsClient.CreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, DiskPool)` to `(context.Context, string, string, DiskPoolCreate)`
info	[Changelog] - Const `Free` has been removed
info	[Changelog] - Function `DiskPoolProperties.MarshalJSON` has been removed
info	[Changelog] - Function `IscsiTargetProperties.MarshalJSON` has been removed
info	[Changelog] - Function `TargetPortalGroup.MarshalJSON` has been removed
info	[Changelog] - Function `PossibleSkuTierValues` has been removed
info	[Changelog] - Struct `Sku` has been removed
info	[Changelog] - Field `Sku` of struct `DiskPool` has been removed
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New const `Updating`
info	[Changelog] - New const `Running`
info	[Changelog] - New const `Stoppeddeallocated`
info	[Changelog] - New const `Stopped`
info	[Changelog] - New function `*IscsiTargetUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IscsiTargetCreate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdateResponder(*http.Response) (IscsiTarget, error)`
info	[Changelog] - New function `*DiskPoolUpdate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*DiskPoolCreate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `DiskPoolCreate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdatePreparer(context.Context, string, string, string, IscsiTargetUpdate) (*http.Request, error)`
info	[Changelog] - New function `IscsiTargetUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `IscsiTargetsClient.UpdateSender(*http.Request) (IscsiTargetsUpdateFuture, error)`
info	[Changelog] - New function `*IscsiTargetCreate.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `IscsiTargetsClient.Update(context.Context, string, string, string, IscsiTargetUpdate) (IscsiTargetsUpdateFuture, error)`
info	[Changelog] - New function `DiskPoolUpdate.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleDiskPoolTierValues() []DiskPoolTier`
info	[Changelog] - New struct `DiskPoolCreate`
info	[Changelog] - New struct `DiskPoolCreateProperties`
info	[Changelog] - New struct `DiskPoolUpdate`
info	[Changelog] - New struct `DiskPoolUpdateProperties`
info	[Changelog] - New struct `DiskPoolsUpdateFuture`
info	[Changelog] - New struct `IscsiTargetCreate`
info	[Changelog] - New struct `IscsiTargetCreateProperties`
info	[Changelog] - New struct `IscsiTargetUpdate`
info	[Changelog] - New struct `IscsiTargetUpdateProperties`
info	[Changelog] - New struct `IscsiTargetsUpdateFuture`
info	[Changelog] - New struct `TargetPortalGroupCreate`
info	[Changelog] - New struct `TargetPortalGroupUpdate`
info	[Changelog] - New field `AdditionalCapabilities` in struct `DiskPoolProperties`
info	[Changelog] - New field `Tier` in struct `DiskPoolProperties`
info	[Changelog]
info	[Changelog] Total 18 breaking change(s), 42 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8f96985. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/storagepool/resource-manager/readme.md

️✔️@azure/arm-storagepool [View full logs] [Release SDK Changes]

azure-arm-storagepool-1.0.0.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/storagePoolManagement.js → ./dist/arm-storagepool.js...
cmderr	[npmPack] created ./dist/arm-storagepool.js in 312ms

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 8f96985. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-03-16 05:31:00 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-storagepool"
cmderr	[generate.py] 2021-03-16 05:31:00 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-03-16 05:31:00 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/storagepool/azure-resourcemanager-storagepool --java.namespace=com.azure.resourcemanager.storagepool   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/storagepool/resource-manager/readme.md
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [POM][Skip] pom already has module azure-resourcemanager-storagepool
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-03-16 05:31:31 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-storagepool [View full logs] [Release SDK Changes]

cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Got artifact_id: azure-resourcemanager-storagepool
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1-sources.jar
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Got artifact: azure-resourcemanager-storagepool-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG Match jar package: azure-resourcemanager-storagepool-1.0.0-beta.1.jar
cmderr	[Inst] 2021-03-16 05:34:18 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/12954/azure-sdk-for-java/azure-resourcemanager-storagepool/azure-resourcemanager-storagepool-1.0.0-beta.1.jar\" -o azure-resourcemanager-storagepool-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-storagepool -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-storagepool-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 8f96985. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-storage [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group IscsiTargetsOperations
info	[Changelog]   - Added operation group DiskPoolsOperations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorResponse has a new signature

️🔄[Staging] ApiDocPreview inProgress [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

azure-pipelines · 2021-02-18T03:56:39Z

Azure Pipelines successfully started running 2 pipeline(s).

openapi-workflow-bot · 2021-02-18T04:06:25Z

Hi @harshitha-akkaraju, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

openapi-workflow-bot · 2021-02-18T04:06:25Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

...oragepool/resource-manager/Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json

Juliehzl · 2021-03-01T06:32:19Z

@harshitha-akkaraju could you fix comments above first?

chiragg4u · 2021-03-01T17:56:16Z

Please go through the contribution checklist added as part of the review and mark them completed. This is a requirement before review can be continued.

openapi-workflow-bot · 2021-03-08T17:07:03Z

Hi @harshitha-akkaraju, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

Task	How to fix	Priority	Support (Microsoft alias)
Avocado	Fix-Avocado	High	ruowan
Semantic validation	Fix-SemanticValidation-Error	High	raychen, jianyxi
Model validation	Fix-ModelValidation-Error	High	raychen,jianyxi
LintDiff	Fix-LintDiff	high	jianyxi, ruoxuan

If you need further help, please feedback via swagger feedback."

openapi-workflow-bot · 2021-03-09T05:41:48Z

Hi, @harshitha-akkaraju your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @Juliehzl

JeffreyRichter

No customers yet

* Bug fix to support ARM template deployments * Revisions * Prettier fixes Co-authored-by: Harshitha Akkaraju <[email protected]>

Bug fix to support ARM template deployments

2462300

harshitha-akkaraju marked this pull request as ready for review February 12, 2021 22:57

openapi-assignment-bot bot assigned allenjzhang Feb 12, 2021

allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 17, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired labels Feb 18, 2021

openapi-sdkautomation bot mentioned this pull request Feb 18, 2021

[AutoPR @azure/arm-storagepool] Bug fix to support ARM template deployments AzureSDKAutomation/azure-sdk-for-js#3675

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Feb 18, 2021

This was referenced Feb 18, 2021

[AutoPR azure-resourcemanager-storagepool] Bug fix to support ARM template deployments AzureSDKAutomation/azure-sdk-for-java#7522

Closed

[AutoPR azure-mgmt-storage] Bug fix to support ARM template deployments AzureSDKAutomation/azure-sdk-for-python#4215

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python label Feb 19, 2021

openapi-sdkautomation bot mentioned this pull request Feb 19, 2021

[AutoPR Microsoft.Azure.Management.StoragePool] Bug fix to support ARM template deployments AzureSDKAutomation/azure-sdk-for-net#3267

Draft

Juliehzl reviewed Feb 20, 2021

View reviewed changes

...oragepool/resource-manager/Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json Show resolved Hide resolved

allenjzhang assigned Juliehzl and unassigned allenjzhang Feb 21, 2021

RamyasreeChakka reviewed Feb 24, 2021

View reviewed changes

...oragepool/resource-manager/Microsoft.StoragePool/preview/2020-03-15-preview/storagepool.json Show resolved Hide resolved

RamyasreeChakka added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 24, 2021

Revisions

9b012c9

harshitha-akkaraju force-pushed the hakkaraj/storagepool-bug-fix branch from 8fd86ab to 9b012c9 Compare March 8, 2021 17:05

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Mar 8, 2021

openapi-pipeline-app bot removed BreakingChangeReviewRequired CI-BreakingChange-Python CI-BreakingChange-Go labels Mar 8, 2021

Prettier fixes

11378ff

harshitha-akkaraju removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Mar 9, 2021

openapi-pipeline-app bot added BreakingChangeReviewRequired CI-BreakingChange-Go CI-BreakingChange-Python and removed CI-FixRequiredOnFailure labels Mar 9, 2021

j5lim self-requested a review March 12, 2021 01:07

j5lim approved these changes Mar 12, 2021

View reviewed changes

j5lim added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 12, 2021

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 15, 2021

JeffreyRichter approved these changes Mar 15, 2021

View reviewed changes

Juliehzl approved these changes Mar 16, 2021

View reviewed changes

Juliehzl merged commit 8f96985 into master Mar 16, 2021

JackTn deleted the hakkaraj/storagepool-bug-fix branch August 17, 2021 06:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug fix to support ARM template deployments #12954

Bug fix to support ARM template deployments #12954

harshitha-akkaraju commented Feb 11, 2021 •

edited

Loading

openapi-workflow-bot bot commented Feb 11, 2021

zhenglaizhang commented Feb 18, 2021

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

azure-pipelines bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

Juliehzl commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

openapi-workflow-bot bot commented Mar 8, 2021

openapi-workflow-bot bot commented Mar 9, 2021

JeffreyRichter left a comment

Bug fix to support ARM template deployments #12954

Bug fix to support ARM template deployments #12954

Conversation

harshitha-akkaraju commented Feb 11, 2021 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 11, 2021

zhenglaizhang commented Feb 18, 2021

openapi-pipeline-app bot commented Feb 18, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 18, 2021 • edited Loading

Swagger Generation Artifacts

azure-pipelines bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

openapi-workflow-bot bot commented Feb 18, 2021

Juliehzl commented Mar 1, 2021

chiragg4u commented Mar 1, 2021

openapi-workflow-bot bot commented Mar 8, 2021

openapi-workflow-bot bot commented Mar 9, 2021

JeffreyRichter left a comment

Choose a reason for hiding this comment

harshitha-akkaraju commented Feb 11, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading

openapi-pipeline-app bot commented Feb 18, 2021 •

edited

Loading