Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.BotService to add version stable/2020-06-02 #12564

Merged
merged 1 commit into from
Jan 25, 2021
Merged

[Hub Generated] Review request for Microsoft.BotService to add version stable/2020-06-02 #12564

merged 1 commit into from
Jan 25, 2021

Conversation

ssss141414
Copy link
Contributor

@ssss141414 ssss141414 commented Jan 22, 2021

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @ssss141414 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

    Rule Message
    1011 - AddingResponseCode The new version adds a response code 'default'.
    New: Microsoft.BotService/stable/2020-06-02/botservice.json#L766:11
    ️️✔️LintDiff succeeded [Detail] [Expand]
    Validation passes for LintDiff.

    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 22, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b197995. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️preview/botservice/mgmt/2018-07-12/botservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    • ️✔️preview/botservice/mgmt/2017-12-01/botservice [View full logs]  [Release SDK Changes]
      info	[Changelog] No exported changes
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from b197995. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-5.0
      command	autorest --version=V2 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
    • Microsoft.Azure.Management.BotService [View full logs]  [Release SDK Changes]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Tests/BotServiceTests.cs(51,99): error CS1503: Argument 2: cannot convert from 'string' to 'bool' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Microsoft.Azure.Management.BotService.Tests.csproj]
      cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Tests/BotServiceTests.cs(51,115): error CS1503: Argument 3: cannot convert from 'bool' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Microsoft.Azure.Management.BotService.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Tests/BotServiceTests.cs(51,99): error CS1503: Argument 2: cannot convert from 'string' to 'bool' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Microsoft.Azure.Management.BotService.Tests.csproj]
      cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Tests/BotServiceTests.cs(51,115): error CS1503: Argument 3: cannot convert from 'bool' to 'string' [/home/vsts/work/1/s/azure-sdk-for-net/sdk/botservice/Microsoft.Azure.Management.BotService/tests/Microsoft.Azure.Management.BotService.Tests.csproj]
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b197995. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6351 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
    • ️✔️botservice [View full logs]  [Release Schema Changes]
      cmderr	[resource-manager] node-pre-gyp
      cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
      cmderr	[resource-manager]  [email protected] No repository field.
      cmderr	[resource-manager] optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
      cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
      cmderr	[resource-manager] code ELIFECYCLE
      cmderr	[resource-manager] npm ERR! errno 3
      cmderr	[resource-manager] npm ERR! [email protected] test: `mocha -r ts-node/register tests.ts`
      cmderr	[resource-manager] npm ERR! Exit status 3
      cmderr	[resource-manager] npm ERR!
      cmderr	[resource-manager] npm ERR! Failed at the [email protected] test script.
      cmderr	[resource-manager] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
      cmderr	[resource-manager]  A complete log of this run can be found in:
      cmderr	[resource-manager] npm ERR!     /home/vsts/.npm/_logs/2021-01-25T02_16_59_703Z-debug.log
      cmderr	[resource-manager] Error: Command failed: npm run test --prefix tools
      cmderr	[resource-manager]     at checkExecSyncError (child_process.js:635:11)
      cmderr	[resource-manager]     at Object.execSync (child_process.js:671:15)
      cmderr	[resource-manager]     at Object.<anonymous> (/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas/sdkauto_afterscript.js:13:28)
      cmderr	[resource-manager]     at Module._compile (internal/modules/cjs/loader.js:999:30)
      cmderr	[resource-manager]     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
      cmderr	[resource-manager]     at Module.load (internal/modules/cjs/loader.js:863:32)
      cmderr	[resource-manager]     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
      cmderr	[resource-manager]     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
      cmderr	[resource-manager]     at internal/main/run_main_module.js:17:47 {
      cmderr	[resource-manager]   status: 3,
      cmderr	[resource-manager]   signal: null,
      cmderr	[resource-manager]   output: [ null, null, null ],
      cmderr	[resource-manager]   pid: 2874,
      cmderr	[resource-manager]   stdout: null,
      cmderr	[resource-manager]   stderr: null
      cmderr	[resource-manager] }
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b197995. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
    • ️✔️@azure/arm-botservice [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/azureBotService.js → ./dist/arm-botservice.js...
      cmderr	[npmPack] created ./dist/arm-botservice.js in 388ms
    ️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b197995. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	python3 -m venv venv
      command	pip install --upgrade setuptools wheel pip
      command	pip install pathlib jinja2 msrestazure
      command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/botservice/resource-manager/readme.md
    • ️✔️azure-mgmt-botservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-botservice
      cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-botservice
      cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
      cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.botservice
      cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.botservice
      cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.botservice
      cmderr	[changelogReport] INFO:__main__:Report written to sdk/botservice/azure-mgmt-botservice/code_reports/latest/report.json
      cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-botservice on PyPI
      cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '1.0.0b1']
      cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
      cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.2.0 of azure-mgmt-botservice in a venv
      cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
      cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.botservice
      cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.botservice
      cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.botservice
      cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/botservice/azure-mgmt-botservice/code_reports/0.2.0/report.json
      cmdout	[Changelog] Size of delta 22.787% size of original (original: 32247 chars, delta: 7348 chars)
      cmdout	[Changelog] **Features**
      cmdout	[Changelog]   - Model BotProperties has a new parameter is_cmek_enabled
      cmdout	[Changelog]   - Model BotProperties has a new parameter cmek_key_vault_url
      cmdout	[Changelog]   - Model SlackChannelProperties has a new parameter signing_secret
      cmdout	[Changelog]   - Added operation group DirectLineOperations
      cmdout	[Changelog] **Breaking changes**
      cmdout	[Changelog]   - Removed operation group EnterpriseChannelsOperations
      warn	Breaking change found in changelog
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @ssss141414, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants