Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scope from marketplace registration definitions operations #12397

Merged
merged 8 commits into from
Feb 3, 2021
Merged

Remove scope from marketplace registration definitions operations #12397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8dec92a
Remove scope from marketplace registration definitions operations
skayani Jan 12, 2021
e9c70dc
Swagger fixes
skayani Jan 27, 2021
beb6d9f
Changed operation ids
skayani Jan 27, 2021
4b52275
Validation fixes
skayani Jan 28, 2021
2e59f89
Unique x-ms-example names
skayani Jan 28, 2021
90a82ea
Name fix for examples
skayani Jan 28, 2021
24c0877
Removed sub from example responses
skayani Jan 29, 2021
7094ea8
Added empty eligibleAuths to 2020-02-01-preview MRD examples
skayani Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...esource-manager/Microsoft.ManagedServices/preview/2020-02-01-preview/managedservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,17 +380,14 @@
}
}
},
"/{scope}/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to have {scopeOptional} as this API supports tenant and subscription level as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with removing; as I see for operations API also we have removed it.

"/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions": {
"get": {
"tags": [
"MarketplaceRegistrationDefinitions"
],
"operationId": "MarketplaceRegistrationDefinitions_List",
"description": "Gets a list of the marketplace registration definitions for the marketplace identifier.",
"parameters": [
{
"$ref": "#/parameters/ScopeParameter"
},
{
"$ref": "#/parameters/Filter"
},
Expand Down Expand Up @@ -422,17 +419,14 @@
}
}
},
"/{scope}/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions/{marketplaceIdentifier}": {
"/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions/{marketplaceIdentifier}": {
"get": {
"tags": [
"MarketplaceRegistrationDefinitions"
],
"operationId": "MarketplaceRegistrationDefinitions_Get",
"description": "Get the marketplace registration definition for the marketplace identifier.",
"parameters": [
{
"$ref": "#/parameters/ScopeParameter"
},
{
"$ref": "#/parameters/MarketplaceIdentifier"
},
Expand Down
10 changes: 2 additions & 8 deletions ...ervices/resource-manager/Microsoft.ManagedServices/stable/2019-09-01/managedservices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,17 +380,14 @@
}
}
},
"/{scope}/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions": {
"/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions": {
"get": {
"tags": [
"MarketplaceRegistrationDefinitions"
],
"operationId": "MarketplaceRegistrationDefinitions_List",
"description": "Gets a list of the marketplace registration definitions for the marketplace identifier.",
"parameters": [
{
"$ref": "#/parameters/ScopeParameter"
},
{
"$ref": "#/parameters/Filter"
},
Expand Down Expand Up @@ -422,17 +419,14 @@
}
}
},
"/{scope}/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions/{marketplaceIdentifier}": {
"/providers/Microsoft.ManagedServices/marketplaceRegistrationDefinitions/{marketplaceIdentifier}": {
"get": {
"tags": [
"MarketplaceRegistrationDefinitions"
],
"operationId": "MarketplaceRegistrationDefinitions_Get",
"description": "Get the marketplace registration definition for the marketplace identifier.",
"parameters": [
{
"$ref": "#/parameters/ScopeParameter"
},
{
"$ref": "#/parameters/MarketplaceIdentifier"
},
Expand Down