Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new DevOps API swagger #11836

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Add new DevOps API swagger #11836

merged 3 commits into from
Dec 8, 2020

Conversation

eswatad
Copy link
Contributor

@eswatad eswatad commented Nov 27, 2020

Add new DevOps API swagger

@eswatad eswatad requested a review from bcham as a code owner November 27, 2020 01:01
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 27, 2020
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 27, 2020

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.

️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/sql/resource-manager/readme.md
tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Posted by Swagger Pipeline | How to fix these errors?

@ghost
Copy link

ghost commented Nov 27, 2020

Thank you for your contribution eswatad! We will review the pull request and get back to you soon.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 27, 2020

Swagger Generation Artifacts

️️✔️ azure-sdk-for-python succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 586c0f8. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	python3 -m venv venv
    command	pip install --upgrade setuptools wheel pip
    command	pip install pathlib jinja2 msrestazure
    command	autorest --version=V2 [email protected]/autorest.python@~4.0.71 --python --python-mode=update --multiapi --keep-version-file --no-async --python-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-python/sdk ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
  • ️✔️azure-mgmt-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
    cmderr	[buildConf] INFO:packaging_tools:Building template azure-mgmt-sql
    cmderr	[buildConf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    cmderr	[buildConf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    cmderr	[buildConf] INFO:packaging_tools:Template done azure-mgmt-sql
    cmderr	[changelogSetup] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[changelogReport] INFO:__main__:Looking for Autorest generated package in azure.mgmt.sql
    cmderr	[changelogReport] INFO:__main__:Found azure.mgmt.sql
    cmderr	[changelogReport] INFO:__main__:Working on azure.mgmt.sql
    cmderr	[changelogReport] INFO:__main__:Report written to sdk/sql/azure-mgmt-sql/code_reports/latest/report.json
    cmderr	[changelogReportLatest] INFO:__main__:Download versions of azure-mgmt-sql on PyPI
    cmderr	[changelogReportLatest] INFO:__main__:Got ['0.1.0', '0.2.0', '0.3.0', '0.3.1', '0.3.2', '0.3.3', '0.4.0', '0.5.0', '0.5.1', '0.5.2', '0.5.3', '0.6.0', '0.7.0', '0.7.1', '0.8.0', '0.8.1', '0.8.2', '0.8.3', '0.8.4', '0.8.5', '0.8.6', '0.9.0', '0.9.1', '0.10.0', '0.11.0', '0.12.0', '0.13.0', '0.14.0', '0.15.0', '0.16.0', '0.17.0', '0.18.0', '0.19.0', '0.20.0', '0.21.0', '0.22.0', '0.23.0', '0.24.0', '1.0.0b1', '1.0.0']
    cmderr	[changelogReportLatest] INFO:__main__:Only keep last PyPI version
    cmderr	[changelogReportLatest] INFO:__main__:Installing version 0.24.0 of azure-mgmt-sql in a venv
    cmderr	[changelogReportLatest] Cache entry deserialization failed, entry ignored
    cmderr	[changelogReportLatest] INFO:__main__:Looking for Autorest generated package in azure.mgmt.sql
    cmderr	[changelogReportLatest] INFO:__main__:Found azure.mgmt.sql
    cmderr	[changelogReportLatest] INFO:__main__:Working on azure.mgmt.sql
    cmderr	[changelogReportLatest] INFO:__main__:Report written to sdk/sql/azure-mgmt-sql/code_reports/0.24.0/report.json
    cmdout	[Changelog] Size of delta 1.387% size of original (original: 327004 chars, delta: 4537 chars)
    cmdout	[Changelog] **Features**
    cmdout	[Changelog]   - Added operation DatabasesOperations.import_method
    cmdout	[Changelog]   - Added operation DatabasesOperations.list_inaccessible_by_server
    cmdout	[Changelog]   - Added operation DatabasesOperations.import_database
    cmdout	[Changelog]   - Added operation group ServerDevOpsAuditSettingsOperations
    cmdout	[Changelog] **Breaking changes**
    cmdout	[Changelog]   - Removed operation ServersOperations.import_database
    cmdout	[Changelog]   - Removed operation group ImportExportOperations
    warn	Breaking change found in changelog
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 586c0f8. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    cmderr	[generate.py] 2020-12-08 11:27:21 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-sql-generated"
    cmderr	[generate.py] 2020-12-08 11:27:21 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
    cmderr	[generate.py] 2020-12-08 11:27:21 INFO autorest --version=3.0.6327 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/sql/azure-resourcemanager-sql-generated --java.namespace=com.azure.resourcemanager.sql.generated  --package-version=1.0.0-beta.1 --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --pipeline.modelerfour.flatten-payloads=false --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    cmderr	[generate.py] 2020-12-08 11:31:09 INFO [CI][Success] Write to ci.yml
    cmderr	[generate.py] 2020-12-08 11:31:09 INFO [POM][Process] dealing with pom.xml
    cmderr	[generate.py] 2020-12-08 11:31:09 INFO [POM][Success] Write to pom.xml
    cmderr	[generate.py] 2020-12-08 11:31:09 INFO [POM][Process] dealing with root pom
    cmderr	[generate.py] 2020-12-08 11:31:09 INFO [POM][Success] Write to root pom
    cmderr	[generate.py] WARNING: An illegal reflective access operation has occurred
    cmderr	[generate.py] WARNING: Illegal reflective access by org.codehaus.groovy.reflection.ReflectionUtils (file:/home/vsts/.m2/repository/org/codehaus/groovy/groovy/3.0.0-beta-2/groovy-3.0.0-beta-2-indy.jar) to method java.util.Collections$UnmodifiableCollection.toString()
    cmderr	[generate.py] WARNING: Please consider reporting this to the maintainers of org.codehaus.groovy.reflection.ReflectionUtils
    cmderr	[generate.py] WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
    cmderr	[generate.py] WARNING: All illegal access operations will be denied in a future release
  • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes]
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Got artifact_id: azure-resourcemanager-sql-generated
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Got artifact: pom.xml
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-sources.jar
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1-javadoc.jar
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Got artifact: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG Match jar package: azure-resourcemanager-sql-generated-1.0.0-beta.1.jar
    cmderr	[Inst] 2020-12-08 11:35:25 DEBUG output: {"full": "curl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/11836/azure-sdk-for-java/azure-resourcemanager-sql-generated/azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-sql-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-sql-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-sql-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true\n"}
️⚠️ azure-sdk-for-net warning [Detail]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 586c0f8. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
  • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes]
    cmderr	[npmPack] loaded rollup.config.js with warnings
    cmderr	[npmPack] (!) Unused external imports
    cmderr	[npmPack] default imported from external module 'rollup' but never used
    cmderr	[npmPack] ./esm/sqlManagementClient.js → ./dist/arm-sql.js...
    cmderr	[npmPack] created ./dist/arm-sql.js in 2.3s
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 586c0f8. SDK Automation 14.0.0
    command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️preview/sql/mgmt/v3.0/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/sql/mgmt/2018-06-01-preview/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/sql/mgmt/2017-10-01-preview/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/sql/mgmt/2017-03-01-preview/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️preview/sql/mgmt/2015-05-01-preview/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
  • ️✔️sql/mgmt/2014-04-01/sql [View full logs]  [Release SDK Changes]
    info	[Changelog] No exported changes
️❌ azure-sdk-for-ruby failed [Detail]
  • Failed [Logs]Release - Generate from 586c0f8. SDK Automation 14.0.0
    warn	Skip initScript due to not configured
    command	autorest --version=preview [email protected]/autorest.ruby@preview --ruby --multiapi --ruby-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-ruby ../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js - FAILURE {}
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (Use `node --trace-warnings ...` to show where the warning was created)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 77)
    cmderr	[Autorest] (node:2646) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 78)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 79)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 80)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 81)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 82)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Error: Plugin modeler reported failure.
    cmderr	[Autorest]     at /home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/plugins/external.js:26:19
    cmderr	[Autorest]     at async ScheduleNode (/home/vsts/.autorest/@[email protected]/node_modules/@autorest/core/dist/lib/pipeline/pipeline.js:280:33)
    cmderr	[Autorest] (node:2646) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 83)
    cmderr	[Autorest] Failure during batch task - {"tag":"package-pure-2014-04"} -- Error: Plugin modeler reported failure..
    cmderr	[Autorest]   Error: Plugin modeler reported failure.
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-ruby]: autorest
    warn	Skip package processing as generation is failed
️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 586c0f8. Schema Automation 14.0.0
    warn	Skip initScript due to not configured
    command	npx n 12
    command	autorest --use=@autorest/[email protected] --version=3.0.6320 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/sql/resource-manager/readme.md
    cmdout	[Autorest] WARNING: Found duplicate definition for type Microsoft.Sql/servers/firewallRules in scope ResourceGroup
  • cmderr	[resource-manager] node-pre-gyp
    cmderr	[resource-manager] WARN Using request for node-pre-gyp https download
    cmderr	[resource-manager]  [email protected] No repository field.
    cmderr	[resource-manager]  SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
    cmderr	[resource-manager] npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
️🔄[Staging] ApiDocPreview inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@akning-ms
Copy link
Contributor

Hi @eswatad, Looks you removed template when submit PR. can we know why you have this PR?
As you are adding a Devops API, as this API is already in version 2020-08-01-preview which just merged last week. will it be better to have this change base on 2020-08-01-preview?
@ericshape

@akning-ms akning-ms added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Nov 28, 2020
custom-words.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@ericshape ericshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericshape
Copy link
Contributor

@jamestao can you take a look at this PR?

@ericshape
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 11836 in repo Azure/azure-rest-api-specs

@eswatad eswatad changed the title [DO NOT MERGE] Add new DevOps API swagger Add new DevOps API swagger Dec 2, 2020
@j5lim j5lim self-requested a review December 2, 2020 02:01
"lastModifiedAt": {
"type": "string",
"format": "date-time",
"description": "The type of identity that last modified the resource."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a typo from the global common type file. feel free to modify it.
it should be "The timestamp of last modification (UTC)."

Copy link
Contributor

@ericshape ericshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the systemData def.
this systemData def was generated from SQL DB DSMainDev repo and match the global ones.

@zhenglaizhang
Copy link
Contributor

fyi, ApiDocPreview hangs and I am now investigating the issue with docs team. Will post here if any more update.

@PhoenixHe-NV
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@akning-ms akning-ms merged commit 586c0f8 into Azure:master Dec 8, 2020
giromm2ms pushed a commit to giromm2ms/azure-rest-api-specs that referenced this pull request Dec 20, 2020
* Add new DevOps API swagger

* Fix SDK error

* updating swagger version 2020-08-01-preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-BreakingChange-Python customer-reported Issues that are reported by GitHub users external to the Azure organization. Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants