-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new DevOps API swagger #11836
Add new DevOps API swagger #11836
Conversation
Swagger Validation Report
|
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/sql/resource-manager/readme.md tag: specification/sql/resource-manager/readme.md#tag-package-composite-v4 |
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail] [Expand]
There are no breaking changes.
Thank you for your contribution eswatad! We will review the pull request and get back to you soon. |
Swagger Generation Artifacts
|
Hi @eswatad, Looks you removed template when submit PR. can we know why you have this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jamestao can you take a look at this PR? |
specification/sql/resource-manager/Microsoft.Sql/preview/2020-02-02-preview/DevOpsAudit.json
Outdated
Show resolved
Hide resolved
specification/sql/resource-manager/Microsoft.Sql/preview/2020-02-02-preview/DevOpsAudit.json
Outdated
Show resolved
Hide resolved
/azp run |
Commenter does not have sufficient privileges for PR 11836 in repo Azure/azure-rest-api-specs |
...ication/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/ServerDevOpsAudit.json
Outdated
Show resolved
Hide resolved
...ication/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/ServerDevOpsAudit.json
Outdated
Show resolved
Hide resolved
...ication/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/ServerDevOpsAudit.json
Show resolved
Hide resolved
...ication/sql/resource-manager/Microsoft.Sql/preview/2020-08-01-preview/ServerDevOpsAudit.json
Show resolved
Hide resolved
"lastModifiedAt": { | ||
"type": "string", | ||
"format": "date-time", | ||
"description": "The type of identity that last modified the resource." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a typo from the global common type file. feel free to modify it.
it should be "The timestamp of last modification (UTC)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the systemData def.
this systemData def was generated from SQL DB DSMainDev repo and match the global ones.
fyi, ApiDocPreview hangs and I am now investigating the issue with docs team. Will post here if any more update. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
* Add new DevOps API swagger * Fix SDK error * updating swagger version 2020-08-01-preview
Add new DevOps API swagger